Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64242 discussions

Check_MK Git: check_mk: Multisite: omit duplicate filled_in HTML var

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: fe3c4d2090ce47a23f5984b73d6ed71052c717da URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fe3c4d2090ce47… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Apr 10 14:40:40 2012 +0200 Multisite: omit duplicate filled_in HTML var --- web/htdocs/htmllib.py | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py index 069b71d..0044448 100644 --- a/web/htdocs/htmllib.py +++ b/web/htdocs/htmllib.py @@ -301,7 +301,8 @@ class html: else: # add *all* get variables, that are not set by any input! for var, value in self.req.vars.items(): if var not in self.form_vars and \ - (var[0] != "_" or add_action_vars): + (var[0] != "_" or add_action_vars) and \ + var != "filled_in": self.hidden_field(var, value) def add_global_vars(self, varnames):

12 years, 5 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 8f636dece16d1c9de8c3afe1d82072bd7353d122 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8f636dece16d1c… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Apr 10 14:40:46 2012 +0200 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

12 years, 5 months

Check_MK Git: check_mk: Add new bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 50967bb0bd88b3812c373fbc62c6052ff006e068 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=50967bb0bd88b3… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Tue Apr 10 10:54:00 2012 +0200 Add new bug entries --- .bugs/582 | 11 +++++++++++ .bugs/583 | 12 ++++++++++++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/.bugs/582 b/.bugs/582 new file mode 100644 index 0000000..72dab63 --- /dev/null +++ b/.bugs/582 @@ -0,0 +1,11 @@ +Title: configure first_notification_delay from WATO +Component: wato +State: open +Date: 2012-04-10 10:27:46 +Targetversion: 1.2.0 +Class: feature + +Currently we don't have support for setting the first notification delay from within WATO. +This is a helpful feature we recommended to many people, so it would be important to have it available; +I think it's the only notification-related setting not available in WATO, so by adding it we'd have +it all covered. diff --git a/.bugs/583 b/.bugs/583 new file mode 100644 index 0000000..1803996 --- /dev/null +++ b/.bugs/583 @@ -0,0 +1,12 @@ +Title: parenting configuration from WATO (folders/tags) +Component: wato +State: open +Date: 2012-04-10 10:31:31 +Targetversion: 1.2.0 +Class: feature + +Currently you can't edit the parents from within WATO. +There's multiple ways to get this, usually you'd just need a location tag +for systems in a certain location, +on the other hand we could think about doing this on the folder level as +a WATO-super-feature (most people seem to have "geo-folders" anyway)

12 years, 5 months

Check_MK Git: check_mk: WATO: fix single typo :)

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: d9b8f96c4f44233bda23e257d101d2759ea1d586 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d9b8f96c4f4423… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Tue Apr 10 10:24:00 2012 +0200 WATO: fix single typo :) --- web/plugins/wato/check_parameters.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 82f069f..f021fe0 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -997,7 +997,7 @@ checkgroups.append(( checkgroups.append(( subgroup_storage, "raid", - _("RAID: overal state"), + _("RAID: overall state"), None, TextAscii( title = _("Name of the device"),

12 years, 5 months

Check_MK Git: check_mk: Updated bug entries #0672, #0610, #0635, #0581, #0668, #0631, #0588, #0674, #0595, #0599, #0575, #0636, #0607

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 80190eb573b53b8774ee1aa206acd8dcf9035597 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=80190eb573b53b… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Apr 10 09:24:51 2012 +0200 Updated bug entries #0672, #0610, #0635, #0581, #0668, #0631, #0588, #0674, #0595, #0599, #0575, #0636, #0607 --- .bugs/575 | 6 ++++-- .bugs/581 | 15 ++++++++++----- .bugs/588 | 11 +++++++---- .bugs/595 | 4 ++-- .bugs/599 | 6 ++++-- .bugs/607 | 4 ++-- .bugs/610 | 13 +++++++++---- .bugs/631 | 7 +++++-- .bugs/635 | 5 +++++ .bugs/636 | 10 +++++----- .bugs/668 | 3 +++ .bugs/672 | 12 +++++++----- .bugs/674 | 11 +++++++++++ 13 files changed, 74 insertions(+), 33 deletions(-) diff --git a/.bugs/575 b/.bugs/575 index 09ee9b0..64ef5a4 100644 --- a/.bugs/575 +++ b/.bugs/575 @@ -1,9 +1,9 @@ Title: Undo changes from the commit queue Component: wato -State: open +Class: nastiness +State: wontfix Date: 2012-01-09 15:38:00 Targetversion: 1.2.0 -Class: nastiness This will be an unloved request... @@ -19,3 +19,5 @@ ore transactions but are direct modifications to the config files. Also changes build are built on previous changes. The only possible thing is to make a snapshot and get back to the snapshot later. + +2012-04-10 08:53:57: changed state open -> wontfix diff --git a/.bugs/581 b/.bugs/581 index da16c11..038697b 100644 --- a/.bugs/581 +++ b/.bugs/581 @@ -1,9 +1,14 @@ -Title: windows dhcp check doesnt if its needed on a server +Title: Skip windows dhcp check if not on a server Component: checks -State: open +Class: cleanup +State: wontfix Date: 2012-03-19 16:38:29 Targetversion: 1.2.0 -Class: cleanup -If would be nice if the windows agent plugin for dhcp pools checked if its run on an active dhcp server. -then it would be unix-like so that the plugins autodetects applicable checks. +If would be nice if the windows agent plugin for dhcp pools checked if its +run on an active dhcp server. then it would be unix-like so that the plugins +autodetects applicable checks. + +2012-04-10 08:55:47: changed state open -> wontfix +The official style is: don't run plugins on Windows that are +not needed on a host. In general. diff --git a/.bugs/588 b/.bugs/588 index 58e52b7..984f9d1 100644 --- a/.bugs/588 +++ b/.bugs/588 @@ -2,8 +2,11 @@ Title: Mandatory Attribut in wato nicht ersichtlich Component: wato State: open Date: 2012-01-12 10:42:27 -Targetversion: 1.2.0 -Class: nastiness +Targetversion: future +Class: feature -Man kann in den Masken von WATO nicht erkennen, welche Felder unbedingt ausgefüllt -werden müssen. Eine Markierung ist auf jeden Fall sinnvoll. +Man kann in den Masken von WATO nicht erkennen, welche Felder unbedingt +ausgefüllt werden müssen. Eine Markierung ist auf jeden Fall sinnvoll. + +Wenn man das macht, dann muss das allerdings in *allen* WATO-Masken +und auch bei dem Vieweditor, etc. durchgezogen werden. diff --git a/.bugs/595 b/.bugs/595 index f2a45fa..dadb30d 100644 --- a/.bugs/595 +++ b/.bugs/595 @@ -5,5 +5,5 @@ Date: 2012-01-13 11:05:09 Targetversion: 1.2.0 Class: todo -Repliziert User A in Wato änderungen und User B produziert gleichzeitig neue, verhält sich die Replizierung falsch -. +Repliziert User A in Wato änderungen und User B produziert gleichzeitig neue, +verhält sich die Replizierung falsch. diff --git a/.bugs/599 b/.bugs/599 index 4c14d5c..228c706 100644 --- a/.bugs/599 +++ b/.bugs/599 @@ -1,11 +1,13 @@ Title: Multisite should wait a couple of secs when live is missing Component: multisite -State: open +Class: todo +State: done Date: 2012-01-13 11:02:04 Targetversion: 1.2.0 -Class: todo When one users restarts the core and another user is in Multisite, he gets an error message that live is missing. The Livestatus API should wait up to "connect_timeout" seconds and retry to find the socket instead. + +2012-04-10 09:06:55: changed state open -> done diff --git a/.bugs/607 b/.bugs/607 index 26c6db7..660fb24 100644 --- a/.bugs/607 +++ b/.bugs/607 @@ -1,11 +1,11 @@ -Title: Chaning of wato_activation_method in Wato needs apache restart +Title: Changing wato_activation_method in Wato needs apache restart Component: wato State: open Date: 2012-01-27 14:46:10 Targetversion: 1.2.0 Class: nastiness -Das Ändern der Einstellung: wato_activation_method über Wato erforder einen +Das Ändern der Einstellung: wato_activation_method über Wato erfordert einen Apache restart damit es funktioniert. Wato führt diesen jedoch nicht aus. Mathias: Das kann eigentlich nicht so sein. Änderungen in multisite.mk brauchen diff --git a/.bugs/610 b/.bugs/610 index 1ab852a..8fb16bf 100644 --- a/.bugs/610 +++ b/.bugs/610 @@ -1,9 +1,14 @@ Title: OMD: Keine command.cfg mehr Component: core -State: open +Class: nastiness +State: wontfix Date: 2012-01-30 22:20:50 Targetversion: 1.2.0 -Class: nastiness -Zumindest in unseren OMD Versionen findet sich keine commands.cfg mehr, welche die Nagios Command definitionen der Mitgelieferten Checks enthält. -Ist das absicht? +Zumindest in unseren OMD Versionen findet sich keine commands.cfg mehr, +welche die Nagios Command Definitionen der mitgelieferten Checks enthält. +Ist das Absicht? + +Ja. + +2012-04-10 09:12:04: changed state open -> wontfix diff --git a/.bugs/631 b/.bugs/631 index c9271ba..760a5f3 100644 --- a/.bugs/631 +++ b/.bugs/631 @@ -1,12 +1,15 @@ Title: WATO folder view: tags in table take too much space Component: wato -State: open +Class: nastiness +State: done Date: 2012-02-13 11:39:57 Targetversion: 1.2.0 -Class: nastiness In the table of hosts when you have defined more than just a few host tags the table looks nasty since the tags column takes up to much space. We could either hide the tags or - maybe this is better - just show the first X characters and put the complete list into the title= attribute. + +2012-04-10 09:15:02: changed state open -> done +Is controlled by a global setting. diff --git a/.bugs/635 b/.bugs/635 index 9bf1f40..3134db7 100644 --- a/.bugs/635 +++ b/.bugs/635 @@ -9,3 +9,8 @@ When a user changes his password, then that change is not automatically replicated to the slave sites in replicated mode. I think we'd really need to do some isolated replication only of htpasswd in that case - automatically. + +Solution: Create a new webservice that just replicates the password +file. This mini-replication is then automatically done when the +user changes his password. + diff --git a/.bugs/636 b/.bugs/636 index 48bf20a..daeb7b8 100644 --- a/.bugs/636 +++ b/.bugs/636 @@ -1,11 +1,11 @@ -Title: Add missing field to contact configuration +Title: Add missing fields to contact configuration Component: wato State: open Date: 2012-02-22 19:40:24 Targetversion: 1.2.0 Class: todo -For example the mobile number field is missing. This -is sometime a showstopper since it is not possible to -manually add further attributes. We even could think -about letting the user add custom attributes here. +For example the mobile number field is missing. This is sometime a showstopper +since it is not possible to manually add further attributes. We even could +think about letting the user add custom attributes here. Or at least the +six supplement fields that nagios provides. diff --git a/.bugs/668 b/.bugs/668 index 09cde3e..f860c9d 100644 --- a/.bugs/668 +++ b/.bugs/668 @@ -10,3 +10,6 @@ message ERROR cannot reschedule check: time out appears (after ~ 1 sec.) LM: Works for me. + +MK: Most time for me as well. But sometimes it +immediately fails.... diff --git a/.bugs/672 b/.bugs/672 index d175e8c..723cd0a 100644 --- a/.bugs/672 +++ b/.bugs/672 @@ -1,10 +1,12 @@ -Title: Commands with checkboxes -> Request-URI Too Large -Component: multisite +Title: Hosts with many services in replicated WATO -> Request-URI Too Large +Component: wato State: open Date: 2012-04-06 11:23:12 Targetversion: 1.2.0 Class: bug -When you use checkboxes for selecting many items in a host -or service view and then issue a command, then the request -URI will be too long. Can we convert this to a POST request? +When a host has many services and you save a manual check +configuration for a host on a slave site, then the internal +web services the remotely does inventory creates a too large +URL. Either convert this to POST or send the list of +services as a Python object as the body of the request. diff --git a/.bugs/674 b/.bugs/674 new file mode 100644 index 0000000..ad24b0f --- /dev/null +++ b/.bugs/674 @@ -0,0 +1,11 @@ +Title: No login form in frame +Component: multisite +State: open +Date: 2012-04-10 09:08:07 +Targetversion: 1.2.0 +Class: nastiness + +When the login dialog detects that it is running in a frame +and not as the main page (or the frame's name is "main" or "side"), +then it should redirect to index.py and remove the frame set. +This can be done by Javascript.

12 years, 5 months

Check_MK Git: check_mk: WATO: new setting wato_hide_varnames

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 157a8aa5043f280cc0aaed4e36f4c2edac7da48b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=157a8aa5043f28… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Apr 9 14:15:44 2012 +0200 WATO: new setting wato_hide_varnames --- ChangeLog | 3 +++ web/htdocs/config.py | 1 + web/htdocs/wato.py | 21 +++++++++++++-------- web/plugins/wato/check_mk_configuration.py | 9 +++++++++ 4 files changed, 26 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 43e8cda..e38edc1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8,6 +8,9 @@ have the mail addresses and other notification options persisted * FIX: deletion of automation accounts now works * FIX: Disabling notifications for users does work now + * New main overview for rule editor + * New multisite.mk option wato_hide_varnames for hiding Check_MK + configuration variable names from the user Multisite * Added config option default_ts_format to configure default timestamp diff --git a/web/htdocs/config.py b/web/htdocs/config.py index 9ed4fad..4d161cb 100644 --- a/web/htdocs/config.py +++ b/web/htdocs/config.py @@ -615,6 +615,7 @@ wato_host_tags = [] wato_aux_tags = [] wato_hide_filenames = True wato_hide_hosttags = False +wato_hide_varnames = False wato_max_snapshots = 50 wato_num_hostspecs = 12 wato_num_itemspecs = 15 diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 33fc553..4876b55 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -4684,9 +4684,10 @@ def mode_globalvars(phase): for groupname in groupnames: html.begin_foldable_container("globalvars", groupname, False, groupname, indent=False) html.write('<table class="data globalvars">') - html.write("<tr><th>" + _("Configuration variable") + - "</th><th>" +_("Check_MK variable") + "</th><th>" + - _("Default") + "</th><th>" + _("Your setting") + "</th><th></th></tr>\n") + html.write("<tr><th>" + _("Configuration variable") + "</th>") + if not config.wato_hide_varnames: + html.write("<th>" +_("Check_MK variable") + "</th>") + html.write("<th>" + _("Default") + "</th><th>" + _("Your setting") + "</th><th></th></tr>\n") odd = "even" for domain, varname, valuespec in g_configvar_groups[groupname]: @@ -4704,7 +4705,8 @@ def mode_globalvars(phase): edit_url = make_link([("mode", "edit_configvar"), ("varname", varname)]) html.write('<td class=title><a href="%s">%s</a></td>' % (edit_url, valuespec.title())) - html.write('<td class=varname><tt>%s</tt></td>' % varname) + if not config.wato_hide_varnames: + html.write('<td class=varname><tt>%s</tt></td>' % varname) if varname in current_settings: html.write('<td class=inherited>%s</td>' % valuespec.value_to_text(defaultvalue)) html.write('<td><b>%s</b></td>' % valuespec.value_to_text(current_settings[varname])) @@ -8552,7 +8554,7 @@ def mode_rulesets(phase): return if not only_host: - render_folder_path(keepvarnames = ["mode", "local"]) + render_folder_path(keepvarnames = ["mode", "local", "group"]) if help: html.write("<div class=info>%s</div>" % help) @@ -8629,8 +8631,10 @@ def mode_rulesets(phase): if do_folding: html.begin_foldable_container("rulesets", groupname, False, subgroupname, indent=False) html.write('<table class="data rulesets">') - html.write("<tr><th>" + _("Rule set") + "</th>" - "<th>" + _("Check_MK Variable") + "</th><th>" + _("Rules") + "</th></tr>\n") + html.write("<tr><th>" + _("Rule set") + "</th>") + if not config.wato_hide_varnames: + html.write("<th>" + _("Check_MK Variable") + "</th>") + html.write("<th>" + _("Rules") + "</th></tr>\n") odd = "even" title_shown = True @@ -8645,7 +8649,8 @@ def mode_rulesets(phase): html.write('<td class=title><a href="%s">%s</a></td>' % (view_url, rulespec["title"])) display_varname = ':' in varname and '%s["%s"]' % tuple(varname.split(":")) or varname - html.write('<td class=varname><tt>%s</tt></td>' % display_varname) + if not config.wato_hide_varnames: + html.write('<td class=varname><tt>%s</tt></td>' % display_varname) html.write('<td class=number>') if num_local_rules: if only_host: diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py index 3e2eb7f..98e16b0 100644 --- a/web/plugins/wato/check_mk_configuration.py +++ b/web/plugins/wato/check_mk_configuration.py @@ -173,6 +173,15 @@ register_configvar(group, domain = "multisite") register_configvar(group, + "wato_hide_varnames", + Checkbox(title = _("Hide names of configuration variables"), + label = _("hide variable names"), + help = _("When enabled, internal configuration variable names of Check_MK are hidded " + "from the user (for example in the rule editor)"), + default_value = False), + domain = "multisite") + +register_configvar(group, "wato_max_snapshots", Integer(title = _("Number of configuration snapshots to keep"), help = _("Whenever you successfully activate changes a snapshot of the configuration "

12 years, 5 months

Check_MK Git: check_mk: WATO: introduce main rule overview

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3f9be6c4286c3edd10212fa3a5c04df4aa902235 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3f9be6c4286c3e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Apr 9 14:09:22 2012 +0200 WATO: introduce main rule overview --- web/htdocs/wato.css | 2 +- web/htdocs/wato.py | 82 +++++++++++++++++++++++----- web/plugins/wato/builtin_modules.py | 3 +- web/plugins/wato/check_mk_configuration.py | 20 ++++++-- web/plugins/wato/check_parameters.py | 75 ++++++++++++++++++++++--- 5 files changed, 153 insertions(+), 29 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=3f9be6c428…

12 years, 5 months

Check_MK Git: check_mk: Updated bug entries #0673

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3b3fe6b5f9bce4fc97aaf0e0132ec3f95b04d6aa URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3b3fe6b5f9bce4… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Apr 8 11:02:33 2012 +0200 Updated bug entries #0673 --- .bugs/673 | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/.bugs/673 b/.bugs/673 new file mode 100644 index 0000000..5c63269 --- /dev/null +++ b/.bugs/673 @@ -0,0 +1,12 @@ +Title: Service details view should not show Filter tab +Component: multisite +State: open +Date: 2012-04-08 11:01:32 +Targetversion: 1.2.0 +Class: nastiness + +No filter is being shown, but the filter tab is there +and a search button. + +The reason is probably that one filter is there (the +WATO path filter?) but is not being displayed?

12 years, 5 months

Check_MK Git: check_mk: Further smaller layout improvements

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: f2b6a6e91a63a7e6aec4e135b78733d11588ae62 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f2b6a6e91a63a7… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Apr 6 16:03:55 2012 +0200 Further smaller layout improvements --- web/htdocs/check_mk.css | 4 +- web/htdocs/pages.css | 50 +++++++++++++++----------- web/htdocs/views.css | 49 ++++++-------------------- web/htdocs/views.py | 53 ++++++++++++++++------------ web/htdocs/wato.css | 33 +++++++---------- web/htdocs/wato.py | 1 + web/plugins/wato/check_mk_configuration.py | 2 +- 7 files changed, 88 insertions(+), 104 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=f2b6a6e91a…

12 years, 5 months

Check_MK Git: check_mk: WATO: make reschedule_timeout configurable

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: e1c3a5519791c6273534d7ade16afcadde1d0e00 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e1c3a5519791c6… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Apr 6 11:36:24 2012 +0200 WATO: make reschedule_timeout configurable --- web/plugins/wato/check_mk_configuration.py | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py index 1f296d2..f246f0f 100644 --- a/web/plugins/wato/check_mk_configuration.py +++ b/web/plugins/wato/check_mk_configuration.py @@ -183,6 +183,19 @@ register_configvar(group, domain = "multisite") register_configvar(group, + "reschedule_timeout", + Float(title = _("Timeout for rescheduling checks in Multisite"), + help = _("When you reschedule a check by clicking on the "arrow"-icon " + "then Multisite will use this number of seconds as a timeout. If the " + "monitoring core has not executed the check within this time, an error " + "will be displayed and the page not reloaded."), + minvalue = 1.0, + default_value = 10.0, + unit = "sec", + display_format = "%.1f sec"), + domain = "multisite") + +register_configvar(group, "wato_activation_method", DropdownChoice( title = _("Wato restart mode for Nagios"),

12 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits