Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64242 discussions

Check_MK Git: check_mk: Added Check: fileinfo.groups

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: b314634e3fedbc59d7d8689af681e49e53deb185 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b314634e3fedbc… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Tue Apr 17 17:50:04 2012 +0200 Added Check: fileinfo.groups --- checkman/fileinfo.groups | 84 +++++++++++++++++++++ checks/fileinfo | 135 +++++++++++++++++++++++++++------- web/plugins/perfometer/check_mk.py | 15 ++++- web/plugins/views/perfometer.py | 2 +- web/plugins/wato/check_parameters.py | 116 +++++++++++++++++++++++++++++- 5 files changed, 322 insertions(+), 30 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=b314634e3f…

12 years, 5 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 5e70b477c6d6d9eef1106a3c894b79eebb0243f8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5e70b477c6d6d9… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Tue Apr 17 17:50:14 2012 +0200 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

12 years, 5 months

Check_MK Git: check_mk: Updated bug entries #0674, #0651

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 5e7ad9ab429069d26eb7379922524344cf22d958 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5e7ad9ab429069… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 17 17:08:48 2012 +0200 Updated bug entries #0674, #0651 --- .bugs/651 | 7 +++++-- .bugs/674 | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.bugs/651 b/.bugs/651 index e640a22..4a69acb 100644 --- a/.bugs/651 +++ b/.bugs/651 @@ -1,8 +1,11 @@ Title: WAT tag management needs input fields for secondary tags Component: wato -State: open +Class: nastiness +State: done Date: 2012-02-14 11:22:42 Targetversion: future -Class: nastiness Is an important feature to be able to manage the tags in wATo. + +2012-04-17 16:58:43: changed state open -> done +Has already been implemented. diff --git a/.bugs/674 b/.bugs/674 index ad24b0f..0514d16 100644 --- a/.bugs/674 +++ b/.bugs/674 @@ -1,11 +1,14 @@ Title: No login form in frame Component: multisite -State: open +Class: nastiness +State: done Date: 2012-04-10 09:08:07 Targetversion: 1.2.0 -Class: nastiness When the login dialog detects that it is running in a frame and not as the main page (or the frame's name is "main" or "side"), then it should redirect to index.py and remove the frame set. This can be done by Javascript. + +2012-04-17 17:07:41: changed state open -> done +Has just been implemented. Never allowing login.py in a frame.

12 years, 5 months

Check_MK Git: check_mk: Login page is not shown in framesets anymore ( redirects framed page to

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: c4187363ab28704406963ec926eb9fbe2b6dbea8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c4187363ab2870… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 17 17:08:50 2012 +0200 Login page is not shown in framesets anymore (redirects framed page to full screen login page) --- ChangeLog | 2 ++ web/htdocs/login.py | 5 +++++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 96d897c..b52ae4e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -48,6 +48,8 @@ * FIX: Fix problem where snapins where invisible * FIX: Fixed multisite timeout errors when nagios not running * Sidebar: some new layout improvements + * Login page is not shown in framesets anymore (redirects framed page to + full screen login page) BI * FIX: Fixed filtering of Single-Host Aggregations diff --git a/web/htdocs/login.py b/web/htdocs/login.py index fcbb1f4..30550c6 100644 --- a/web/htdocs/login.py +++ b/web/htdocs/login.py @@ -220,6 +220,11 @@ def normal_login_page(): html.set_render_headfoot(False) html.header(_("Check_MK Multisite Login"), javascripts=[], stylesheets=["pages", "login"]) + # Never allow the login page to be opened in a frameset. Redirect top page to login page + html.javascript('''if(top != self) { + window.top.location.href = location; +}''') + origtarget = html.var('_origtarget', '') if not origtarget and not html.req.myfile == 'login': origtarget = html.makeuri([])

12 years, 5 months

Check_MK Git: check_mk: Merge branch 'master' of mathias-kettner.de: check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 5182343479aaec4bcca5e517a418a332a64ce2cf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5182343479aaec… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 17 17:19:20 2012 +0200 Merge branch 'master' of mathias-kettner.de:check_mk Conflicts: ChangeLog ---

12 years, 5 months

Check_MK Git: check_mk: FIX: fix exception when disallowing changing display options

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 9e21643107e6503b1b1b6d5cbabdf4243f647b06 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9e21643107e650… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Apr 17 17:08:01 2012 +0200 FIX: fix exception when disallowing changing display options --- .bugs/707 | 7 +++++-- ChangeLog | 1 + web/htdocs/views.py | 3 ++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.bugs/707 b/.bugs/707 index eca28fe..09b672a 100644 --- a/.bugs/707 +++ b/.bugs/707 @@ -1,9 +1,9 @@ Title: WATO dashlets Service problems and Events of rec. 4 hours can die if view is missing Component: multisite -State: open +Class: nastiness +State: done Date: 2012-04-16 17:10:07 Targetversion: 1.2.0 -Class: nastiness The dashlets will print the following error Internal error:: 'aggr_onlyproblems' @@ -24,3 +24,6 @@ Change column display options Since this is user-modifyable we need to catch it and i.e. disable the dashlets. + +2012-04-17 17:07:35: changed state open -> done +Fixed. diff --git a/ChangeLog b/ChangeLog index 96d897c..15326a2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -48,6 +48,7 @@ * FIX: Fix problem where snapins where invisible * FIX: Fixed multisite timeout errors when nagios not running * Sidebar: some new layout improvements + * FIX: fix exception when disallowing changing display options BI * FIX: Fixed filtering of Single-Host Aggregations diff --git a/web/htdocs/views.py b/web/htdocs/views.py index 0eeeae8..c897f36 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -1561,7 +1561,8 @@ def view_options(viewname): else: for on, opt in multisite_painter_options.items(): - del v[on] + if on in v: + del v[on] opt["value"] = None if must_save:

12 years, 5 months

Check_MK Git: check_mk: Updated bug entries #0691

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 90b3eb190de3332565d161eacb865886f7d1030b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=90b3eb190de333… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 17 16:55:20 2012 +0200 Updated bug entries #0691 --- .bugs/691 | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/691 b/.bugs/691 index 0f37013..bc75964 100644 --- a/.bugs/691 +++ b/.bugs/691 @@ -1,9 +1,12 @@ Title: Remove/Secure eval() on html.var() Component: wato -State: open +Class: nastiness +State: done Date: 2012-04-11 11:39:35 Targetversion: 1.2.0 -Class: nastiness It is VERY insecure and VERY easy to do bad things at these places. They must be secured/removed in some way. + +2012-04-17 16:55:16: changed state open -> done +Has been fixed for direct reading from HTML parameters

12 years, 5 months

Check_MK Git: check_mk: Fixed latest IE7 JS fix

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: d2df957304a331e72d39776559817af741caee73 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d2df957304a331… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 17 16:57:50 2012 +0200 Fixed latest IE7 JS fix --- web/htdocs/js/wato.js | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/web/htdocs/js/wato.js b/web/htdocs/js/wato.js index 542d1d1..cb14b46 100644 --- a/web/htdocs/js/wato.js +++ b/web/htdocs/js/wato.js @@ -145,14 +145,14 @@ function wato_fix_visibility() { // Prepare current visibility information which is used // within the attribut validation in wato // Hidden attributes are not validated at all - oAttrDisp = document.getElementById("attr_display_" + attrname); - if (!oAttrDisp){ - var newInput = document.createElement("input"); - newInput.name = "attr_display_" + attrname; - newInput.id = "attr_display_" + attrname; - newInput.type = "hidden"; - newInput.className = "text"; - oTr.appendChild(newInput); + var oAttrDisp = document.getElementById("attr_display_" + attrname); + if (!oAttrDisp) { + var oAttrDisp = document.createElement("input"); + oAttrDisp.name = "attr_display_" + attrname; + oAttrDisp.id = "attr_display_" + attrname; + oAttrDisp.type = "hidden"; + oAttrDisp.className = "text"; + oTr.appendChild(oAttrDisp); } if ( display == "none" ) { oAttrDisp.value = "0";

12 years, 5 months

Check_MK Git: check_mk: FIX: Only showing sudo hint message on sudo error message in automation

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: c9c28992b815782600ab5604edeae787bb340f5d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c9c28992b81578… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 17 15:59:37 2012 +0200 FIX: Only showing sudo hint message on sudo error message in automation command --- ChangeLog | 2 ++ web/htdocs/wato.py | 2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6a1766d..94152ef 100644 --- a/ChangeLog +++ b/ChangeLog @@ -25,6 +25,8 @@ all host related wato configuration files to distribute changed tags * WATO: Added new internal hook pre-activate-changes to execute custom code BEFORE Check_MK is called to restart Nagios + * FIX: Only showing sudo hint message on sudo error message in automation + command Multisite * Added config option default_ts_format to configure default timestamp diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 65e50d0..7b316b1 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -3405,7 +3405,7 @@ def check_mk_local_automation(command, args=[], indata=""): if config.debug: log_audit(None, "automation", "Automation command %s failed with exit code %d: %s" % (" ".join(cmd), exitcode, outdata)) raise MKGeneralException("Error running <tt>%s</tt> (exit code %d): <pre>%s</pre>%s" % - (" ".join(cmd), exitcode, hilite_errors(outdata), sudo_msg)) + (" ".join(cmd), exitcode, hilite_errors(outdata), outdata.lstrip().startswith('sudo:') and sudo_msg or '')) # On successful "restart" command execute the activate changes hook if command == 'restart':

12 years, 5 months

Check_MK Git: check_mk: Updated bug entries #0601, #0659, #0654

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 2b3ed0d9b49d3123a53f1560a1649df9d9e74ac4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2b3ed0d9b49d31… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 17 15:59:36 2012 +0200 Updated bug entries #0601, #0659, #0654 --- .bugs/601 | 7 +++++-- .bugs/654 | 7 +++++-- .bugs/659 | 7 +++++-- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/.bugs/601 b/.bugs/601 index 6f86b24..f074e95 100644 --- a/.bugs/601 +++ b/.bugs/601 @@ -1,9 +1,9 @@ Title: Checkboxes in views and brower back in disharmony Component: multisite -State: open +Class: bug +State: works4me Date: 2012-01-17 11:43:07 Targetversion: 1.2.0 -Class: bug Tested on IE8, but might be browser independent. The following steps produce the problem: @@ -18,3 +18,6 @@ The following steps produce the problem: 5. Now again select a command. -> Now the command will be applied to *all* services instead of the one. + +2012-04-17 15:15:51: changed state open -> works4me +Maybe already fixed. Tested in Firefox, IE7-9 diff --git a/.bugs/654 b/.bugs/654 index 770b51a..64cd990 100644 --- a/.bugs/654 +++ b/.bugs/654 @@ -1,10 +1,13 @@ Title: View editor mixes up views on editing Component: multisite -State: open +Class: bug +State: works4me Date: 2012-02-15 08:48:38 Targetversion: future -Class: bug We had a strange problem. We had a view named "offline_locations" using the "All services" table. Then we added a "offline_locations1" view which used the "All hosts" table. BUt after saving the second view had the same options as the first view. + +2012-04-17 15:41:40: changed state open -> works4me +Must have been a user problem. I can not reproduce such problems. diff --git a/.bugs/659 b/.bugs/659 index 011f48a..238c7da 100644 --- a/.bugs/659 +++ b/.bugs/659 @@ -1,11 +1,14 @@ Title: Host validation error does invalidate the _transid of the current page Component: wato -State: open +Class: bug +State: works4me Date: 2012-02-17 15:42:32 Targetversion: future -Class: bug If a host validation error occurs on saving a host, the user needs to return to the folder an re-edit the host from start. It seems that the transaction id of the current page gets invalid, and a subsequent save on the same page wont work + +2012-04-17 15:22:17: changed state open -> works4me +Seems that this has already been fixed. It works foor me over here

12 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits