Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64400 discussions

Check_MK Git: check_mk: Fixed problem on user profile page when no alias set for a user

by Lars Michelsen

Module: check_mk Branch: master Commit: b22e1fd423892da497a182a544efeade27b1409c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b22e1fd423892d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 21 15:41:16 2013 +0100 Fixed problem on user profile page when no alias set for a user --- ChangeLog | 2 ++ web/htdocs/wato.py | 2 +- web/plugins/userdb/ldap.py | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 378b33e..529fa72 100644 --- a/ChangeLog +++ b/ChangeLog @@ -7,6 +7,8 @@ WATO: * Added hr_mem check to the memory checkgroup to make it configurable in WATO + * Fixed some typos in ldap error messages + * Fixed problem on user profile page when no alias set for a user 1.2.1i5: Core: diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index fae9b2c..f5da593 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -10947,7 +10947,7 @@ def page_user_profile(): forms.header(_("Personal Settings")) forms.section(_("Name"), simple=True) - html.write(user["alias"]) + html.write(user.get("alias", config.user_id)) if config.may('general.change_password') and not is_locked('password'): forms.section(_("Password")) diff --git a/web/plugins/userdb/ldap.py b/web/plugins/userdb/ldap.py index 86eb6b2..af09db0 100644 --- a/web/plugins/userdb/ldap.py +++ b/web/plugins/userdb/ldap.py @@ -159,7 +159,7 @@ def ldap_default_bind(): ldap_bind('', '', catch = False) # anonymous bind except (ldap.INVALID_CREDENTIALS, ldap.INAPPROPRIATE_AUTH): raise MKLDAPException(_('Unable to connect to LDAP server with the configured bind credentials. ' - 'Plase fix this in the ' + 'Please fix this in the ' '<a href="wato.py?mode=edit_configvar&varname=ldap_connection">LDAP ' 'connection settings</a>.')) @@ -423,7 +423,7 @@ ldap_attribute_plugins['alias'] = { def ldap_convert_auth_expire(params, user_id, ldap_user, user): changed_attr = params.get('attr', ldap_attr('pw_changed')) if not changed_attr in ldap_user: - raise MKLDAPException(_('The "Authentication Expiration" attribute (%s) could not be fetched' + raise MKLDAPException(_('The "Authentication Expiration" attribute (%s) could not be fetched ' 'from the LDAP server for user %s.') % (changed_attr, ldap_user)) # For keeping this thing simple, we don't parse the date here. We just store

11 years, 8 months

Check_MK Git: check_mk: Merge branch 'master' of mathias-kettner.de: check_mk

by Lars Michelsen

Module: check_mk Branch: master Commit: fdafdce2095cd93ff72e7de3aa9256dfc1c2374c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fdafdce2095cd9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 21 16:45:54 2013 +0100 Merge branch 'master' of mathias-kettner.de:check_mk Conflicts: ChangeLog ---

11 years, 8 months

Check_MK Git: check_mk: Reserved 20 bug IDS

by Lars Michelsen

Module: check_mk Branch: master Commit: c762c418157c2228824c18ee1de6c83f33feb48c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c762c418157c22… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 21 16:46:10 2013 +0100 Reserved 20 bug IDS --- .bugs/first_free | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/.bugs/first_free b/.bugs/first_free index 8a65506..cdfbfef 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -897 +917

11 years, 8 months

Check_MK Git: check_mk: Updated bug entries #0876

by Mathias Kettner

Module: check_mk Branch: master Commit: 67762a388441d69ed3e570d44df52754d98c8981 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=67762a388441d6… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Jan 21 16:38:46 2013 +0100 Updated bug entries #0876 --- .bugs/876 | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/876 b/.bugs/876 index 0ddf177..6490d00 100644 --- a/.bugs/876 +++ b/.bugs/876 @@ -1,9 +1,9 @@ Title: Notification form broken after personal settings editing Component: wato -State: open +Class: bug +State: done Date: 2013-01-18 11:50:32 Targetversion: 1.2.2 -Class: bug When editing the personal settings while being permitted to edit the custom notifications, the shown data seems to be broken after submission. For example the title of a custom @@ -11,3 +11,6 @@ notification is set to "Notify by: (no title)" instead of the correct title. It seems that the CascadingDropdown (and maybe also ListOf) do not use the "value" provided to the render_input() method. Instead of it they try to fetch the infos from html.var. + +2013-01-21 16:38:44: changed state open -> done +fixed.

11 years, 8 months

Check_MK Git: check_mk: Removed bug entry for a bug that was not a bug

by Mathias Kettner

Module: check_mk Branch: master Commit: 5878144c25b03c223db56c6c9b868809bae993e2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5878144c25b03c… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Jan 21 16:38:21 2013 +0100 Removed bug entry for a bug that was not a bug --- .bugs/664 | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/.bugs/664 b/.bugs/664 deleted file mode 100644 index 535fe54..0000000 --- a/.bugs/664 +++ /dev/null @@ -1,7 +0,0 @@ -Title: ups_bat_temp check_info group has no counterpart in wato gui -Component: checks -State: open -Date: 2013-01-18 16:33:38 -Targetversion: future -Class: bug -

11 years, 8 months

Check_MK Git: check_mk: Fix two bugs in value specs ListOf and Foldable

by Mathias Kettner

Module: check_mk Branch: master Commit: 7ab33bb837f99236ce5beadd6aada11df49706a5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7ab33bb837f992… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Jan 21 16:37:04 2013 +0100 Fix two bugs in value specs ListOf and Foldable --- ChangeLog | 2 ++ web/htdocs/pages.css | 5 ++++- web/htdocs/valuespec.py | 21 ++++++++++++++------- 3 files changed, 20 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 378b33e..4ec22b0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -7,6 +7,8 @@ WATO: * Added hr_mem check to the memory checkgroup to make it configurable in WATO + * FIX: list valuespecs could not be extended after once saving + * FIX: fix title of foldable areas contained in list valuespecs 1.2.1i5: Core: diff --git a/web/htdocs/pages.css b/web/htdocs/pages.css index 1444c71..2bf6d35 100644 --- a/web/htdocs/pages.css +++ b/web/htdocs/pages.css @@ -623,10 +623,13 @@ table.nform tr.heading > td:hover { background-image: url("images/white_20percent.png"); } +table.nform > tbody > tr td { + color: black; +} + table.nform > tbody > tr > td { vertical-align: middle; height: 27px; - color: black; } table.nform > tbody > tr > td.simple { diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index 0b985db..37ec526 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -656,11 +656,12 @@ class ListOf(ValueSpec): value = [None] * count # dummy for the loop else: filled_in = False - html.hidden_field('%s_count' % varprefix, - str(len(value)), - id = '%s_count' % varprefix, - add_var = True - ) + count = len(value) + + html.hidden_field('%s_count' % varprefix, + str(count), + id = '%s_count' % varprefix, + add_var = True) # Actual table of currently existing entries html.write('<table class="valuespec_listof" id="%s_table">' % varprefix) @@ -2058,13 +2059,19 @@ class Foldable(ValueSpec): def render_input(self, varprefix, value): try: - title = self._title_function(value) + title_value = value + if html.form_submitted(): + try: + title_value = self._valuespec.from_html_vars(varprefix) + except: + pass + title = self._title_function(title_value) except: title = self._valuespec.title() if not title: title = _("(no title)") html.begin_foldable_container("valuespec_foldable", varprefix, self._open, - title, False) + title, False) html.help(self._valuespec.help()) self._valuespec.render_input(varprefix, value) html.end_foldable_container()

11 years, 8 months

Check_MK Git: check_mk: Updated bug entries #0885

by Mathias Kettner

Module: check_mk Branch: master Commit: dadec77f1bd47edf84db6046199d28a60317ba39 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=dadec77f1bd47e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Jan 21 15:56:52 2013 +0100 Updated bug entries #0885 --- .bugs/885 | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/.bugs/885 b/.bugs/885 new file mode 100644 index 0000000..aa1ce44 --- /dev/null +++ b/.bugs/885 @@ -0,0 +1,10 @@ +Title: Password field in personal settings must not be prefilled by browser +Component: multisite +State: open +Date: 2013-01-21 15:55:44 +Targetversion: 1.2.2 +Class: bug + +If the browser enters a possible previous password then after saving +(because of changes to the notifications) the user password gets +changed and the user logged out - forever.

11 years, 8 months

Check_MK Git: check_mk: Added hr_mem check to the memory checkgroup to make it configurable in WATO

by Lars Michelsen

Module: check_mk Branch: master Commit: 27bf3136bb87254471bb0dca90261698fa15a299 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=27bf3136bb8725… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 21 12:29:37 2013 +0100 Added hr_mem check to the memory checkgroup to make it configurable in WATO --- ChangeLog | 3 +++ checks/hr_mem | 1 + 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9f9f508..378b33e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,9 @@ * cmk --notify: added the macros NOTIFY_LASTHOSTSTATECHANGE, NOTIFY_HOSTSTATEID, NOTIFY_LASTSERVICESTATECHANGE and NOTIFY_SERVICESTATEID + WATO: + * Added hr_mem check to the memory checkgroup to make it configurable in WATO + 1.2.1i5: Core: * Improved handling of CTRL+C (SIGINT) to terminate long runnining tasks diff --git a/checks/hr_mem b/checks/hr_mem index 4f334eb..51ca31f 100644 --- a/checks/hr_mem +++ b/checks/hr_mem @@ -103,3 +103,4 @@ snmp_info["hr_mem"] = ( ".1.3.6.1.2.1.25.2.3.1", [ ] ) snmp_scan_functions["hr_mem"] = lambda oid: \ not not oid('.1.3.6.1.2.1.25.1.1.0') # HOST-RESOURCES-MIB::hrSystemUptime.0 +checkgroup_of['hr_mem'] = "memory"

11 years, 8 months

Check_MK Git: check_mk: cmk --notify: added notification script to generate HTML mails including the performance graphs of hosts and services

by Lars Michelsen

Module: check_mk Branch: master Commit: 936fcb0cc58624868845179e6b376de2bf73e05b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=936fcb0cc58624… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Jan 21 11:17:55 2013 +0100 cmk --notify: added notification script to generate HTML mails including the performance graphs of hosts and services --- ChangeLog | 5 + check_mk_templates.cfg | 4 + modules/notify.py | 28 ++++- notifications/mail | 397 ++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 433 insertions(+), 1 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=936fcb0cc5…

11 years, 8 months

Check_MK Git: check_mk: Updated bug entries #0664

by Andreas Boesl

Module: check_mk Branch: master Commit: f1d67d2a692edbeb3d367eb549c62a780304cb7a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f1d67d2a692edb… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Jan 18 16:34:09 2013 +0100 Updated bug entries #0664 --- .bugs/664 | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/.bugs/664 b/.bugs/664 new file mode 100644 index 0000000..535fe54 --- /dev/null +++ b/.bugs/664 @@ -0,0 +1,7 @@ +Title: ups_bat_temp check_info group has no counterpart in wato gui +Component: checks +State: open +Date: 2013-01-18 16:33:38 +Targetversion: future +Class: bug +

11 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits