Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64477 discussions

Check_MK Git: check_mk: Reserved 10 bug IDS

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: c21c6f30ac8d30b34c874a691d29fc3932de6f4c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c21c6f30ac8d30… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Mon Aug 26 09:44:39 2013 +0200 Reserved 10 bug IDS --- .bugs/972 | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ .bugs/973 | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ .bugs/first_free | 2 +- 3 files changed, 98 insertions(+), 1 deletion(-) diff --git a/.bugs/972 b/.bugs/972 new file mode 100644 index 0000000..c6ea266 --- /dev/null +++ b/.bugs/972 @@ -0,0 +1,48 @@ +Title: parent scan fails after renaming a wato folder +Component: wato +State: open +Date: 2013-08-09 16:33:23 +Targetversion: 1.2.3 +Class: bug + +came in via feedback@ // original mail still available at folder feedback/gitbug + + +To: feedback(a)check-mk.org +MIME-Version: 1.0 +Subject: =?ISO-8859-1?Q?[BUG]=3A_2013=2E06=2E17=2E_-_Parent_Scan_schl=E4gt_fehl?= + =?ISO-8859-1?Q?_nach_Ordner_Namensanpassung?= +X-KeepSent: 8EC789A2:22AB56CB-C1257B91:0039EA95; + type=4; name=$KeepSent +X-Mailer: Lotus Notes Release 8.5.3FP1 March 08, 2012 +Message-ID: <OF8EC789A2.22AB56CB-ONC1257B91.0039EA95-C1257B91.003ADE67(a)bechtle.de> +From: tim.kreutzer(a)bechtle.com +Date: Fri, 21 Jun 2013 12:43:00 +0200 + + +Hallo Feedback, + +mir ist folgendes in der Entwickler Version 2013.06.17 aufgefallen. +Kurzes Beispiel: + +Folgende Ordner in WATO: +Main Directory\Kunde\Hosts + +Nach Änderung des Namens des Ordners in z.B: +Main Directory\KundeXYZ\Hosts + +Versucht der Parent Scan in WATO die Hosts unter dem alten Ordner Namen (Main Directory\Kunde\Hosts )zu finden und schlägt fehl. Alle bestehenden Regeln wurden, einwandfrei auf den neuen Ordner angepasst. +Hoffe das war euch noch nicht bekannt, habe in der Bug Liste nichts dazu gefunden. + +Mit freundlichen Grüßen + +Tim Kreutzer +System Engineer + +Bechtle GmbH +IT-Systemhaus Bremen +Otto-Lilienthal Straße 20, D - 28199 Bremen +Tel: +49 421 59680-804 +Fax: +49 421 59680-596 +E-Mail: tim.kreutzer(a)bechtle.com +Internet: http://www.bechtle.com diff --git a/.bugs/973 b/.bugs/973 new file mode 100644 index 0000000..7aa850a --- /dev/null +++ b/.bugs/973 @@ -0,0 +1,49 @@ +Title: problem in check options for check_dns +Component: checks +State: open +Date: 2013-08-09 16:39:44 +Targetversion: 1.2.3 +Class: bug + +came in via checkmk-de@ // original mail is still available at folder feedback/gitbug + + +Date: Fri, 21 Jun 2013 16:00:56 +0200 +From: Martin Schwarz <ms(a)ilk.net> +To: checkmk-de(a)lists.mathias-kettner.de +Message-ID: <20130621140055.GJ11388(a)ilk.net> +MIME-Version: 1.0 +Content-Disposition: inline +User-Agent: Mutt/1.5.18 (2008-05-17) +Subject: [Check_mk (deutsch)] =?iso-8859-1?q?Fehler_in_Optionen_f=FCr_Chec?= + =?iso-8859-1?q?k_DNS_service=3F?= + +Hallo, + +bin gerade in WATO auf einen Punkt gestoßen, den ich für einen Fehler +halte, und zwar beim Konfigurieren eines aktiven DNS-Checks unter + + WATO > Host & Service Parameters > Active checks (HTTP, TCP, etc.) > Check DNS service + +Wenn ich das richtig verstehe, ist das ja "nur" die Check_MK-Integration +für das Standard-Nagios-Plugin "check_dns". Die WATO-Eingabemaske für +den Check erwartet nun bei angekreuztem "Expected Authority" auch +zwingend eine Eingabe in diesem Feld. Im Nagios-Plugin ist das Argument +aber: + + -A, --expect-authority + Optionally expect the DNS server to be authoritative for the lookup + +Also einfach die Option Ja/Nein, ob die erwartete DNS-Antwort +autoritativ sein soll, nicht "-A %s" wie im Check-MK-Script. + +Ich hab mir in WATO erstmal durch Eingabe von '' (also leerem String) +geholfen. Ich bin noch nicht so vertraut mit Check_MK, daher wollte ich +lieber erstmal hier nachfragen - als Alternative zu einem Bug-Report. + +Gruß +Martin + +(Check_MK 1.2.2p2 aus OMD 1.00) + +-- Martin Schwarz, Systems Engineer, mailto:ms@ilk.net ILK Internet GmbH, Am Sandfeld 15, D-76149 Karlsruhe Tel: +49 (0) 721 9100-0, Fax: -191, http://www.ilk.net/ Geschaeftsfuehrer Matthias Felger, AG Mannheim, HRB 107037 _______________________________________________ checkmk-de mailing list checkmk-de(a)lists.mathias-kettner.de http://lists.mathias-kettner.de/mailman/listinfo/checkmk-de diff --git a/.bugs/first_free b/.bugs/first_free index 327f63b..4fba33e 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -1027 +1037

11 years, 1 month

Check_MK Git: check_mk: Updated bug entries #0936

by Andreas Boesl

Module: check_mk Branch: master Commit: cbd68069095a5d34e09f5a480166bf74e3f97544 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cbd68069095a5d… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Aug 23 14:39:34 2013 +0200 Updated bug entries #0936 --- .bugs/936 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.bugs/936 b/.bugs/936 new file mode 100644 index 0000000..73f6772 --- /dev/null +++ b/.bugs/936 @@ -0,0 +1,8 @@ +Title: WATO dictionary parameter inheritance +Component: wato +State: open +Date: 2013-08-23 14:38:18 +Targetversion: 1.2.3 +Class: nastiness + +Once set, there is no option to unset a dictionary key from a parent folder

11 years, 1 month

Check_MK Git: check_mk: Updated bug entries #0830

by Bastian Kuhn

Module: check_mk Branch: master Commit: f736336246b81913638808e46c0e2c99851d3bcf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f736336246b819… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Fri Aug 23 13:57:00 2013 +0200 Updated bug entries #0830 --- .bugs/830 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.bugs/830 b/.bugs/830 new file mode 100644 index 0000000..d0e9890 --- /dev/null +++ b/.bugs/830 @@ -0,0 +1,8 @@ +Title: check_dns is missing in omd builds of debian 7.1 +Component: checks +State: open +Date: 2013-08-23 13:56:01 +Targetversion: 1.2.3 +Class: bug + +the nagios plugin check_dns is missing in the omd build of debian 7.1

11 years, 1 month

Check_MK Git: check_mk: win_printers: Monitoring of printer queue on a windows printserver

by Bastian Kuhn

Module: check_mk Branch: master Commit: fc9471fe2ed1bc8915aae50da85cf4ace8cc3ed4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fc9471fe2ed1bc… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Fri Aug 23 14:09:46 2013 +0200 win_printers: Monitoring of printer queue on a windows printserver --- ChangeLog | 1 + agents/windows/plugins/win_printers.ps1 | 240 +++++++++++++++++++++++++++++++ checkman/win_printers | 20 +++ checks/win_printers | 95 ++++++++++++ web/plugins/wato/check_parameters.py | 18 +++ 5 files changed, 374 insertions(+) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=fc9471fe2e…

11 years, 1 month

Check_MK Git: check_mk: Added another missing help text

by Lars Michelsen

Module: check_mk Branch: master Commit: 04b574f621a0069d95d3cdce61e36343c1a1a6d6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=04b574f621a006… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Aug 23 13:36:51 2013 +0200 Added another missing help text --- web/plugins/userdb/ldap.py | 2 ++ web/plugins/wato/check_mk_configuration.py | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/web/plugins/userdb/ldap.py b/web/plugins/userdb/ldap.py index d58d873..488fccb 100644 --- a/web/plugins/userdb/ldap.py +++ b/web/plugins/userdb/ldap.py @@ -338,6 +338,7 @@ def ldap_search(base, filt = '(objectclass=*)', columns = [], scope = None): except ldap.SERVER_DOWN: if tries_left: ldap_log(' Received SERVER_DOWN. Retrying...') + ldap_connection.reconnect(ldap_connection._uri) time.sleep(0.5) else: break @@ -345,6 +346,7 @@ def ldap_search(base, filt = '(objectclass=*)', columns = [], scope = None): duration = time.time() - start_time if not success: + ldap_log(' FAILED') raise MKLDAPException(_('Unable to successfully perform the LDAP search. ' 'Maybe there is a connection problem with the LDAP server.')) diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py index 8d1b649..54b7cf6 100644 --- a/web/plugins/wato/check_mk_configuration.py +++ b/web/plugins/wato/check_mk_configuration.py @@ -1202,7 +1202,10 @@ register_rule(group, "host_groups", GroupSelection( "host", - title = _("Assignment of hosts to host groups")), + title = _("Assignment of hosts to host groups"), + help = _("Hosts can be grouped together into host groups. The most common use case " + "is to put hosts which belong together in a host group to make it possible " + "to get them listed together in the status GUI.")), match = "all") register_rule(group,

11 years, 1 month

Check_MK Git: check_mk: Added missing help string

by Lars Michelsen

Module: check_mk Branch: master Commit: 851acca2b3f1aa4cbb4f5d7cd7fd81dc005b85f3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=851acca2b3f1aa… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Aug 23 12:46:20 2013 +0200 Added missing help string --- web/plugins/wato/check_mk_configuration.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py index 85d5344..8d1b649 100644 --- a/web/plugins/wato/check_mk_configuration.py +++ b/web/plugins/wato/check_mk_configuration.py @@ -1822,7 +1822,9 @@ register_rule(group, title = _("Privacy protocol")), TextAscii(title = _("Privacy pass phrase")), ])], - title = _("SNMP communities of monitored hosts"))) + title = _("SNMP communities of monitored hosts"), + help = _("By default Check_MK uses the community \"public\" to contact hosts via SNMP. This rule " + "can be used to customize the the credentials to be used when contacting hosts via SNMP."))) register_rule(group, "snmp_character_encodings",

11 years, 1 month

Check_MK Git: check_mk: Updated bug entries #1017, #1018

by Lars Michelsen

Module: check_mk Branch: master Commit: c70958b364298fe9e850128155f4ace5303c8017 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c70958b364298f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Aug 23 12:27:30 2013 +0200 Updated bug entries #1017, #1018 --- .bugs/1017 | 8 ++++++++ .bugs/1018 | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/.bugs/1017 b/.bugs/1017 new file mode 100644 index 0000000..23bdb20 --- /dev/null +++ b/.bugs/1017 @@ -0,0 +1,8 @@ +Title: df levels percentage is treated wrong (int instead of float) +Component: checks +State: open +Date: 2013-08-23 12:25:23 +Targetversion: 1.2.3 +Class: nastiness + +fix either check, wato and/or manpage diff --git a/.bugs/1018 b/.bugs/1018 new file mode 100644 index 0000000..a084bfa --- /dev/null +++ b/.bugs/1018 @@ -0,0 +1,8 @@ +Title: Remove peer replication from WATO -> useless, senseless, confusing +Component: wato +State: open +Date: 2013-08-23 12:26:21 +Targetversion: 1.2.3 +Class: nastiness + +It confuses people. This feature does not seem to matter.

11 years, 1 month

Check_MK Git: check_mk: Reserved 10 bug IDS

by Lars Michelsen

Module: check_mk Branch: master Commit: c502a47ab452d3bf28e0e52e90880db4ca056d4f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c502a47ab452d3… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Aug 23 12:24:56 2013 +0200 Reserved 10 bug IDS --- .bugs/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/first_free b/.bugs/first_free index 0842778..327f63b 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -1017 +1027

11 years, 1 month

Check_MK Git: check_mk: Fixed string

by Lars Michelsen

Module: check_mk Branch: master Commit: ba5e67b38b1b3a8c716b7b08e220a9ed1d004fed URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ba5e67b38b1b3a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Aug 23 12:25:11 2013 +0200 Fixed string --- web/htdocs/bi.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/bi.py b/web/htdocs/bi.py index c67a410..35caefd 100644 --- a/web/htdocs/bi.py +++ b/web/htdocs/bi.py @@ -321,7 +321,7 @@ def compile_forest(user, only_hosts = None, only_groups = None): continue if len(entry) < 3: - raise MKConfigError(_("<h1>Invalid aggregation <tt>%s</tt>'</h1>" + raise MKConfigError(_("<h1>Invalid aggregation <tt>%s</tt></h1>" "Must have at least 3 entries (has %d)") % (entry, len(entry))) if type(entry[0]) == list:

11 years, 1 month

Check_MK Git: check_mk: ldap: Trying to handle unstable ldap connections a bit better

by Lars Michelsen

Module: check_mk Branch: master Commit: 396ee8524aa590c426ba5e9615ec8f44b6cbb657 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=396ee8524aa590… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Aug 23 09:39:54 2013 +0200 ldap: Trying to handle unstable ldap connections a bit better --- web/plugins/userdb/ldap.py | 69 +++++++++++++++++++++++++++----------------- 1 file changed, 42 insertions(+), 27 deletions(-) diff --git a/web/plugins/userdb/ldap.py b/web/plugins/userdb/ldap.py index 1e8d2c4..d58d873 100644 --- a/web/plugins/userdb/ldap.py +++ b/web/plugins/userdb/ldap.py @@ -304,37 +304,52 @@ def ldap_search(base, filt = '(objectclass=*)', columns = [], scope = None): ldap_log('LDAP_SEARCH "%s" "%s" "%s" "%r"' % (base, scope, filt, columns)) start_time = time.time() - result = [] - try: - - search_func = config.ldap_connection.get('page_size') \ - and ldap_paged_async_search or ldap_async_search - for dn, obj in search_func(base, scope, filt, columns): - if dn is None: - continue # skip unwanted answers - new_obj = {} - for key, val in obj.iteritems(): - # Convert all keys to lower case! - new_obj[key.lower().decode('utf-8')] = [ i.decode('utf-8') for i in val ] - result.append((dn, new_obj)) - except ldap.NO_SUCH_OBJECT, e: - raise MKLDAPException(_('The given base object "%s" does not exist in LDAP (%s))') % (base, e)) - - except ldap.FILTER_ERROR, e: - raise MKLDAPException(_('The given ldap filter "%s" is invalid (%s)') % (filt, e)) - - except ldap.SIZELIMIT_EXCEEDED: - raise MKLDAPException(_('The response reached a size limit. This could be due to ' - 'a sizelimit configuration on the LDAP server.<br />Throwing away the ' - 'incomplete results. You should change the scope of operation ' - 'within the ldap or adapt the limit settings of the LDAP server.')) + # In some environments, the connection to the LDAP server does not seem to + # be as stable as it is needed. So we try to repeat the query for three times. + tries_left = 3 + success = False + while not success: + tries_left -= 1 + try: + result = [] + try: + search_func = config.ldap_connection.get('page_size') \ + and ldap_paged_async_search or ldap_async_search + for dn, obj in search_func(base, scope, filt, columns): + if dn is None: + continue # skip unwanted answers + new_obj = {} + for key, val in obj.iteritems(): + # Convert all keys to lower case! + new_obj[key.lower().decode('utf-8')] = [ i.decode('utf-8') for i in val ] + result.append((dn, new_obj)) + success = True + except ldap.NO_SUCH_OBJECT, e: + raise MKLDAPException(_('The given base object "%s" does not exist in LDAP (%s))') % (base, e)) + + except ldap.FILTER_ERROR, e: + raise MKLDAPException(_('The given ldap filter "%s" is invalid (%s)') % (filt, e)) + + except ldap.SIZELIMIT_EXCEEDED: + raise MKLDAPException(_('The response reached a size limit. This could be due to ' + 'a sizelimit configuration on the LDAP server.<br />Throwing away the ' + 'incomplete results. You should change the scope of operation ' + 'within the ldap or adapt the limit settings of the LDAP server.')) + except ldap.SERVER_DOWN: + if tries_left: + ldap_log(' Received SERVER_DOWN. Retrying...') + time.sleep(0.5) + else: + break duration = time.time() - start_time + + if not success: + raise MKLDAPException(_('Unable to successfully perform the LDAP search. ' + 'Maybe there is a connection problem with the LDAP server.')) + ldap_log(' RESULT length: %d, duration: %0.3f' % (len(result), duration)) return result - #return ldap_connection.search_s(base, scope, filter, columns) - #for dn, obj in ldap_connection.search_s(base, scope, filter, columns): - # html.log(repr(dn) + ' ' + repr(obj)) # Returns the ldap filter depending on the configured ldap directory type def ldap_filter(key, handle_config = True):

11 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits