Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64478 discussions

Check_MK Git: check_mk: Updated bug entries #1054

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: 781ad19d81dbd7c5b0f9e6ec302eed7d53839094 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=781ad19d81dbd7… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Mon Sep 23 12:33:47 2013 +0200 Updated bug entries #1054 --- .bugs/1054 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.bugs/1054 b/.bugs/1054 new file mode 100644 index 0000000..f4bd6ce --- /dev/null +++ b/.bugs/1054 @@ -0,0 +1,10 @@ +Title: ps check returns perfdata +Component: checks +State: open +Date: 2013-09-23 12:32:48 +Targetversion: 1.2.3i2 +Class: nastiness + +ps check returns (some) perfdata: +pcpuavg=0;90;98;0;15 +but it should not. only ps.perf should!

11 years

Check_MK Git: check_mk: removed FIXME notes from check manpages, moved them into a gitbug

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: 6efaada9b8799e3878168cc91ca64de5bcc22285 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6efaada9b8799e… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Mon Sep 23 11:48:19 2013 +0200 removed FIXME notes from check manpages, moved them into a gitbug --- checkman/blade_bx_load | 2 -- checkman/blade_bx_powerfan | 2 -- checkman/blade_bx_powermod | 6 ++---- checkman/blade_bx_temp | 2 -- 4 files changed, 2 insertions(+), 10 deletions(-) diff --git a/checkman/blade_bx_load b/checkman/blade_bx_load index e6b857c..d1dfae1 100644 --- a/checkman/blade_bx_load +++ b/checkman/blade_bx_load @@ -4,8 +4,6 @@ catalog: hw/server/fujitsu license: GPL distribution: check_mk description: - FIXME: is this really CPU of enclosure? Asked Bastian to figure this out... - This check measures and checks the averaged CPU load of a Primergy BX600 Blade Enclosure. The values for 1, 5 and 15 minute average are reported. diff --git a/checkman/blade_bx_powerfan b/checkman/blade_bx_powerfan index 3ba4c61..5554605 100644 --- a/checkman/blade_bx_powerfan +++ b/checkman/blade_bx_powerfan @@ -4,8 +4,6 @@ catalog: hw/server/fujitsu license: GPL distribution: check_mk description: - FIXME: in Blade or in Enclosure? - Checks fans in Primergy BX600 Blade Servers. Returns {CRIT} if the fan is not present or powered off or reports a diff --git a/checkman/blade_bx_powermod b/checkman/blade_bx_powermod index 6eabc1a..f27b8c3 100644 --- a/checkman/blade_bx_powermod +++ b/checkman/blade_bx_powermod @@ -1,12 +1,10 @@ -title: Primergy BX600 Blade Server: Power module +title: Primergy BX600 Blade Enclosure: Power module agents: snmp catalog: hw/server/fujitsu license: GPL distribution: check_mk description: - FIXME: Blade Server or Blade Enclosure? - - Checks the state of power modules in Primergy BX600 Blade Servers + Checks the state of power modules in Primergy BX600 Blade Enclosures Returns {OK} if the power module reports ok status and {CRIT} on any other status. diff --git a/checkman/blade_bx_temp b/checkman/blade_bx_temp index 1567b3b..70d30e3 100644 --- a/checkman/blade_bx_temp +++ b/checkman/blade_bx_temp @@ -4,8 +4,6 @@ catalog: hw/server/fujitsu license: GPL distribution: check_mk description: - FIXME: in Blade Servers or Blade Enclosures? - Checks temperature sensors in Primergy BX600 Blade Servers. Returns {CRIT} if the sensor is not present or powered off or if the sensor

11 years

Check_MK Git: check_mk: Updated bug entries #1053

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: b56762eede0a30ed7be3681a7151cc27e2e40659 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b56762eede0a30… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Mon Sep 23 11:47:25 2013 +0200 Updated bug entries #1053 --- .bugs/1053 | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.bugs/1053 b/.bugs/1053 new file mode 100644 index 0000000..cac924a --- /dev/null +++ b/.bugs/1053 @@ -0,0 +1,15 @@ +Title: blade_bx_*: find out, what these check really check +Component: checks +State: open +Date: 2013-09-23 11:38:30 +Targetversion: future +Class: todo + +Bastian promised to figure this out +blade_bx_load: is this really CPU of enclosure? or in the Blade +blade_bx_powerfan: is it about fans in enclosure or in the blade +blade_bx_powermod: is it about power modules in enclosure or in the blade? +blade_bx_temp: is it about the temperature in enclosure or in the blade? + +Bastian needs to figure that out, afterwards the named check manpages +need to be updated

11 years

Check_MK Git: check_mk: Fixed strange html bug

by Andreas Boesl

Module: check_mk Branch: master Commit: b95080f57791734b194cde259385398269c84a42 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b95080f5779173… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Mon Sep 23 11:12:34 2013 +0200 Fixed strange html bug Incorrect rendering of valuespec_listof arrows/recyle bin Reason: Newline after html tag... (???) --- web/htdocs/htmllib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py index e856f33..88226a1 100644 --- a/web/htdocs/htmllib.py +++ b/web/htdocs/htmllib.py @@ -200,7 +200,7 @@ class html: def hidden_field(self, var, value, id = None, add_var = False): if value != None: id = id and ' id="%s"' % id or '' - self.write("<input type=\"hidden\" name=\"%s\" value=\"%s\"%s />\n" % + self.write("<input type=\"hidden\" name=\"%s\" value=\"%s\"%s />" % (self.attrencode(var), self.attrencode(value), id)) if add_var: self.add_form_var(var)

11 years

Check_MK Git: check_mk: Several spelling and grammar fixes

by Götz Golla

Module: check_mk Branch: master Commit: a3cbdbe6245d855c1ea055b27a7f871fef7b20a9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a3cbdbe6245d85… Author: Götz Golla <gg(a)mathias-kettner.de> Date: Mon Sep 23 10:24:19 2013 +0200 Several spelling and grammar fixes --- checkman/cisco_wlc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/checkman/cisco_wlc b/checkman/cisco_wlc index 300270f..a878761 100644 --- a/checkman/cisco_wlc +++ b/checkman/cisco_wlc @@ -1,12 +1,12 @@ -title: Wlan accesspoints from Cisco Wireless Lan Controller +title: Wlan accesspoints on Cisco Wireless Lan Controller agents: snmp catalog: hw/network/cisco license: GPL distribution: check_mk description: - This check automaticly detects all online accesspoints and checks for the current status. - If a accesspoint is not longer reachable, the checks also triggers an critical state. - The checks direct connects against a Cisco Wireless Lan Controller. Currently its tested + This check automatically detects all online accesspoints and checks for the current status. + If an accesspoint is not longer reachable, the checks also triggers a critical state. + The checks directly connects to a Cisco Wireless Lan Controller. Currently its tested with the model 5508. inventory: @@ -23,9 +23,9 @@ examples: [parameters] parameters(dict): with the keys "ap_model" and "ap_name" - The values of in this dict are list of tuples. Each tuple contain - eiter (ap_name(string), action(int)) or (ap_model(string), action(int)), - whereas the ap_name is the human readable name of the AP and the ap_model is the model number - The action represent the outcome when this model is missing and can be - set from 0 to 3 (OK, WARN, CRIT, UNKNOWN) + The values in this dict are lists of tuples. Each tuple contains + either (ap_name(string), action(int)) or (ap_model(string), action(int)), + where the ap_name is the human readable name of the AP and the ap_model is the model number. + The action represents the outcome when this model is missing and can be + from 0 to 3 (OK, WARN, CRIT, UNKNOWN)

11 years

Check_MK Git: check_mk: help text takes into account the new staleness feature

by Götz Golla

Module: check_mk Branch: master Commit: adc2daa2a4ac97124ba8b6dac30d3aff9142a5f4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=adc2daa2a4ac97… Author: Götz Golla <gg(a)mathias-kettner.de> Date: Mon Sep 23 10:14:48 2013 +0200 help text takes into account the new staleness feature --- web/plugins/wato/active_checks.py | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/web/plugins/wato/active_checks.py b/web/plugins/wato/active_checks.py index 2562b65..a8473f8 100644 --- a/web/plugins/wato/active_checks.py +++ b/web/plugins/wato/active_checks.py @@ -872,15 +872,13 @@ register_rule(group, ( "freshness", Dictionary( title = _("Check freshness"), - help = _("Freshness checking is only useful for passive checks. It makes sure that passive " - "check results are submitted on a regular basis. If not, the check is being set to " - "warning, critical or unknown.<br>" - "The freshness checking works in addition to the staleness feature. The latter grays " - "out passive checks for which no data were received after an interval. The interval " - "is calculated from the staleness value in <tt>Global Settings</tt> multiplied by " - "the normal check interval defined in a separate rule (default is 60sec). If you use " - "freshness checking you might want to modify the normal check interval for your check " - "as well."), + help = _("Freshness checking is only useful for passive checks when the staleness feature " + "is not enough for you. It changes the state of a check to a configurable other state " + "when the check results are not arriving in time. Staleness will still grey out the " + "test after the corrsponding interval. If you dont want that, you might want to adjust " + "the staleness interval as well. The staleness interval is calculated from the normal " + "check interval multiplied by the stateness value in the <tt>Global Settings</tt>. " + "The normal check interval can be configured in a separate rule for your check."), optional_keys = False, elements = [ ( "interval",

11 years

Check_MK Git: check_mk: Further minor cleanups in ChangeLog

by Mathias Kettner

Module: check_mk Branch: master Commit: e97024163a9d8e56d65884955d56008faa7a4f15 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e97024163a9d8e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Sep 22 11:50:26 2013 +0200 Further minor cleanups in ChangeLog --- ChangeLog | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 79516a9..3f55961 100644 --- a/ChangeLog +++ b/ChangeLog @@ -94,6 +94,11 @@ * windows_agent: windows eventlog informational/audit logs now reported with O prefix * mk_logwatch: ignored loglines now reported with an "." prefix (if required) * check_mk-if.pnp: fixed bug with pnp template on esx hosts without perfdata + * jolokia checks (JVM): uptime, threads, sessions, requests, queue + now configurable via WATO + * vSphere checks: secret is not shown to the user via WATO anymore + * WATO rule to check state of physical switch (currently used by etherbox check) + * cisco_wlc: Allows to configure handling of missing AP * FIX: blade_blades: Fixed output of "(UNKNOWN)" even if state is OK * FIX: apache_status: fix exception if parameter is None * FIX: hr_mem: handle virtual memory correct on some devices @@ -186,9 +191,6 @@ WATO: * Allow to configure check-/retry_interval in second precision - * vSphere secret is not shown to the user via WATO anymore - * New rules for jolokia check (JVM): uptime, threads, sessions, - requests, queue * Custom user attributes can now be managed using WATO * Allow GIT to be used for change tracking (enable via global option) * Hosts/Folders: SNMP communities can now be configured via the host @@ -198,8 +200,6 @@ * Removed "do not connect" option from site socket editor. Use the checkbox "Disable" to disable the site for multisite. * Converted table of Event Console Rules to new implementation, make it sortable - * ADD: Rule to check state of physical switch (currently used by etherbox check) - * ADD: new ruleset cisco_wlc: Allows to configure handling of missing AP * FIX: do validation of check items in rule editor * FIX: More consistent handling of folderpath select in rule editor * FIX: Now correctly handling depends_on_tags on page rendering for

11 years

Check_MK Git: check_mk: Convert one .f12 to .site possibility

by Mathias Kettner

Module: check_mk Branch: master Commit: f2c6bd5d99e79504336ae74a6aa8db7d8bfd9be8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f2c6bd5d99e795… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Sep 22 11:36:48 2013 +0200 Convert one .f12 to .site possibility --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 074a283..f78274b 100644 --- a/.gitignore +++ b/.gitignore @@ -19,3 +19,4 @@ check-mk-agent-*.exe .metadata RemoteSystemsTempFiles .directory +.site

11 years

Check_MK Git: check_mk: Make EC rules table searchable

by Mathias Kettner

Module: check_mk Branch: master Commit: 4a51ba280fac9f53643769a967690d099590b154 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4a51ba280fac9f… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Sep 22 11:35:22 2013 +0200 Make EC rules table searchable --- ChangeLog | 7 +++-- mkeventd/web/.f12 | 1 + mkeventd/web/plugins/wato/mkeventd.py | 54 ++++++++++++--------------------- 3 files changed, 24 insertions(+), 38 deletions(-) diff --git a/ChangeLog b/ChangeLog index ab657df..b666170 100644 --- a/ChangeLog +++ b/ChangeLog @@ -99,6 +99,7 @@ vCenter is still queried by old version * windows_agent: windows eventlog informational/audit logs now reported with O prefix * mk_logwatch: ignored loglines now reported with an "." prefix (if required) + * check_mk-if.pnp: fixed bug with pnp template on esx hosts without perfdata Notifications: @@ -119,7 +120,6 @@ performance value. This might not always be the one you like, but its far better than nothing. * logwatch: Logwatch icon no longer uses notes_url - * check_mk-if.pnp: fixed bug with pnp template on esx hosts without perfdata * Inventory screen: Host inventory also displays its clustered services * Rules: Renamed "Ignored services" to "Disabled services" Renamed "Ignored checks" to "Disabled checks" @@ -139,7 +139,7 @@ * LDAP: Moved configuration to dedicated page which also provides some testing mechanisms for the configuration * Added option to enable browser scrollbar to the multisite sidebar (only - via "sidebar_show_scrollbar = True" in multisite.mk + via "sidebar_show_scrollbar = True" in multisite.mk * Added option to disable automatic userdb synchronizations in multisite * Implemented search forms for most data tables * New icons in view footers: export as CSV, export as JSON @@ -190,6 +190,7 @@ Host/Service/Contact Groups, Timeperiods and Roles * Removed "do not connect" option from site socket editor. Use the checkbox "Disable" to disable the site for multisite. + * Converted table of Event Console Rules to new implementation, make it sortable * ADD: Rule to check state of physical switch (currently used by etherbox check) * ADD: new ruleset cisco_wlc: Allows to configure handling of missing AP * FIX: do validation of check items in rule editor @@ -198,7 +199,7 @@ inherited values * FIX: Changed several forms from GET to POST to prevent "Request-URI too large" error messages during submitting forms - * FIX: automation snmp scan now adhere rules for shoddy snmp devices + * FIX: automation snmp scan now adhere rules for shoddy snmp devices which have no sys description * FIX: Cisco ruleset "Cisco WLC WiFi client connections" has been generalized to "WLC WiFi client connections" diff --git a/mkeventd/web/.f12 b/mkeventd/web/.f12 index 099b086..65cd700 100644 --- a/mkeventd/web/.f12 +++ b/mkeventd/web/.f12 @@ -1,4 +1,5 @@ #!/bin/bash +SITE=${SITE:-$(cat ../../.site)} SITE=${SITE:-$(omd sites --bare | head -n 1)} C=$(sudo cp --preserve=mode -rv * /omd/sites/$SITE/share/check_mk/web/ | wc -l) #C=$(sudo cp --preserve=mode -rv htdocs/*.{css,py} /omd/versions/default/share/check_mk/web/htdocs/ | wc -l) diff --git a/mkeventd/web/plugins/wato/mkeventd.py b/mkeventd/web/plugins/wato/mkeventd.py index f836951..25a5c43 100644 --- a/mkeventd/web/plugins/wato/mkeventd.py +++ b/mkeventd/web/plugins/wato/mkeventd.py @@ -872,26 +872,11 @@ def mode_mkeventd_rules(phase): event = None if rules: - html.write('<table class=data>') - html.write("<tr>") - html.write("<th>%s</th>" % _("Actions")) - html.write("<th></th>") - html.write("<th>%s</th>" % _("ID")) - html.write("<th>%s</th>" % _("State")) - html.write("<th>%s</th>" % _("Priority")) - html.write("<th>%s</th>" % _("Facility")) - html.write("<th>%s</th>" % _("Service Level")) - if defaults.omd_root: - html.write("<th>%s</th>" % _("Hits")) - html.write("<th>%s</th>" % _("Description")) - html.write("<th>%s</th>" % _("Text to match")) - html.write("</tr>") + table.begin(limit = None) - odd = "even" have_match = False for nr, rule in enumerate(rules): - odd = odd == "odd" and "even" or "odd" - html.write('<tr class="data %s0">' % odd) + table.row() delete_url = make_action_link([("mode", "mkeventd_rules"), ("_delete", nr)]) top_url = make_action_link([("mode", "mkeventd_rules"), ("_move", nr), ("_where", 0)]) bottom_url = make_action_link([("mode", "mkeventd_rules"), ("_move", nr), ("_where", len(rules)-1)]) @@ -899,7 +884,8 @@ def mode_mkeventd_rules(phase): down_url = make_action_link([("mode", "mkeventd_rules"), ("_move", nr), ("_where", nr+1)]) edit_url = make_link([("mode", "mkeventd_edit_rule"), ("edit", nr)]) clone_url = make_link([("mode", "mkeventd_edit_rule"), ("clone", nr)]) - html.write('<td class=buttons>') + + table.cell(_("Actions"), css="buttons") html.icon_button(edit_url, _("Edit this rule"), "edit") html.icon_button(clone_url, _("Create a copy of this rule"), "clone") html.icon_button(delete_url, _("Delete this rule"), "delete") @@ -917,8 +903,7 @@ def mode_mkeventd_rules(phase): html.empty_icon_button() html.empty_icon_button() - html.write('</td>') - html.write('<td>') + table.cell("") if rule.get("disabled"): html.icon(_("This rule is currently disabled and will not be applied"), "disabled") elif event: @@ -941,13 +926,13 @@ def mode_mkeventd_rules(phase): msg += _(" Match groups: %s") % ",".join(groups) html.icon(msg, icon) - html.write('</td>') - html.write('<td><a href="%s">%s</a></td>' % (edit_url, rule["id"])) + table.cell(_("ID"), '<a href="%s">%s</a>' % (edit_url, rule["id"])) + if rule.get("drop"): - html.write('<td class="state statep">%s</td>' % _("DROP")) + table.cell(_("Priority"), _("DROP"), css="state statep") else: - html.write('<td class="state state%d">%s</td>' % (rule["state"], - {0:_("OK"), 1:_("WARN"), 2:_("CRIT"), 3:_("UNKNOWN"), -1:_("(syslog)")}[rule["state"]])) + txt = {0:_("OK"), 1:_("WARN"), 2:_("CRIT"), 3:_("UNKNOWN"), -1:_("(syslog)")}[rule["state"]] + table.cell(_("Priority"), txt, css="state state%d" % rule["state"]) # Syslog priority if "match_priority" in rule: @@ -959,23 +944,22 @@ def mode_mkeventd_rules(phase): mkeventd.syslog_priorities[prio_to][1][:2] else: prio_text = "" - html.write("<td>%s</td>" % prio_text) + table.cell(_("Priority"), prio_text) # Syslog Facility + table.cell(_("Facility")) if "match_facility" in rule: facnr = rule["match_facility"] - html.write("<td>%s</td>" % dict(mkeventd.syslog_facilities)[facnr]) - else: - html.write("<td></td>") + html.write("%s" % dict(mkeventd.syslog_facilities)[facnr]) - html.write('<td>%s</td>' % dict(mkeventd.service_levels()).get(rule["sl"], rule["sl"])) + table.cell(_("Service Level"), + dict(mkeventd.service_levels()).get(rule["sl"], rule["sl"])) if defaults.omd_root: hits = rule.get('hits') - html.write('<td class=number>%s</td>' % (hits != None and hits or '')) - html.write('<td>%s</td>' % rule.get("description")) - html.write('<td>%s</td>' % rule.get("match")) - html.write('</tr>\n') - html.write('</table>') + table.cell(_("Hits"), hits != None and hits or '', css="number") + table.cell(_("Description"), rule.get("description")) + table.cell(_("Text to match"), rule.get("match")) + table.end() def copy_rules_from_master():

11 years

Check_MK Git: check_mk: Minor cleanup in ChangeLog

by Mathias Kettner

Module: check_mk Branch: master Commit: ba93e9222de251dbd40323e0c8f9a0f9ac2e94ae URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ba93e9222de251… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Sep 22 11:34:13 2013 +0200 Minor cleanup in ChangeLog --- ChangeLog | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4aa9efe..ab657df 100644 --- a/ChangeLog +++ b/ChangeLog @@ -253,7 +253,7 @@ Event Console: * New rule feature: automatically delete event after actions - * New filter for maximum services level (minimum already existed) + * New filter for maximum service level (minimum already existed) * New global setting: hostname translation (allows e.g. to drop domain name) * New rule match: only apply rule within specified time period @@ -323,14 +323,15 @@ * logwatch: Agent can now rewrite Messages * apache_status: New rule: set levels for number of remaining open slots * mrpe: handle long plugin output correctly, including performance data + * cisco_qos: parameters now configurable via WATO Notifications: * notify.py: unique spoolfiles name no longer created with uuid - * Warn user if only_services does never match + * Warn user if only_services does never match Livestatus: * Table statehist: Improved detection of vanished hosts and services. - Now able to detect and remove nonsense check plugin output + Now able to detect and remove nonsense check plugin output * FIX: able to handle equal comment_id between host and service * livestatus.log: show utf-8 decoding problems only with debug logging >=2 * livestatus: fixed incorrect output formatting of comments_with_info column @@ -343,11 +344,10 @@ * New editor for Business Intelligence rules * Rule Editor: Now able to show infeffective rules * Valuespec: CascadingDropdown now able to process choice values from functions - * cisco_qos parameters now configurable via WATO * Removed global option logwatch_forward_to_ec, moved this to the logwatch_ec ruleset. With this option the forwarding can now be enabled for each logfile on a host - * Configuration of an alternativ host check command + * Configuration of an alternative host check command * Inventory: Display link symbol for ps ruleset * New rule for notification_options of hosts and services * FIX: Rulesets: correct display of rules within subfolders

11 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits