Module: check_mk
Branch: master
Commit: 80ab9a27dd5d67e361834a572e62c512bde50cc2
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=80ab9a27dd5d67…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Mon Oct 7 21:46:39 2013 +0200
Updated bug entries #0979
---
.bugs/979 | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/.bugs/979 b/.bugs/979
new file mode 100644
index 0000000..269f6f0
--- /dev/null
+++ b/.bugs/979
@@ -0,0 +1,13 @@
+Title: winperf_phydisk: better handle counter wraps
+Component: checks
+State: open
+Date: 2013-10-07 21:44:26
+Targetversion: 1.2.3i3
+Class: nastiness
+
+If you reboot a server then the diskstat.include based checks
+need many cycles before the produce output again. This shows
+up with the new staleness feature.
+
+Resolution: handle CounterWrapped exceptions and make sure, that
+all counters are handled, even if one exception occurs.
Module: check_mk
Branch: master
Commit: ecc455835e9f41e480c6017e424af22770d151a1
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ecc455835e9f41…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Mon Oct 7 20:36:57 2013 +0200
FIX: winperf_phydisk: handle case where not performance counters are available
---
ChangeLog | 1 +
checks/winperf_phydisk | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 404710a..451d601 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -20,6 +20,7 @@
* FIX: host notification email in html format: fixed formating error
(typo in tag)
* FIX: netapp_volumes: better output when volume is missing
+ * FIX: winperf_phydisk: handle case where not performance counters are available
Multisite:
* FIX: add missing service icons to view "All Services with this descr..."
diff --git a/checks/winperf_phydisk b/checks/winperf_phydisk
index 7703041..7881971 100644
--- a/checks/winperf_phydisk
+++ b/checks/winperf_phydisk
@@ -63,6 +63,10 @@
check_includes['winperf_phydisk'] = [ "diskstat.include" ]
def winperf_phydisk_convert(info):
+ # In case disk performance counters are not enabled, the agent sends
+ # an almost empty section, where the second line is missing completely
+ if len(info) == 1:
+ return []
disks = [ d.split('_')[-1] for d in info[1][2:-1] ]
for line in info[2:]:
if line[0] == '-14':