Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64518 discussions

Check_MK Git: check_mk: FIX Context help toggled on/off randomly

by Lars Michelsen

Module: check_mk Branch: master Commit: ff13548ef4f4462feecb7e3b83c3c106a8cf68f0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ff13548ef4f446… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 22 14:53:00 2013 +0100 FIX Context help toggled on/off randomly During browsing different multisite pages, it could happen that the help switched on/off randomly. The setting was loaded before having the correct user context loaded. Now setting that option after the user has been logged in. --- .werks/284 | 13 +++++++++++++ ChangeLog | 1 + web/htdocs/html_mod_python.py | 2 ++ web/htdocs/index.py | 1 + 4 files changed, 17 insertions(+) diff --git a/.werks/284 b/.werks/284 new file mode 100644 index 0000000..0a92370 --- /dev/null +++ b/.werks/284 @@ -0,0 +1,13 @@ +Title: Context help toggled on/off randomly +Level: 1 +Component: multisite +Version: 1.2.3i7 +Date: 1385127740 +Class: fix + +During browsing different multisite pages, it could happen +that the help switched on/off randomly. + +The setting was loaded before having the correct user +context loaded. Now setting that option after the user has +been logged in. diff --git a/ChangeLog b/ChangeLog index 81fc4eb..e952bc2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -44,6 +44,7 @@ * 0210 FIX: LDAP: Fixed problem syncing contactgroups of a user with umlauts in CN * 0035 FIX: http[s] links are display again in the plugin output... * 0006 FIX: Checkboxes for hosts/services were missing on modified views... + * 0284 FIX: Context help toggled on/off randomly... WATO: * 0053 New rule for configuring the display_name of a service... diff --git a/web/htdocs/html_mod_python.py b/web/htdocs/html_mod_python.py index 401b9bc..e104bb3 100644 --- a/web/htdocs/html_mod_python.py +++ b/web/htdocs/html_mod_python.py @@ -17,6 +17,8 @@ class html_mod_python(htmllib.html): self.user = req.user self.read_get_vars() self.read_cookies() + + def load_help_visible(self): try: self.help_visible = config.load_user_file("help", False) # cache for later usage except: diff --git a/web/htdocs/index.py b/web/htdocs/index.py index 162d62f..7c080a8 100644 --- a/web/htdocs/index.py +++ b/web/htdocs/index.py @@ -300,6 +300,7 @@ def handler(req, profiling = True): # Set all permissions, read site config, and similar stuff config.login(html.user) + html.load_help_visible() # Initialize the multiste i18n. This will be replaced by # language settings stored in the user profile after the user

10 years, 10 months

Check_MK Git: check_mk: rewrite text of werk 235

by Andreas Boesl

Module: check_mk Branch: master Commit: 58098b041f674f15af8cd32089b9deacd7456bfa URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=58098b041f674f… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Nov 22 14:13:26 2013 +0100 rewrite text of werk 235 --- .werks/235 | 19 ++++++++++++++++++- ChangeLog | 2 +- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/.werks/235 b/.werks/235 index 547cd21..56617ff 100644 --- a/.werks/235 +++ b/.werks/235 @@ -1,8 +1,25 @@ -Title: table headers are now omitted if all fields are empty and no table action is set +Title: module table.py: table headers are omitted if all header fields are empty Level: 1 Component: wato Version: 1.2.3i7 Date: 1385120851 Class: feature +Html tables rendered with the help of the table module always displayed the <th> fields, +even if none if this fields were filled. For example: +C+: +table.begin(searchable = False) +# Firma +table.row() +table.cell("", "Company") +table.cell("", "Yummifood") +# Adresse +table.row() +table.cell("", "Address") +table.cell("", "Yummistreet 7, 12345 Yummiville") +table.end() +C-: + +This created a table with empty headers. +The new feature omits this headerline if it's not used otherwise, e.g. by a table action. diff --git a/ChangeLog b/ChangeLog index 81fc4eb..4f88397 100644 --- a/ChangeLog +++ b/ChangeLog @@ -48,7 +48,7 @@ WATO: * 0053 New rule for configuring the display_name of a service... * 0216 Supporting float values as SNMP timeout value now... - * 0235 table headers are now omitted if all fields are empty and no table action is set + * 0235 module table.py: table headers are omitted if all header fields are empty... * 0048 FIX: Tests on host diagnose page are executed parallel now... * 0033 FIX: Fixed problem when saving settings in WATOs host diagnostic page... * 0205 FIX: NagVis related permissions of roles can be edited again...

10 years, 10 months

Check_MK Git: check_mk: Updated help text of use_inline_snmp option in WATO

by Lars Michelsen

Module: check_mk Branch: master Commit: 60f0e0a2cb0c6bae0579d43377f7ac1f135e44ad URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=60f0e0a2cb0c6b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 22 14:01:49 2013 +0100 Updated help text of use_inline_snmp option in WATO --- web/plugins/wato/check_mk_configuration.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py index 0c758c0..654d535 100644 --- a/web/plugins/wato/check_mk_configuration.py +++ b/web/plugins/wato/check_mk_configuration.py @@ -1001,15 +1001,15 @@ register_configvar(group, register_configvar(group, "use_inline_snmp", Checkbox( - title = _("Use Inline SNMP (EXPERIMENTAL)"), + title = _("Use Inline SNMP"), label = _("Enable inline SNMP (directly use net-snmp libraries)"), - help = _("In older versions Check_MK used command line calls of net-snmp " - "tools like snmpget or snmpwalk. For each request a new command line " - "program had to be executed. The new default is the inline SNMP implementation " + help = _("By default Check_MK uses command line calls of Net-SNMP tools like snmpget or " + "snmpwalk to gather SNMP information. For each request a new command line " + "program is being executed. It is now possible to use the inline SNMP implementation " "which calls the net-snmp libraries directly via its python bindings. This " - "should increase the performance of SNMP checks in a significant way. " - "For compatibility the classic SNMP integration is still available and can be " - "enabled here."), + "should increase the performance of SNMP checks in a significant way. The inline " + "SNMP mode is a feature which improves the performance for large installations and " + "only available via our subscription."), default_value = False ), need_restart = True

10 years, 10 months

Check_MK Git: check_mk: Updated bug entries #1026

by Lars Michelsen

Module: check_mk Branch: master Commit: c20ef4c0ccb0bf91cbe6fc5ade7c64520f9ace91 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c20ef4c0ccb0bf… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 22 13:17:54 2013 +0100 Updated bug entries #1026 --- .bugs/1026 | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.bugs/1026 b/.bugs/1026 new file mode 100644 index 0000000..4e63e8a --- /dev/null +++ b/.bugs/1026 @@ -0,0 +1,11 @@ +Title: Postfix mailqueue check should use more flexible thresholds +Component: checks +State: open +Date: 2013-11-22 13:15:25 +Targetversion: 1.2.3i6 +Class: nastiness + +The check is currently only using absolute levels, which is OK for the first moment, but +in fact it is not really a problem when having several hundret mails in the queue, as long +as all mails are processed after a short time. Only a queue which remains filled is +a problem. Some kind of dynamic calculation should be better, a rate or similar.

10 years, 10 months

Check_MK Git: check_mk: Fritz!Box Connection check handled "Connection" state now

by Lars Michelsen

Module: check_mk Branch: master Commit: 2465c53b34168af87726faaf980d25eeb5a42d0d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2465c53b34168a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 22 13:15:20 2013 +0100 Fritz!Box Connection check handled "Connection" state now --- checks/fritz | 1 + 1 file changed, 1 insertion(+) diff --git a/checks/fritz b/checks/fritz index 812d519..02ffc1d 100644 --- a/checks/fritz +++ b/checks/fritz @@ -42,6 +42,7 @@ def inventory_fritz_conn(info): fritz_conn_states = { 'Connected': 0, + 'Connecting': 1, 'Disconnected': 1, }

10 years, 10 months

Check_MK Git: check_mk: updated usage text - rewrite command was missing

by Andreas Boesl

Module: check_mk Branch: master Commit: 76d0c2c483e7807fec360708fb2ad5b03479dead URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=76d0c2c483e780… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Nov 22 12:54:41 2013 +0100 updated usage text - rewrite command was missing --- werk | 1 + 1 file changed, 1 insertion(+) diff --git a/werk b/werk index 38aaa65..8a27654 100755 --- a/werk +++ b/werk @@ -289,6 +289,7 @@ where COMMAND is one of: grep [-v] KW1 KW2... - show werks containing all of the given keywords (-v: verbose) edit [#] - open werk # in editor (or newest werk) blame [#] - show who worked on a werk + rewrite - rewrite changelog """) sys.exit(1)

10 years, 10 months

Check_MK Git: check_mk: table headers are now omitted if all fields are empty and no table action is set

by Andreas Boesl

Module: check_mk Branch: master Commit: 5ba5383ecd7fb899060a81fb307bd86db93df9be URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5ba5383ecd7fb8… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Nov 22 12:48:29 2013 +0100 table headers are now omitted if all fields are empty and no table action is set --- .werks/235 | 8 ++++++++ ChangeLog | 1 + web/htdocs/table.py | 51 +++++++++++++++++++++++++++------------------------ 3 files changed, 36 insertions(+), 24 deletions(-) diff --git a/.werks/235 b/.werks/235 new file mode 100644 index 0000000..547cd21 --- /dev/null +++ b/.werks/235 @@ -0,0 +1,8 @@ +Title: table headers are now omitted if all fields are empty and no table action is set +Level: 1 +Component: wato +Version: 1.2.3i7 +Date: 1385120851 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index f82cd94..e1dd50f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -49,6 +49,7 @@ WATO: * 0053 New rule for configuring the display_name of a service... * 0216 Supporting float values as SNMP timeout value now... + * 0235 table headers are now omitted if all fields are empty and no table action is set * 0048 FIX: Fixed locking issue on host diagnose page * 0033 FIX: Fixed problem when saving settings in WATOs host diagnostic page... * 0205 FIX: Allowing star chars in variable names to fix role/permission editing... diff --git a/web/htdocs/table.py b/web/htdocs/table.py index 94dada3..e6aadae 100644 --- a/web/htdocs/table.py +++ b/web/htdocs/table.py @@ -172,30 +172,33 @@ def end(): html.write(" %s" % table["css"]) html.write('">\n') - html.write(" <tr>") - first_col = True - for header, help in table["headers"]: - if help: - header = '<span title="%s">%s</span>' % (html.attrencode(help), header) - html.write(" <th>") - - # Add the table action link - if first_col: - if actions_enabled: - if actions_visible: - state = '0' - help = _('Hide table actions') - img = 'table_actions_on' - else: - state = '1' - help = _('Display table actions') - img = 'table_actions_off' - html.icon_button(html.makeuri([('_%s_actions' % table_id, state)]), - help, img, cssclass = 'toggle_actions') - first_col = False - - html.write("%s</th>\n" % header) - html.write(" </tr>\n") + + use_headers = [ header for header in table["headers"] if header[0] != "" ] + if use_headers or actions_enabled: + html.write(" <tr>") + first_col = True + for header, help in table["headers"]: + if help: + header = '<span title="%s">%s</span>' % (html.attrencode(help), header) + html.write(" <th>") + + # Add the table action link + if first_col: + if actions_enabled: + if actions_visible: + state = '0' + help = _('Hide table actions') + img = 'table_actions_on' + else: + state = '1' + help = _('Display table actions') + img = 'table_actions_off' + html.icon_button(html.makeuri([('_%s_actions' % table_id, state)]), + help, img, cssclass = 'toggle_actions') + first_col = False + + html.write("%s</th>\n" % header) + html.write(" </tr>\n") if actions_enabled and actions_visible: html.write('<tr class="data even0 actions"><td colspan=%d>' % num_cols)

10 years, 10 months

Check_MK Git: check_mk: Updated werk descriptions/titles

by Lars Michelsen

Module: check_mk Branch: master Commit: f02e456b68794e3a5e406f1e077c45d289654c00 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f02e456b68794e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 22 12:30:50 2013 +0100 Updated werk descriptions/titles --- .werks/204 | 7 +++++-- .werks/205 | 4 +++- .werks/206 | 9 ++++----- .werks/207 | 7 +++++-- .werks/209 | 8 -------- .werks/212 | 6 ++++-- .werks/213 | 3 ++- .werks/41 | 4 +++- .werks/43 | 2 +- .werks/44 | 2 +- .werks/45 | 3 ++- .werks/46 | 9 +++++++-- .werks/48 | 6 ++++-- .werks/49 | 3 ++- ChangeLog | 19 +++++++++---------- werk | 7 ++++--- 16 files changed, 56 insertions(+), 43 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=f02e456b68…

10 years, 10 months

Check_MK Git: check_mk: FIX Inventory problem with inventory_processes parameter

by Lars Michelsen

Module: check_mk Branch: master Commit: 6ae4c4bfb7b74437faa751327cf689b4a0deefd7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6ae4c4bfb7b744… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 22 10:57:27 2013 +0100 FIX Inventory problem with inventory_processes parameter --- web/htdocs/login.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/web/htdocs/login.py b/web/htdocs/login.py index 5cb2f23..3d65284 100644 --- a/web/htdocs/login.py +++ b/web/htdocs/login.py @@ -175,7 +175,10 @@ def do_login(): raise MKUserError('_password', _('No password given.')) origtarget = html.var('_origtarget') - if not origtarget or "logout.py" in origtarget: + # Disallow redirections to: + # - logout.py: Happens after login + # - Full qualified URLs (http://...) to prevent redirection attacks + if not origtarget or "logout.py" in origtarget or '://' in origtarget: origtarget = defaults.url_prefix + 'check_mk/' # None -> User unknown, means continue with other connectors

10 years, 10 months

Check_MK Git: check_mk: df manpage: Added more information about differences between the output of df and the df check

by Lars Michelsen

Module: check_mk Branch: master Commit: d43d8d15a688a24b15dfe66f2d67b891cc0e6c0b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d43d8d15a688a2… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 22 11:49:29 2013 +0100 df manpage: Added more information about differences between the output of df and the df check --- checkman/df | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/checkman/df b/checkman/df index 241c07c..02c563d 100644 --- a/checkman/df +++ b/checkman/df @@ -6,11 +6,17 @@ distribution: check_mk description: This check measures the usage of filesystems. The usage is checked against a warning and a critical level, which - can be specified in numerous ways. Beware: on Linux and UNIX systems - the filesystem might reserve a certain amount for root (typical is 5%). - This checks considers that reserved space as used. This is consistent with - the percentage-column in the output of {df}. So your filesystem might - be at 100% in a situation where root still has 5% free space available. + can be specified in numerous ways. + + Beware: on Linux and UNIX systems the filesystem might reserve a certain amount for + root (typical is 5%). This checks considers that reserved space as used. This is + consistent with the percentage-column in the output of {df} on most distributions. + So your filesystem might be at 100% in a situation where root still has 5% free + space available. On some distributions, {df} seems to use the user allocatable space + instead of the total filesystem size as base for the percentage calculation, this might + result in differences between the percentage values shown by that {df} version and + the value shown in Check_MK. From our point of view, the calculation of Check_MK is + more accurate. {Trends:} This checks supports filesystem {trends}. This means that the {df} check is able to compute the {change} of the used space over the time and can

10 years, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits