Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64597 discussions

Check_MK Git: check_mk: RBN: implement throttling of periodic notifications

by Mathias Kettner

Module: check_mk Branch: master Commit: 1e6f0062e09af1fd5ab58c6c80ad1e08074a5620 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1e6f0062e09af1… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Mar 6 18:31:21 2014 +0100 RBN: implement throttling of periodic notifications --- modules/notify.py | 37 +++++++++++++++++++++++++------------ web/htdocs/wato.py | 30 ++++++++++++++++++++++++++++-- 2 files changed, 53 insertions(+), 14 deletions(-) diff --git a/modules/notify.py b/modules/notify.py index 058b278..caef69f 100644 --- a/modules/notify.py +++ b/modules/notify.py @@ -583,18 +583,19 @@ def rbn_match_rule(rule, context): return "This rule is disabled" return \ - rbn_match_folder(rule, context) or \ - rbn_match_hosttags(rule, context) or \ - rbn_match_hosts(rule, context) or \ - rbn_match_exclude_hosts(rule, context) or \ - rbn_match_services(rule, context) or \ - rbn_match_exclude_services(rule, context) or \ - rbn_match_plugin_output(rule, context) or \ - rbn_match_checktype(rule, context) or \ - rbn_match_timeperiod(rule) or \ - rbn_match_escalation(rule, context) or \ - rbn_match_servicelevel(rule, context) or \ - rbn_match_host_event(rule, context) or \ + rbn_match_folder(rule, context) or \ + rbn_match_hosttags(rule, context) or \ + rbn_match_hosts(rule, context) or \ + rbn_match_exclude_hosts(rule, context) or \ + rbn_match_services(rule, context) or \ + rbn_match_exclude_services(rule, context) or \ + rbn_match_plugin_output(rule, context) or \ + rbn_match_checktype(rule, context) or \ + rbn_match_timeperiod(rule) or \ + rbn_match_escalation(rule, context) or \ + rbn_match_escalation_throtte(rule, context) or \ + rbn_match_servicelevel(rule, context) or \ + rbn_match_host_event(rule, context) or \ rbn_match_service_event(rule, context) @@ -708,6 +709,18 @@ def rbn_match_escalation(rule, context): return "The notification number %d does not lie in range %d ... %d" % ( notification_number, from_number, to_number) +def rbn_match_escalation_throtte(rule, context): + if "match_escalation_throttle" in rule: + from_number, rate = rule["match_escalation_throttle"] + if context["WHAT"] == "HOST": + notification_number = int(context.get("HOSTNOTIFICATIONNUMBER", 1)) + else: + notification_number = int(context.get("SERVICENOTIFICATIONNUMBER", 1)) + if notification_number <= from_number: + return + if (notification_number - from_number) % rate != 0: + return "This notification is being skipped due to throttling. The next number will be %d" % \ + (notification_number + rate - ((notification_number - from_number) % rate)) def rbn_match_servicelevel(rule, context): if "match_sl" in rule: diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 8c04161..1839917 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -7574,6 +7574,30 @@ def vs_notification_rule(userid = None): ], ), ), + ( "match_escalation_throttle", + Tuple( + title = _("Throttle periodic notifications"), + help = _("This match option allows you to throttle periodic notifications after " + "a certain number of notifications have been created by the monitoring " + "core. If you for example select 10 as the beginning and 5 as the rate " + "then you will receive the notification 1 through 10 and then 15, 20, " + "25.. and so on."), + orientation = "float", + elements = [ + Integer( + label = _("beginning from notifcation number"), + default_value = 10, + minvalue = 1, + ), + Integer( + label = _("send only every"), + default_value = 5, + unit = _("th notification"), + minvalue = 1, + ) + ], + ) + ), ( "match_sl", Tuple( title = _("Match service level"), @@ -7702,7 +7726,8 @@ def vs_notification_rule(userid = None): ], optional_keys = [ "match_folder", "match_hosttags", "match_hosts", "match_exclude_hosts", "match_services", "match_exclude_services", "match_plugin_output", - "match_timeperiod", "match_escalation", "match_sl", "match_host_event", "match_service_event", + "match_timeperiod", "match_escalation", "match_escalation_throttle", + "match_sl", "match_host_event", "match_service_event", "match_checktype", "bulk", "contact_users", "contact_groups", "contact_emails" ], headers = [ ( _("General Properties"), [ "description", "disabled", "allow_disable" ] ), @@ -7712,7 +7737,8 @@ def vs_notification_rule(userid = None): ( _("Conditions"), [ "match_folder", "match_hosttags", "match_hosts", "match_exclude_hosts", "match_services", "match_exclude_services", "match_plugin_output", "match_checktype", "match_timeperiod", - "match_escalation", "match_sl", "match_host_event", "match_service_event" ] ), + "match_escalation", "match_escalation_throttle", + "match_sl", "match_host_event", "match_service_event" ] ), ], render = "form", form_narrow = True,

10 years, 7 months

Check_MK Git: check_mk: FIX cmc: fixed bug displaying logentries after a logfile rotation

by Andreas Boesl

Module: check_mk Branch: master Commit: d825effcc58fcef0ff4f390e45038adfef90902d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d825effcc58fce… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Mar 6 16:56:26 2014 +0100 FIX cmc: fixed bug displaying logentries after a logfile rotation The Check_MK microcore didn't cleanup cached logfiles correctly. Thus caused missing logentries, when accessing views like "Host and Service Events" or "Search global logfile". The logentries itself were not lost, just unavailable in views. The problem could be fixed by restarting (not reloading) the cmc. --- .werks/730 | 14 ++++++++++++++ ChangeLog | 1 + livestatus/src/LogCache.cc | 14 +++++++++++++- 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/.werks/730 b/.werks/730 new file mode 100644 index 0000000..4fe49e4 --- /dev/null +++ b/.werks/730 @@ -0,0 +1,14 @@ +Title: cmc: fixed bug displaying logentries after a logfile rotation +Level: 2 +Component: core +Class: fix +State: unknown +Version: 1.2.5i1 +Date: 1394120989 + +The Check_MK microcore didn't cleanup cached logfiles correctly. +Thus caused missing logentries, when accessing views like +"Host and Service Events" or "Search global logfile". + +The logentries itself were not lost, just unavailable in views. +The problem could be fixed by restarting (not reloading) the cmc. diff --git a/ChangeLog b/ChangeLog index 9dd39a4..5559426 100644 --- a/ChangeLog +++ b/ChangeLog @@ -22,6 +22,7 @@ * 0682 FIX: Allow overriding of active and custom checks by more specific rule... * 0267 FIX: Fixed auth.serials permission problem in check_mk standalone installation... * 0282 FIX: TIMEPERIOD TRANSITION messages no longer cut at 64 bytes... + * 0730 FIX: cmc: fixed bug displaying logentries after a logfile rotation... Checks & Agents: * 0306 esx_vsphere_counters: added missing ramdisk levels sfcbtickets diff --git a/livestatus/src/LogCache.cc b/livestatus/src/LogCache.cc index 9261be8..900ce25 100644 --- a/livestatus/src/LogCache.cc +++ b/livestatus/src/LogCache.cc @@ -38,10 +38,18 @@ #include "LogEntry.h" #include "LogCache.h" +#ifdef CMC +#include "Core.h" +extern Core *g_core; +#else +extern time_t last_log_rotation; +#endif // CMC + + + #define CHECK_MEM_CYCLE 1000 /* Check memory every N'th new message */ // watch nagios' logfile rotation -extern time_t last_log_rotation; extern int g_debug_level; extern char *log_archive_path; extern char *log_file; @@ -108,7 +116,11 @@ bool LogCache::logCachePreChecks() // Has Nagios rotated logfiles? => Update // our file index. And delete all memorized // log messages. + #ifdef CMC + if (g_core->_last_logfile_rotation > _last_index_update) { + #else if (last_log_rotation > _last_index_update) { + #endif logger(LG_INFO, "Nagios has rotated logfiles. Rebuilding logfile index"); forgetLogfiles(); updateLogfileIndex();

10 years, 7 months

Check_MK Git: check_mk: Removed obsolete draft ( because now it is implemented)

by Mathias Kettner

Module: check_mk Branch: master Commit: 67fcafe8529d4aa461d152101dacad9ed75b9e20 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=67fcafe8529d4a… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Mar 6 16:56:34 2014 +0100 Removed obsolete draft (because now it is implemented) --- doc/drafts/README.bulk_notifications | 102 ---------------------------------- 1 file changed, 102 deletions(-) diff --git a/doc/drafts/README.bulk_notifications b/doc/drafts/README.bulk_notifications deleted file mode 100644 index ac4b76a..0000000 --- a/doc/drafts/README.bulk_notifications +++ /dev/null @@ -1,102 +0,0 @@ -BULK NOTIFICATIONS ------------------- -The idea of "bulk notifications" or "notification aggregation" is to cut -down the number of notifications in cases where some general problem causes -hundreds or thousands of similar alerts at the same time. In some cases this -problem can be tackled with Nagios "service dependencies". The problem is -that this is very tedious to configure and includes the risk of blocking -critical notification per mistake. - -The bulk notification feature would collect all notifications of the same -channel and target user for a certain time into a pool and then send *one* -notification email/sms/whatever that contains all those notifications. A -typical time frame of such a pooling could be 1 minute. Assuming that your -check period is one minute, that would mean that all alerts that origin from -the same problem would be packed into one single notification. - -In order to make you not blind to *other* problems that happen during such a -burst of alerts the pooling could be done on a per-checktype or per-hostgroup -or per-whatever base. It also could take the service level of objects into -account so that e.g. all alerts of the level "Tier 3" is bulked by 5 minutes, -the alerts of "Tier 1" would not be bulked by sent independently. - -The configuration of the notification aggregation could be done as a parameter -to the notification rules. Example: - -Condition: -- Service Level <= 10 (Tier 3) - -Notification: -- Send to all configured monitoring contacts -- Send via Email - -Aggregation: - - time range (e.g. collect notifications up to 2 minutes) - - force separate notification bulks for different - [ ] hosts - [ ] check types - [ ] states (WARN, CRIT, etc.) - [ ] service descriptions - [ ] service levels - - -OVERRIDING ----------- -If there is a global rule that configures a notification without aggregation, -then a later rule can override that and add an aggregation. That way a user -can enable bulk notifications for otherwise un-bulked ones. - -Vice versa: if in a rule notifications are aggregated and a later rule -(e.g. one of a user) has aggregation disabled, that setting has precedence. - - -IMPLEMENTATION --------------- -We implement the bulk notifications as an addition to the "rule -based notifications." - -A) WATO - -[1] Each positive notification rule has some new options for bulking - [x] Enable bulk notifications - - Bulk up to [__0] days [_0] hours [10] minutes [_0] seconds - - Bulk up to [__100] notifications - - Force separate notifications for different - [X] Hosts - [ ] Check types - [ ] Service Levels - -[2] Complain if the selected plugin does not support bulking. - -[3] Extend the API of the notification plugins so that bulking - ability can be detected by WATO. - -B) NOTIFICATION - -[11] The bulk options are stored as an additional parameter in the notification - table. Later rules that trigger the same check plugin override these options. - That way a user can enable bulking if its globally turned off or vice versa. - -[12] If a plugin is being called with bulk notifications on, then - a) compute a unique name for the bulk. This takes into account - the separation options. - b) compute the path of a directory below var/check_mk/notify/bulk/$USER and - create it if its missing - c) add a file into that directory that contains the notification context - d) If the directory was new then also add some general information needed later - -C) NOTIFICATION SPOOLER -The bulk notifications require the notification spooler, since asynchronous -actions need to be done (i.e. sending the actual notification after the timeout) - -[21] Create a regular scan of the bulk directories - -[22] Detect wheter a bulk is "ripe". - -[23] In that case call the notification plugin matching the bulk and send the notification - context via stdin - -D) NOTIFICATION PLUGINS - -[31] Implement bulking for the HTML emails -

10 years, 7 months

Check_MK Git: check_mk: RBN: Fix rule anaysis, allow disable bulking by later rule

by Mathias Kettner

Module: check_mk Branch: master Commit: 885c2ba5211dfe9bc65e81d1cddce865741c9f5f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=885c2ba5211dfe… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Mar 6 16:49:57 2014 +0100 RBN: Fix rule anaysis, allow disable bulking by later rule --- doc/treasures/mknotifyd | 5 ----- modules/notify.py | 13 +++++++------ web/htdocs/wato.py | 31 +++++++++++++++++++++++-------- 3 files changed, 30 insertions(+), 19 deletions(-) diff --git a/doc/treasures/mknotifyd b/doc/treasures/mknotifyd index b60f791..215c8cb 100755 --- a/doc/treasures/mknotifyd +++ b/doc/treasures/mknotifyd @@ -573,8 +573,3 @@ try: except Exception, e: bail_out(e) - - - - - diff --git a/modules/notify.py b/modules/notify.py index f57e5be..058b278 100644 --- a/modules/notify.py +++ b/modules/notify.py @@ -216,7 +216,7 @@ def notify_notify(raw_context, analyse=False): if not also_local: return - locally_deliver_raw_context(raw_context, analyse=analyse) + return locally_deliver_raw_context(raw_context, analyse=analyse) # Here we decide which notification implementation we are using. @@ -239,8 +239,7 @@ def locally_deliver_raw_context(raw_context, analyse=False): if not contactname or contactname == "check-mk-notify": # 1. RULE BASE NOTIFICATIONS notify_log("Preparing rule based notifications") - notify_rulebased(raw_context, analyse=analyse) - return + return notify_rulebased(raw_context, analyse=analyse) if analyse: return # Analysis only possible when rule based notifications are enabled @@ -283,7 +282,7 @@ def notification_analyse_backlog(nr): global notify_mode notify_mode = "replay" raw_context = raw_context_from_backlog(nr) - notify_notify(raw_context, analyse=True) + return notify_notify(raw_context, analyse=True) #. @@ -432,7 +431,7 @@ def notify_rulebased(raw_context, analyse=False): key = contact, plugin plugintxt = plugin or "plain email" if key in notifications: - locked, method, bulk = notifications[key] + locked, method, old_bulk = notifications[key] if locked and "contact" in rule: notify_log(" - cannot modify notification of %s via %s: it is locked" % (contact, plugintxt)) continue @@ -466,7 +465,9 @@ def notify_rulebased(raw_context, analyse=False): verb = "would notify" else: verb = "notifying" - notify_log(" * %s %s via %s, parameters: %s" % (verb, contact, (plugin or "plain email"), ", ".join(params))) + notify_log(" * %s %s via %s, parameters: %s, bulk: %s" % ( + verb, contact, (plugin or "plain email"), params and ", ".join(params) or "(no parameters)", + bulk and "yes" or "no")) plugin_info.append((contact, plugin, params, bulk)) # for analysis try: rbn_add_contact_information(raw_context, contact) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index da05672..8c04161 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -7735,7 +7735,8 @@ def validate_notification_rule(rule, varprefix): _("The plain emails currently do not support bulking.")) -def render_notification_rules(rules, userid="", show_title=False, show_buttons=True, analyse=False, start_nr=0, profilemode=False): +def render_notification_rules(rules, userid="", show_title=False, show_buttons=True, + analyse=False, start_nr=0, profilemode=False): if not rules: html.message(_("You have not created any rules yet.")) @@ -7779,12 +7780,12 @@ def render_notification_rules(rules, userid="", show_title=False, show_buttons=T listmode = "notifications" if show_buttons: - analyse = html.var("analyse", "") + anavar = html.var("analyse", "") delete_url = make_action_link([("mode", listmode), ("user", userid), ("_delete", nr)]) - top_url = make_action_link([("mode", listmode), ("analyse", analyse), ("user", userid), ("_move", nr), ("_where", 0)]) - bottom_url = make_action_link([("mode", listmode), ("analyse", analyse), ("user", userid), ("_move", nr), ("_where", len(rules)-1)]) - up_url = make_action_link([("mode", listmode), ("analyse", analyse), ("user", userid), ("_move", nr), ("_where", nr-1)]) - down_url = make_action_link([("mode", listmode), ("analyse", analyse), ("user", userid), ("_move", nr), ("_where", nr+1)]) + top_url = make_action_link([("mode", listmode), ("analyse", anavar), ("user", userid), ("_move", nr), ("_where", 0)]) + bottom_url = make_action_link([("mode", listmode), ("analyse", anavar), ("user", userid), ("_move", nr), ("_where", len(rules)-1)]) + up_url = make_action_link([("mode", listmode), ("analyse", anavar), ("user", userid), ("_move", nr), ("_where", nr-1)]) + down_url = make_action_link([("mode", listmode), ("analyse", anavar), ("user", userid), ("_move", nr), ("_where", nr+1)]) suffix = profilemode and "_p" or "" edit_url = make_link([("mode", "notification_rule" + suffix), ("edit", nr), ("user", userid)]) clone_url = make_link([("mode", "notification_rule" + suffix), ("clone", nr), ("user", userid)]) @@ -8027,7 +8028,7 @@ def mode_notifications(phase): table.end() # Do analysis - if html.has_var("analyse"): + if html.var("analyse"): nr = int(html.var("analyse")) analyse = check_mk_local_automation("notification-analyse", [str(nr)], None) else: @@ -14432,7 +14433,8 @@ def page_user_profile(): def create_sample_config(): if os.path.exists(multisite_dir + "hosttags.mk") \ or os.path.exists(root_dir + "rules.mk") \ - or os.path.exists(root_dir + "groups.mk"): + or os.path.exists(root_dir + "groups.mk") \ + or os.path.exists(root_dir + "notifications.mk"): return # A contact group where everyone is member of @@ -14500,6 +14502,19 @@ def create_sample_config(): save_rulesets(g_root_folder, rulesets) + notification_rules = [{ + 'allow_disable' : True, + 'contact_all' : False, + 'contact_all_with_email' : False, + 'contact_object' : True, + 'description' : 'Notify all contacts of a host/service via HTML email', + 'disabled' : False, + 'notify_method' : [], + 'notify_plugin' : 'mail' + }] + save_notification_rules(notification_rules) + + # Make sure the host tag attributes are immediately declared! config.wato_host_tags = wato_host_tags config.wato_aux_tags = wato_aux_tags

10 years, 7 months

Check_MK Git: check_mk: Major internal cleanup of notification code

by Mathias Kettner

Module: check_mk Branch: master Commit: 09fad9b4b9b08134d594f4731d241de62d108b59 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=09fad9b4b9b081… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Mar 6 15:13:01 2014 +0100 Major internal cleanup of notification code --- doc/Notifications.png | Bin 0 -> 64105 bytes doc/Notifications.svg | 800 +++++++++++++++++ doc/treasures/mknotifyd | 28 +- mkeventd/web/plugins/wato/mkeventd.py | 28 +- modules/notify.py | 1591 ++++++++++++++++----------------- notifications/mail | 4 + notifications/sms | 7 +- web/htdocs/wato.py | 16 +- web/plugins/wato/mknotifyd.py | 15 +- 9 files changed, 1638 insertions(+), 851 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=09fad9b4b9…

10 years, 7 months

Check_MK Git: check_mk: Fix remote spooling with RBN

by Mathias Kettner

Module: check_mk Branch: master Commit: 9a796a4ce657aadd7e9b0e5b4a0519f5838bc442 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9a796a4ce657aa… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Mar 6 16:16:04 2014 +0100 Fix remote spooling with RBN --- doc/treasures/mknotifyd | 9 +++++---- modules/notify.py | 12 ++++++++++-- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/doc/treasures/mknotifyd b/doc/treasures/mknotifyd index 4b75d8a..b60f791 100755 --- a/doc/treasures/mknotifyd +++ b/doc/treasures/mknotifyd @@ -239,6 +239,7 @@ class TcpServer: client_data = "" chunk_count = 0 client_socket, addr_info = s.accept() + from_name = "%s:%s" % addr_info while True: try: data_ready = select.select([client_socket], [], [], 2)[0] @@ -254,21 +255,21 @@ class TcpServer: break # Error while reading if opt_verbose > 1: - verbose("Received notification %d from %s in %d chunks" % ( handled_connections, pprint.pformat(addr_info), chunk_count), 2) + verbose("Received notification %d from %s in %d chunks" % ( handled_connections, from_name, chunk_count), 2) handled_connections = handled_connections + 1 try: content = pickle.loads(client_data) - del content["forward"] if not os.path.exists(g_spool_dir): os.makedirs(g_spool_dir) - spoolfile = "%s/%s" % uuid.uuid1() + spoolfile = "%s/%s" % (g_spool_dir, uuid.uuid1()) file(spoolfile,"w").write(pprint.pformat(content)) verbose("client data processed - sending OK", 2) client_socket.send("OK") except Exception, e: - log("Error processing data from %s" % pprint.pformat(addr_info)) + + log("Error processing data from %s: %s\n%s" % (from_name, e, format_exception())) try: if client_socket: client_socket.send("ERROR") diff --git a/modules/notify.py b/modules/notify.py index 590058f..f57e5be 100644 --- a/modules/notify.py +++ b/modules/notify.py @@ -544,7 +544,15 @@ def rbn_add_contact_information(raw_context, contact): if key[0] == '_': raw_context["CONTACT" + key.upper()] = contact[key] else: - contact_dict = contacts.get(contact, { "name" : contact, "alias" : contact }) + if contact.startswith("mailto:"): # Fake contact + contact_dict = { + "name" : contact[7:].split("@")[0], + "alias" : "Email address " + contact, + "email" : contact[7:], + "pager" : "" } + else: + contact_dict = contacts.get(contact, { "name" : contact, "alias" : contact }) + rbn_add_contact_information(raw_context, contact_dict) @@ -1186,7 +1194,7 @@ def handle_spoolfile(spoolfile): # several or no actual plugins. notify_log("Got spool file from remote host for local delivery.") raw_context = data["context"] - locally_deliver_plugin_context(data["context"]) + locally_deliver_raw_context(data["context"]) return 0 # No error handling for async delivery except Exception, e:

10 years, 7 months

Check_MK Git: check_mk: FIX ldap sync: syncing if rules against ldap is not longer case sensitiv

by Bastian Kuhn

Module: check_mk Branch: master Commit: d9505a504ec082a6c4dba542c03fb089bc18855d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d9505a504ec082… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Mar 6 15:26:14 2014 +0100 FIX ldap sync: syncing if rules against ldap is not longer case sensitiv --- .werks/139 | 9 +++++++++ ChangeLog | 1 + web/plugins/userdb/ldap.py | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.werks/139 b/.werks/139 new file mode 100644 index 0000000..067499e --- /dev/null +++ b/.werks/139 @@ -0,0 +1,9 @@ +Title: ldap sync: syncing if rules against ldap is not longer case sensitiv +Level: 1 +Component: wato +Class: fix +State: unknown +Version: 1.2.5i1 +Date: 1394115867 + + diff --git a/ChangeLog b/ChangeLog index dfb73c0..9dd39a4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -306,6 +306,7 @@ * 0559 FIX: WATO snapshots: improved validation of (uploaded) snapshots... * 0709 FIX: Fix NoneType has not attribute userdb_automatic_sync bug in D-WATO * 0728 FIX: mem.win: fixed bug in WATO configuration rule... + * 0139 FIX: ldap sync: syncing if rules against ldap is not longer case sensitiv Notifications: * 0362 sms: now searching PATH for sendsms and smssend commands... diff --git a/web/plugins/userdb/ldap.py b/web/plugins/userdb/ldap.py index 31e1ced..3351bb2 100644 --- a/web/plugins/userdb/ldap.py +++ b/web/plugins/userdb/ldap.py @@ -875,7 +875,7 @@ ldap_attribute_plugins['groups_to_contactgroups'] = { def ldap_convert_groups_to_roles(plugin, params, user_id, ldap_user, user): # Load the needed LDAP groups, which match the DNs mentioned in the role sync plugin config - ldap_groups = dict(ldap_group_members([ dn for role_id, dn in params.items() if isinstance(dn, str) ], + ldap_groups = dict(ldap_group_members([ dn.lower() for role_id, dn in params.items() if isinstance(dn, str) ], filt_attr = 'distinguishedname', nested = params.get('nested', False))) roles = set([])

10 years, 7 months

Check_MK Git: check_mk: Make handling of spaces in hostnames of ESX configurable

by Mathias Kettner

Module: check_mk Branch: master Commit: efd9c05bba54c4e487c9d6dfd807d07b6fd67586 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=efd9c05bba54c4… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Jan 9 15:16:31 2014 +0100 Make handling of spaces in hostnames of ESX configurable Cherry picked. Feature was in 1.2.4 but not in the master branch Conflicts: agents/special/agent_vsphere --- agents/special/agent_vsphere | 25 ++++++++++++++++++++----- checks/agent_vsphere | 3 +++ web/plugins/wato/check_parameters.py | 9 --------- web/plugins/wato/datasource_programs.py | 12 +++++++++++- 4 files changed, 34 insertions(+), 15 deletions(-) diff --git a/agents/special/agent_vsphere b/agents/special/agent_vsphere index 6e0a836..5076949 100755 --- a/agents/special/agent_vsphere +++ b/agents/special/agent_vsphere @@ -55,6 +55,12 @@ soapdata_list = [ ] +def convert_hostname(h): + if opt_spaces == "cut": + return h.split()[0] + else: + return h.replace(" ", "_") + # List of predefined SOAP requests # ( [{used_by_object}], {internal_id}, {SOAP telegram} ) @@ -158,12 +164,16 @@ OPTIONS: -c, --dump-counters Simply dumping out all available counters and their values. This mode is meant for debugging and diagnostic purposes. + -S, --spaces HOW How to handle spaces in hostnames. "cut": cut everyting + after the first space, "underscore": replace with + underscores. Default is "underscore". + """) -short_options = 'hi:u:s:Dat:H:cPp:' +short_options = 'hi:u:s:Dat:H:cPp:S:' long_options = [ 'help', 'user=', 'secret=', 'direct', 'agent', 'debug', 'modules=', 'timeout=', 'hostname=', - 'dump-counters', 'tracefile=', "pysphere", "port=", + 'dump-counters', 'tracefile=', "pysphere", "port=", "spaces=", ] opt_debug = False @@ -176,6 +186,7 @@ opt_hostname = None opt_skip_placeholder_vm = False opt_pysphere = False opt_tracefile = None +opt_spaces = "underscore" error = None error_exit = 1 @@ -219,11 +230,15 @@ for o,a in opts: opt_hostname = a elif o in [ '-c', '--dump-counters' ]: opt_dump_counters = True + elif o in [ '-S', '--spaces']: + if a not in [ "cut", "underscore" ]: + usage() + sys.exit(1) + opt_spaces = a elif o in [ '-h', '--help' ]: usage() sys.exit(0) - # vCenter only supports the classical slow vSphere agent (based on pysphere) # Also we do not support ESX 4.1 (yet). if not opt_direct or opt_pysphere: @@ -583,7 +598,7 @@ if not error: for key in sorted(vms.keys()): data = vms[key] if data.get("name"): - print "<<<<%s>>>>" % data.get("name").replace(" ", "_") + print "<<<<%s>>>>" % convert_hostname(data.get("name")) print "<<<esx_vsphere_vm>>>" entries = list(data.items()) entries.sort() @@ -606,7 +621,7 @@ if not error: for key in sorted(vms.keys()): data = vms[key] running_on = hostsystem_name.get(data.get("runtime.host"), data.get("runtime.host")) - print "virtualmachine\t%s\t%s\t%s" % (data.get("name").replace(" ", "_"), running_on, data.get("runtime.powerState")) + print "virtualmachine\t%s\t%s\t%s" % (convert_hostname(data.get("name")), running_on, data.get("runtime.powerState")) except Exception, e: if opt_debug: diff --git a/checks/agent_vsphere b/checks/agent_vsphere index c917b39..878d2c9 100644 --- a/checks/agent_vsphere +++ b/checks/agent_vsphere @@ -50,6 +50,9 @@ def agent_vsphere_arguments(params, hostname, ipaddress): if params.get("skip_placeholder_vms", True): args += " -P" + if "spaces" in params: + args += ' --spaces %s' % params["spaces"] + if "timeout" in params: args += ' --timeout %d' % params["timeout"] diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index ba1fc47..1386eb4 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -3221,15 +3221,6 @@ register_check_parameters( None, None ) -# register_check_parameters( -# subgroup_virt, -# "esx_hostsystems", -# _("Available HostSystems in ESX cluster"), -# None, -# "first", -# False, -# ) - register_check_parameters( subgroup_hardware, diff --git a/web/plugins/wato/datasource_programs.py b/web/plugins/wato/datasource_programs.py index 7b40e19..97c55de 100644 --- a/web/plugins/wato/datasource_programs.py +++ b/web/plugins/wato/datasource_programs.py @@ -97,6 +97,16 @@ register_rule(group, title = _("Retrieve information about..."), ) ), + ( "spaces", + DropdownChoice( + title = _("Spaces in hostnames"), + choices = [ + ( "underscore", _("Replace with underscores") ), + ( "cut", _("Cut everything after first space") ), + ], + default = "underscore", + ) + ), ( "direct", DropdownChoice( title = _("Type of query"), @@ -138,7 +148,7 @@ register_rule(group, help = _("This rule selects the vSphere agent instead of the normal Check_MK Agent " "and allows monitoring of VMWare ESX via the vSphere API. You can configure " "your connection settings here."), - forth = lambda a: dict([("skip_placeholder_vms", True), ("use_pysphere" , False)] + a.items()) + forth = lambda a: dict([("skip_placeholder_vms", True), ("use_pysphere" , False), ("spaces", "underscore")] + a.items()) ), factory_default = FACTORY_DEFAULT_UNUSED, # No default, do not use setting if no rule matches match = 'first')

10 years, 7 months

Check_MK Git: check_mk: FIX esx_vsphere_hostsystem: fixed incorrect status label (not state)

by Andreas Boesl

Module: check_mk Branch: master Commit: b0ecb2f218d434ab07bcaf527b6e65fe6e4095c3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b0ecb2f218d434… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Mar 6 14:21:11 2014 +0100 FIX esx_vsphere_hostsystem: fixed incorrect status label (not state) The status label in the check output was incorrect when the overallStatus of the hostsystem was grey or red. --- .werks/729 | 9 +++++++++ ChangeLog | 1 + checks/esx_vsphere_hostsystem | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.werks/729 b/.werks/729 new file mode 100644 index 0000000..68bbdd3 --- /dev/null +++ b/.werks/729 @@ -0,0 +1,9 @@ +Title: esx_vsphere_hostsystem: fixed incorrect status label (not state) +Level: 1 +Component: checks +Version: 1.2.5i1 +Date: 1394111987 +Class: fix + +The status label in the check output was incorrect when +the overallStatus of the hostsystem was grey or red. diff --git a/ChangeLog b/ChangeLog index 03916a3..dfb73c0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -197,6 +197,7 @@ * 0137 FIX: Fixed printer_pages... * 0587 FIX: if64: problems resolved when running as a clustered service... * 0563 FIX: windows agent: now able to process perl scripts... + * 0729 FIX: esx_vsphere_hostsystem: fixed incorrect status label (not state)... Multisite: * 0371 Added log class filter to hostsvcevents view diff --git a/checks/esx_vsphere_hostsystem b/checks/esx_vsphere_hostsystem index aec2a42..343d213 100644 --- a/checks/esx_vsphere_hostsystem +++ b/checks/esx_vsphere_hostsystem @@ -174,7 +174,7 @@ def check_esx_vsphere_hostsystem_state(item, params, info): label['Status'] = "(!)" elif overallStatus in [ "red", "gray"]: state = 2 - label['Satus'] = "(!!)" + label['Status'] = "(!!)" messages.append("Entity state: %s%s" % (overallStatus, label['Status'])) label['powerState'] = ''

10 years, 7 months

Check_MK Git: check_mk: FIX mem.win: fixed bug in WATO configuration rule

by Andreas Boesl

Module: check_mk Branch: master Commit: 07e3ea9d9c9e47050a638c02add52ff3e947bc01 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=07e3ea9d9c9e47… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Mar 5 17:55:24 2014 +0100 FIX mem.win: fixed bug in WATO configuration rule The WATO configuration showed "Absolute used pagefile" (and memory) as configurable limits. The check instead interpreted this value as "Absolute free pagefile". This has been fixed. WATO now shows "Absolute free pagefile", too. Additionally the configured value was off by a factor of 1024 * 1024. --- .werks/728 | 13 +++++++++++ ChangeLog | 1 + web/plugins/wato/check_parameters.py | 40 ++++++++++++++++++++++------------ 3 files changed, 40 insertions(+), 14 deletions(-) diff --git a/.werks/728 b/.werks/728 new file mode 100644 index 0000000..7b12982 --- /dev/null +++ b/.werks/728 @@ -0,0 +1,13 @@ +Title: mem.win: fixed bug in WATO configuration rule +Level: 1 +Component: wato +Class: fix +State: unknown +Version: 1.2.5i1 +Date: 1394038275 + +The WATO configuration showed "Absolute used pagefile" (and memory) as configurable limits. +The check instead interpreted this value as "Absolute free pagefile". +This has been fixed. WATO now shows "Absolute free pagefile", too. + +Additionally the configured value was off by a factor of 1024 * 1024. diff --git a/ChangeLog b/ChangeLog index 9cca635..03916a3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -304,6 +304,7 @@ * 0666 FIX: Minimum port for the mknotifyd is now 1024 (never use well known ports)... * 0559 FIX: WATO snapshots: improved validation of (uploaded) snapshots... * 0709 FIX: Fix NoneType has not attribute userdb_automatic_sync bug in D-WATO + * 0728 FIX: mem.win: fixed bug in WATO configuration rule... Notifications: * 0362 sms: now searching PATH for sendsms and smssend commands... diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 718cee8..ba1fc47 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1113,18 +1113,24 @@ register_check_parameters( title = _("Memory Levels"), elements = [ Tuple( - title = _("Usage Levels in Percent"), + title = _("Memory usage in percent"), elements = [ Percentage(title = _("Warning if above")), Percentage(title = _("Critical if above")), ], ), - Tuple( - title = _("Absolute Usage Levels"), - elements = [ - Filesize(title = _("Warning if above")), - Filesize(title = _("Critical if above")), - ] + Transform( + Tuple( + title = _("Absolute free memory"), + elements = [ + Filesize(title = _("Warning if less than")), + Filesize(title = _("Critical if less than")), + ] + ), + # Note: Filesize values lesser 1MB will not work + # -> need hide option in filesize valuespec + back = lambda x: (x[0] / 1024 / 1024, x[1] / 1024 / 1024), + forth = lambda x: (x[0] * 1024 * 1024, x[1] * 1024 * 1024) ) ], default_value = (80.0, 90.0))), @@ -1133,18 +1139,24 @@ register_check_parameters( title = _("Pagefile Levels"), elements = [ Tuple( - title = _("Usage Levels in Percent"), + title = _("Pagefile usage in percent"), elements = [ Percentage(title = _("Warning if above")), Percentage(title = _("Critical if above")), ] ), - Tuple( - title = _("Absolute Usage Levels"), - elements = [ - Filesize(title = _("Warning if above")), - Filesize(title = _("Critical if above")), - ] + Transform( + Tuple( + title = _("Absolute free pagefile"), + elements = [ + Filesize(title = _("Warning if less than")), + Filesize(title = _("Critical if less than")), + ] + ), + # Note: Filesize values lesser 1MB will not work + # -> need hide option in filesize valuespec + back = lambda x: (x[0] / 1024 / 1024, x[1] / 1024 / 1024), + forth = lambda x: (x[0] * 1024 * 1024, x[1] * 1024 * 1024) ) ], default_value = (50.0, 70.0))

10 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits