Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64625 discussions

Check_MK Git: check_mk: Better inline docu in mail notification script

by Mathias Kettner

Module: check_mk Branch: master Commit: ba90fa9691746255daa8b364152c6b8d1493df24 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ba90fa96917462… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Apr 17 16:56:40 2014 +0200 Better inline docu in mail notification script --- notifications/mail | 1 + 1 file changed, 1 insertion(+) diff --git a/notifications/mail b/notifications/mail index c051b73..11a4c32 100755 --- a/notifications/mail +++ b/notifications/mail @@ -4,6 +4,7 @@ # # Argument 1: Full system path to the pnp4nagios index.php for fetching the graphs. Usually auto configured in OMD. # Argument 2: HTTP-URL-Prefix to open Multisite. When provided, several links are added to the mail. +# Example: http://myserv01/prod # # This script creates a nifty HTML email in multipart format with # attached graphs and such neat stuff. Sweet!

10 years, 5 months

Check_MK Git: check_mk: FIX fritz.link: Not inventorizing "unconfigured" interfaces anymore

by Lars Michelsen

Module: check_mk Branch: master Commit: 59f86fe5323f70a25668861e49d1ec9f102da46c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=59f86fe5323f70… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 22 08:41:44 2014 +0200 FIX fritz.link: Not inventorizing "unconfigured" interfaces anymore --- .werks/810 | 8 ++++++++ ChangeLog | 1 + checks/fritz | 4 +++- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/810 b/.werks/810 new file mode 100644 index 0000000..efb1929 --- /dev/null +++ b/.werks/810 @@ -0,0 +1,8 @@ +Title: fritz.link: Not inventorizing "unconfigured" interfaces anymore +Level: 1 +Component: checks +Version: 1.2.5i3 +Date: 1398148880 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index 477451c..e7698e8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -45,6 +45,7 @@ * 0606 FIX: apache_status: now also sends an accept header to make it work with mod_security enables servers * 0832 FIX: solaris_mem: fixed invalid calculation of total swap... * 0152 FIX: windows_updates: Added Error Handling (Thanks to Stefan Kick)... + * 0810 FIX: fritz.link: Not inventorizing "unconfigured" interfaces anymore Multisite: * 0779 Hostgroups (Summary): Empty hostgroups are no longer shown (can be re-enabled by filter) diff --git a/checks/fritz b/checks/fritz index 4a43403..d6f7faa 100644 --- a/checks/fritz +++ b/checks/fritz @@ -37,13 +37,15 @@ def fritz_parse_info(info): def inventory_fritz_conn(info): data = fritz_parse_info(info) if 'NewConnectionStatus' in data \ - and 'NewExternalIPAddress' in data: + and 'NewExternalIPAddress' in data \ + and data.get('NewConnectionStatus') != 'Unconfigured': return [(None, {})] fritz_conn_states = { 'Connected': 0, 'Connecting': 1, 'Disconnected': 1, + 'Unconfigured': 1, } def check_fritz_conn(_unused, _no_params, info):

10 years, 5 months

Check_MK Git: check_mk: Updated bug entries #2128

by Lars Michelsen

Module: check_mk Branch: master Commit: 09be677103d3c2dfbdb2c3277f5222b1c5db4d02 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=09be677103d3c2… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Apr 22 08:33:52 2014 +0200 Updated bug entries #2128 --- .bugs/2128 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.bugs/2128 b/.bugs/2128 new file mode 100644 index 0000000..5dd4bef --- /dev/null +++ b/.bugs/2128 @@ -0,0 +1,10 @@ +Title: mk-job: Start time is only available after job finished +Component: checks +State: open +Date: 2014-04-22 08:32:35 +Targetversion: 1.2.5i1 +Class: bug + +This should really be changed. The start time should be available once the job has been +started. The check needs to deal with the old job info and the start time of the just +started and currently running job while the job is running.

10 years, 5 months

Check_MK Git: check_mk: FIX windows_updates: Added Error Handling ( Thanks to Stefan Kick)

by Bastian Kuhn

Module: check_mk Branch: master Commit: e75347fdb48fc5be804938e2b19982bdb93fe6fb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e75347fdb48fc5… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Apr 17 16:17:48 2014 +0200 FIX windows_updates: Added Error Handling (Thanks to Stefan Kick) The windows_update plugin now also handles windows servers with deactivated update function. --- .werks/152 | 8 ++++++++ ChangeLog | 1 + agents/windows/plugins/windows_updates.vbs | 15 ++++++++++++++- checks/windows_updates | 3 +++ 4 files changed, 26 insertions(+), 1 deletion(-) diff --git a/.werks/152 b/.werks/152 new file mode 100644 index 0000000..bed4540 --- /dev/null +++ b/.werks/152 @@ -0,0 +1,8 @@ +Title: windows_updates: Added Error Handling (Thanks to Stefan Kick) +Level: 1 +Component: checks +Version: 1.2.5i3 +Date: 1397744176 +Class: fix + +The windows_update plugin now also handles windows servers with deactivated update function. diff --git a/ChangeLog b/ChangeLog index b34156d..477451c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -44,6 +44,7 @@ * 0882 FIX: check_bi_local.py: fix crash in case of non-ascii characters... * 0606 FIX: apache_status: now also sends an accept header to make it work with mod_security enables servers * 0832 FIX: solaris_mem: fixed invalid calculation of total swap... + * 0152 FIX: windows_updates: Added Error Handling (Thanks to Stefan Kick)... Multisite: * 0779 Hostgroups (Summary): Empty hostgroups are no longer shown (can be re-enabled by filter) diff --git a/agents/windows/plugins/windows_updates.vbs b/agents/windows/plugins/windows_updates.vbs index 7ef05df..596fce4 100644 --- a/agents/windows/plugins/windows_updates.vbs +++ b/agents/windows/plugins/windows_updates.vbs @@ -6,7 +6,7 @@ ' to a new inventorized service. ' ' Author: Lars Michelsen <lm(a)mathias-kettner.de>, 2011-03-21 -' Editor: Patrick Schlüter <ps(a)pdv-systeme.de>, 2011-08-21 +' Editor: Patrick SchlÃŒter <ps(a)pdv-systeme.de>, 2011-08-21 ' ' Updated by Phil Randal, 2012-09-21, to cache results using a randomised check interval ' of 16 to 24 hours @@ -16,6 +16,8 @@ ' ' Updated by Bastian Kuhn, 2014-03-03: Removed all caching functions cause the current agent ' has a native caching support. Make sure that you activate caching for this script in check_mk.ini +' +' 2014-04-17: Fix by Stefan Kick to handle errors. Payed by Adaptron. ' ----------------------------------------------------------------------------------------- Option Explicit @@ -64,7 +66,18 @@ If CreateObject("Microsoft.Update.SystemInfo").RebootRequired Then reboot = 1 End If +On Error Resume Next + Set result = updtSearcher.Search("IsInstalled = 0 and IsHidden = 0") + +If Err.Number <> 0 then + WScript.Echo "<<<windows_updates>>>" + Wscript.Echo "x x x" + Wscript.Echo "There was an error getting update information. Maybe Windows update is not activated. Error Number: " & Err.Number + WScript.Quit() +End If + + Set colDownloads = result.Updates For Each objEntry in colDownloads diff --git a/checks/windows_updates b/checks/windows_updates index 1a6c153..9f04829 100644 --- a/checks/windows_updates +++ b/checks/windows_updates @@ -47,6 +47,9 @@ def inventory_windows_updates(info): def check_windows_updates(_unused, params, info): if info and len(info[0]) == 3: status = 0 + # Workarround to return errors from the plugin + if info[0][0] == 'x': + return 2, ' '.join(info[1]) reboot_required, num_imp, num_opt = map(saveint, info[0]) imp_warn, imp_crit, opt_warn, opt_crit = params[0:4] if len(params) == 7:

10 years, 5 months

Check_MK Git: check_mk: FIX event console view: fixed exception on rendering host tags for unknown hosts

by Andreas Boesl

Module: check_mk Branch: master Commit: f2bd1dffc44596abd212de8b30ab6d0891f2e13e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f2bd1dffc44596… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Apr 17 15:05:42 2014 +0200 FIX event console view: fixed exception on rendering host tags for unknown hosts The event console was unable to render specific host tag columns when the monitoring system had no knowledge of the host in question. --- .werks/902 | 10 ++++++++++ ChangeLog | 1 + web/htdocs/views.py | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/902 b/.werks/902 new file mode 100644 index 0000000..adf8c9b --- /dev/null +++ b/.werks/902 @@ -0,0 +1,10 @@ +Title: event console view: fixed exception on rendering host tags for unknown hosts +Level: 1 +Component: ec +Class: fix +State: unknown +Version: 1.2.5i3 +Date: 1397739863 + +The event console was unable to render specific host tag columns +when the monitoring system had no knowledge of the host in question. diff --git a/ChangeLog b/ChangeLog index b4e41b8..b34156d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -66,6 +66,7 @@ Event Console: * 0885 New option for writing all messages into a syslog-like logfile... + * 0902 FIX: event console view: fixed exception on rendering host tags for unknown hosts... Livestatus: * 0747 FIX: livestatus table hostsbygroup: fixed bug with group_authorization strict... diff --git a/web/htdocs/views.py b/web/htdocs/views.py index bcb8f5c..6029ff1 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -2735,7 +2735,7 @@ def get_painter_option(name): return opt.get("value", opt['valuespec'].default_value()) def get_host_tags(row): - if "host_custom_variables" in row: + if type(row.get("host_custom_variables")) == dict: return row["host_custom_variables"].get("TAGS", "") for name, val in zip(row["host_custom_variable_names"],

10 years, 5 months

Check_MK Git: check_mk: Reserved 50 Werk IDS

by Andreas Boesl

Module: check_mk Branch: master Commit: eb5e0d08bcf243121acff4fd3739cc4273f550db URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=eb5e0d08bcf243… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Apr 17 15:03:53 2014 +0200 Reserved 50 Werk IDS --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index ed8cc24..be1c55a 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -902 +952

10 years, 5 months

Check_MK Git: check_mk: wagner_titanus_topsense.smoke: New check for Smoke Detectors in Wagner Titanus Top Sens devices

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: cd9dfbfd8bbced9448da209dc1117f8e5877e13d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cd9dfbfd8bbced… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Thu Apr 17 14:46:37 2014 +0200 wagner_titanus_topsense.smoke: New check for Smoke Detectors in Wagner Titanus Top Sens devices --- .werks/894 | 8 ++++ ChangeLog | 1 + checkman/wagner_titanus_topsense.smoke | 18 ++++++++ checks/wagner_titanus_topsense | 45 ++++++++++++++++++-- .../check_mk-wagner_titanus_topsense.smoke.php | 34 +++++++++++++++ web/plugins/perfometer/check_mk.py | 6 +++ 6 files changed, 109 insertions(+), 3 deletions(-) diff --git a/.werks/894 b/.werks/894 new file mode 100644 index 0000000..00edc06 --- /dev/null +++ b/.werks/894 @@ -0,0 +1,8 @@ +Title: wagner_titanus_topsense.smoke: New check for Smoke Detectors in Wagner Titanus Top Sens devices +Level: 1 +Component: checks +Version: 1.2.5i3 +Date: 1397738763 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index 83cdd29..b4e41b8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -29,6 +29,7 @@ * 0808 brocade_mlx*: Checks now also work correctly with Brocade ADX / FGS / ICX devices * 0892 wagner_titanus_topsense: new info check and overall status check for Wagner Titanus Top Sens devices * 0893 wagner_titanus_topsense.alarm: New check for Alarms Triggered on Wagner Titanus Top Sens devices + * 0894 wagner_titanus_topsense.smoke: New check for Smoke Detectors in Wagner Titanus Top Sens devices * 0777 FIX: special agent emcvnx: did not work with security file authentication... * 0786 FIX: zfsget: fixed compatibility with older Solaris agents... * 0809 FIX: brocade_fcport: Fixed recently introduced problem with port speed detection diff --git a/checkman/wagner_titanus_topsense.smoke b/checkman/wagner_titanus_topsense.smoke new file mode 100644 index 0000000..20709bf --- /dev/null +++ b/checkman/wagner_titanus_topsense.smoke @@ -0,0 +1,18 @@ +title: Wagner Titanus Top Sens: Smoke Detectors +agents: snmp +catalog: hw/environment/wagner +license: GPL +distribution: check_mk +description: + Checks the Levels reported by Smoke Detectors of Wagner Titanus Top Sens devices. + + The check returns {OK} if the level is 0.000000 % and {CRIT} otherwise. + +inventory: + Creates two checks, one for every Smoke Detector. + +item: + The ID of the detector. + +perfdata: + One value: The level of smoke in percent. diff --git a/checks/wagner_titanus_topsense b/checks/wagner_titanus_topsense index c084814..7fec122 100644 --- a/checks/wagner_titanus_topsense +++ b/checks/wagner_titanus_topsense @@ -41,8 +41,10 @@ wagner_titanus_topsense_info = [(".1.3.6.1.2.1.1", [1, # 1006]), # pswFailureDisplayOn 9 # off(0), on(1) - (".1.3.6.1.4.1.34187.21501.2.1", [24584008]), # tsLSNbusOnline 0 - # offline(0),online(1) + (".1.3.6.1.4.1.34187.21501.2.1", [24584008, # tsLSNbusOnline 0 + # offline(0),online(1) + 245810000, # tsBarGraph1String + 245820000]), # tsBarGraph2String ] def wagner_titanus_topsense_scan(oid): @@ -146,7 +148,7 @@ def check_wagner_titanus_topsense_alarm(item, _no_params, info): pre_alarm = info[1][0][7] info_alarm = info[1][0][8] else: - return 3, "%s not found in SNMP" % item + return 3, "Alarm Detector %s not found in SNMP" % item status = 0 message = "No Alarm" @@ -172,4 +174,41 @@ check_info["wagner_titanus_topsense.alarm"] = { } #. +# .--smoke percent-------------------------------------------------------. +# | _ _ | +# | ___ _ __ ___ ___ | | _____ _ __ ___ _ __ ___ ___ _ __ | |_ | +# | / __| '_ ` _ \ / _ \| |/ / _ \ | '_ \ / _ \ '__/ __/ _ \ '_ \| __| | +# | \__ \ | | | | | (_) | < __/ | |_) | __/ | | (_| __/ | | | |_ | +# | |___/_| |_| |_|\___/|_|\_\___| | .__/ \___|_| \___\___|_| |_|\__| | +# | |_| | +# '----------------------------------------------------------------------' + +def inventory_wagner_titanus_topsense_smoke(info): + return [ ("1", None), ("2", None) ] +def check_wagner_titanus_topsense_smoke(item, _no_params, info): + if item == "1": + smoke_perc = float(info[2][0][1]) + elif item == "2": + smoke_perc = float(info[2][0][2]) + else: + return 3, "Smoke Detector %s not found in SNMP" % item + + perfdata = [("smoke_perc", smoke_perc)] + if smoke_perc > 0: + status = 2 + else: + status = 0 + + return status, "%0.6f%% smoke detected" % smoke_perc, perfdata + +check_info["wagner_titanus_topsense.smoke"] = { + "check_function" : check_wagner_titanus_topsense_smoke, + "inventory_function" : inventory_wagner_titanus_topsense_smoke, + "service_description" : "Smoke Detector %s", + "has_perfdata" : True, + "snmp_info" : wagner_titanus_topsense_info, + "snmp_scan_function" : wagner_titanus_topsense_scan +} + +#. diff --git a/pnp-templates/check_mk-wagner_titanus_topsense.smoke.php b/pnp-templates/check_mk-wagner_titanus_topsense.smoke.php new file mode 100644 index 0000000..cadd4f1 --- /dev/null +++ b/pnp-templates/check_mk-wagner_titanus_topsense.smoke.php @@ -0,0 +1,34 @@ +<?php +# +------------------------------------------------------------------+ +# | ____ _ _ __ __ _ __ | +# | / ___| |__ ___ ___| | __ | \/ | |/ / | +# | | | | '_ \ / _ \/ __| |/ / | |\/| | ' / | +# | | |___| | | | __/ (__| < | | | | . \ | +# | \____|_| |_|\___|\___|_|\_\___|_| |_|_|\_\ | +# | | +# | Copyright Mathias Kettner 2013 mk(a)mathias-kettner.de | +# +------------------------------------------------------------------+ +# +# This file is part of Check_MK. +# The official homepage is at http://mathias-kettner.de/check_mk. +# +# check_mk is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation in version 2. check_mk is distributed +# in the hope that it will be useful, but WITHOUT ANY WARRANTY; with- +# out even the implied warranty of MERCHANTABILITY or FITNESS FOR A +# PARTICULAR PURPOSE. See the GNU General Public License for more de- +# ails. You should have received a copy of the GNU General Public +# License along with GNU Make; see the file COPYING. If not, write +# to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, +# Boston, MA 02110-1301 USA. + +$opt[1] = "--vertical-label \"%\" -l 0 --title \"$hostname / $servicedesc\" "; + +$def[1] = "DEF:var1=$RRDFILE[1]:$DS[1]:MAX "; +$def[1] .= "AREA:var1#808080:\"Smoke\:\" "; +$def[1] .= "GPRINT:var1:LAST:\"%0.6lf%%\" "; +$def[1] .= "LINE1:var1#000080:\"\" "; +$def[1] .= "GPRINT:var1:MAX:\"(Max\: %0.6lf%%,\" "; +$def[1] .= "GPRINT:var1:AVERAGE:\"Avg\: %0.6lf%%)\" "; +?> diff --git a/web/plugins/perfometer/check_mk.py b/web/plugins/perfometer/check_mk.py index 0738ddb..63d1258 100644 --- a/web/plugins/perfometer/check_mk.py +++ b/web/plugins/perfometer/check_mk.py @@ -931,3 +931,9 @@ def perfometer_licenses_percent(row, check_command, perf_data): return "%.0f%% used" % used_perc, perfometer_linear( used_perc, 'orange' ) perfometers['check_mk-innovaphone_licenses'] = perfometer_licenses_percent + +def perfometer_smoke_percent(row, command, perf): + used_perc = float(perf[0][1]) + return "%0.6f%%" % used_perc, perfometer_linear(used_perc, "#404040") + +perfometers['check_mk-wagner_titanus_topsense.smoke'] = perfometer_smoke_percent

10 years, 5 months

Check_MK Git: check_mk: Force notification number to be at least one (e.g. for custom notifications)

by Mathias Kettner

Module: check_mk Branch: master Commit: 5bc2c7ea3c9520dd8400056cc498db8e34bb11d2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5bc2c7ea3c9520… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Apr 17 10:04:45 2014 +0200 Force notification number to be at least one (e.g. for custom notifications) --- modules/notify.py | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/modules/notify.py b/modules/notify.py index 06da82f..2aa518d 100644 --- a/modules/notify.py +++ b/modules/notify.py @@ -203,11 +203,17 @@ def notify_notify(raw_context, analyse=False): notify_log("Got raw notification context with %s variables" % len(raw_context)) # Add some further variable for the conveniance of the plugins - complete_raw_context(raw_context) if notification_logging >= 2: notify_log("Raw notification context:\n" - + "\n".join(["%s=%s" % v for v in sorted(raw_context.items())])) + + "\n".join([" %s=%s" % v for v in sorted(raw_context.items())])) + + raw_keys = list(raw_context.keys()) + complete_raw_context(raw_context) + + if notification_logging >= 2: + notify_log("Computed variables:\n" + + "\n".join(sorted([" %s=%s" % (k, raw_context[k]) for k in raw_context if k not in raw_keys]))) # Spool notification to remote host, if this is enabled if notification_spool_to: @@ -1518,6 +1524,12 @@ def complete_raw_context(raw_context): if not contact or contact == "check-mk-notify": add_rulebased_macros(raw_context) + # For custom notifications the number is set to 0 by the core (Nagios and CMC). We force at least + # number 1 here, so that rules with conditions on numbers do not fail (the minimum is 1 here) + for what in [ "HOST", "SERVICE" ]: + key = what + "NOTIFICATIONNUMBER" + if key in raw_context and raw_context[key] == "0": + raw_context[key] = "1" # Add the previous hard state. This is neccessary for notification rules that depend on certain transitions, # like OK -> WARN (but not CRIT -> WARN). The CMC sends PREVIOUSHOSTHARDSTATE and PREVIOUSSERVICEHARDSTATE.

10 years, 5 months

Check_MK Git: check_mk: added colspan support for single cells to table api

by Lars Michelsen

Module: check_mk Branch: master Commit: 325abef0bb39952a4618d69aa2a78a4cd3fe5aa5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=325abef0bb3995… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Apr 17 09:53:10 2014 +0200 added colspan support for single cells to table api --- web/htdocs/table.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/web/htdocs/table.py b/web/htdocs/table.py index 6561ef6..2bb03c4 100644 --- a/web/htdocs/table.py +++ b/web/htdocs/table.py @@ -109,13 +109,13 @@ def cell(*posargs, **kwargs): next_func = add_cell next_args = posargs, kwargs -def add_cell(title="", text="", css=None, help=None): +def add_cell(title="", text="", css=None, help=None, colspan=None): if type(text) != unicode: text = str(text) htmlcode = text + html.drain() if table["collect_headers"] == True: table["headers"].append((title, help)) - table["rows"][-1][0].append((htmlcode, css)) + table["rows"][-1][0].append((htmlcode, css, colspan)) def end(): global table @@ -272,8 +272,9 @@ def end(): if css: html.write(' %s' % css) html.write('">\n') - for cell_content, css_classes in row: - html.write(" <td%s>" % (css_classes and (" class='%s'" % css_classes) or "")) + for cell_content, css_classes, colspan in row: + colspan = colspan and (' colspan="%d"' % colspan) or '' + html.write(" <td%s%s>" % (css_classes and (" class='%s'" % css_classes) or "", colspan)) html.write(cell_content) html.write("</td>\n") html.write("</tr>\n")

10 years, 5 months

Check_MK Git: check_mk: Fix attrencode in notification tooltip

by Mathias Kettner

Module: check_mk Branch: master Commit: 1601aedbce7d85302bc1e14906d3a33eb318d8bc URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1601aedbce7d85… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Apr 17 09:41:45 2014 +0200 Fix attrencode in notification tooltip --- web/htdocs/htmllib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py index 6862841..488852f 100644 --- a/web/htdocs/htmllib.py +++ b/web/htdocs/htmllib.py @@ -326,7 +326,7 @@ class html: 'src="images/button_%s_lo.png" ' 'onmouseover=\"hilite_icon(this, 1)\" ' 'onmouseout=\"hilite_icon(this, 0)\">' - '</a>' % (id, onclick, style, target, cssclass, url, help, icon)) + '</a>' % (id, onclick, style, target, cssclass, url, self.attrencode(help), icon)) def empty_icon_button(self): self.write('<img class="iconbutton trans" src="images/trans.png">')

10 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits