Module: check_mk
Branch: master
Commit: de0b3818e981b90d3e5dfd109d2126c5eec97bed
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=de0b3818e981b9…
Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de>
Date: Tue May 6 11:50:20 2014 +0200
Updated bug entries #1067
---
.bugs/1067 | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/.bugs/1067 b/.bugs/1067
new file mode 100644
index 0000000..df7d40f
--- /dev/null
+++ b/.bugs/1067
@@ -0,0 +1,24 @@
+Title: Avoid multiple notifications for a single problem on a single host
+Component: checks
+State: open
+Date: 2014-05-06 11:42:27
+Targetversion: 1.2.5i1
+Class: feature
+
+you have e. g. a machine with some oracle instances
+per instance there are multiple checks
+now if one instance goes down, you get multiple notifications (one per check)
+this is normally unwanted
+
+in classical Nagios setups service dependencies are used to avoid these
+but service dependencies have conceptual weaknesses
+a notification may or may not be sent, depending on the timing of the both checks
+
+as an alternative solution Mathias suggests:
+Throw counter wrap exceptions in case a dependent service fails
+dependent services should get stale in this case
+but this means a check needs to know on which other services it depends
+for the named oracle checks this should work fine
+
+so let's try it this way
+for other szenarios we might find a similar way
Module: check_mk
Branch: master
Commit: 409dd8a33a5486489909481495861fb50996c57e
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=409dd8a33a5486…
Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de>
Date: Tue May 6 11:55:09 2014 +0200
Updated bug entries #1068
---
.bugs/1068 | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/.bugs/1068 b/.bugs/1068
new file mode 100644
index 0000000..b6792ff
--- /dev/null
+++ b/.bugs/1068
@@ -0,0 +1,14 @@
+Title: check_mk_exit_status does not work for SNMP based devices
+Component: checks
+State: open
+Date: 2014-05-06 11:50:46
+Targetversion: 1.2.5i1
+Class: bug
+
+If you do checks on devices not switched on 24x7, you define a rule
+"Status of Check_MK Service", which sets check_mk_exit_status
+
+For devices using the Check_MK agent, this works fine.
+For devices using SNMP it does not work.
+But also maybe a printer (queried by SNMP) may be switched off during
+none office hours.
Module: check_mk
Branch: master
Commit: 62d960b897bb209ec9f1826365430c4dbad0b95a
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=62d960b897bb20…
Author: Andreas Boesl <ab(a)mathias-kettner.de>
Date: Mon May 5 18:13:33 2014 +0200
Improved transaction handling to speedup the Web-GUI
On some systems the number of transaction ids could get very high,
thus slowing down the web interface. This has been improved by re-using
the same transaction id on a page multiple times.
---
.werks/914 | 10 ++++++++++
ChangeLog | 1 +
web/htdocs/htmllib.py | 12 +++++++++---
web/htdocs/sidebar.py | 2 +-
web/htdocs/wato.py | 2 +-
5 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/.werks/914 b/.werks/914
new file mode 100644
index 0000000..09d613d
--- /dev/null
+++ b/.werks/914
@@ -0,0 +1,10 @@
+Title: Improved transaction handling to speedup the Web-GUI
+Level: 1
+Component: multisite
+Version: 1.2.5i3
+Date: 1399306196
+Class: feature
+
+On some systems the number of transaction ids could get very high,
+thus slowing down the web interface. This has been improved by re-using
+the same transaction id on a page multiple times.
diff --git a/ChangeLog b/ChangeLog
index c6ac540..6aa3c1f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -69,6 +69,7 @@
* 0779 Hostgroups (Summary): Empty hostgroups are no longer shown (can be re-enabled by filter)
* 0887 Add new column painter "Host Notifications Enabled"...
* 0963 New snapin with virtual host trees...
+ * 0914 Improved transaction handling to speedup the Web-GUI...
* 0905 FIX: Multisite context buttons: links in context buttons are no longer called twice...
* 0906 FIX: Improved transaction handling in Web GUI...
* 0909 FIX: Table checkboxes: Fixed bug where selected checkboxes got ignored...
diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py
index 2cac2e1..b569b51 100644
--- a/web/htdocs/htmllib.py
+++ b/web/htdocs/htmllib.py
@@ -76,6 +76,7 @@ class html:
self.caches = {}
self.new_transids = []
self.ignore_transids = False
+ self.current_transid = None
RETURN = 13
SHIFT = 16
@@ -178,7 +179,7 @@ class html:
enctype, onsubmit))
self.hidden_field("filled_in", name)
if add_transid:
- self.hidden_field("_transid", str(self.fresh_transid()))
+ self.hidden_field("_transid", str(self.get_transid()))
self.hidden_fields(self.global_vars)
self.form_name = name
@@ -250,7 +251,7 @@ class html:
return filename
def makeactionuri(self, addvars):
- return self.makeuri(addvars + [("_transid", self.fresh_transid())])
+ return self.makeuri(addvars + [("_transid", self.get_transid())])
def makeuri_contextless(self, vars, filename=None):
if not filename:
@@ -279,7 +280,7 @@ class html:
def buttonlink(self, href, text, add_transid=False, obj_id='', style='', title='', disabled=''):
if add_transid:
- href += "&_transid=%s" % self.fresh_transid()
+ href += "&_transid=%s" % self.get_transid()
if not obj_id:
obj_id = self.some_id()
obj_id = ' id=%s' % obj_id
@@ -963,6 +964,11 @@ class html:
self.new_transids.append(transid)
return transid
+ def get_transid(self):
+ if not self.current_transid:
+ self.current_transid = self.fresh_transid()
+ return self.current_transid
+
# Marks a transaction ID as used. This is done by saving
# it in a user specific settings file "transids.mk". At this
# time we remove all entries from that list that are older
diff --git a/web/htdocs/sidebar.py b/web/htdocs/sidebar.py
index 13e9100..31c0869 100644
--- a/web/htdocs/sidebar.py
+++ b/web/htdocs/sidebar.py
@@ -450,7 +450,7 @@ def page_add_snapin():
snapin = sidebar_snapins[name]
title = snapin["title"]
description = snapin.get("description", "")
- transid = html.fresh_transid()
+ transid = html.get_transid()
url = 'sidebar_add_snapin.py?name=%s&_transid=%s&pos=top' % (name, transid)
html.write('<div class=snapinadder '
'onmouseover="this.style.cursor=\'pointer\';" '
diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py
index d153ecc..d6cdd40 100644
--- a/web/htdocs/wato.py
+++ b/web/htdocs/wato.py
@@ -16650,7 +16650,7 @@ def make_link_to(vars, folder):
return html.makeuri_contextless(vars)
def make_action_link(vars):
- return make_link(vars + [("_transid", html.fresh_transid())])
+ return make_link(vars + [("_transid", html.get_transid())])
# Show confirmation dialog, send HTML-header if dialog is shown.
Module: check_mk
Branch: master
Commit: 317302fee706d8ea887d5b85ad95175c6d06c3a9
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=317302fee706d8…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Mon May 5 15:43:46 2014 +0200
Better naming of SNMP bulkwalk/v2c rules
---
web/plugins/wato/check_mk_configuration.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py
index 65a9e47..43b84da 100644
--- a/web/plugins/wato/check_mk_configuration.py
+++ b/web/plugins/wato/check_mk_configuration.py
@@ -2137,7 +2137,7 @@ register_rule(group,
register_rule(group,
"bulkwalk_hosts",
- title = _("Hosts using bulk walk (and SNMP v2c)"),
+ title = _("Hosts using SNMP bulk walk (enforces SNMP v2c)"),
help = _("Most SNMP hosts support SNMP version 2c. However, Check_MK defaults to version 1, "
"in order to support as many devices as possible. Please use this ruleset in order "
"to configure SNMP v2c for as many hosts as possible. That version has two advantages: "
@@ -2157,7 +2157,7 @@ register_rule(group,
register_rule(group,
"snmpv2c_hosts",
- title = _("Hosts using SNMP v2c (and no bulk walk)"),
+ title = _("Hosts using SNMP v2c"),
help = _("There exist a few devices out there that behave very badly when using SNMP bulk walk. "
"If you want to use SNMP v2c on those devices, nevertheless, then use this rule set. "
"One reason is enabling 64 bit counters."))