Module: check_mk
Branch: master
Commit: 7d81d4e10e775bb42c50d321ead720ce96d4e23b
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7d81d4e10e775b…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Fri Jul 4 09:32:25 2014 +0200
Updated bug entries #2132
---
.bugs/2132 | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/.bugs/2132 b/.bugs/2132
new file mode 100644
index 0000000..407ab21
--- /dev/null
+++ b/.bugs/2132
@@ -0,0 +1,11 @@
+Title: WATO context button on quicksearch result page broken
+Component: multisite
+State: open
+Date: 2014-07-04 09:30:24
+Targetversion: 1.2.5i1
+Class: bug
+
+When searching for a host substring, for example "node", results in a page listing
+all services of the hosts node1 and node2. When clicking on the context button
+WATO, it displays a red error message that the host "node" (the substring) is not
+managed by WATO.
Module: check_mk
Branch: master
Commit: ab07d442026c05a84f65c19c2d807f9a50f7e209
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ab07d442026c05…
Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de>
Date: Thu Jul 3 17:42:46 2014 +0200
raritan_pdu_outletcount: got levels now to check the value against and a WATO rule to set them
---
checkman/raritan_pdu_outletcount | 15 ++++++++++++---
checks/raritan_pdu_outletcount | 18 +++++++++++++++---
web/plugins/wato/check_parameters.py | 18 ++++++++++++++++++
3 files changed, 45 insertions(+), 6 deletions(-)
diff --git a/checkman/raritan_pdu_outletcount b/checkman/raritan_pdu_outletcount
index 6725d86..f5c6a97 100644
--- a/checkman/raritan_pdu_outletcount
+++ b/checkman/raritan_pdu_outletcount
@@ -4,14 +4,23 @@ catalog: hw/other
license: GPL
distribution: check_mk
description:
- This check displays the current outlet count of the Raritan PX-2000
+ Checks the current outlet count of the Raritan PX-2000
family of intelligent rack power distribution units (iPDUs).
- It is for reporting only and returns always {OK}.
+ By default this check does report only and returns always {OK}.
+ Only if you set levels explicitly, it returns {WARN} or {CRIT} if
+ the value is outside the given ranges.
perfdata:
- Exactly one number: The outlet count.
+ Exactly one number: The outlet count. If levels are given: Together
+ with it's levels.
inventory:
Creates exactly one check per host called Outlet Count.
+[parameters]
+tuple(int, int, int, int): crit_low, warn_low, warn_high, crit_high:
+ If the value is lower or equal crit_low, the check returns {CRIT}.
+ If the value is lower or equal warn_low, the check returns {WARN}.
+ If the value is higher or equal warn_high, the check returns {WARN}.
+ If the value is higher or equal crit_high, the check returns {CRIT}.
diff --git a/checks/raritan_pdu_outletcount b/checks/raritan_pdu_outletcount
index f55fa3a..0f3fb72 100644
--- a/checks/raritan_pdu_outletcount
+++ b/checks/raritan_pdu_outletcount
@@ -31,14 +31,26 @@ def inventory_raritan_pdu_outletcount(info):
return []
def check_raritan_pdu_outletcount(item, params, info):
- message = "Outlet Count is %s" % info[0][0]
- perfdata = [ ("outletcount", int(info[0][0])) ]
- return 0, message, perfdata
+ outletcount = int(info[0][0])
+ status = 0
+ if params:
+ crit_low, warn_low, warn_high, crit_high = params
+ perfdata = [ ("outletcount", outletcount, "%d:%d" % (warn_low, warn_high), "%d:%d" % (crit_low, crit_high), 0) ]
+ if outletcount <= warn_low or outletcount >= warn_high:
+ status = 1
+ if outletcount <= crit_low or outletcount >= crit_high:
+ status = 2
+ else:
+ perfdata = [ ("outletcount", outletcount, None, None, 0) ]
+
+ message = "Outlet Count is %s" % outletcount
+ return status, message, perfdata
check_info['raritan_pdu_outletcount'] = {
"inventory_function" : inventory_raritan_pdu_outletcount,
"check_function" : check_raritan_pdu_outletcount,
"service_description" : "Outlet Count",
+ "group" : "plug_count",
"has_perfdata" : True,
"snmp_info" : (".1.3.6.1.4.1.13742.6.3.2.2.1.4", ["1"]), # outletCount
"snmp_scan_function" : lambda oid: \
diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py
index 9a3a1f0..4785542 100644
--- a/web/plugins/wato/check_parameters.py
+++ b/web/plugins/wato/check_parameters.py
@@ -5365,3 +5365,21 @@ register_check_parameters(
),
"first"
)
+
+register_check_parameters(
+ subgroup_environment,
+ "plug_count",
+ _("Number of active Plugs"),
+ Tuple(
+ help = _("Levels for the number of active plugs in a devices."),
+ elements = [
+ Integer(title = _("critical if below or equal"), default_value = 30),
+ Integer(title = _("warning if below or equal"), default_value = 32),
+ Integer(title = _("warning if above or equal"), default_value = 38),
+ Integer(title = _("critical if above or equal"), default_value = 40),
+ ]),
+ None,
+ "first"
+)
+
+
Module: check_mk
Branch: master
Commit: 4017bd67e1594df300f426d91c32db2d93262c09
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4017bd67e1594d…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Thu Jul 3 16:41:45 2014 +0200
FIX Remove icon for service parameters in WATO service list for missing services
In the services list of a host in WATO in the section <i>Available (missing) services</i>
the icon for the service parameters has been removed. It didn't work properly because
Check_MK cannot safely analyse non-existent services. It is dangerous anyway if the user
thinks he could do configuration for those services.
---
.werks/1044 | 11 +++++++++++
ChangeLog | 1 +
modules/automation.py | 2 +-
web/htdocs/wato.py | 11 ++++++-----
4 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/.werks/1044 b/.werks/1044
new file mode 100644
index 0000000..c5061b4
--- /dev/null
+++ b/.werks/1044
@@ -0,0 +1,11 @@
+Title: Remove icon for service parameters in WATO service list for missing services
+Level: 1
+Component: wato
+Version: 1.2.5i5
+Date: 1404398390
+Class: fix
+
+In the services list of a host in WATO in the section <i>Available (missing) services</i>
+the icon for the service parameters has been removed. It didn't work properly because
+Check_MK cannot safely analyse non-existent services. It is dangerous anyway if the user
+thinks he could do configuration for those services.
diff --git a/ChangeLog b/ChangeLog
index b501045..9228911 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -43,6 +43,7 @@
* 1004 FIX: Fix exception when saving rules, caused by empty item
* 0947 FIX: WATO snapshots: fixed missing files on restoring nagvis backup domains
* 0826 FIX: Fixed problem where user access times were not updated correctly
+ * 1044 FIX: Remove icon for service parameters in WATO service list for missing services...
Notifications:
* 1042 Rule based notifications: allow matching on host groups...
diff --git a/modules/automation.py b/modules/automation.py
index e0eca6c..2882a54 100644
--- a/modules/automation.py
+++ b/modules/automation.py
@@ -637,7 +637,7 @@ def automation_analyse_service(args):
"item" : item,
"inv_parameters" : params,
"factory_settings" : fs,
- "parameters" : compute_check_parameters(hostname, ct, item, params),
+ "parameters" : compute_check_parameters(hostname, ct, item, params),
}
except:
if opt_debug:
diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py
index 4fb4a60..a96c89a 100644
--- a/web/htdocs/wato.py
+++ b/web/htdocs/wato.py
@@ -3343,12 +3343,13 @@ def show_service_table(host, firsttime):
# #html.write('<a href="%s"><img title="%s" class=icon src="images/icon_rulesets.png"></a>' %
# # (url, title))
- # Icon for Service parameters
+ # Icon for Service parameters. Not for missing services!
table.cell("", "")
- params_url = make_link([("mode", "object_parameters"),
- ("host", hostname),
- ("service", descr)])
- html.icon_button(params_url, _("View and modify the parameters for this service"), "rulesets")
+ if state_type != "new":
+ params_url = make_link([("mode", "object_parameters"),
+ ("host", hostname),
+ ("service", descr)])
+ html.icon_button(params_url, _("View and modify the parameters for this service"), "rulesets")
# Permanently disable icon