Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: c4a5c350df7bb8e852b6c68a6d53bd1751268157
https://github.com/Checkmk/checkmk/commit/c4a5c350df7bb8e852b6c68a6d53bd175…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2024-02-29 (Thu, 29 Feb 2024)
Changed paths:
M cmk/base/config.py
M cmk/ec/rule_packs.py
M cmk/gui/config.py
Log Message:
-----------
Improve warnings created while reading in .mk files #2
Previously we produced exceptions or python warning messages without
references to the origin of this issue, similar to this:
```
<string>:52: SyntaxWarning: invalid escape sequence '\D'
```
With this change we get messages referencing to source of the message:
```
/omd/sites/beta/etc/check_mk/conf.d/wato/rules.mk:52: SyntaxWarning: invalid escape sequence '\D'
{'id': '24da4ccd-0d1b-40e3-af87-0097df8668f2', 'value': ('service', '\Docker container status'), 'condition': {'host_label_groups': [('and', [('and', 'cmk/docker_object:container')])]}, 'options': {'description': 'Make all docker container host states base on the "Docker container status" service'}},
```
Change-Id: I184163c36772f3c87c10ee6f06e3f65723276b47
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications
Branch: refs/heads/2.3.0
Home: https://github.com/Checkmk/checkmk
Commit: 869aff13ad67ac9db9b393ffbcb64907a8eea90e
https://github.com/Checkmk/checkmk/commit/869aff13ad67ac9db9b393ffbcb64907a…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2024-02-29 (Thu, 29 Feb 2024)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/test_cpu_threads.py
Log Message:
-----------
Add base line test
... this reveals the non-resilient parse function
Change-Id: I69935d00914baca3bb169a483826858e2c4f1328
JIRA-Ref: SUP-16682
Commit: c2dced785f062df68ec997f7aebb8c3af8dc973a
https://github.com/Checkmk/checkmk/commit/c2dced785f062df68ec997f7aebb8c3af…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2024-02-29 (Thu, 29 Feb 2024)
Changed paths:
A .werks/16240.md
M cmk/base/plugins/agent_based/cpu.py
M cmk/base/plugins/agent_based/cpu_threads.py
M cmk/plugins/lib/cpu.py
M tests/unit/cmk/base/plugins/agent_based/test_cpu_threads.py
Log Message:
-----------
16240 FIX Crash on missing thread count on AIX
You're affected if you want to monitor your CPU and the cpu check crashes with something like:
```
File "/omd/sites/YOURSITE/lib/python3/cmk/base/plugins/agent_based/cpu.py", line 48, in parse_cpu
count=int(row[3].split("/")[1]),
ValueError (invalid literal for int() with base 10: '')
```
We saw this happening on AIX system when the ps information cannot be obtained due to low memory.
The parsing is now more resilient against such missing data.
Change-Id: I4118c37e0f78621864ca5aa6a26186b2a548ad42
JIRA-Ref: SUP-16682
Compare: https://github.com/Checkmk/checkmk/compare/d9668a1d212f...c2dced785f06
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 52e9f310a9e2f95c8ec1463e8ca49f6de2b499a0
https://github.com/Checkmk/checkmk/commit/52e9f310a9e2f95c8ec1463e8ca49f6de…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2024-02-29 (Thu, 29 Feb 2024)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/test_cpu_threads.py
Log Message:
-----------
Add base line test
... this reveals the non-resilient parse function
Change-Id: I69935d00914baca3bb169a483826858e2c4f1328
JIRA-Ref: SUP-16682
Commit: 18c91414fa68999666c836088f0e9c0b439ec135
https://github.com/Checkmk/checkmk/commit/18c91414fa68999666c836088f0e9c0b4…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2024-02-29 (Thu, 29 Feb 2024)
Changed paths:
A .werks/16240.md
M cmk/base/plugins/agent_based/cpu.py
M cmk/base/plugins/agent_based/cpu_threads.py
M cmk/plugins/lib/cpu.py
M tests/unit/cmk/base/plugins/agent_based/test_cpu_threads.py
Log Message:
-----------
16240 FIX Crash on missing thread count on AIX
You're affected if you want to monitor your CPU and the cpu check crashes with something like:
```
File "/omd/sites/YOURSITE/lib/python3/cmk/base/plugins/agent_based/cpu.py", line 48, in parse_cpu
count=int(row[3].split("/")[1]),
ValueError (invalid literal for int() with base 10: '')
```
We saw this happening on AIX system when the ps information cannot be obtained due to low memory.
The parsing is now more resilient against such missing data.
Change-Id: I4118c37e0f78621864ca5aa6a26186b2a548ad42
JIRA-Ref: SUP-16682
Compare: https://github.com/Checkmk/checkmk/compare/d608911d49e1...18c91414fa68
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications
Branch: refs/heads/2.3.0
Home: https://github.com/Checkmk/checkmk
Commit: d9668a1d212f9d31d4889b31254d29f01161d740
https://github.com/Checkmk/checkmk/commit/d9668a1d212f9d31d4889b31254d29f01…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2024-02-29 (Thu, 29 Feb 2024)
Changed paths:
M cmk/gui/utils/rule_specs/legacy_converter.py
M cmk/gui/validation/visitors/vue_formspec_visitor.py
M tests/unit/cmk/gui/utils/rulespecs/test_legacy_converter.py
Log Message:
-----------
Ruleset API: Remove Tuple from API
Use Dictionary or Levels instead
CMK-15645
Change-Id: I14df707ae2612a7a4e2d1787eb6e1d5c7d1ad5c8
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 9bc38c5d8d9268776432c066be5a836002a3a1da
https://github.com/Checkmk/checkmk/commit/9bc38c5d8d9268776432c066be5a83600…
Author: Sven Panne <sven.panne(a)checkmk.com>
Date: 2024-02-29 (Thu, 29 Feb 2024)
Changed paths:
M cmk/plugins/cisco/server_side_calls/prime.py
M cmk/plugins/collection/server_side_calls/check_sftp.py
M cmk/plugins/elasticsearch/server_side_calls/special_agent.py
M cmk/plugins/prism/server_side_calls/special_agent.py
M packages/cmk-server-side-calls/cmk/server_side_calls/v1/_utils.py
Log Message:
-----------
Make parse_secret's type more honest.
It *has* more requirements than its previous signature stated, and testing
these requirements within that function is an anti-pattern.
If we really want more validation for the value part of the secret, that
should live in e.g. __post_init__()s of StoredSecret and PlainSecret, but
there is not really much point in doing so: If we deem this necessary, we
would need *tons* of other validations and should probably switch to
pydantic models directly.
Fixed a wrong type annotation in the cisco plugin on the way.
Change-Id: I550e75e66d13ec9cad47e7531b5a890b1068f44f
Commit: d608911d49e1bd2795a246fdfe94bd54bd76a360
https://github.com/Checkmk/checkmk/commit/d608911d49e1bd2795a246fdfe94bd54b…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2024-02-29 (Thu, 29 Feb 2024)
Changed paths:
M cmk/gui/utils/rule_specs/legacy_converter.py
M cmk/gui/validation/visitors/vue_formspec_visitor.py
M tests/unit/cmk/gui/utils/rulespecs/test_legacy_converter.py
Log Message:
-----------
Ruleset API: Remove Tuple from API
Use Dictionary or Levels instead
CMK-15645
Change-Id: I14df707ae2612a7a4e2d1787eb6e1d5c7d1ad5c8
Compare: https://github.com/Checkmk/checkmk/compare/44e832c31553...d608911d49e1
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications