Module: check_mk
Branch: master
Commit: 68d1cfbcfcf06795da8dd846b91060f1e5a30e87
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=68d1cfbcfcf067…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Mon Dec 1 18:16:52 2014 +0100
Updated bug entries #2137
---
.bugs/2137 | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/.bugs/2137 b/.bugs/2137
index fc51569..db5a919 100644
--- a/.bugs/2137
+++ b/.bugs/2137
@@ -1,9 +1,9 @@
Title: Foldable containers with Umlauts in titles are not expanded on load
Component: multisite
-State: open
+Class: bug
+State: done
Date: 2014-07-16 10:13:33
Targetversion: 1.2.5i1
-Class: bug
When unicode strings with umlauts are used as titles for foldable containers,
the states are saved, but can not be read/parsed/compared correctly. This seems
@@ -11,3 +11,6 @@ to be related to the pprint.pformat() function which writes the unicode string
as key of a dict, but does not re-reads the value correctly as unicode string.
It has happened here with the titles of the views snapin.
+
+2014-12-01 18:16:50: changed state open -> done
+Fixed.
Module: check_mk
Branch: master
Commit: 0cd6466c9d9218b3dc0be048a85bf890b767919a
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0cd6466c9d9218…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Mon Dec 1 18:09:14 2014 +0100
#1578 FIX Folding states of containers with umlauts in titles are now persisted
When a foldable container has umlauts in the title, for example when a view
topic has umlauts in it, the folding state was not persisted across page reloads.
---
.werks/1578 | 10 ++++++++++
ChangeLog | 1 +
web/htdocs/config.py | 2 ++
web/htdocs/js/bi.js | 4 ++--
web/htdocs/js/checkmk.js | 7 ++++---
web/htdocs/js/sidebar.js | 27 ++++++++++++++-------------
web/htdocs/js/wato.js | 25 +++++++++++++------------
web/htdocs/lib.py | 11 ++++++++++-
web/htdocs/weblib.py | 3 ++-
9 files changed, 58 insertions(+), 32 deletions(-)
Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=0cd6466c9d…
Module: check_mk
Branch: master
Commit: 878da42a4f41a6f120b07303ce0963a6aaffe834
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=878da42a4f41a6…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Mon Dec 1 13:54:16 2014 +0100
#1572 FIX Sample configs, plugins etc. for windows agent use windows linebreaks now
Some files which are meant to be used on windows systems had unix style linebreaks,
which are not interpreted correctly by some editors, like for example notepad. This
has been fixed now. All files in packend agents are now using windows style linebreaks.
---
.bugs/2203 | 7 +-
.werks/1572 | 12 ++
ChangeLog | 1 +
agents/windows/Makefile | 16 ++-
agents/windows/check_mk.example.ini | 196 ++++++++++++-------------
agents/windows/crash.exe | Bin 20024 -> 20024 bytes
agents/windows/install_agent-64.exe | Bin 160296 -> 160305 bytes
agents/windows/install_agent.exe | Bin 157225 -> 157231 bytes
agents/windows/mrpe/check_crit.bat | 4 +-
agents/windows/plugins/dmi_sysinfo.bat | 30 ++--
agents/windows/plugins/hyperv_vms.ps1 | 4 +-
agents/windows/plugins/megaraid.bat | 2 +-
agents/windows/plugins/mk_inventory.ps1 | 198 +++++++++++++-------------
agents/windows/plugins/windows_multipath.vbs | 48 +++----
agents/windows/plugins/windows_tasks.ps1 | 2 +-
agents/windows/plugins/wmic_if.ps1 | Bin 3634 -> 3635 bytes
16 files changed, 272 insertions(+), 248 deletions(-)
Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=878da42a4f…
Module: check_mk
Branch: master
Commit: e36a03cf537d6e1dfed23df15c1cb904b69c6861
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e36a03cf537d6e…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Mon Dec 1 16:13:11 2014 +0100
#1576 FIX SNMP Community host attribute is now visible for IE<=8
The SNMP Community was not visible on host edit page for hosts
using the snmp tag when opening the page with Internet Explorer
version 8 or below.
---
.bugs/2184 | 7 +++++--
.werks/1576 | 11 +++++++++++
ChangeLog | 1 +
web/htdocs/js/wato.js | 19 ++++++++++---------
4 files changed, 27 insertions(+), 11 deletions(-)
diff --git a/.bugs/2184 b/.bugs/2184
index 9f39b7c..fd548b3 100644
--- a/.bugs/2184
+++ b/.bugs/2184
@@ -1,12 +1,15 @@
Title: SNMP Community in host properties not shown on IE?
Component: wato
-State: open
+Class: bug
+State: done
Date: 2014-09-25 16:13:09
Targetversion: future
-Class: bug
A host that is tagged as SNMP host is opened in WATO. Nevertheless
the attribute SNMP Community is not visible. In Firefox it is
visible. Looks like some JS problem with IE...
Switching back and forth the tag seems not help.
+
+2014-12-01 16:09:41: changed state open -> done
+Fixed.
diff --git a/.werks/1576 b/.werks/1576
new file mode 100644
index 0000000..ccb1c87
--- /dev/null
+++ b/.werks/1576
@@ -0,0 +1,11 @@
+Title: SNMP Community host attribute is now visible for IE<=8
+Level: 1
+Component: wato
+Compatible: compat
+Version: 1.2.5i7
+Date: 1417446679
+Class: fix
+
+The SNMP Community was not visible on host edit page for hosts
+using the snmp tag when opening the page with Internet Explorer
+version 8 or below.
diff --git a/ChangeLog b/ChangeLog
index d46cc47..adebc73 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -107,6 +107,7 @@
* 1542 FIX: Changed text of "debug_log" option to be clearer in distributed setups...
* 1546 FIX: Fixed adding cluster nodes to new cluster in complain phase...
* 1556 FIX: WATO inventory ignores already inventorized checks which does not exist anymore...
+ * 1576 FIX: SNMP Community host attribute is now visible for IE<=8...
Notifications:
* 1512 Bulk notification can now be grouped according to custom macro values...
diff --git a/web/htdocs/js/wato.js b/web/htdocs/js/wato.js
index 9961431..afe109f 100644
--- a/web/htdocs/js/wato.js
+++ b/web/htdocs/js/wato.js
@@ -86,7 +86,8 @@ function wato_fix_visibility() {
var oTable = oHostTags.childNodes[0]; /* tbody */
oHostTags = null;
- for (var i in oTable.childNodes) {
+
+ for (var i = 0; i < oTable.childNodes.length; i++) {
var oTr = oTable.childNodes[i];
if (oTr.tagName == 'TR') {
var oTdLegend = oTr.childNodes[0];
@@ -119,7 +120,7 @@ function wato_fix_visibility() {
stored in the global variable wato_depends_on_tags, which is filled
during the creation of the web page. */
- for (var i in wato_check_attributes) {
+ for (var i = 0; i < wato_check_attributes.length; i++) {
var attrname = wato_check_attributes[i];
/* Now comes the tricky part: decide whether that attribute should
be visible or not: */
@@ -132,8 +133,8 @@ function wato_fix_visibility() {
// Visibility depends on roles
if( display == "" && attrname in wato_depends_on_roles){
- for (var i in wato_depends_on_roles[attrname]) {
- var role = wato_depends_on_roles[attrname][i];
+ for (var index = 0; index < wato_depends_on_roles[attrname].length; index++) {
+ var role = wato_depends_on_roles[attrname][index];
var negate = role[0] == '!';
var rolename = negate ? role.substr(1) : role;
var have_role = user_roles.indexOf(rolename) != -1;
@@ -146,8 +147,8 @@ function wato_fix_visibility() {
// Visibility depends on tags
if( display == "" && attrname in wato_depends_on_tags){
- for (var i in wato_depends_on_tags[attrname]) {
- var tag = wato_depends_on_tags[attrname][i];
+ for (var index = 0; index < wato_depends_on_tags[attrname].length; index++) {
+ var tag = wato_depends_on_tags[attrname][index];
var negate = tag[0] == '!';
var tagname = negate ? tag.substr(1) : tag;
var have_tag = currentTags.indexOf(tagname) != -1;
@@ -199,9 +200,9 @@ function wato_fix_visibility() {
// FIXME: use generic identifier for each form
var available_forms = [ "form_edithost", "form_editfolder", "form_bulkedit" ];
- for ( var try_form in available_forms ){
- var my_form = document.getElementById(available_forms[try_form]);
- if (my_form != null) {
+ for (var try_form = 0; try_form < available_forms.length; try_form++) {
+ var my_form = document.getElementById(available_forms[try_form]);
+ if (my_form != null) {
for (var child in my_form.childNodes){
oTr = my_form.childNodes[child];
if (oTr.className == "nform"){
Module: check_mk
Branch: master
Commit: daece7c467e22d4c5691be43cf88002d4edf9891
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=daece7c467e22d…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Mon Dec 1 14:24:17 2014 +0100
#1574 FIX Hosts named like used python modules do not break precompiled checks anymore
Previously, when creating a host named "random" and using the Nagios core, which is
using the precompiled checks, all checks broke with a python exception.
---
.bugs/2155 | 7 +++++--
.werks/1574 | 10 ++++++++++
ChangeLog | 1 +
modules/check_mk_base.py | 9 ++++++++-
4 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/.bugs/2155 b/.bugs/2155
index c34b3bc..09bc8f2 100644
--- a/.bugs/2155
+++ b/.bugs/2155
@@ -1,9 +1,9 @@
Title: Host named like a Python module will break precompiled checks
Component: core
-State: open
+Class: bug
+State: done
Date: 2014-05-14 13:57:30
Targetversion: 1.2.5i1
-Class: bug
Operating System: Debian 7
@@ -16,3 +16,6 @@ instead of the real random module.
This only seems to affect that indrectly imported module. A test with creating a
host with the name 'os' did not show any abnormalities.
+
+2014-12-01 14:22:43: changed state open -> done
+Fixed.
diff --git a/.werks/1574 b/.werks/1574
new file mode 100644
index 0000000..2a43ea0
--- /dev/null
+++ b/.werks/1574
@@ -0,0 +1,10 @@
+Title: Hosts named like used python modules do not break precompiled checks anymore
+Level: 1
+Component: core
+Compatible: compat
+Version: 1.2.5i7
+Date: 1417440175
+Class: fix
+
+Previously, when creating a host named "random" and using the Nagios core, which is
+using the precompiled checks, all checks broke with a python exception.
diff --git a/ChangeLog b/ChangeLog
index ada1df0..20b4989 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,6 +5,7 @@
* 1431 FIX: windows_agent: fixed error on parsing unicode formatted logfiles...
* 1545 FIX: Terminating with exit code 3 now when duplicate host has been found
* 1555 FIX: Improved validation on timeperiod references of non existing periods...
+ * 1574 FIX: Hosts named like used python modules do not break precompiled checks anymore...
Checks & Agents:
* 1197 climaveneta_temp: New check for temperature sensors on Climaveneta clima devices
diff --git a/modules/check_mk_base.py b/modules/check_mk_base.py
index db6b925..f86fcaf 100644
--- a/modules/check_mk_base.py
+++ b/modules/check_mk_base.py
@@ -24,7 +24,14 @@
# to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
# Boston, MA 02110-1301 USA.
-import socket, os, sys, time, re, signal, math, tempfile
+import sys
+
+# Remove precompiled directory from sys.path. Leaving it in the path
+# makes problems when host names (name of precompiled files) are equal
+# to python module names like "random"
+sys.path.pop(0)
+
+import socket, os, time, re, signal, math, tempfile
# Python 2.3 does not have 'set' in normal namespace.
# But it can be imported from 'sets'
Module: check_mk
Branch: master
Commit: f22ddb5ac6cc7c3c41247a13357b4847d3213d1e
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f22ddb5ac6cc7c…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Mon Dec 1 14:54:26 2014 +0100
Updated bug entries #2262
---
.bugs/2262 | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/.bugs/2262 b/.bugs/2262
new file mode 100644
index 0000000..ffe0b92
--- /dev/null
+++ b/.bugs/2262
@@ -0,0 +1,9 @@
+Title: A user without permissions for changing the sidebar (guest) should not be allowd to fold
+Component: multisite
+State: open
+Date: 2014-12-01 14:53:36
+Targetversion: 1.2.5i1
+Class: nastiness
+
+Reason: the folding state is not persisted. Therefore the snapins will fold back
+when the sidebar is reloaded.