Module: check_mk
Branch: master
Commit: e1f37292c4fd6d3e70bb2973979f7a9df70a8d1f
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e1f37292c4fd6d…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Wed Dec 10 11:00:56 2014 +0100
Updated bug entries #2265
---
.bugs/2265 | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/.bugs/2265 b/.bugs/2265
new file mode 100644
index 0000000..a041f7e
--- /dev/null
+++ b/.bugs/2265
@@ -0,0 +1,17 @@
+Title: Preserve files in OMD tmpfs during reboot or update
+Component: core
+State: open
+Date: 2014-12-10 09:51:47
+Targetversion: 1.2.5i1
+Class: todo
+
+When unmounting the tmpfs of an OMD site would should create a tarball
+of tmp, without tmp/run. Before this we need to do some cleanup things:
+
+- Nobody must have PID files or sockets in other place than tmp/run
+ (fix apache and rrdcached)
+- Create *all* directories already via skel (e.g. tmp/check_mk/piggyback
+ is missing here)
+
+When later mounting the tmpfs populate it from skel as usual and then
+extract all files from the tarball that match *existing* directories.
Module: check_mk
Branch: master
Commit: 808312a0a1325d2fdf70cd933dd3dac8e38bb51b
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=808312a0a1325d…
Author: Bastian Kuhn <bk(a)mathias-kettner.de>
Date: Wed Dec 10 09:59:27 2014 +0100
Updated bug entries #2277
---
.bugs/2277 | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/.bugs/2277 b/.bugs/2277
new file mode 100644
index 0000000..eabbd87
--- /dev/null
+++ b/.bugs/2277
@@ -0,0 +1,14 @@
+Title: It's not possible to edit a dashlet anymore
+Component: checks
+State: open
+Date: 2014-12-10 09:57:05
+Targetversion: 1.2.5i1
+Class: bug
+
+Clicking the edit button for a dashlet and saving the formular after leads to the following error:
+Internal error:: local variable 'action' referenced before assignment (Retry with debug mode)
+
+and then you get the following error when trying to open the view again:
+
+
+Missing needed host parameter. ( Sorry the dasboard not view )
Module: check_mk
Branch: master
Commit: 8b29f838047e0f7dd6c383f8d4c431372b9504b7
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8b29f838047e0f…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Tue Dec 9 17:24:42 2014 +0100
#1751 FIX winperf_ts_sessions: try to fix invalid number of active and inactive sessions
M$ seems to have changed the order of the performance counters in newer OS versions
(horray!). We try to compensate for that by doing some computations.
---
.werks/1751 | 10 ++++++++++
ChangeLog | 1 +
checkman/winperf_ts_sessions | 4 ++--
checks/winperf_ts_sessions | 12 +++++++++---
4 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/.werks/1751 b/.werks/1751
new file mode 100644
index 0000000..45ca05a
--- /dev/null
+++ b/.werks/1751
@@ -0,0 +1,10 @@
+Title: winperf_ts_sessions: try to fix invalid number of active and inactive sessions
+Level: 1
+Component: checks
+Compatible: compat
+Version: 1.2.5i7
+Date: 1418142192
+Class: fix
+
+M$ seems to have changed the order of the performance counters in newer OS versions
+(horray!). We try to compensate for that by doing some computations.
diff --git a/ChangeLog b/ChangeLog
index ee57b1f..b21a2c7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -158,6 +158,7 @@
* 1736 FIX: lparstat_aix: Trying to deal with more kind of lparstat output...
* 1737 FIX: mk_sap: Working around garbled SAP state file when multiple instances were running parallel
* 1738 FIX: oracle_instance: Be compatible to old oracle agent outputs
+ * 1751 FIX: winperf_ts_sessions: try to fix invalid number of active and inactive sessions...
Multisite:
* 1508 Allow input of plugin output and perfdata when faking check results...
diff --git a/checkman/winperf_ts_sessions b/checkman/winperf_ts_sessions
index f55db18..e2d10eb 100644
--- a/checkman/winperf_ts_sessions
+++ b/checkman/winperf_ts_sessions
@@ -8,11 +8,11 @@ description:
Server Sessions using the windows performance counters (agent section
{<<<winperf_ts_sessions>>>}).
- To make this check work, you need to configure the agent via it's .ini
+ To make this check work, you need to configure the agent via it's <tt>check_mk.ini</tt>
file to forward the terminal service session related counters. Take a
look at the windows monitoring documentation for details.
- It allows to set {WARN} and {CRIT} tresholds on the active and idle session.
+ It allows to set WARN and CRIT tresholds on the active and idle session.
inventory:
The check generates service per host.
diff --git a/checks/winperf_ts_sessions b/checks/winperf_ts_sessions
index 8866f98..a1846bc 100644
--- a/checks/winperf_ts_sessions
+++ b/checks/winperf_ts_sessions
@@ -27,9 +27,9 @@
# Example output from agent:
# <<<winperf_ts_sessions>>>
# 1385714515.93 2102
-# 2 1 rawcount
-# 4 1 rawcount
-# 6 0 rawcount
+# 2 20 rawcount
+# 4 18 rawcount
+# 6 2 rawcount
# Counters, relative to the base ID (e.g. 2102)
# 2 Total number of Terminal Services sessions.
@@ -45,6 +45,12 @@ def check_winperf_ts_sessions(_unused, params, info):
return 3, "Performance counters not available"
total, active, inactive = [ int(l[1]) for l in info[1:4] ]
+ # Tom Moore said, that the order of the columns has recently changed
+ # in newer Windows versions (hooray!) and is now active, inactive, total.
+ # We try to accomodate for that.
+ if active + inactive != total:
+ active, inactive, total = total, active, inactive
+
state = 0
state_txt = []
for val, key, title in [ (active, 'active', 'Active'),
Module: check_mk
Branch: master
Commit: 6f6783023701f2226a79944c7936d5b1b3a56bba
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6f6783023701f2…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Tue Dec 9 17:09:18 2014 +0100
#1750 FIX Handle rare cases where SNMP response string begins with a line feed
The SNMP engine von Check_MK already handled the case correctly that a string
contains newlines. But the rare case that it <i>started</i> with a newline
was not handled correctly. This has been fixed now.
---
.werks/1750 | 11 +++++++++++
ChangeLog | 1 +
modules/snmp.py | 2 +-
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/.werks/1750 b/.werks/1750
new file mode 100644
index 0000000..eac8470
--- /dev/null
+++ b/.werks/1750
@@ -0,0 +1,11 @@
+Title: Handle rare cases where SNMP response string begins with a line feed
+Level: 1
+Component: core
+Compatible: compat
+Version: 1.2.5i7
+Date: 1418141289
+Class: fix
+
+The SNMP engine von Check_MK already handled the case correctly that a string
+contains newlines. But the rare case that it <i>started</i> with a newline
+was not handled correctly. This has been fixed now.
diff --git a/ChangeLog b/ChangeLog
index b2bae67..40944d3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -14,6 +14,7 @@
* 1628 FIX: Remove trailing backslashes from service descriptions...
* 1649 FIX: Check_MK inventory service has been renamed to Check_MK Discovery...
* 1706 FIX: Fix file permissions when installing MKPs to 0644 or 0755...
+ * 1750 FIX: Handle rare cases where SNMP response string begins with a line feed...
Checks & Agents:
* 1197 climaveneta_temp: New check for temperature sensors on Climaveneta clima devices
diff --git a/modules/snmp.py b/modules/snmp.py
index d5c0050..c376d06 100644
--- a/modules/snmp.py
+++ b/modules/snmp.py
@@ -445,7 +445,7 @@ def snmpwalk_on_suboid(hostname, ip, oid, hex_plain = False):
or value.startswith('No Such Object available') or value.startswith('No Such Instance currently exists'):
continue
- if len(value) > 0 and value[0] == '"' and value[-1] != '"': # to be continued
+ if value == '"' or (len(value) > 1 and value[0] == '"' and (value[-1] != '"')): # to be continued
while True: # scan for end of this dataset
nextline = line_iter.next().strip()
value += " " + nextline