Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64361 discussions

[Checkmk/checkmk] c282a2: Refactoring: Simplify EOL handling in console.error

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: c282a214eb2414e9a871a5b33f1b8a743f7d2c44 https://github.com/Checkmk/checkmk/commit/c282a214eb2414e9a871a5b33f1b8a743… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M bin/check_mk M cmk/base/api/agent_based/register/_discover.py M cmk/base/api/bakery/register.py M cmk/base/automations/__init__.py M cmk/base/config.py M cmk/base/core_nagios/_precompile_host_checks.py M cmk/base/modes/check_mk.py M cmk/base/notify.py M cmk/base/parent_scan.py M cmk/checkengine/discovery/_host_labels.py M cmk/checkengine/discovery/_services.py M cmk/utils/log/console.py M tests/unit/cmk/utils/test_log_console.py Log Message: ----------- Refactoring: Simplify EOL handling in console.error It doesn't make sense to go the extra mile to avoid emitting an EOL in print(), just to add that EOL at every call site. Note that one must be very careful when chaning such things in our code, because the console code is effectively used for three totally different purposes to emit: * fancy, perhaps colored output on the TTY * log lines in some log file * a fixed internal protocol Sometimes one doesn't even know actual the purpose, because the code in question is used in various scenarios. This is quite suboptimal and should really be disentangled, but this is something for future cleanups. Change-Id: I681ee1b567d2f04c33c055f63f97f38ebada5252 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

[Checkmk/checkmk] ed23a9: notify: Prefer arg passing to global - log_level

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: ed23a9baea7087e2dd2732d4500fb11a1c59aee6 https://github.com/Checkmk/checkmk/commit/ed23a9baea7087e2dd2732d4500fb11a1… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/config.py M cmk/base/modes/check_mk.py M cmk/base/notify.py Log Message: ----------- notify: Prefer arg passing to global - log_level CMK-16672 Change-Id: I57eca69455ae8ae7429c01702ca73b868605a94d Commit: e308a31114d8737ff52d1b2dcccbf2665cd719b2 https://github.com/Checkmk/checkmk/commit/e308a31114d8737ff52d1b2dcccbf2665… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/config.py M cmk/base/modes/check_mk.py M cmk/base/notify.py Log Message: ----------- notify: Prefer arg passing to global - spooling CMK-16672 Change-Id: I3a908e144953bc203c46f22c9d973cacbd02cc40 Commit: 7eae913bc9f2dca07dee0e57ac6e28bc2664ad37 https://github.com/Checkmk/checkmk/commit/7eae913bc9f2dca07dee0e57ac6e28bc2… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/modes/check_mk.py M cmk/base/notify.py Log Message: ----------- notify: Prefer arg passing to global - fallback_email CMK-16672 Change-Id: I47ff39e93d4a9dc2108d24b83d595a6899fd0174 Commit: ee3e119804e237f6f1ee80b79b80f9c37e5d5bb3 https://github.com/Checkmk/checkmk/commit/ee3e119804e237f6f1ee80b79b80f9c37… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/modes/check_mk.py M cmk/base/notify.py Log Message: ----------- notify: Prefer arg passing to global: bulk_interval CMK-16672 Change-Id: Ibd609f57678224ed213d36f4d81d3fdebec09df2 Commit: 6b99fb5eb172d49822a2fc06b46e9a7975621f41 https://github.com/Checkmk/checkmk/commit/6b99fb5eb172d49822a2fc06b46e9a797… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/modes/check_mk.py M cmk/base/notify.py Log Message: ----------- notify: Prefer arg passing to global: fallback_format CMK-16672 Change-Id: Ibc575cee89fc20464c9dbd7de8b8900c0f23f800 Compare: https://github.com/Checkmk/checkmk/compare/cc996d0af59e...6b99fb5eb172 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

[Checkmk/checkmk] cc996d: add test for broken forwarding method

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: cc996d0af59e7622d5b1927de92abad3f80a3931 https://github.com/Checkmk/checkmk/commit/cc996d0af59e7622d5b1927de92abad3f… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/unit/checks/test_check_mail.py Log Message: ----------- add test for broken forwarding method Change-Id: Id001138baf9f34ec25300ad4e7863d31930e7744 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

[Checkmk/checkmk] 65a84a: 16854 FIX SNMP: Fix missing data error when using ...

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: 65a84a1df0f4926a3aa5f456a0b18d318da81095 https://github.com/Checkmk/checkmk/commit/65a84a1df0f4926a3aa5f456a0b18d318… Author: Sofia Colakovic <sofia.colakovic(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: A .werks/16854 M cmk/base/sources.py M cmk/checkers/_parseragent.py M cmk/checkers/_parsersnmp.py M cmk/fetchers/cache.py M tests/unit/cmk/checkers/test_parsers.py Log Message: ----------- 16854 FIX SNMP: Fix missing data error when using 'Fetch intervals for SNMP sections' Users using the `Fetch intervals for SNMP sections` rule, would occasionally get a missing data error, after which the monitoring would return back to normal. The cause was SNMP section becoming expired during the checking. The problem is fixed by using the last fetched section data instead. SUP-18415 Change-Id: I8e2080f5fa3b2fd17647c577a9bfd14785949904 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

[Checkmk/checkmk] a2fdc0: Nuke LoadStructuredDataError

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: a2fdc083d9096475959929e9ca8e49870186c120 https://github.com/Checkmk/checkmk/commit/a2fdc083d9096475959929e9ca8e49870… Author: Simon Jess <simon.jess(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M cmk/gui/inventory/__init__.py Log Message: ----------- Nuke LoadStructuredDataError Change-Id: I840afb6b0bbcb417664da54aa384718189d44809 Commit: 4886b89f9c35e670606fb89b9f9bd4931bdd43de https://github.com/Checkmk/checkmk/commit/4886b89f9c35e670606fb89b9f9bd4931… Author: Simon Jess <simon.jess(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M cmk/gui/views/inventory/_tree_renderer.py Log Message: ----------- Completely nuke _LoadTreeError Change-Id: I9ed6b53210edfc0487a153f1ace8879ea588ccfb Compare: https://github.com/Checkmk/checkmk/compare/f8501beea6d6...4886b89f9c35 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

[Checkmk/checkmk] 759b45: Remove old 'Update reports'

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 759b45123527d91f1e8293e9b9739a443e82b55b https://github.com/Checkmk/checkmk/commit/759b45123527d91f1e8293e9b9739a443… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: R cmk/update_config/plugins/actions/visuals_utils.py Log Message: ----------- Remove old 'Update reports' CMK-17209 Change-Id: I9fc0226cfebf9383ef78bebf7f8ebba999019a47 Commit: 50ee57fe51953f602fdf4e1544d39433e5932e56 https://github.com/Checkmk/checkmk/commit/50ee57fe51953f602fdf4e1544d39433e… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/integration/cmk/base/test_automations.py Log Message: ----------- integration test: avoid false positives on DNS lookup In test_automation_update_dns_cache() there is a negative test for a name resolution which is expected to fail. This change makes sure no false positive should be returned by the lookup and adds a more descriptive and helpful message in case this should happen anyway. Change-Id: I0163e8e81adba351a8a02a1e36282ed6e8cb40c0 Commit: f8501beea6d6aba9a7555c7e52ebd90c2fed0934 https://github.com/Checkmk/checkmk/commit/f8501beea6d6aba9a7555c7e52ebd90c2… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/integration/cmk/snmplib/test_snmp_modes.py M tests/integration/cmk/snmplib/test_snmp_table.py Log Message: ----------- integration test: avoid false positives on DNS lookup Two SNMP negative tests assert that unresolvable names are treated as such. This changes makes sure we use an .internal. FQDN that is not resolvable for the test. Change-Id: I19caa0f863c20230374d5615a0ab3b2d7eb494ad Compare: https://github.com/Checkmk/checkmk/compare/dd3c7786b214...f8501beea6d6 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

[Checkmk/checkmk] 4c58ee: omd: move sitename_must_be_valid

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 4c58eedea7668e8e411b8d2bb49ec0545a6c2991 https://github.com/Checkmk/checkmk/commit/4c58eedea7668e8e411b8d2bb49ec0545… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M omd/packages/omd/omdlib/main.py A omd/packages/omd/omdlib/site_name.py M tests/unit/omdlib/test_omdlib_main.py A tests/unit/omdlib/test_omdlib_site_name.py Log Message: ----------- omd: move sitename_must_be_valid `omd/packages/omd/omdlib/main.py` is way too big. Also replace `bail_out` by `sys.exit`. Change-Id: I5945566d0d04ece22d189e679cde581ddf6ee6a3 Commit: 42680fa65bbf4d63883182969f415d75d8b1fa53 https://github.com/Checkmk/checkmk/commit/42680fa65bbf4d63883182969f415d75d… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/unit/omdlib/test_omdlib_site_name.py Log Message: ----------- omd: simplify test Change-Id: Ib0ea7f204242264d1e8744de50a87b6ee620d25a Commit: 025891389eca09f0a2e436f55f8ea17204a40239 https://github.com/Checkmk/checkmk/commit/025891389eca09f0a2e436f55f8ea1720… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/unit/omdlib/test_omdlib_version.py M tests/unit/omdlib/test_site_context.py M tests/unit/omdlib/test_sites.py Log Message: ----------- omd: remove unused monkeypatching Change-Id: Ida3c7832e6d1b35f0afa248f0890e7bb732a8529 Commit: 4016f6e1a7f48e8307c0608f23cda12ec94e4b5d https://github.com/Checkmk/checkmk/commit/4016f6e1a7f48e8307c0608f23cda12ec… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/unit/omdlib/conftest.py M tests/unit/omdlib/test_omdlib_site_name.py M tests/unit/omdlib/test_omdlib_version.py M tests/unit/omdlib/test_site_context.py M tests/unit/omdlib/test_sites.py M tests/unit/omdlib/test_system_apache.py Log Message: ----------- omd: mark tests with fixtures Explicit is better than implicit. Also, makes moving around files easier. CMK-17417 Change-Id: I7172da5a78c348790cced3dce04860c41f12ed79 Commit: 2dece8290d5e76e91e4b66854822103ae46ba872 https://github.com/Checkmk/checkmk/commit/2dece8290d5e76e91e4b66854822103ae… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/system_apache.py M tests/unit/omdlib/test_system_apache.py Log Message: ----------- omd: explicitly pass apache_config This makes improves testability. CMK-17417 Change-Id: Icf9d19a45cb7c465f85cbb6cd334b95962ac3560 Commit: 0cfee23221479d256ce44d415148ccf441a1d1d6 https://github.com/Checkmk/checkmk/commit/0cfee23221479d256ce44d415148ccf44… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/sites.py M omd/packages/omd/omdlib/version.py M tests/unit/omdlib/test_omdlib_version.py M tests/unit/omdlib/test_sites.py Log Message: ----------- omd: explicitely pass /omd/versions This improves testability. CMK-17417 Change-Id: I220d5f027a9800aa79dc37400ea990a8cdc8bfba Commit: 8e948c1c4973d7b9cca9207ad4dce367f774ee4c https://github.com/Checkmk/checkmk/commit/8e948c1c4973d7b9cca9207ad4dce367f… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M omd/packages/omd/omdlib/contexts.py M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/site_name.py M omd/packages/omd/omdlib/utils.py M omd/packages/omd/omdlib/version.py M tests/unit/omdlib/test_omdlib_site_name.py M tests/unit/omdlib/test_omdlib_version.py M tests/unit/omdlib/test_site_context.py A tests/unit/omdlib/test_utils.py Log Message: ----------- omd: move exist out of SiteContext CMK-17417 Change-Id: I42ac83c57daf35cdf957faf5e1909dbada7d5403 Commit: 1b58ce03f5b53620efdf40c4fe67075852fbff83 https://github.com/Checkmk/checkmk/commit/1b58ce03f5b53620efdf40c4fe6707585… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M omd/packages/omd/omdlib/contexts.py Log Message: ----------- omd: move version out of SiteContext CMK-17417 Change-Id: Ic8a73b8f947377abb6c3b1ce46f0d42deb6541ff Commit: c7157d4c23d3e4710996e4d7289797cb5e530956 https://github.com/Checkmk/checkmk/commit/c7157d4c23d3e4710996e4d7289797cb5… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M omd/packages/omd/omdlib/contexts.py M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/sites.py M omd/packages/omd/omdlib/version.py M tests/unit/omdlib/test_omdlib_version.py M tests/unit/omdlib/test_site_context.py Log Message: ----------- omd: pass site_dir to version CMK-17417 Change-Id: I544b1409c5307d39e1a1d39c5b811edb268518e4 Commit: dd3c7786b2140f6330afaf995822ee3067ac2807 https://github.com/Checkmk/checkmk/commit/dd3c7786b2140f6330afaf995822ee306… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M cmk/update_config/plugins/lib/rulesets.py Log Message: ----------- Remove old BI config updates CMK-17209 Change-Id: Idb37a95b6b10fdc7df0bd63d3d367741e244f15e Compare: https://github.com/Checkmk/checkmk/compare/e48d36a43e3c...dd3c7786b214 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

[Checkmk/checkmk] e48d36: Fix default parameters of lnx_sysctl

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: e48d36a43e3c2ac79074109038e16a9531c6c7b9 https://github.com/Checkmk/checkmk/commit/e48d36a43e3c2ac79074109038e16a953… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M cmk/plugins/collection/agent_based/inventory_lnx_sysctl.py M tests/unit/cmk/plugins/collection/agent_based/test_inventory_lnx_sysctl.py Log Message: ----------- Fix default parameters of lnx_sysctl Change-Id: I39cd53277db4d683d6c9fffb751a52f3196830e6 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

[Checkmk/checkmk] bb90d7: gui-e2e: improve readability.

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: bb90d7403a7017212c028f3d4b3784d2dfb72fea https://github.com/Checkmk/checkmk/commit/bb90d7403a7017212c028f3d4b3784d2d… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/testlib/playwright/pom/page.py Log Message: ----------- gui-e2e: improve readability. `primary object` followed by `helper objects`. Change-Id: Ia61f6bb02b3d16a32d8f992aa3b59ebaf4a27681 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

[Checkmk/checkmk] bbc239: tests.gui_e2e: Create host rule test

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: bbc239bbe1cd2f43373daaebc08875c48dc37909 https://github.com/Checkmk/checkmk/commit/bbc239bbe1cd2f43373daaebc08875c48… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/gui_e2e/conftest.py A tests/gui_e2e/customize_rules.json A tests/gui_e2e/test_rules.py Log Message: ----------- tests.gui_e2e: Create host rule test Change-Id: I1d340c60d632c9acaf9e7ecbc17bd01703f153f8 Commit: d8c8f32aaba9d8e749e734d40ad6efcd9b1d101d https://github.com/Checkmk/checkmk/commit/d8c8f32aaba9d8e749e734d40ad6efcd9… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/gui_e2e/test_menu_user.py M tests/gui_e2e/test_rules.py M tests/gui_e2e/test_sidebar.py M tests/testlib/playwright/helpers.py M tests/testlib/playwright/pom/navigation.py Log Message: ----------- gui-e2e tests: Sample updates to PoM development style. + Use `playwright.sync_api` functionality, as much as possible. + Use GUI information on Checkmk site to interact with web elements Minimize usage of HTML ids, values or names. + Add docstrings + Changes to corresponding test-cases. CMK-16736 Change-Id: I84db29a92ea0f2ca7786a172be4fdbb9852fbee4 Commit: 448a0a1bb5510f6134d6205d80e55b06f1261433 https://github.com/Checkmk/checkmk/commit/448a0a1bb5510f6134d6205d80e55b06f… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/gui_e2e/test_rules.py Log Message: ----------- gui-e2e: extend test-design of `test_create_rules` by selecting an icon image. As seen within master commit with `change id` I722a44afd37e6fc39e4fcecb6926316e870b75d8 Change-Id: I6f99a71789ad9224152625b4accb10ea1e6dbe35 Commit: a7c230ae059aef8239c843c402c6d1cc15b2da01 https://github.com/Checkmk/checkmk/commit/a7c230ae059aef8239c843c402c6d1cc1… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M tests/gui_e2e/conftest.py M tests/gui_e2e/test_asvs.py M tests/gui_e2e/test_backup.py M tests/gui_e2e/test_change_password.py M tests/gui_e2e/test_hosts.py M tests/gui_e2e/test_login.py M tests/gui_e2e/test_menu_help.py M tests/gui_e2e/test_menu_user.py M tests/gui_e2e/test_mobile.py M tests/gui_e2e/test_rules.py M tests/gui_e2e/test_sidebar.py M tests/gui_e2e/test_signature_keys_for_signing_agents.py M tests/gui_e2e/test_totp.py M tests/gui_e2e/test_werks.py R tests/testlib/playwright/pom/dashboard.py A tests/testlib/playwright/pom/login.py R tests/testlib/playwright/pom/navigation.py A tests/testlib/playwright/pom/page.py M tests/testlib/playwright/pom/setup/hosts.py M tests/testlib/playwright/pom/werks.py Log Message: ----------- gui-e2e: update module names. Improve module names to increase readability. CMK-17299 Change-Id: I5e11e828f1a935f0f78f3d95d3384dd4e36c2218 Compare: https://github.com/Checkmk/checkmk/compare/af52e3704ed1...a7c230ae059a To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 months, 2 weeks

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits