Checkmk git commits July 2024

checkmk-commits@lists.checkmk.com

1 participants
737 discussions

[Checkmk/checkmk] 95beb8: REST API: Fix AttributeError when starting parent ...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 95beb8b4fa046eff3bb10ba2e8f164af99ac8aff https://github.com/Checkmk/checkmk/commit/95beb8b4fa046eff3bb10ba2e8f164af9… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/gui/openapi/endpoints/parent_scan/__init__.py M tests/unit/cmk/gui/openapi/test_openapi_parent_scan.py Log Message: ----------- REST API: Fix AttributeError when starting parent scan Calling the "Start the parent scan background job" endpoint resulted in the following exception: 'HostAddress' object has no attribute 'site_id' Sadly the issue was not found by mypy because params is not well typed. This is a systematical issue of the REST API we need to solve at some point to get rid of this kind of issue. Change-Id: I4409053ada83a1487f85a62ee77f7c1be225f045 Commit: 017d30eb2db452e5081b689cca0d2ec161a70a8d https://github.com/Checkmk/checkmk/commit/017d30eb2db452e5081b689cca0d2ec16… Author: Wontek Hong <wontek.hong(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: A .werks/17119.md Log Message: ----------- 17119 FIX parent_scan: resolve failing parent scan background job The REST API endpoint to initiate the parent scan background job returned a 204 status code, which theoretically is correct. However, the started background job failed immediately due to an invalid Python syntax concerning the involving requested hosts. This werk fixes the issue. Change-Id: I8faa6504368450e5b36c9be63ef5086b3b859e4a Compare: https://github.com/Checkmk/checkmk/compare/670da32a97be...017d30eb2db4 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

[Checkmk/checkmk] a2566f: fix SNMPHostConfig serialization

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: a2566fa9dab757bbf599a0c79796391183d31633 https://github.com/Checkmk/checkmk/commit/a2566fa9dab757bbf599a0c7979639118… Author: Sofia Colakovic <sofia.colakovic(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/snmplib/_typedefs.py Log Message: ----------- fix SNMPHostConfig serialization SUP-18652 SUP-19246 Change-Id: Ic8b53a7cfeb997d792d5781c2b113aece4cae975 Commit: 7a750f902bb6d90d26f1babde78c2676ec2e72bc https://github.com/Checkmk/checkmk/commit/7a750f902bb6d90d26f1babde78c2676e… Author: Wontek Hong <wontek.hong(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: A .werks/17119.md Log Message: ----------- 17119 FIX parent_scan: resolve failing parent scan background job The REST API endpoint to initiate the parent scan background job returned a 204 status code, which theoretically is correct. However, the started background job failed immediately due to an invalid Python syntax concerning the involving requested hosts. This werk fixes the issue. Change-Id: I8faa6504368450e5b36c9be63ef5086b3b859e4a Compare: https://github.com/Checkmk/checkmk/compare/f1463f2dd50b...7a750f902bb6 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

[Checkmk/checkmk] 5793ee: kube_pod_conditions: simplify disruptiontarget

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 5793eef4b272e4cfb6ce4570ab0d7fe01de92197 https://github.com/Checkmk/checkmk/commit/5793eef4b272e4cfb6ce4570ab0d7fe01… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/plugins/collection/agent_based/kube_pod_conditions.py Log Message: ----------- kube_pod_conditions: simplify disruptiontarget CMK-17818 Change-Id: I659400915ef0870854d9680f6e5abefc630c57e0 Commit: dac3d2222a4ea39e90a5e8a463341b83f100f10f https://github.com/Checkmk/checkmk/commit/dac3d2222a4ea39e90a5e8a463341b83f… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/plugins/collection/agent_based/kube_pod_conditions.py Log Message: ----------- kube_pod_conditions: factor function out Prepares Pod condition renaming. CMK-17818 Change-Id: Iafead28f4d1dcdf79fec42add017bff01db8d135 Commit: 9caa0f8024359810f62f7e826877a622ba68af76 https://github.com/Checkmk/checkmk/commit/9caa0f8024359810f62f7e826877a622b… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/plugins/collection/agent_based/kube_pod_conditions.py M tests/unit/cmk/plugins/collection/agent_based/test_kube_pod_conditions.py Log Message: ----------- kube_pod_conditions: pass name explicitely Prepares Pod condition renaming. We also update some outdated description of PodConditions. All conditions are now always set by the Kubelet (unless a feature gate is disabled). CMK-17818 Change-Id: Ia1fa7313454d63ed00c6b3cacae5b9f2a331c7ad Commit: 8d2831c70b082fd14aa3ef46e9e161d0559d60fd https://github.com/Checkmk/checkmk/commit/8d2831c70b082fd14aa3ef46e9e161d05… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/plugins/collection/agent_based/kube_pod_conditions.py M tests/unit/cmk/plugins/collection/agent_based/test_kube_pod_conditions.py Log Message: ----------- kube_pod_conditions: remove summary This functionality was broken since Werk 15588. `PodHasNetwork` is turned off by default in all Kubernetes clusters, and does not exist in k8s v1.28 any longer. This meant the check summary would depend on the feature gates enabled by the customer. There is no way to restore the old functionality, since we don't know whether a condition is missing due the k8s version or the feature gates. This change does not affect the monitoring capabilities, it merely removes a distinct way to display the same data. CMK-17818 Change-Id: I0da19d124ca8e65a2a46dd6fb4b4507d122c465f Commit: f1463f2dd50b4e63a43129ad9fbbbf98db86968b https://github.com/Checkmk/checkmk/commit/f1463f2dd50b4e63a43129ad9fbbbf98d… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: A .werks/16436.md M cmk/gui/plugins/wato/check_parameters/kube_pod_conditions.py M cmk/plugins/collection/agent_based/kube_pod_conditions.py M cmk/plugins/kube/schemata/section.py M tests/unit/cmk/gui/plugins/wato/check_parameters/test_kube_pod_conditions.py Log Message: ----------- 16436 kube_pod_conditions: Support PodReadyToStartContainers Condition CMK-17818 Change-Id: I4778796200dcefc983a4d196feda6838dd8eecac Compare: https://github.com/Checkmk/checkmk/compare/8f6bc4ee9d1d...f1463f2dd50b To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

[Checkmk/checkmk] 670da3: 16864 FIX snmp: Fix error in SNMP context serializ...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 670da32a97bee98972398e1f3b092ebe3228df58 https://github.com/Checkmk/checkmk/commit/670da32a97bee98972398e1f3b092ebe3… Author: Sofia Colakovic <sofia.colakovic(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: A .werks/16864.md Log Message: ----------- 16864 FIX snmp: Fix error in SNMP context serialization introduced with werk 16862 Werk 16862, which solved one SNMP context serialization bug, introduced another one. When using SNMP contexts, the change activation crashes in 2.3.0p8. After this Werk, SNMP contexts should work without errors. SUP-18652 SUP-19246 Change-Id: Ie2b824033f990bd9e902ea72da9b810d34c8d110 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

[Checkmk/checkmk] bb0411: 16533 FIX Event Console regex match in rule text

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: bb0411f6511eab558da24ab4566988be02677ca4 https://github.com/Checkmk/checkmk/commit/bb0411f6511eab558da24ab4566988be0… Author: Konstantin Baikov <konstantin.baikov(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: A .werks/16533 M cmk/ec/main.py Log Message: ----------- 16533 FIX Event Console regex match in rule text SUP-19224 A typo in the returned var name in the method compile_matching_value caused a valid regex to not match, because it was sent as a string Change-Id: I80e76af1da275b0fdea0fc115c590b51f145beaf To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

[Checkmk/checkmk] 8f6bc4: 16751 Transfer Arista temperature sensors to our c...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 8f6bc4ee9d1debcc86cd0d6869f92e0a2cfa79c2 https://github.com/Checkmk/checkmk/commit/8f6bc4ee9d1debcc86cd0d6869f92e0a2… Author: Simon Jess <simon.jess(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: A .werks/16751.md R cmk/base/legacy_checks/arista_temp.py M cmk/plugins/collection/agent_based/entity_sensors.py R cmk/plugins/collection/checkman/arista_temp M cmk/plugins/lib/entity_sensors.py R tests/unit/checks/generictests/datasets/arista_temp.py R tests/unit/checks/generictests/datasets/switch-arista.py M tests/unit/checks/test_generic_legacy_conversion.py M tests/unit/cmk/plugins/collection/agent_based/test_entity_sensors.py M tests/unit/cmk/plugins/lib/test_entity_sensors_utils.py Log Message: ----------- 16751 Transfer Arista temperature sensors to our common entity sensor monitoring Change-Id: I16e9e8b937158c0c34182c265d97c69de57938dc To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

[Checkmk/checkmk] 1f2959: 17076 Fix float valuespec ignoring its self._validate

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 1f29596328173f4f212e889cd9c2a560848eb081 https://github.com/Checkmk/checkmk/commit/1f29596328173f4f212e889cd9c2a5608… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: A .werks/17076.md M cmk/gui/utils/rule_specs/legacy_converter.py M cmk/gui/valuespec.py M tests/unit/cmk/gui/utils/rulespecs/test_legacy_converter.py Log Message: ----------- 17076 Fix float valuespec ignoring its self._validate The Percentage form spec relied on the validate_value function of the float valuespec to report its validators.NumberInRange. However, the Float validate_value method was overwritten instead of its _validate_value method. Resulting in all valuespecs only checking its bounds and not its custom validation functions. This also fixes the assumption that the Percentage form spec continues to use the legacy Percentage default bounds. Change-Id: I476ec419c80784dc4cad85b5acd7b19cd60de856 Commit: f6f96b931b1849f3e62f2f6777e08d8052e0d386 https://github.com/Checkmk/checkmk/commit/f6f96b931b1849f3e62f2f6777e08d805… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: A .werks/17077.md M cmk/base/plugins/agent_based/df_netapp.py M cmk/gui/plugins/wato/check_parameters/filesystem_utils.py M cmk/gui/plugins/wato/check_parameters/netapp_volumes.py Log Message: ----------- 17077 Allow filesystem service rule levels to go above 100% We have one monster "filesystem" rule which is being used all over the place. However, there have been quite a few support requests for single checks coming in asking us to remove the 101% limit for the used space level as they are monitoring virtualized file systems. However, making just some checks use a specialized rule set of is a lot of work and in the end it's easier to lift the restriction for the whole rule set, even if some cases values above 100% still might not be valid. Motivated by SUP-18744 Change-Id: I107a0c885ce03b2cfab7bcbfd2278896a040f3a4 Commit: e382884c29c3a955e77b537ef995cf5b7a64fab7 https://github.com/Checkmk/checkmk/commit/e382884c29c3a955e77b537ef995cf5b7… Author: Sofia Colakovic <sofia.colakovic(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/snmplib/_typedefs.py Log Message: ----------- fix SNMPHostConfig serialization SUP-18652 SUP-19246 Change-Id: Ic8b53a7cfeb997d792d5781c2b113aece4cae975 Compare: https://github.com/Checkmk/checkmk/compare/8a448b5caba8...e382884c29c3 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

[Checkmk/checkmk] 498f64: replace partial by type safe wrapper

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 498f64a30ed6369745d3bd5f4ce686e1ea4fa11f https://github.com/Checkmk/checkmk/commit/498f64a30ed6369745d3bd5f4ce686e1e… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/base/checkers.py Log Message: ----------- replace partial by type safe wrapper We also need this wrapper to place a very regrettable hack for the logwatch plugin. Change-Id: I6048bf033ab5500c5ccab0021cbd7ef85fd981a3 Commit: 5ed2ac9f3c8cec58deead68744e2b7f3e396d6b1 https://github.com/Checkmk/checkmk/commit/5ed2ac9f3c8cec58deead68744e2b7f3e… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/base/api/agent_based/register/_discover.py M cmk/base/checkers.py M cmk/gui/mkeventd/_rulespecs.py M cmk/plugins/logwatch/agent_based/commons.py M cmk/plugins/logwatch/agent_based/logwatch.py M cmk/plugins/logwatch/agent_based/logwatch_ec.py M tests/unit/cmk/plugins/logwatch/agent_based/test_logwatch.py M tests/unit/cmk/plugins/logwatch/agent_based/test_logwatch_ec.py Log Message: ----------- logwatch: add host name hack This adds a hack (two, actually) to pass the host name to the logwatch plugin without requiring a global variable. While this is still very regrettable, it allows us to nuke `plugin_contexts`. Change-Id: I6ec3d8c73ab70f5c3aefe0d4ac8286eec8ee5586 Commit: d28053742c4342b3968d86ed8edc9974e986d17a https://github.com/Checkmk/checkmk/commit/d28053742c4342b3968d86ed8edc9974e… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/checkers.py M cmk/base/modes/check_mk.py R cmk/base/plugin_contexts.py M tests/unit/checks/checktestlib.py M tests/unit/checks/generictests/run.py M tests/unit/cmk/base/test_discovery.py M tests/unit/cmk/plugins/collection/agent_based/test_check_plugin_properties.py M tests/unit/cmk/plugins/logwatch/agent_based/test_logwatch_ec.py Log Message: ----------- nuke plugin_contexts Change-Id: I88cc1ad44ed93520e72754016319a6fddbbbd31e Commit: 9f7691c982029566e0750088b03b027e36ce08fc https://github.com/Checkmk/checkmk/commit/9f7691c982029566e0750088b03b027e3… Author: Lukas Lengler <lukas.lengler(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M cmk/automations/results.py M cmk/base/automations/check_mk.py M cmk/base/modes/check_mk.py M cmk/gui/watolib/services.py M tests/integration/cmk/base/test_automations.py M tests/unit/cmk/base/test_unit_automations.py Log Message: ----------- Get rid of deprecated try-inventory automation Should've already been done before 2.3 release. CMK-17742 Change-Id: Iba28fcdf656b66700a9049c3ba12a17671664476 Compare: https://github.com/Checkmk/checkmk/compare/241c606385d4...9f7691c98202 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

[Checkmk/checkmk] a2f1a1: Fix Werk version

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: a2f1a1d8820bf5a8e279b68d68a20a6fd1d7dba8 https://github.com/Checkmk/checkmk/commit/a2f1a1d8820bf5a8e279b68d68a20a6fd… Author: Sofia Colakovic <sofia.colakovic(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M .werks/16863 Log Message: ----------- Fix Werk version Change-Id: Id922a5d35313a07d705f3678eed6718097257bd5 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

[Checkmk/checkmk] 8a448b: 17016 FIX notification_rules: typo in field

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 8a448b5caba83d780f4ce4fc9c3d9bf6275f0460 https://github.com/Checkmk/checkmk/commit/8a448b5caba83d780f4ce4fc9c3d9bf62… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: A .werks/17016.md M cmk/gui/openapi/endpoints/notification_rules/request_example.py M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/openapi/endpoints/notification_rules/response_schemas.py M cmk/gui/rest_api_types/notifications_rule_types.py M cmk/gui/rest_api_types/notifications_types.py M tests/unit/cmk/gui/openapi/test_notification_rules.py Log Message: ----------- 17016 FIX notification_rules: typo in field sort_order_for_bulk_notifications The REST-API endpoints previously had a typo in the field 'sort_order_for_bulk_notifications'. The second t was missing. This werk now corrects this. Change-Id: I0bf10255dd4df2440072bf58da84e0bbbd4d2d7c To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months

← Newer
1
...
66
67
68
69
70
71
72
73
74
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2024