Checkmk git commits May 2024

checkmk-commits@lists.checkmk.com

1 participants
678 discussions

[Checkmk/checkmk] f30116: 16638 FIX Re-enable bulk service discovery in empt...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: f30116dd9ef0dcae76e3c7a6e171af3f3e88e8b3 https://github.com/Checkmk/checkmk/commit/f30116dd9ef0dcae76e3c7a6e171af3f3… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2024-05-31 (Fri, 31 May 2024) Changed paths: A .werks/16638.md M cmk/gui/wato/pages/folders.py Log Message: ----------- 16638 FIX Re-enable bulk service discovery in empty folders The page menu entry "Hosts" > "In this folder" > "Run bulk service discovery" on folder setup pages was unclickable if there was no host given in the current folder, even if subfolders held hosts. This bug is fixed to the former behavior, enabling the bulk service discovery whenever the current folder or any of its subfolders holds at least one host. CMK-17223 SUP-18889 Change-Id: I6f48c167e5a641104267e6493df70409c9c726e7 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks

[Checkmk/checkmk] dd764c: Make windows integration tests independent of top ...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: dd764c16291e7e8f02196107b5a0564c1172290f https://github.com/Checkmk/checkmk/commit/dd764c16291e7e8f02196107b5a0564c1… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-05-31 (Fri, 31 May 2024) Changed paths: A agents/modules/windows/tests/pyproject.toml Log Message: ----------- Make windows integration tests independent of top level pytest config This is a package specific test job which is not executed in our Checkmk python version nor regular virtual environment. Therefore we need to separate both to prevent side effects. As a follow-up this should be cleaned up. The test job should be using some git controlled venv at least which it currently does not seem to do according to the winagt-build-modules job output: ``` (...) Downloading python-3.12.1_9585aacecd8_30.cab from cache... The file exists in cache. Moving cached file to artifact 1 file(s) moved. [+] Downloaded successfully Builds are successfull make[1]: Entering directory 'd:/workdir/workspace/checkmk/master/cv/winagt-build-modules/checkout/agents/modules/windows/tests' Integration tests starting Traceback (most recent call last): File "C:\Python310\lib\site-packages\_pytest\config\__init__.py", line 746, in import_plugin __import__(importspec) ModuleNotFoundError: No module named ' no:faker' (...) ``` The pyproject.toml should probably be placed in a higher level and component specific level directory. Change-Id: I269870c626d9b5e969cafefbf46bdd4e6a7fec40 Commit: cb4b78c520bc1794b5859e4ba62adf259d66b390 https://github.com/Checkmk/checkmk/commit/cb4b78c520bc1794b5859e4ba62adf259… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-05-31 (Fri, 31 May 2024) Changed paths: M pyproject.toml Log Message: ----------- Reland "Disable a few plugins which slow down the pytest startup even when not used"" Change-Id: I45fafc96e5d34d88e4633267e8ec5056bcc17f79 Compare: https://github.com/Checkmk/checkmk/compare/379cad41a66e...cb4b78c520bc To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks

[Checkmk/checkmk] 8627b6: 16785 FIX notification rules: allow for the global...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 8627b6939fbbf16277c7bf96551c14e52c132565 https://github.com/Checkmk/checkmk/commit/8627b6939fbbf16277c7bf96551c14e52… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: A .werks/16785.md M cmk/gui/fields/__init__.py M cmk/gui/fields/custom_fields.py M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/openapi/endpoints/notification_rules/response_schemas.py M cmk/gui/rest_api_types/notifications_rule_types.py M cmk/utils/notify_types.py M tests/unit/cmk/gui/openapi/test_notification_rules.py Log Message: ----------- 16785 FIX notification rules: allow for the global http proxy configuration for plugins When configuring a notification rule with one of the following plugins * Cisco Webex Teams * iLert * MS Teams * PagerDuty * Splunk On-Call * SIGNL4 Alerting the option to select a globally configured http proxy was not possible via the REST-API. This werk addresses this issue and you can now select a globally configured http proxy for any of the mentioned plugins. Change-Id: Ia531e271275c621c96106494f622268b48ac32fc Commit: 972bc6230c0d71cdcbb43b52a4fa003d36edb601 https://github.com/Checkmk/checkmk/commit/972bc6230c0d71cdcbb43b52a4fa003d3… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M cmk/gui/rest_api_types/notifications_types.py M cmk/gui/watolib/notifications.py M cmk/gui/watolib/sample_config.py M cmk/utils/notify_types.py Log Message: ----------- notification rules: add plugin types to EventRule typeddict Change-Id: I8f3b40f9570085279ef6f97100b320ab3b856baf Compare: https://github.com/Checkmk/checkmk/compare/8197be0bc385...972bc6230c0d To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks

[Checkmk/checkmk] 6191f3: Split parametrized test into more descriptive indi...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 6191f3353900acdbc87a8507c77a86b8a9df172d https://github.com/Checkmk/checkmk/commit/6191f3353900acdbc87a8507c77a86b8a… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M tests/unit/cmk/gui/test_sites.py Log Message: ----------- Split parametrized test into more descriptive individual tests We should not have single-line tests that have a huge amount of parameters as this is really hard to read and maintain. Additionally we need to be careful when parametrizing tests with dynamic data as this may unintentionally lead to dynamic test names as well. Change-Id: Idd365f8bfdcdbe4fea35f98fb87096c16e89cd16 Commit: 379cad41a66e4754150c5f3136a97cbe26a078f7 https://github.com/Checkmk/checkmk/commit/379cad41a66e4754150c5f3136a97cbe2… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M tests/unit/cmk/base/test_diagnostics.py Log Message: ----------- Set static test name for parametrized test We should be careful when using dynamic data in a parametrization as it is rarely desired to generate dynamic test case names. Change-Id: Ic2ce224a59bbbb3ffeb5e6f5c92c526dbb2976ee Compare: https://github.com/Checkmk/checkmk/compare/c448a3d0769f...379cad41a66e To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks

[Checkmk/checkmk] c448a3: buildscripts: install netcat into containers

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: c448a3d0769fc8d1622e11f01214cc6bb57066fe https://github.com/Checkmk/checkmk/commit/c448a3d0769fc8d1622e11f01214cc6bb… Author: Niko Wenselowski <niko.wenselowski(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M buildscripts/infrastructure/build-nodes/debian-10/Dockerfile M buildscripts/infrastructure/build-nodes/debian-11/Dockerfile M buildscripts/infrastructure/build-nodes/sles-12sp5/Dockerfile M buildscripts/infrastructure/build-nodes/sles-15sp3/Dockerfile M buildscripts/infrastructure/build-nodes/sles-15sp4/Dockerfile Log Message: ----------- buildscripts: install netcat into containers This is used in integration tests. References CMK-17065 Change-Id: I87e219bedbf41e58838a1fa5728b07d019159f29 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks

[Checkmk/checkmk] 7365d4: tests/update/conftest.py: Small refactoring

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 7365d4f0db941c00680669586de50676ddf36557 https://github.com/Checkmk/checkmk/commit/7365d4f0db941c00680669586de50676d… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M tests/update/conftest.py Log Message: ----------- tests/update/conftest.py: Small refactoring Change-Id: I6a3d3b4ce6fa92c79264da007fbdafc55165a541 Commit: 2ddc37a93f237c776d8f7419c34e2d6be1362b70 https://github.com/Checkmk/checkmk/commit/2ddc37a93f237c776d8f7419c34e2d6be… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M tests/update/test_update_from_backup.py Log Message: ----------- test_update_from_backup: Use static agent dumps in test site CMK-17565 Change-Id: I7c529e0aa0126cc150b7af4e559b93ce74db0e0a Commit: 0b41fcf976d196f77a89e8c94dd409ecee013936 https://github.com/Checkmk/checkmk/commit/0b41fcf976d196f77a89e8c94dd409ece… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M tests/update/test_update_rules.py Log Message: ----------- test_update_rules: Refactoring Since there is no agent data involved in this test, we here remove the code related to it. Change-Id: I2630d59f38f55b2335ed2c3546448aadd45d2eb2 Commit: 7b3f7585ad48a51b82f1095a2a401ebee0f04f04 https://github.com/Checkmk/checkmk/commit/7b3f7585ad48a51b82f1095a2a401ebee… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M tests/update/conftest.py M tests/update/test_update_rules.py Log Message: ----------- test_update_rules: Perform rules' injection via helper function Change-Id: I7c12bff46fdd747f80d72ddf3e5768ce2267c7b6 Commit: c22d42c2236ea4770bb516db99710d3823733cff https://github.com/Checkmk/checkmk/commit/c22d42c2236ea4770bb516db99710d382… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M tests/update/conftest.py R tests/update/test_update_rules.py Log Message: ----------- test_update: Include rules' injection in the test module The 'test_update_rules.py' module is here removed. This avoids code repetition and reduces overall duration of the test-job. Change-Id: I86b0116a6b3fdbc8712a7c7e66bbda2f5ece8382 Commit: 8e798df56d610b7d043d836ed66a3469de9ec647 https://github.com/Checkmk/checkmk/commit/8e798df56d610b7d043d836ed66a3469d… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M tests/update/conftest.py Log Message: ----------- test_update: Add custom pytest flag to disable rules' injection Change-Id: I715f1c467ac4a4233d8c8b2124c3ca975d9f857d Compare: https://github.com/Checkmk/checkmk/compare/81862ae7c40d...8e798df56d61 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks

[Checkmk/checkmk] 81862a: Reserved 10 Werk IDS

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 81862ae7c40d0cbbc2944c40b7f2a9b078120cd4 https://github.com/Checkmk/checkmk/commit/81862ae7c40d0cbbc2944c40b7f2a9b07… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M .werks/first_free Log Message: ----------- Reserved 10 Werk IDS Change-Id: Id219c0c922c39a0552b7b79e1bcf196c835ef971 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks, 1 day

[Checkmk/checkmk] e42b92: notification rules: move incident and case state t...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: e42b92c12fe30129ba028e2471de79f8ebd1c9fa https://github.com/Checkmk/checkmk/commit/e42b92c12fe30129ba028e2471de79f8e… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/rest_api_types/notifications_rule_types.py M cmk/utils/notify_types.py M tests/unit/cmk/gui/openapi/test_notification_rules.py Log Message: ----------- notification rules: move incident and case state types to notify types Change-Id: Ifed816b7f0f6eb7a0c592ea100f183703d2aea0e Commit: 4ea4792b956ae736a0cddca0c98dd7880a3f024a https://github.com/Checkmk/checkmk/commit/4ea4792b956ae736a0cddca0c98dd7880… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py Log Message: ----------- notification rules: remove duplicate field type Change-Id: Icf90da02e9c651a3562322cf5bd53e9cfca73983 Commit: e264f4ddaebe2a2c12be1eb2c2673efd6a86803c https://github.com/Checkmk/checkmk/commit/e264f4ddaebe2a2c12be1eb2c2673efd6… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M cmk/utils/notify_types.py Log Message: ----------- notification rules: add typedict models for the plugins This commit only adds the typed dicts for the builtin plugins. However, the EventRule typeddict is still not aware of these plugin types. Will do this in a separate commit. Change-Id: I825ac1260fcac38b5851ddfa5174320d5e5c1b9f Commit: ba71c95bf63e15423d070cbe91732140c34678db https://github.com/Checkmk/checkmk/commit/ba71c95bf63e15423d070cbe91732140c… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M cmk/base/notify.py M cmk/gui/rest_api_types/notifications_rule_types.py M cmk/gui/wato/pages/notifications.py M cmk/utils/notify_types.py Log Message: ----------- notification rules: improve typing for bulk parameters Change-Id: If1b3cc12431ed9af1483a61e33d6e70b670ed9cf Commit: d3af470827d35be3aa08dc50837910725cace1c6 https://github.com/Checkmk/checkmk/commit/d3af470827d35be3aa08dc50837910725… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M cmk/gui/rest_api_types/notifications_rule_types.py M cmk/utils/notify_types.py Log Message: ----------- notification rules: improve typing for url prefix Change-Id: Ic31385a0845e686d8ab532c85c1493aa1e327e85 Commit: 8197be0bc3858cddb417eedeb074a56b3d321bb6 https://github.com/Checkmk/checkmk/commit/8197be0bc3858cddb417eedeb074a56b3… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M cmk/gui/rest_api_types/notifications_rule_types.py M cmk/utils/notify_types.py Log Message: ----------- notification rules: improve rest api types Change-Id: I16f09857db05da294c2a5f74380cbd50ab003a6d Compare: https://github.com/Checkmk/checkmk/compare/068b17931614...8197be0bc385 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks, 1 day

[Checkmk/checkmk] 3f791d: 16785 FIX notification rules: allow for the global...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 3f791d5f547d429b6e5313973a3f1c77d2e425bb https://github.com/Checkmk/checkmk/commit/3f791d5f547d429b6e5313973a3f1c77d… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: A .werks/16785.md M cmk/gui/fields/__init__.py M cmk/gui/fields/custom_fields.py M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/openapi/endpoints/notification_rules/response_schemas.py M cmk/gui/rest_api_types/notifications_rule_types.py M cmk/utils/notify_types.py M tests/unit/cmk/gui/openapi/test_notification_rules.py Log Message: ----------- 16785 FIX notification rules: allow for the global http proxy configuration for plugins When configuring a notification rule with one of the following plugins * Cisco Webex Teams * iLert * MS Teams * PagerDuty * Splunk On-Call * SIGNL4 Alerting the option to select a globally configured http proxy was not possible via the REST-API. This werk addresses this issue and you can now select a globally configured http proxy for any of the mentioned plugins. Change-Id: Ia531e271275c621c96106494f622268b48ac32fc Commit: bff0bbd25e6863195d0938a992fe20c52562db96 https://github.com/Checkmk/checkmk/commit/bff0bbd25e6863195d0938a992fe20c52… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M cmk/gui/rest_api_types/notifications_types.py M cmk/gui/watolib/notifications.py M cmk/gui/watolib/sample_config.py M cmk/utils/notify_types.py Log Message: ----------- notification rules: add plugin types to EventRule typeddict Change-Id: I8f3b40f9570085279ef6f97100b320ab3b856baf Compare: https://github.com/Checkmk/checkmk/compare/e5d9a6e2974d...bff0bbd25e68 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks, 1 day

[Checkmk/checkmk] b89f01: install-gnu-toolchain: fix syntax error

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: b89f0181dda382198e9364bc25498a0d5efe43d1 https://github.com/Checkmk/checkmk/commit/b89f0181dda382198e9364bc25498a0d5… Author: Frans Fürst <frans.fuerst(a)checkmk.com> Date: 2024-05-30 (Thu, 30 May 2024) Changed paths: M buildscripts/infrastructure/build-nodes/scripts/install-gnu-toolchain.sh Log Message: ----------- install-gnu-toolchain: fix syntax error Change-Id: Ia3ae48e96aa942cb90a6d382fd213d8e53a5554c To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

4 weeks, 1 day

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits May 2024