Checkmk git commits February 2024

checkmk-commits@lists.checkmk.com

1 participants
1013 discussions

[Checkmk/checkmk] a471ac: 16504 nfsiostat: resolve error when displaying graphs

by Checkmk git commit messages

Branch: refs/heads/2.1.0 Home: https://github.com/Checkmk/checkmk Commit: a471acc8cc13784159e0fb8f038006ddc85124f9 https://github.com/Checkmk/checkmk/commit/a471acc8cc13784159e0fb8f038006ddc… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A .werks/16504 R checks/nfsiostat A cmk/base/plugins/agent_based/nfsiostat.py M cmk/gui/plugins/metrics/network.py M cmk/gui/plugins/metrics/translation.py M cmk/gui/plugins/wato/check_parameters/nfsiostats.py R tests/unit/checks/generictests/datasets/nfsiostat.py R tests/unit/checks/generictests/datasets/nfsiostat2.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/base/plugins/agent_based/test_nfsiostat.py Log Message: ----------- 16504 nfsiostat: resolve error when displaying graphs This fixes SUP-17463 Just as we report bytes instead of KiB for example in the metrics we reverted the reported values to seconds and let the metric/graph handle the scaling. Change-Id: Ibe4e80593aef2c288e2a31e6bc2fb3d3e8ba40dc To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

[Checkmk/checkmk] be0873: netapp_ontap_fcp: add tests

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: be0873ec655bfe94b8d3b3e26676cd8aa680ae2d https://github.com/Checkmk/checkmk/commit/be0873ec655bfe94b8d3b3e26676cd8aa… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M cmk/plugins/netapp/agent_based/netapp_ontap_fcp.py A tests/unit/cmk/plugins/netapp/test_netapp_ontap_fcp.py Log Message: ----------- netapp_ontap_fcp: add tests Change-Id: Ic9a732c1187918d6f651711c6af1efa21869e67d Commit: 866ff67422c5ecc286c5229f5405e389fbc7087b https://github.com/Checkmk/checkmk/commit/866ff67422c5ecc286c5229f5405e389f… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M tests/unit/cmk/plugins/lib/test_netapp_api.py A tests/unit/cmk/plugins/netapp/test_netapp_ontap_luns.py Log Message: ----------- netapp_ontap_luns: add tests Change-Id: Iaa486a916bf4d9ce3030d6f33d11319f160de1ef Commit: dbb74d6c74717986153efc4e110b15fdcac5aeb7 https://github.com/Checkmk/checkmk/commit/dbb74d6c74717986153efc4e110b15fdc… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A tests/unit/cmk/plugins/netapp/test_netapp_ontap_ports.py Log Message: ----------- netapp_ontap_ports: add tests Change-Id: I66eeabcba10280d0c61c87c6261153255cfde38f Commit: 5fde21dcff58dcf48fd60b7abe1c6ee102d1a515 https://github.com/Checkmk/checkmk/commit/5fde21dcff58dcf48fd60b7abe1c6ee10… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M tests/unit/cmk/plugins/lib/test_netapp_api.py A tests/unit/cmk/plugins/netapp/test_netapp_ontap_psu.py Log Message: ----------- netapp_ontap_psu: add tests Change-Id: I770a2befb78ff418d5d53a14de5752748c0fdaff Commit: c12537cf2ed37005c4c7552a41663bd5d6c96f13 https://github.com/Checkmk/checkmk/commit/c12537cf2ed37005c4c7552a41663bd5d… Author: Ronny Bruska <ronny.bruska(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M cmk/gui/wato/pages/services.py M web/htdocs/themes/facelift/scss/_wato.scss Log Message: ----------- Remove manpage links for labels on service discovery page CMK-16719 Change-Id: I2e3048db06236794faf6a06fbe9fa55e0ea92462 Compare: https://github.com/Checkmk/checkmk/compare/0a602f36d6d0...c12537cf2ed3 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

[Checkmk/checkmk] 775224: Update lockfile

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 775224df821008c29c28329fcf2ef2b966954b39 https://github.com/Checkmk/checkmk/commit/775224df821008c29c28329fcf2ef2b96… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: M Pipfile.lock Log Message: ----------- Update lockfile Change-Id: Iaba75fe9eafb9a37d69de11de604ca5d16608740 Commit: 085a685d33f052ed93911ebf23207c5c05f64a0d https://github.com/Checkmk/checkmk/commit/085a685d33f052ed93911ebf23207c5c0… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A .werks/16493.md M Pipfile M Pipfile.lock M cmk/plugins/netapp/models.py Log Message: ----------- 16493 FIX netapp_ontap_snapvault: improves lagtime calculation With this new type of calculation, since we don't have a reference for when this lagtime started or ended, we always consider a month to be made up of 30 days. Change-Id: Ida3c370a17fdd7450a1d528a9ff20b68ba9781b6 Compare: https://github.com/Checkmk/checkmk/compare/80f8e1b9681c...085a685d33f0 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

[Checkmk/checkmk] 8db0e0: Update lockfile

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: 8db0e05027f832986c63afbb71a3f5007e3cd3bc https://github.com/Checkmk/checkmk/commit/8db0e05027f832986c63afbb71a3f5007… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M Pipfile.lock Log Message: ----------- Update lockfile Change-Id: Iaba75fe9eafb9a37d69de11de604ca5d16608740 Commit: e579509eb6e3c3c541998974f8c5b566d12a9571 https://github.com/Checkmk/checkmk/commit/e579509eb6e3c3c541998974f8c5b566d… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: A .werks/16493 M Pipfile M Pipfile.lock M cmk/base/plugins/agent_based/utils/netapp_ontap_models.py Log Message: ----------- 16493 FIX netapp_ontap_snapvault: improves lagtime calculation With this new type of calculation, since we don't have a reference for when this lagtime started or ended, we always consider a month to be made up of 30 days. Change-Id: Ida3c370a17fdd7450a1d528a9ff20b68ba9781b6 Compare: https://github.com/Checkmk/checkmk/compare/38a8fc08cc46...e579509eb6e3 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

[Checkmk/checkmk] f50269: 16523 FIX event_console: site_id only required whe...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: f502696105f08696bde87646d4a4370c2697e7f3 https://github.com/Checkmk/checkmk/commit/f502696105f08696bde87646d4a4370c2… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A .werks/16523.md M cmk/gui/livestatus_utils/commands/event_console.py M cmk/gui/mkeventd/_openapi/__init__.py M cmk/gui/mkeventd/_openapi/request_schemas.py M tests/testlib/rest_api_client.py M tests/unit/cmk/gui/openapi/test_event_console.py Log Message: ----------- 16523 FIX event_console: site_id only required when deleting ec events by_id When deleting an ec event via the REST-API, only the 'by_id' option leaves the event selection ambiguous, while the options 'params' or 'query' already have the ability to pinpoint the event requested. Therefore, the site_id should is not required in these cases. CMK-16214 Change-Id: I955e4911a3209f22c2443dad173f3a966eeb11f4 Commit: 80f8e1b9681cbcb82893db691f1fcdd44439607c https://github.com/Checkmk/checkmk/commit/80f8e1b9681cbcb82893db691f1fcdd44… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-02-21 (Wed, 21 Feb 2024) Changed paths: A .werks/16522.md M cmk/gui/livestatus_utils/commands/comment.py M cmk/gui/openapi/endpoints/comment/__init__.py M cmk/gui/openapi/endpoints/comment/request_schemas.py M tests/testlib/rest_api_client.py M tests/unit/cmk/gui/openapi/test_service_and_host_comments.py Log Message: ----------- 16522 FIX comment: site_id only required when deleting comments by id When deleting a comment via the REST-API, only the 'by_id' option leaves the comment selection ambiguous, while the options 'params' or 'query' already have the ability to pinpoint the comment requested. Therefore, the site_id should is not required in these cases. CMK-14591 Change-Id: I1046a352d4ce0bfbfeb6cbe74df5458ac14a1135 Compare: https://github.com/Checkmk/checkmk/compare/adc88cca4ad0...80f8e1b9681c To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

[Checkmk/checkmk] 39c0a2: nodevis: context menu overhaul. fixed grab/grabbin...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 39c0a2add5c3e6ed8996992e7459f4afd91beecf https://github.com/Checkmk/checkmk/commit/39c0a2add5c3e6ed8996992e7459f4afd… Author: Andreas Boesl <andreas.boesl(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M web/htdocs/js/modules/nodevis/layers.ts M web/htdocs/js/modules/nodevis/layout.ts M web/htdocs/js/modules/nodevis/texts.ts M web/htdocs/js/modules/nodevis/topology.ts M web/htdocs/js/modules/nodevis/type_defs.ts M web/htdocs/js/modules/nodevis/viewport.ts M web/htdocs/themes/facelift/scss/_node_visualization.scss Log Message: ----------- nodevis: context menu overhaul. fixed grab/grabbing cursor. fixed incorrect compare history icon Change-Id: Iac616575bf4ed31496a14a92edb83c9b669f3f4a Commit: adc88cca4ad03fb8a9a56b59585e66b5550f31b9 https://github.com/Checkmk/checkmk/commit/adc88cca4ad03fb8a9a56b59585e66b55… Author: Andreas Boesl <andreas.boesl(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: A web/htdocs/themes/facelift/images/icon_tick.svg Log Message: ----------- added new icon: icon_tick.svg Change-Id: If0f127a0ecbecc80fed5376a8d393788e1bd876c Compare: https://github.com/Checkmk/checkmk/compare/23257b92e572...adc88cca4ad0 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

[Checkmk/checkmk] 862476: nodevis: context menu overhaul. fixed grab/grabbin...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 862476697aeff8df1b419bf3410a7b1901f44413 https://github.com/Checkmk/checkmk/commit/862476697aeff8df1b419bf3410a7b190… Author: Andreas Boesl <andreas.boesl(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M web/htdocs/js/modules/nodevis/layers.ts M web/htdocs/js/modules/nodevis/layout.ts M web/htdocs/js/modules/nodevis/texts.ts M web/htdocs/js/modules/nodevis/topology.ts M web/htdocs/js/modules/nodevis/type_defs.ts M web/htdocs/js/modules/nodevis/viewport.ts M web/htdocs/themes/facelift/scss/_node_visualization.scss Log Message: ----------- nodevis: context menu overhaul. fixed grab/grabbing cursor. fixed incorrect compare history icon Change-Id: Iac616575bf4ed31496a14a92edb83c9b669f3f4a Commit: 0a602f36d6d05f8090125ab8ea232b518ed6fd0e https://github.com/Checkmk/checkmk/commit/0a602f36d6d05f8090125ab8ea232b518… Author: Andreas Boesl <andreas.boesl(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: A web/htdocs/themes/facelift/images/icon_tick.svg Log Message: ----------- added new icon: icon_tick.svg Change-Id: If0f127a0ecbecc80fed5376a8d393788e1bd876c Compare: https://github.com/Checkmk/checkmk/compare/4edd693ccfe8...0a602f36d6d0 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

[Checkmk/checkmk] 23257b: Execute spec endpoint tests with dummy spec

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 23257b92e572def10b414aff6679096a290acaca https://github.com/Checkmk/checkmk/commit/23257b92e572def10b414aff6679096a2… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M cmk/gui/openapi/spec_generator.py M tests/unit/cmk/gui/openapi/test_spec_files.py Log Message: ----------- Execute spec endpoint tests with dummy spec Previously these tests were meant to ensure the endpoints work and whether the API spec can be computed. This lead to long execution times. Since the spec is now generated separately, we can also execute the tests with a dummy spec and can remove the slow marker. For the computation of the spec in the site environment we have an integration test in place. Of course, this is not ideal for the development workflow. So we need to find a way to test the spec computation in a subsequent step. Cleanup `validate_spec` related warnings along the way. CMK-15981 Change-Id: Id8a642fa4b5aaa55beff9a87df76a708e7b14308 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

[Checkmk/checkmk] ec1acf: check plugin: add mac support to winperf

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: ec1acf7702ce7f937f29a1ee5c19840725c30f4a https://github.com/Checkmk/checkmk/commit/ec1acf7702ce7f937f29a1ee5c1984072… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M cmk/base/plugins/agent_based/winperf_if.py M tests/unit/cmk/base/plugins/agent_based/test_winperf_if.py Log Message: ----------- check plugin: add mac support to winperf using pseudo counter 2006 lot of refactoring in tests to make errors more readable Change-Id: Iabeafa3fd809ddb86b7594262bed50f54d7ca2bc To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

[Checkmk/checkmk] 806681: Add dedicated command to compute REST API spec: cm...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 80668104a0f18845cfc6794f1724eff25408b2e2 https://github.com/Checkmk/checkmk/commit/80668104a0f18845cfc6794f1724eff25… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M bin/.f12 A bin/cmk-compute-api-spec M cmk/gui/openapi/restful_objects/specification.py M cmk/gui/openapi/spec_generator.py M cmk/gui/wsgi/applications/rest_api.py M tests/testlib/pylint_checker_cmk_module_layers.py Log Message: ----------- Add dedicated command to compute REST API spec: cmk-compute-api-spec Previously the REST API specification was computed and cached in every apache process. This caused several issues: a) After spawning a new apache, the spec needed to be recomputed for every process. This caused a delay in the first request hitting an apache process asking for it. b) It was held in memory by every process consuming a few MB. c) The invalidation of the cache and computation of new spec could not be triggered manually. With this change the spec is now stored in the site and made available to all apache processes from there. With the dedicated command `cmk-compute-api-spec` the computation can now be triggered in specific situations automatically or manually for debugging. CMK-15981 Change-Id: I7c7a04b15d7715024f4ef213689edbf0ad630795 Commit: abde7377876b98e3f93a482c30768381d0e13daf https://github.com/Checkmk/checkmk/commit/abde7377876b98e3f93a482c30768381d… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M cmk/gui/wsgi/applications/rest_api.py Log Message: ----------- Drop dead code Change-Id: Ib8b244e26b3a6694a4034619fae5d1a2f0532693 Commit: 2e98df5b2b7ab70d86b0fd7c16240c59bf7d0507 https://github.com/Checkmk/checkmk/commit/2e98df5b2b7ab70d86b0fd7c16240c59b… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: A tests/integration/cmk/gui/openapi/test_spec_generator.py Log Message: ----------- Add integration test to ensure cmk-compute-api-spec works CMK-15981 Change-Id: Icc64b14bf029d64db6b24e2a2ccea8ab5766833d Commit: a13e3744f83838c0efdf5b4d4d9aec215285edd2 https://github.com/Checkmk/checkmk/commit/a13e3744f83838c0efdf5b4d4d9aec215… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: A cmk/post_rename_site/plugins/actions/compute_api_spec.py A cmk/update_config/plugins/actions/compute_api_spec.py M omd/packages/check_mk/check_mk.make A omd/packages/check_mk/post-create/02_cmk-compute-api-spec M tests/unit/cmk/post_rename_site/test_load_plugins.py Log Message: ----------- Execute the API spec generation in various situations This change registers the new cmk-compose-api-spec command into various events happening during the lifecycle of a site. - post-create hook: Create the initial spec after a site has been created - post rename action: Update the spec after a site has been copied, restored or renamed - update-config action: Update the spec after Checkmk has been updated It might be necessary to run the command in some other situations. We'll have to find out about those along the way. CMK-15981 Change-Id: I29eeffd60ec11a797f55d103a8a86fd74fdf3935 Commit: 741455761777d03a9bf90329107a7882b324df0e https://github.com/Checkmk/checkmk/commit/741455761777d03a9bf90329107a7882b… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: A .werks/15724.md Log Message: ----------- 15724 FIX Change API specification computation The specification of the REST API defines the structure of the API. It is computed automatically from the implementation in Checkmk. Previously the specification was computed during runtime when something requested access to the specification. This could be a user opening ReDoc or the Swagger UI. The specification was then computed ad-hoc and cached in the memory of the apache process. This caused several issues: * After spawning a new apache, the specification needed to be recomputed for every process. This caused a delay in the first request hitting an apache process asking for it. * It was held in memory by every process consuming a few MB. * The invalidation of the cache and computation of new specification could not be triggered manually. With this change the specification is now stored in the site and made available to all apache processes from there. With the dedicated command `cmk-compute-api-spec` the computation can now be triggered in specific situations automatically or manually for debugging. The specification is now updated in these situations: * post-create hook: Create the initial spec after a site has been created * post rename action: Update the spec after a site has been copied, restored or renamed * update-config action: Update the spec after the site has been updated CMK-15981 Change-Id: Ic524bf8146640c66919fd49653b805c981f47771 Commit: 4f1bca39a14ea1df47ae4902bd744d3d18cfc5ce https://github.com/Checkmk/checkmk/commit/4f1bca39a14ea1df47ae4902bd744d3d1… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M cmk/gui/wsgi/applications/rest_api.py Log Message: ----------- Improve spec serving performance by using a cache The final spec is now cached in the tmpfs of the site. This way the API UIs can be rendered even faster. The cache is invalidated once a new specification is available. CMK-15981 Change-Id: I71c4aa43a0e631f6a2022ec2e7905993941db47d Commit: 9a30dd35839b930b86ea2006e86f1a274d830fb1 https://github.com/Checkmk/checkmk/commit/9a30dd35839b930b86ea2006e86f1a274… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M cmk/gui/wato/pages/tags.py Log Message: ----------- Consistently use shared helper for editing tags CMK-15981 Change-Id: I066da0f9d5de5942a21386a45d96bb49035d4c5b Commit: cc3f8d1403b7030fc0e1ce90a86b2d885948e4ae https://github.com/Checkmk/checkmk/commit/cc3f8d1403b7030fc0e1ce90a86b2d885… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M cmk/gui/openapi/registration.py A cmk/gui/openapi/spec_generator_job.py M cmk/gui/plugins/main_modules/registration.py M cmk/gui/watolib/tags.py M tests/unit/cmk/gui/test_background_job.py Log Message: ----------- Background job for spec creation triggered by UI actions We need to trigger an update of the spec to reflect changes made by previous config steps in the API specification. Since the computation takes some time, this must not be done synchronously. We need to be able to track the outcome of the job and be able to analyze the progress of the job through the UI. So it makes sense to realize this as background job. The job shall be triggered by every change to the configuration which has an effect on the API specification. The first place we trigger this job is the configuration of tags. Change-Id: Ie595552cd79eb3c38abdfa594b91ac7c99ac9330 Compare: https://github.com/Checkmk/checkmk/compare/7af6994a6ae3...cc3f8d1403b7 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2024