Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: b8919b63a5866f031c89471fb284a0e61a9ef2f6
https://github.com/Checkmk/checkmk/commit/b8919b63a5866f031c89471fb284a0e61…
Author: Benedikt Seidl <benedikt.seidl(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M cmk/utils/werks/__init__.py
M cmk/utils/werks/__main__.py
A cmk/utils/werks/mail/__init__.py
A cmk/utils/werks/mail/templates/mail.txt.jinja2
Log Message:
-----------
werks: tool for mailing werk changes
The currently used mailing of werk changes had several drawbacks:
- It was directly implemented in a git post-commit hook. This means:
- hard to debug
- hard to test changes
- no error reporting in place
- easy to forget about it
- It was a standalone python script:
- not checked in
- reimplemented werks parsing
- It had a feature that werks are only emailed once: for the version the
werk was first committed to our main repo. If this is for example
version 2.1.0, no additional mail for version 2.2.0 will be sent.
With this commit we make it possible to change to a new mail sending
approach:
- Instead of sending out the mails as soon as the commits reach the main
repo, mails are sent at midnight.
- The mail sending script manages states via git notes: if the commit is
a werks commit, and a mail has been sent a git note is added.
- We now annotate if the werk was deleted/modified or created.
- Send out a mail for every werk merged to any active branch. Before
only a single mail for each werk id was sent.
CMK-14325
Change-Id: I7fe0716589e7dd9aecda7add99eb3b12657dea7e
Commit: c2b7161eb9ac7272ec6166d1539c7a9ffa0f1157
https://github.com/Checkmk/checkmk/commit/c2b7161eb9ac7272ec6166d1539c7a9ff…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M cmk/utils/werks/mail/__init__.py
Log Message:
-----------
Consolidate getting fullname and address
Change-Id: I8e23efc656a6263ba17dab0bc224d7fd311d9efc
Commit: 07f0a35013647a4562b6025468edb9509ae2cee4
https://github.com/Checkmk/checkmk/commit/07f0a35013647a4562b6025468edb9509…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M cmk/utils/werks/mail/__init__.py
Log Message:
-----------
Factor out building mail address
Change-Id: Ied62360451400d772514a7044046aea0be625a4c
Commit: 5e4af22faaa62dffcba8d0d5f9adee3a80710fa2
https://github.com/Checkmk/checkmk/commit/5e4af22faaa62dffcba8d0d5f9adee3a8…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M cmk/utils/werks/mail/__init__.py
Log Message:
-----------
Adapt mail addresses to prior used logic
* We used to sent, e.g. level 3 werks also to level 2 and 1
* further: refactor replacing the default addresses for testing
Change-Id: I649022035dbea83fc02059234551f7a3825fddbc
Commit: 398b0e39e27862eb39df0696a0b4354cfdcf26a3
https://github.com/Checkmk/checkmk/commit/398b0e39e27862eb39df0696a0b4354cf…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
A buildscripts/scripts/send-werks-to-mailing-lists.groovy
Log Message:
-----------
Add job for sending werks to mailing list
Change-Id: I07cb983e5d2bbcb55444465778d323379dc98144
Commit: 59e48a13f48cf75683954a830e94d8b5b9c09293
https://github.com/Checkmk/checkmk/commit/59e48a13f48cf75683954a830e94d8b5b…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M buildscripts/scripts/send-werks-to-mailing-lists.groovy
Log Message:
-----------
Switch to production ref/notes/werk_mail
Change-Id: Idc86887c84ed9198e71e14b6a0ddce23dd7c9945
Commit: f5d2fd6724aec4112f24947a9075f8a1d61052dc
https://github.com/Checkmk/checkmk/commit/f5d2fd6724aec4112f24947a9075f8a1d…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M buildscripts/scripts/send-werks-to-mailing-lists.groovy
Log Message:
-----------
Alter default params if we're timer triggered
... as this is the production mode
Change-Id: Ifce6f985149561e8b1cfef58b55be8bc58edd0c1
Compare: https://github.com/Checkmk/checkmk/compare/88779aa92692...f5d2fd6724ae
Branch: refs/heads/2.2.0
Home: https://github.com/Checkmk/checkmk
Commit: 2e71206184bd1bdffdbd99ff7b2a678ba648d4c3
https://github.com/Checkmk/checkmk/commit/2e71206184bd1bdffdbd99ff7b2a678ba…
Author: Luka Racic <luka.racic(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
A .werks/15917
M agents/windows/plugins/mssql.vbs
Log Message:
-----------
15917 FIX mssql_backup: Now mssql_backup finds backup even if collation is case sensitive
Previously, if the collation was case sensitive some of the backup were not found.
This has now been fixed and the backups will be found regardless of case sensitivity.
SUP-15614
Change-Id: I418dab6ed32ee119e0bddf9ebf6a8c5b759f40e8
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: b54ef105700fbe0e26db4cc432dec9fb7d11fed6
https://github.com/Checkmk/checkmk/commit/b54ef105700fbe0e26db4cc432dec9fb7…
Author: Gav <gavin.mcguigan(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M cmk/gui/plugins/openapi/endpoints/acknowledgement/__init__.py
M cmk/gui/plugins/openapi/endpoints/cert/__init__.py
M cmk/gui/plugins/openapi/endpoints/host_config/__init__.py
M cmk/gui/plugins/openapi/endpoints/host_internal/__init__.py
M cmk/gui/plugins/openapi/endpoints/host_tag_group/__init__.py
M cmk/gui/plugins/openapi/endpoints/service_discovery/__init__.py
M cmk/gui/plugins/openapi/utils.py
M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_internal.py
Log Message:
-----------
problem response: ensure all problem responses include the detail field
On a few REST API endpoints, the problem response was missing the detail
field which violates the schema.
CMK-14273
Change-Id: Ia15611d73e033dd83d9c8e8b2df1792f1e455087
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 4ed1d34dc48dd245e55efddfd0f707ebd72eecd6
https://github.com/Checkmk/checkmk/commit/4ed1d34dc48dd245e55efddfd0f707ebd…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M cmk/base/config.py
M cmk/utils/rulesets/ruleset_matcher.py
M tests/unit/cmk/utils/rulesets/test_tuple_rulesets.py
Log Message:
-----------
Remove useless indirection #4
CMK-14467
Change-Id: I83392c66490e9118167701af052ea01103159ee3
Commit: 2f9304a9fe0b5dbe5b6b84caff0c712ee20566c6
https://github.com/Checkmk/checkmk/commit/2f9304a9fe0b5dbe5b6b84caff0c712ee…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M cmk/automations/results.py
M cmk/base/api/agent_based/value_store/_utils.py
M cmk/base/config.py
M cmk/base/core_config.py
M cmk/base/export.py
M cmk/checkengine/checking/__init__.py
M cmk/checkengine/checking/_plugin.py
M cmk/checkengine/discovery/_autochecks.py
M cmk/checkengine/discovery/_autodiscovery.py
M cmk/checkengine/discovery/_impl.py
M cmk/checkengine/discovery/_preview.py
M cmk/gui/wato/pages/object_parameters.py
M cmk/gui/wato/pages/pattern_editor.py
M cmk/gui/wato/pages/services.py
M cmk/gui/watolib/services.py
M cmk/utils/rulesets/ruleset_matcher.py
M cmk/utils/servicename.py
Log Message:
-----------
Move more MatchObject pessimization to matcher
where it is used
CMK-14467
Change-Id: Ie7d26ef29f64f169b63c730f279fece4f511bc71
Compare: https://github.com/Checkmk/checkmk/compare/80cc055a9da0...2f9304a9fe0b
Branch: refs/heads/2.1.0
Home: https://github.com/Checkmk/checkmk
Commit: 996ba6378a6089033a16e331bb3c5c5e38ceac87
https://github.com/Checkmk/checkmk/commit/996ba6378a6089033a16e331bb3c5c5e3…
Author: Luka Racic <luka.racic(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
A .werks/15915
M cmk/base/plugins/agent_based/oracle_instance.py
M tests/unit/cmk/base/plugins/agent_based/test_oracle_instance.py
Log Message:
-----------
15915 FIX oracle_instances: Fixed parsing of section with failure and additional information
Sometimes when an oracle instance has a failure it deliveres some additional information. This information caused the failure of the section parsing.
The section in the agent output looks something like this:
C+:
<<<oracle_instance:sep(124)>>>
+ASM|FAILURE|ERROR: ORA-12541: ...
NAME DATABASE_ROLE OPEN_MODE DB_UNIQUE_NAME FLASHBACK_ON FORCE_LOGGING SWITCHOVER_STATUS
C-:
This has now been fixed and the additional information should not cause any problems.
SUP-15616
Change-Id: Id50f7a39850ee3b3ad32884fe92c92c5a3f5e9fb
Branch: refs/heads/2.2.0
Home: https://github.com/Checkmk/checkmk
Commit: 345763309b8e4e0b5424af6a4f01140447a5ee63
https://github.com/Checkmk/checkmk/commit/345763309b8e4e0b5424af6a4f0114044…
Author: Luka Racic <luka.racic(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
A .werks/15915
M cmk/base/plugins/agent_based/oracle_instance.py
M tests/unit/cmk/base/plugins/agent_based/test_oracle_instance.py
Log Message:
-----------
15915 FIX oracle_instances: Fixed parsing of section with failure and additional information
Sometimes when an oracle instance has a failure it deliveres some additional information. This information caused the failure of the section parsing.
The section in the agent output looks something like this:
C+:
<<<oracle_instance:sep(124)>>>
+ASM|FAILURE|ERROR: ORA-12541: ...
NAME DATABASE_ROLE OPEN_MODE DB_UNIQUE_NAME FLASHBACK_ON FORCE_LOGGING SWITCHOVER_STATUS
C-:
This has now been fixed and the additional information should not cause any problems.
SUP-15616
Change-Id: Id50f7a39850ee3b3ad32884fe92c92c5a3f5e9fb
Branch: refs/heads/2.0.0
Home: https://github.com/Checkmk/checkmk
Commit: 359c83dce5fd46208b2aac66580981f0b5eb9f48
https://github.com/Checkmk/checkmk/commit/359c83dce5fd46208b2aac66580981f0b…
Author: Luka Racic <luka.racic(a)checkmk.com>
Date: 2023-09-08 (Fri, 08 Sep 2023)
Changed paths:
A .werks/15915
M checks/oracle_instance
Log Message:
-----------
15915 FIX oracle_instances: Fixed parsing of section with failure and additional information
Sometimes when an oracle instance has a failure it deliveres some additional information. This information caused the failure of the section parsing.
The section in the agent output looks something like this:
C+:
<<<oracle_instance:sep(124)>>>
+ASM|FAILURE|ERROR: ORA-12541: ...
NAME DATABASE_ROLE OPEN_MODE DB_UNIQUE_NAME FLASHBACK_ON FORCE_LOGGING SWITCHOVER_STATUS
C-:
This has now been fixed and the additional information should not cause any problems.
SUP-15616
Change-Id: Id50f7a39850ee3b3ad32884fe92c92c5a3f5e9fb
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: cf48388712e68788ee7d836de850ea80b897776b
https://github.com/Checkmk/checkmk/commit/cf48388712e68788ee7d836de850ea80b…
Author: Gav <gavin.mcguigan(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
A .werks/16098
M cmk/gui/fields/__init__.py
M cmk/gui/fields/custom_fields.py
M cmk/gui/fields/definitions.py
M cmk/gui/plugins/openapi/endpoints/notification_rules/response_schemas.py
M tests/unit/cmk/gui/plugins/openapi/test_notification_rules.py
Log Message:
-----------
16098 FIX notification rules: match_folder value now matches correctly to available folders
This werk addresses an issue when creating or updating a notification rule
via the REST-API. Previously, it would not correctly match the desired folder
and as a result, you had to set this option to disabled which meant all rules
were created in the main folder only.
Now the match_folder value field should match a folder id, in the form of the
folder path, replacing / for ~
E.g.
/folder1 -> ~folder1
/folder1/folder2 -> ~folder1~folder2
Change-Id: If58bcc32bc74bcb485bc66117100dd32fecc348d
Commit: c3e41dd7fa2a35da38057d27888a63da51916c41
https://github.com/Checkmk/checkmk/commit/c3e41dd7fa2a35da38057d27888a63da5…
Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M package-lock.json
M package.json
M web/htdocs/js/modules/forms.ts
M web/htdocs/js/modules/nodevis/layout_styles.ts
M web/htdocs/js/modules/nodevis/viewport.ts
Log Message:
-----------
npm-update
Change-Id: I94cd36639c18b026b1726ab4093a8ae1d1f7c307
Commit: 28e13439d7f3e6eaacca3c79815d655225d08c3d
https://github.com/Checkmk/checkmk/commit/28e13439d7f3e6eaacca3c79815d65522…
Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
M cmk/utils/livestatus_helpers/queries.py
M cmk/utils/livestatus_helpers/testing.py
M mypy-raw.ini
M pyproject.toml
Log Message:
-----------
Improve typing
Change-Id: Icfa6e489b96b80f75b831c5a26a04aad045fa8a5
Commit: 80cc055a9da0f464e29dabf6d3cffe11441f49b2
https://github.com/Checkmk/checkmk/commit/80cc055a9da0f464e29dabf6d3cffe114…
Author: Luka Racic <luka.racic(a)checkmk.com>
Date: 2023-09-13 (Wed, 13 Sep 2023)
Changed paths:
A .werks/15915
M cmk/base/plugins/agent_based/oracle_instance_section.py
M tests/unit/cmk/base/plugins/agent_based/test_oracle_instance.py
Log Message:
-----------
15915 FIX oracle_instances: Fixed parsing of section with failure and additional information
Sometimes when an oracle instance has a failure it deliveres some additional information. This information caused the failure of the section parsing.
The section in the agent output looks something like this:
C+:
<<<oracle_instance:sep(124)>>>
+ASM|FAILURE|ERROR: ORA-12541: ...
NAME DATABASE_ROLE OPEN_MODE DB_UNIQUE_NAME FLASHBACK_ON FORCE_LOGGING SWITCHOVER_STATUS
C-:
This has now been fixed and the additional information should not cause any problems.
SUP-15616
Change-Id: Id50f7a39850ee3b3ad32884fe92c92c5a3f5e9fb
Compare: https://github.com/Checkmk/checkmk/compare/03ea44abac65...80cc055a9da0