Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: ad7287e384790be4f3f1fd8b44aad6c00bd9eec1
https://github.com/Checkmk/checkmk/commit/ad7287e384790be4f3f1fd8b44aad6c00…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
M cmk/ec/config.py
M cmk/gui/plugins/wato/check_parameters/db_jobs.py
M cmk/gui/valuespec.py
M cmk/gui/views/command/commands.py
M cmk/utils/render.py
Log Message:
-----------
inline type aliases
These usages have nothing to do with the
prediction module.
Change-Id: Ie8dc11a8c20d4c75992579be84beb93cd5411140
Commit: ad535c1a22fd1e1ca7fa9a11a3ac651a6af28194
https://github.com/Checkmk/checkmk/commit/ad535c1a22fd1e1ca7fa9a11a3ac651a6…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
M cmk/base/api/agent_based/utils.py
M cmk/base/check_api.py
M cmk/base/config.py
R cmk/base/prediction.py
M cmk/gui/prediction.py
M cmk/gui/watolib/automatic_host_removal.py
R cmk/utils/prediction.py
A cmk/utils/prediction/__init__.py
A cmk/utils/prediction/_plugin_interface.py
A cmk/utils/prediction/_prediction.py
M tests/integration/cmk/base/test_services_prediction.py
M tests/unit/checks/test_mem_win.py
M tests/unit/cmk/base/api/agent_based/test_utils_check_levels_predictive.py
M tests/unit/cmk/base/plugins/agent_based/test_diskstat.py
M tests/unit/cmk/base/plugins/agent_based/utils/test_cpu_load.py
M tests/unit/cmk/base/test_prediction.py
M tests/unit/cmk/utils/test_prediction_commons.py
Log Message:
-----------
prediction: clarify interface
Change-Id: I5398ef3676e748cc92bbf32443e02c254be55bb3
Compare: https://github.com/Checkmk/checkmk/compare/8981b61bc85f...ad535c1a22fd
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 8981b61bc85f8aa9b3be6a8dbc30c68689efa2ed
https://github.com/Checkmk/checkmk/commit/8981b61bc85f8aa9b3be6a8dbc30c6868…
Author: René Slowenski <rene.slowenski(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
M tests/testlib/site.py
Log Message:
-----------
Raising TimeoutError on check timeout
A timeout in _verify_next_check_output() should raise a TimeoutError
instead of an AssertionError. This change fixes that.
Change-Id: I331806b9abcdc86f807684583552fe959f282fc8
Branch: refs/heads/2.1.0
Home: https://github.com/Checkmk/checkmk
Commit: 4874e80ee783604469083f1be71c47b5ed86cae4
https://github.com/Checkmk/checkmk/commit/4874e80ee783604469083f1be71c47b5e…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
A .werks/15903
M checks/cisco_temperature
Log Message:
-----------
15903 FIX cisco_temperature, cisco_temperature_dom: Improved check state and summary if sensor status not ok
The cisco_temperature and cisco_temperature_dom checks currently only consider sensors with the state "ok". If a sensor becomes "unavailable" or "non-operational", the check becomes "UNKNOWN" with the summary "Item not found in monitoring data".
With this werk, the summary will now report the status of the sensor instead.
For the "unavailable" sensor status, the check state will still change to "UNKNOWN", for "non-operational" status it will be CRIT.
SUP-14650
Change-Id: I1f87fe96bf85ee48b4ddeca8a2e731dbeefa3c25
Commit: b9a99808dc9c717d4887f5ad318679de6efea206
https://github.com/Checkmk/checkmk/commit/b9a99808dc9c717d4887f5ad318679de6…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
A .werks/15969
M checks/cisco_temperature
M tests/unit/checks/generictests/datasets/cisco_temperature.py
M tests/unit/checks/generictests/datasets/cisco_temperature_discovery.py
Log Message:
-----------
15969 FIX cisco_temperature: Correct warning threshold for environment temperature
Currently only the threshold specified by OID 1.3.6.1.4.1.9.9.13.1.3.1.4 (ciscoEnvMonTemperatureThreshold) is considered when checking the temperature of a Cisco switch. As only one threshold is given, it is used as both WARN and CRIT threshold, causing confusion when the device itself reports a warning state based on a previously unknown WARN threshold.
Now the upper thresholds specified in OID 1.3.6.1.4.1.9.9.91.1.2.1.1 (entSensorThresholdTable) will be used as WARN and CRIT thresholds if an entry for the relevant switch can be found.
For this, the threshold relation and severity will be used to determine if the threshold can be applied in Checkmk, otherwise it will be ignored.
SUP-14653
Change-Id: If8bc63d378d3a77fbf94b5ead48740fef903594b
Compare: https://github.com/Checkmk/checkmk/compare/7bf9f7558eac...b9a99808dc9c
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: f66557ac4f5892e6f1a0a3a4f911a705570c9632
https://github.com/Checkmk/checkmk/commit/f66557ac4f5892e6f1a0a3a4f911a7055…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
A .werks/15903
M cmk/base/plugins/agent_based/cisco_temperature.py
M tests/unit/cmk/base/plugins/agent_based/test_cisco_temperature.py
Log Message:
-----------
15903 FIX cisco_temperature, cisco_temperature_dom: Improved check state and summary if sensor status not ok
The cisco_temperature and cisco_temperature_dom checks currently only consider sensors with the state "ok". If a sensor becomes "unavailable" or "non-operational", the check becomes "UNKNOWN" with the summary "Item not found in monitoring data".
With this werk, the summary will now report the status of the sensor instead.
For the "unavailable" sensor status, the check state will still change to "UNKNOWN", for "non-operational" status it will be CRIT.
SUP-14650
Change-Id: I1f87fe96bf85ee48b4ddeca8a2e731dbeefa3c25
Commit: aba1f658e164a7c617287ece7412e543c51bc216
https://github.com/Checkmk/checkmk/commit/aba1f658e164a7c617287ece7412e543c…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
A .werks/15969
M cmk/base/plugins/agent_based/cisco_temperature.py
M tests/unit/cmk/base/plugins/agent_based/test_cisco_temperature.py
Log Message:
-----------
15969 FIX cisco_temperature: Correct warning threshold for environment temperature
Currently only the threshold specified by OID 1.3.6.1.4.1.9.9.13.1.3.1.4 (ciscoEnvMonTemperatureThreshold) is considered when checking the temperature of a Cisco switch. As only one threshold is given here, it is used as both WARN and CRIT threshold, causing confusion when the device itself reports a warning state based on a warning threshold not given via this OID.
Now the upper thresholds specified in OID 1.3.6.1.4.1.9.9.91.1.2.1.1 (entSensorThresholdTable) will be used as WARN and CRIT thresholds if an entry for the relevant switch can be found.
For this, the threshold relation and severity will be used to determine if the threshold can be applied in Checkmk, otherwise the threshold will be ignored.
If no thresholds from the entSensorThresholdTable apply, the ciscoEnvMonTemperatureThreshold is used as a fallback.
SUP-14653
Change-Id: If8bc63d378d3a77fbf94b5ead48740fef903594b
Commit: e8cad2f0d1b7d4a616b1db7f4cbdf1f3a518d1f7
https://github.com/Checkmk/checkmk/commit/e8cad2f0d1b7d4a616b1db7f4cbdf1f3a…
Author: Max Linke <max.linke(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
M cmk/gui/login.py
Log Message:
-----------
CSE login redirects to cognito auth
When the login.py page is called the CSE edition will redirect to a page
handling the cognito oauth login. If we use the login.py to redirect we
can rely on the other logic in checkmk to forward a user to login.py
when a session is not active.
To achieve this we replace the login page in the saas edition. Once we
further refactor page registration we might be able to move this fully
into cse specific files and remove the edition check.
Change-Id: I2c6cd5dc1a391b3dcdd13853ad257d91216cfd07
Compare: https://github.com/Checkmk/checkmk/compare/b7d0869d3ec1...e8cad2f0d1b7
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 37a1539f4dcc810b95587a444560a77aa1214fa7
https://github.com/Checkmk/checkmk/commit/37a1539f4dcc810b95587a444560a77aa…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
M buildscripts/scripts/stages.yml
Log Message:
-----------
Fix missing py_import_cycles output processing
The relevant information regarding the detected cycles are written to
stderr which was previously not written to results/py-import-cycles.txt
in our gerrit test job.
Change-Id: I577e0c913ad14444900c5bb60037654f26f0e3e3
Commit: 5d1b85798e13a4e82304142fe1a7a64d807ff6ca
https://github.com/Checkmk/checkmk/commit/5d1b85798e13a4e82304142fe1a7a64d8…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
M cmk/gui/autocompleters.py
M cmk/gui/bi/view.py
M cmk/gui/crash_reporting/views.py
M cmk/gui/dashboard/__init__.py
M cmk/gui/dashboard/dashlet/dashlets/graph.py
M cmk/gui/dashboard/dashlet/dashlets/view.py
M cmk/gui/dashboard/page_create_dashboard.py
M cmk/gui/dashboard/page_edit_dashlet.py
M cmk/gui/dashboard/page_show_dashboard.py
M cmk/gui/dashboard/visual_type.py
M cmk/gui/data_source/base.py
M cmk/gui/data_source/datasources.py
M cmk/gui/data_source/livestatus.py
M cmk/gui/inventory.py
M cmk/gui/mkeventd/views.py
M cmk/gui/mobile/pages.py
M cmk/gui/node_visualization.py
M cmk/gui/page_menu_utils.py
M cmk/gui/plugins/main_modules/registration.py
M cmk/gui/plugins/metrics/utils.py
M cmk/gui/plugins/visuals/filters.py
R cmk/gui/plugins/visuals/infos.py
M cmk/gui/plugins/visuals/inventory.py
M cmk/gui/plugins/visuals/node_vis.py
M cmk/gui/plugins/visuals/utils.py
M cmk/gui/plugins/visuals/wato.py
M cmk/gui/view_renderer.py
M cmk/gui/views/__init__.py
M cmk/gui/views/inventory/__init__.py
M cmk/gui/views/inventory/row_post_processor.py
M cmk/gui/views/join_service_rows.py
M cmk/gui/views/page_edit_view.py
M cmk/gui/views/page_show_view.py
M cmk/gui/views/row_post_processing.py
M cmk/gui/views/visual_type.py
M cmk/gui/visual_link.py
M cmk/gui/visuals/__init__.py
M cmk/gui/visuals/_add_to_visual.py
M cmk/gui/visuals/_breadcrumb.py
M cmk/gui/visuals/_filter_context.py
M cmk/gui/visuals/_filter_valuespecs.py
A cmk/gui/visuals/_livestatus.py
M cmk/gui/visuals/_page_create_visual.py
M cmk/gui/visuals/_page_edit_visual.py
M cmk/gui/visuals/_page_list.py
A cmk/gui/visuals/filter/__init__.py
A cmk/gui/visuals/filter/_base.py
A cmk/gui/visuals/filter/_registry.py
A cmk/gui/visuals/info/__init__.py
A cmk/gui/visuals/info/_base.py
A cmk/gui/visuals/info/_infos.py
A cmk/gui/visuals/info/_registry.py
A cmk/gui/visuals/type/__init__.py
A cmk/gui/visuals/type/_base.py
A cmk/gui/visuals/type/_registry.py
M tests/integration/cmk/gui/plugins/visuals/helper_test_load_visuals_plugin.py
M tests/integration/cmk/gui/plugins/visuals/legacy_visuals_plugin.py
M tests/integration/cmk/gui/plugins/visuals/visuals_plugin.py
M tests/unit/cmk/gui/plugins/visuals/test_filters.py
R tests/unit/cmk/gui/plugins/visuals/test_visuals_utils.py
M tests/unit/cmk/gui/test_node_visualization.py
M tests/unit/cmk/gui/test_visuals.py
M tests/unit/cmk/gui/views/test_page_show_view.py
A tests/unit/cmk/gui/visuals/test_livestatus.py
Log Message:
-----------
Resolve cmk.gui.plugins.visuals.utils
Squashed from:
Move visual info out of plugin namespace
Change-Id: Ic14e6ebb21c14443e7e7772bc8bde5bc0e634cca
Move visual type out of plugin namespace
Change-Id: I4ea7c792408599c6716f7984059789bd54389ff3
Move inventory specific helper to other inventory related code
Change-Id: I746cb5dec97815c1b16017b7761a71fa569d765c
Move remaining visuals utils from plugins
Change-Id: I6a43873a79e9bf484f84512fea5803a6f9a50c51
Commit: 075f31c3152bd2034b491a6b3c2a2314dbf7d5a9
https://github.com/Checkmk/checkmk/commit/075f31c3152bd2034b491a6b3c2a2314d…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
M cmk/gui/node_visualization.py
M cmk/gui/nodevis_lib.py
M cmk/gui/plugins/main_modules/registration.py
R cmk/gui/plugins/visuals/node_vis.py
Log Message:
-----------
Move filters next to node visualization code
Change-Id: Ifc96e2a116f55e140c50025bf1f2c440076ec69a
Commit: b85434f2b75e2d78f9a6f63c3c1f7d881d9e04c2
https://github.com/Checkmk/checkmk/commit/b85434f2b75e2d78f9a6f63c3c1f7d881…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
R cmk/gui/inventory.py
Log Message:
-----------
Make cmk.gui.inventory a package
Change-Id: Ie3371b5fb3a49bc05b2e82ee201d56356ec4bb8f
Commit: b7d0869d3ec141813b377cc56143682732380313
https://github.com/Checkmk/checkmk/commit/b7d0869d3ec141813b377cc5614368273…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2023-07-26 (Wed, 26 Jul 2023)
Changed paths:
A cmk/gui/inventory/__init__.py
A cmk/gui/inventory/_inventory_path.py
A cmk/gui/inventory/filters.py
M cmk/gui/plugins/main_modules/registration.py
R cmk/gui/plugins/visuals/inventory.py
M cmk/gui/query_filters.py
M cmk/gui/views/inventory/__init__.py
M cmk/gui/views/inventory/builtin_display_hints.py
M tests/unit/cmk/gui/test_visuals.py
M tests/unit/cmk/gui/views/test_views_inventory.py
Log Message:
-----------
Move inventory filters next to inventory code
Change-Id: I10d03053129d7084723c61c4649e1073bb731b0a
Compare: https://github.com/Checkmk/checkmk/compare/95f1b3a688fb...b7d0869d3ec1