Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: d536af67957fa6243d268cd3f5406f88050afd00
https://github.com/Checkmk/checkmk/commit/d536af67957fa6243d268cd3f5406f880…
Author: Matteo Stifano <matteo.stifano(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M tests/composition/controller_site_interactions/common.py
M tests/composition/controller_site_interactions/test_proxy_register_import_workflow.py
M tests/composition/controller_site_interactions/test_register_workflow.py
M tests/composition/controller_site_interactions/test_rename_preserves_registration.py
M tests/composition/controller_site_interactions/test_status.py
M tests/testlib/agent.py
M tests/update/test_update.py
Log Message:
-----------
Move utils functions to testlib-agent module
Two utils functions are moved from the composition tests folder to the
testlib-agent module. Tests are adapted accordingly.
Change-Id: I0ac23a0e5535a31b7f9c62dd3d073cb187fb08bd
Commit: 9053d06685b78e59cc31113a8481fc6e26e0e642
https://github.com/Checkmk/checkmk/commit/9053d06685b78e59cc31113a8481fc6e2…
Author: Matteo Stifano <matteo.stifano(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
R tests/composition/controller_site_interactions/common.py
M tests/composition/controller_site_interactions/test_proxy_register_import_workflow.py
M tests/composition/controller_site_interactions/test_register_workflow.py
M tests/composition/controller_site_interactions/test_rename_preserves_registration.py
M tests/composition/controller_site_interactions/test_status.py
M tests/testlib/agent.py
Log Message:
-----------
Move remaining functions from composition-common to testlib-agent
Tests are adapted accordingly.
Change-Id: Icd2e61f28d895c61962b0199dd6c6387c6590ccf
Commit: a9e83cbc46fde99086f55e396d08baa117e045d4
https://github.com/Checkmk/checkmk/commit/a9e83cbc46fde99086f55e396d08baa11…
Author: René Slowenski <rene.slowenski(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M tests/gui_crawl/conftest.py
M tests/gui_e2e/conftest.py
M tests/plugins_integration/conftest.py
M tests/testlib/site.py
M tests/testlib/version.py
Log Message:
-----------
Refactored test_site fixture creation
Change-Id: If6b5bb8e997d15ffc7af9c6f9ae5467d4dcff947
Commit: 96499dd077c84267369cd386ebe6a609b5982ee0
https://github.com/Checkmk/checkmk/commit/96499dd077c84267369cd386ebe6a609b…
Author: René Slowenski <rene.slowenski(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M tests/composition/conftest.py
Log Message:
-----------
Refactored site creation in composition test
Change-Id: I68e1667154cfa24138227c7f70dda7334853d8c7
Compare: https://github.com/Checkmk/checkmk/compare/88249bcfc87b...96499dd077c8
Branch: refs/heads/2.2.0
Home: https://github.com/Checkmk/checkmk
Commit: 03e3b07399b7ec3edacd7075bc6c4f35a6b917be
https://github.com/Checkmk/checkmk/commit/03e3b07399b7ec3edacd7075bc6c4f35a…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M tests/Makefile
M tests/agent-plugin-unit/Dockerfile
Log Message:
-----------
Switch base image for agent plugin unit tests
* it seems deadsnakes does not have 3.4 anymore
* so let's directly use the python docker images
further:
* remove unused 2.6 switches
* drop py3.3 support for agent plugins, this was already done a long time ago in 9405234a9c79393898b4e30d33e742d2bdd05e1c
Change-Id: Iafde92690be93004df8a3dc052686c133124652a
Commit: ca7802bbf9765e9dc3b853f36af9d99ca1ffdd09
https://github.com/Checkmk/checkmk/commit/ca7802bbf9765e9dc3b853f36af9d99ca…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/utils/version.py
M tests/unit/cmk/gui/wato/pages/test_automation.py
Log Message:
-----------
Increase required patch version due to static_checks:cpu_load update fix
See werk #15270
SUP-14336
Change-Id: I9834839810746dcc3520d2fe0403388320b5ba90
Compare: https://github.com/Checkmk/checkmk/compare/f361f7f73e11...ca7802bbf976
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 2a09f35ba76392ce6e29c0c17c253398619f12de
https://github.com/Checkmk/checkmk/commit/2a09f35ba76392ce6e29c0c17c2533986…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15894
M cmk/base/plugins/agent_based/domino_tasks.py
M cmk/base/plugins/agent_based/ps_check.py
M cmk/base/plugins/agent_based/ps_section.py
M cmk/base/plugins/agent_based/utils/ps.py
M tests/unit/cmk/base/plugins/agent_based/test_domino_tasks.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_check.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
M tests/unit/cmk/base/plugins/agent_based/utils/test_ps.py
Log Message:
-----------
FIX: State and Count of Processes: Calculate process creation time consistently
The creation time of a process, as displayed by the "State and Count of Processes" service is calculated by taking the difference between the current time and the time elapsed since the process was started.
Previously, this used the time the check was performed at as the current time, leading to different creation times if different services were created for the same process.
Now the time the agent section was parsed is used instead.
Note that this will still lead to incorrect creation times if it takes too long to fetch the agent output.
SUP-14394
Change-Id: If282dc8258395a69a67344b448fdfec86d0c2f6f
Commit: 740a2d367c0314d182588accf2327f76f0f0b478
https://github.com/Checkmk/checkmk/commit/740a2d367c0314d182588accf2327f76f…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15895
M agents/check_mk_agent.linux
M cmk/base/plugins/agent_based/ps_section.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
Log Message:
-----------
FIX: State and Count of Processes: Use remote server time for process creation time when using Linux agent
As mentioned in werk 15894, the reference time used to calculate the creation time of a process as displayed by the "State and Count of Processes" service is the time the agent section was parsed.
The <tt>check_mk_agent.linux</tt> agent will now also output the time at which the ps command was executed to be used as a reference instead.
The agent must be redeployed to take advantage of this change.
SUP-14394
Change-Id: Iac7c9b59d01a9b5dc5d46ca501d849d6fa84e463
Commit: 5ab7d42e318d5b91de67be746439b8a9fc16fa73
https://github.com/Checkmk/checkmk/commit/5ab7d42e318d5b91de67be746439b8a9f…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15896
M agents/check_mk_agent.aix
M agents/check_mk_agent.solaris
M cmk/base/plugins/agent_based/ps_section.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
Log Message:
-----------
15896 FIX State and Count of Processes: Use remote server time for process creation time when using Solaris or AIX agent
As mentioned in werk 15894, the reference time used to calculate the creation time of a process as displayed by the "State and Count of Processes" service is the time the agent section was parsed.
The <tt>check_mk_agent.solaris</tt> and <tt>check_mk_agent.aix</tt> agents will now also output the time at which the ps command was executed to be used as reference instead.
The agent must be redeployed to take advantage of this change.
SUP-14394
Change-Id: I734ef73b6707310543b7e8bc65160a095742d867
Commit: 6109a94cc696fda6f6e823068efb65f322675fd6
https://github.com/Checkmk/checkmk/commit/6109a94cc696fda6f6e823068efb65f32…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M .werks/15896
M agents/check_mk_agent.freebsd
M agents/check_mk_agent.macosx
M agents/check_mk_agent.netbsd
M agents/check_mk_agent.openbsd
M agents/check_mk_agent.openwrt
Log Message:
-----------
State and Count of Processes: Add remote server time for more agents
Output the time at which the ps-command was executed for freebsd, macosx, netbsd, openbsd and openwrt agents
SUP-14394
Change-Id: Iea08e2e61e79f4b82bbd68ada7520767fe7a52de
Commit: 04f1e33c1db61e286b6229173219c6c7162cfd67
https://github.com/Checkmk/checkmk/commit/04f1e33c1db61e286b6229173219c6c71…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/plugins/openapi/endpoints/ruleset/__init__.py
M cmk/gui/wato/pages/predefined_conditions.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
ruleset: Inline useless `filter` static method
CMK-13680
Change-Id: I515e8b1b5e748668822935be53ad1f599e64a58b
Commit: 504d550fc4d87cf5ba643fb98af5bf2c430f3eff
https://github.com/Checkmk/checkmk/commit/504d550fc4d87cf5ba643fb98af5bf2c4…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
rulespecs: Improve typing a bit
CMK-13680
Change-Id: I192876a3cd73310fa304208e816f696c05243492
Commit: 1187ae24edbbf5518bfd5f4758b135b1ddd65cad
https://github.com/Checkmk/checkmk/commit/1187ae24edbbf5518bfd5f4758b135b1d…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/plugins/openapi/endpoints/ruleset/__init__.py
M cmk/gui/wato/pages/predefined_conditions.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
Get rid of `FilteredRulesetCollection`
Filtering should preserve the type.
CMK-13680
Change-Id: Ib47ab9f4621b5bb27dc400e7cd67ca5108fd473c
Commit: 490c304e85b829c69cf806c69899d2f093d4dec8
https://github.com/Checkmk/checkmk/commit/490c304e85b829c69cf806c69899d2f09…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
Misc. fixups in RulesetCollection hierarchy
Remove non-implemented methods
------------------------------
`save()` and `save_folder()` are only implemented in `AllRulesets` so
polymorphism doesn't make sense. Even worse, `save_folder()` was
*removed* from `SingleRulesetRecursively`, which breaks the LSP.
`SingleRulesetRecursively` is *not* an `AllRulesets` (duh!)
-----------------------------------------------------------
So let it inherit `RulesetCollection` directly. Even if that means
copying a bit of code.
Fix signature of `load*` functions
----------------------------------
`AllRulesets` cannot have an `only_varname` argument, by definition.
Similarly, this argument is required in `SingleRulesetRecursively`
CMK-13680
Change-Id: I86913ecdd69c868c5f9e231aa2466eb7827b507b
Commit: 88249bcfc87b603fd4e4a7e18cd29aea1f386009
https://github.com/Checkmk/checkmk/commit/88249bcfc87b603fd4e4a7e18cd29aea1…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
Move I/O out of class
The RulesetCollection mostly is a `MutableMapping[RulesetName, Ruleset]`
with a non-standard API. I/O doesn't belong here.
CMK-13680
Change-Id: Ic6ed290fbd7ae015490ba34a5c33bcf49b65e56f
Compare: https://github.com/Checkmk/checkmk/compare/f199f0c3a350...88249bcfc87b
Branch: refs/heads/2.1.0
Home: https://github.com/Checkmk/checkmk
Commit: baacf2d14ccf18bf6dd4ed65c559bed934c36329
https://github.com/Checkmk/checkmk/commit/baacf2d14ccf18bf6dd4ed65c559bed93…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15894
M cmk/base/plugins/agent_based/domino_tasks.py
M cmk/base/plugins/agent_based/ps_check.py
M cmk/base/plugins/agent_based/ps_section.py
M cmk/base/plugins/agent_based/utils/ps.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_check.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
M tests/unit/cmk/base/plugins/agent_based/utils/test_ps.py
Log Message:
-----------
FIX: State and Count of Processes: Calculate process creation time consistently
The creation time of a process, as displayed by the "State and Count of Processes" service is calculated by taking the difference between the current time and the time elapsed since the process was started.
Previously, this used the time the check was performed at as the current time, leading to different creation times if different services were created for the same process.
Now the time the agent section was parsed is used instead.
Note that this will still lead to incorrect creation times if it takes too long to fetch the agent output.
SUP-14394
Change-Id: If282dc8258395a69a67344b448fdfec86d0c2f6f
Commit: 4630a43a762a72fcaa7a2073485fc827305e4195
https://github.com/Checkmk/checkmk/commit/4630a43a762a72fcaa7a2073485fc8273…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15895
M agents/check_mk_agent.linux
M cmk/base/plugins/agent_based/ps_section.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
Log Message:
-----------
FIX: State and Count of Processes: Use remote server time for process creation time when using Linux agent
As mentioned in werk 15894, the reference time used to calculate the creation time of a process as displayed by the "State and Count of Processes" service is the time the agent section was parsed.
The <tt>check_mk_agent.linux</tt> agent will now also output the time at which the ps command was executed to be used as a reference instead.
The agent must be redeployed to take advantage of this change.
SUP-14394
Change-Id: Iac7c9b59d01a9b5dc5d46ca501d849d6fa84e463
Commit: 97d3e3ff0c13dfccef60ec06785eac37ec288a0a
https://github.com/Checkmk/checkmk/commit/97d3e3ff0c13dfccef60ec06785eac37e…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15896
M agents/check_mk_agent.aix
M agents/check_mk_agent.solaris
M cmk/base/plugins/agent_based/ps_section.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
Log Message:
-----------
15896 FIX State and Count of Processes: Use remote server time for process creation time when using Solaris or AIX agent
As mentioned in werk 15894, the reference time used to calculate the creation time of a process as displayed by the "State and Count of Processes" service is the time the agent section was parsed.
The <tt>check_mk_agent.solaris</tt> and <tt>check_mk_agent.aix</tt> agents will now also output the time at which the ps command was executed to be used as reference instead.
The agent must be redeployed to take advantage of this change.
SUP-14394
Change-Id: I734ef73b6707310543b7e8bc65160a095742d867
Commit: d1f4922d3083890f2f16502d06c578227c12d95f
https://github.com/Checkmk/checkmk/commit/d1f4922d3083890f2f16502d06c578227…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M .werks/15896
M agents/check_mk_agent.freebsd
M agents/check_mk_agent.macosx
M agents/check_mk_agent.netbsd
M agents/check_mk_agent.openbsd
M agents/check_mk_agent.openwrt
Log Message:
-----------
State and Count of Processes: Add remote server time for more agents
Output the time at which the ps-command was executed for freebsd, macosx, netbsd, openbsd and openwrt agents
SUP-14394
Change-Id: Iea08e2e61e79f4b82bbd68ada7520767fe7a52de
Compare: https://github.com/Checkmk/checkmk/compare/3391b99cd3bc...d1f4922d3083
Branch: refs/heads/2.2.0
Home: https://github.com/Checkmk/checkmk
Commit: 65b163b2cce2b511ce51c572c6b90ef8480038d6
https://github.com/Checkmk/checkmk/commit/65b163b2cce2b511ce51c572c6b90ef84…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15894
M cmk/base/plugins/agent_based/domino_tasks.py
M cmk/base/plugins/agent_based/ps_check.py
M cmk/base/plugins/agent_based/ps_section.py
M cmk/base/plugins/agent_based/utils/ps.py
M tests/unit/cmk/base/plugins/agent_based/test_domino_tasks.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_check.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
M tests/unit/cmk/base/plugins/agent_based/utils/test_ps.py
Log Message:
-----------
FIX: State and Count of Processes: Calculate process creation time consistently
The creation time of a process, as displayed by the "State and Count of Processes" service is calculated by taking the difference between the current time and the time elapsed since the process was started.
Previously, this used the time the check was performed at as the current time, leading to different creation times if different services were created for the same process.
Now the time the agent section was parsed is used instead.
Note that this will still lead to incorrect creation times if it takes too long to fetch the agent output.
SUP-14394
Change-Id: If282dc8258395a69a67344b448fdfec86d0c2f6f
Commit: b60e7cd8ebddeb31790fb2a9a6031ca1fe3f7b1d
https://github.com/Checkmk/checkmk/commit/b60e7cd8ebddeb31790fb2a9a6031ca1f…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15895
M agents/check_mk_agent.linux
M cmk/base/plugins/agent_based/ps_section.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
Log Message:
-----------
FIX: State and Count of Processes: Use remote server time for process creation time when using Linux agent
As mentioned in werk 15894, the reference time used to calculate the creation time of a process as displayed by the "State and Count of Processes" service is the time the agent section was parsed.
The <tt>check_mk_agent.linux</tt> agent will now also output the time at which the ps command was executed to be used as a reference instead.
The agent must be redeployed to take advantage of this change.
SUP-14394
Change-Id: Iac7c9b59d01a9b5dc5d46ca501d849d6fa84e463
Commit: 75f155e44381468558ef6405d22bd78bce3adfa6
https://github.com/Checkmk/checkmk/commit/75f155e44381468558ef6405d22bd78bc…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15896
M agents/check_mk_agent.aix
M agents/check_mk_agent.solaris
M cmk/base/plugins/agent_based/ps_section.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
Log Message:
-----------
15896 FIX State and Count of Processes: Use remote server time for process creation time when using Solaris or AIX agent
As mentioned in werk 15894, the reference time used to calculate the creation time of a process as displayed by the "State and Count of Processes" service is the time the agent section was parsed.
The <tt>check_mk_agent.solaris</tt> and <tt>check_mk_agent.aix</tt> agents will now also output the time at which the ps command was executed to be used as reference instead.
The agent must be redeployed to take advantage of this change.
SUP-14394
Change-Id: I734ef73b6707310543b7e8bc65160a095742d867
Commit: f361f7f73e112de76ff577a2982750699060fc3c
https://github.com/Checkmk/checkmk/commit/f361f7f73e112de76ff577a2982750699…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M .werks/15896
M agents/check_mk_agent.freebsd
M agents/check_mk_agent.macosx
M agents/check_mk_agent.netbsd
M agents/check_mk_agent.openbsd
M agents/check_mk_agent.openwrt
Log Message:
-----------
State and Count of Processes: Add remote server time for more agents
Output the time at which the ps-command was executed for freebsd, macosx, netbsd, openbsd and openwrt agents
SUP-14394
Change-Id: Iea08e2e61e79f4b82bbd68ada7520767fe7a52de
Compare: https://github.com/Checkmk/checkmk/compare/23dddc938aa6...f361f7f73e11
Branch: refs/heads/2.1.0
Home: https://github.com/Checkmk/checkmk
Commit: be5d544eff24fa625b178d69862dd42b9fc1c9ba
https://github.com/Checkmk/checkmk/commit/be5d544eff24fa625b178d69862dd42b9…
Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M tests/Makefile
M tests/agent-plugin-unit/Dockerfile
Log Message:
-----------
Switch base image for agent plugin unit tests
* it seems deadsnakes does not have 3.4 anymore
* so let's directly use the python docker images
further:
* remove unused 2.6 switches
* drop py3.3 support for agent plugins, this was already done a long time ago in 9405234a9c79393898b4e30d33e742d2bdd05e1c
Change-Id: Iafde92690be93004df8a3dc052686c133124652a
Branch: refs/heads/2.1.0
Home: https://github.com/Checkmk/checkmk
Commit: c95e010745fd81d7dc47dbd6fc2d60431a7c9d44
https://github.com/Checkmk/checkmk/commit/c95e010745fd81d7dc47dbd6fc2d60431…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M tests/conftest.py
Log Message:
-----------
Default pytest -T to unit
The unit tests are run the most during a normal development cycle so
defaulting to them is meaningful. With this default, the call to pytest
is the one known from other projects as well and should be less
surprising for beginners.
Change-Id: Ifea9ef7ed1a0f2fed8ddc26d61c8ffdaeae4121e