Checkmk git commits May 2023

checkmk-commits@lists.checkmk.com

3 participants
491 discussions

[Checkmk/checkmk] cee56c: Implement TimeSeries.count

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: cee56c6448215636d16802cc0348776ae8ff3c7a https://github.com/Checkmk/checkmk/commit/cee56c6448215636d16802cc0348776ae… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/utils/prediction.py M tests/unit/cmk/utils/test_prediction_commons.py Log Message: ----------- Implement TimeSeries.count This is needed in order to apply our time series operators to TimeSeries instances. CMK-13561 Change-Id: I0cc32ee5984fa5bcc70fb8833933086465e3b8c4 Commit: 8efacb7ebbbd57d37b3f09be79892086f6ba4be5 https://github.com/Checkmk/checkmk/commit/8efacb7ebbbd57d37b3f09be79892086f… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/views/data_source/livestatus.py M cmk/gui/views/painter/v0/base.py Log Message: ----------- Add common base class for historic and forecast painters for metrics This allows for typing the shared functionality. CMK-13561 Change-Id: I504f3def08d6abbc98a73d310eaf3a6916d410a0 Commit: d50a4166c8c393f0c3b270d1de556cd36d902c8a https://github.com/Checkmk/checkmk/commit/d50a4166c8c393f0c3b270d1de556cd36… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Re-work functionality for handling rrd data relevant for a single metric The current implementation is conceptually wrong: Currently, we scale the rrd data right when fetching it via livestatus. This is wrong because we can only know if we should apply any scalings in the context of a service (since our metric translations are check-plugin specific). Example: Let's say we want historic values for the metric mem_total. Outside the service context, we cannot know whether or not we should scale this metric by 1024**2 (Windows: yes, Linux: no). This issue affects certain painters and the single-metric dashlets. (though most of the latter, namely the ones where the host and service are fixed, could be re-implemented to completely avoid this issue, which is however outside the scope of this change). Note that eg. service graphs are not affected, because we are in the context of a service when rendering them. This change leads to some duplicated code, however, this simplifies the review. In the following commit, we will switch from the old to the new functionality and then remove the old code. CMK-13561 Change-Id: I0e177242d58c4d39e268db37c4c42df37bfec9a9 Commit: dff821f32a1f75ad6b3f5aefaff65849c425d816 https://github.com/Checkmk/checkmk/commit/dff821f32a1f75ad6b3f5aefaff65849c… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: A .werks/15854 Log Message: ----------- 15854 FIX Fix metric scaling issues in views and dashboards CMK-13555 CMK-13561 Change-Id: I12e04ceec103b6d2c3b06c447ec0a5cffdae7be9 Commit: 254a3db36028d578f37c28982abbaf54e15eac53 https://github.com/Checkmk/checkmk/commit/254a3db36028d578f37c28982abbaf54e… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Remove now unused code Change-Id: Id9670ca97b3408ee137eeda94398b63f17e5b2e1 Compare: https://github.com/Checkmk/checkmk/compare/e94c30aa8760...254a3db36028

1 year, 3 months

[Checkmk/checkmk] e94c30: 15682 FIX Hosts that should be monitored do not ha...

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: e94c30aa8760daf72a16cd70edb6672baaa4b3ac https://github.com/Checkmk/checkmk/commit/e94c30aa8760daf72a16cd70edb6672ba… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: A .werks/15682 M cmk/gui/fields/definitions.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_downtime.py Log Message: ----------- 15682 FIX Hosts that should be monitored do not have to exist ...as hosts can "live" on remote sites. Then the host does not exist (on the local site) but they are still monitored (by the remote site) This broke the get_metric endpoint for hosts "living" on remote sites. Change-Id: I45025eb6cf9cd31477351ebb2a04c91d76f90f36

1 year, 3 months

[Checkmk/checkmk] 8b8d74: Some typing improvements

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 8b8d74de10bd786cd41e7a756400f76440b83523 https://github.com/Checkmk/checkmk/commit/8b8d74de10bd786cd41e7a756400f7644… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/timeseries.py M cmk/utils/prediction.py M tests/unit/cmk/utils/test_prediction_commons.py Log Message: ----------- Some typing improvements CMK-13561 Change-Id: I8a7757cfc9008c45f495b58c65302563550ee917 Commit: 8856aa8c4e41ada08277a96fea50fc03cf0a819d https://github.com/Checkmk/checkmk/commit/8856aa8c4e41ada08277a96fea50fc03c… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/views/data_source/livestatus.py M cmk/gui/views/painter/v0/base.py Log Message: ----------- Add common base class for historic and forecast painters for metrics This allows for typing the shared functionality. CMK-13561 Change-Id: I504f3def08d6abbc98a73d310eaf3a6916d410a0 Commit: 3ae74c2299b90b4f464253cfd2b40932de7a53f7 https://github.com/Checkmk/checkmk/commit/3ae74c2299b90b4f464253cfd2b40932d… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Re-work functionality for handling rrd data relevant for a single metric The current implementation is conceptually wrong: Currently, we scale the rrd data right when fetching it via livestatus. This is wrong because we can only know if we should apply any scalings in the context of a service (since our metric translations are check-plugin specific). Example: Let's say we want historic values for the metric mem_total. Outside the service context, we cannot know whether or not we should scale this metric by 1024**2 (Windows: yes, Linux: no). This issue affects certain painters and the single-metric dashlets. (though most of the latter, namely the ones where the host and service are fixed, could be re-implemented to completely avoid this issue, which is however outside the scope of this change). Note that eg. service graphs are not affected, because we are in the context of a service when rendering them. This change leads to some duplicated code, however, this simplifies the review. In the following commit, we will switch from the old to the new functionality and then remove the old code. CMK-13561 Change-Id: I0e177242d58c4d39e268db37c4c42df37bfec9a9 Commit: c818478b2af179130cba19f1a182aab04d09efc7 https://github.com/Checkmk/checkmk/commit/c818478b2af179130cba19f1a182aab04… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: A .werks/15854 Log Message: ----------- 15854 FIX Fix metric scaling issues in views and dashboards CMK-13555 CMK-13561 Change-Id: I12e04ceec103b6d2c3b06c447ec0a5cffdae7be9 Commit: 33feb1a9ed28d6140f15014f2a5f18188b16872b https://github.com/Checkmk/checkmk/commit/33feb1a9ed28d6140f15014f2a5f18188… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Remove now unused code Change-Id: Id9670ca97b3408ee137eeda94398b63f17e5b2e1 Commit: 1b0e154df96ebc3ca7d4875db4c2ac8afcb57484 https://github.com/Checkmk/checkmk/commit/1b0e154df96ebc3ca7d4875db4c2ac8af… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: R cmk/utils/memoize.py M tests/code_quality/test_werks.py R tests/unit/cmk/utils/test_memoize.py Log Message: ----------- Replace cmk.utils.memoize.MemoizeCache -> functools.lru_cache Also remove the former. Change-Id: I4251983aa1aff23659d2e4051999723c1cf67815 Compare: https://github.com/Checkmk/checkmk/compare/1629face7e6c...1b0e154df96e

1 year, 3 months

[Checkmk/checkmk] 1629fa: 15682 FIX Hosts that should be monitored do not ha...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 1629face7e6ca017f57692914373e14b000cfc16 https://github.com/Checkmk/checkmk/commit/1629face7e6ca017f57692914373e14b0… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: A .werks/15682 M cmk/gui/fields/definitions.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_downtime.py Log Message: ----------- 15682 FIX Hosts that should be monitored do not have to exist ...as hosts can "live" on remote sites. Then the host does not exist (on the local site) but they are still monitored (by the remote site) This broke the get_metric endpoint for hosts "living" on remote sites. Change-Id: I45025eb6cf9cd31477351ebb2a04c91d76f90f36

1 year, 3 months

[Checkmk/checkmk] fff8d5: extension packages: pass down checkmk version

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: fff8d594344ce006cb867f640bceaa9a011c1f14 https://github.com/Checkmk/checkmk/commit/fff8d594344ce006cb867f640bceaa9a0… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M bin/mkp M cmk/gui/watolib/activate_changes.py M cmk/utils/packaging/__init__.py M cmk/utils/packaging/_mkp.py M cmk/utils/packaging/cli.py M tests/unit/cmk/utils/packaging/test_packaging.py Log Message: ----------- extension packages: pass down checkmk version Try to be as clear as possible on the different meanings of 'version'. Change-Id: I81a687bbc3279366fd82a7ed4d045bfc77456226 Commit: cf18b15ed36ea67dd93e442bd7adaa3463ad16c6 https://github.com/Checkmk/checkmk/commit/cf18b15ed36ea67dd93e442bd7adaa346… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/utils/packaging/__init__.py Log Message: ----------- trivial import cleanups Change-Id: I5b8e3641d30a395d6e103dc46b90f71ea9112ee0 Compare: https://github.com/Checkmk/checkmk/compare/81531b3343df...cf18b15ed36e

1 year, 3 months

[Checkmk/checkmk] bea0c4: Login mask: New wording of pw error msgs

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: bea0c4e61e20e6ffcbf280946315e26cfc23e911 https://github.com/Checkmk/checkmk/commit/bea0c4e61e20e6ffcbf280946315e26cf… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/login.py M tests/gui_e2e/test_asvs.py Log Message: ----------- Login mask: New wording of pw error msgs CMK-13545 Change-Id: Ib9e3ccba5d50974237a40411dce083662d2c45bc

1 year, 3 months

[Checkmk/checkmk] 81531b: remove strange `\brief` from comment

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 81531b3343dfd6195b9677ed730c00ba59e813e3 https://github.com/Checkmk/checkmk/commit/81531b3343dfd6195b9677ed730c00ba5… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M agents/wnx/include/tools/_win.h M agents/wnx/src/common/cfg_info.h M agents/wnx/src/common/wtools.h M agents/wnx/src/common/wtools_service.cpp M agents/wnx/src/engine/carrier.h M agents/wnx/src/engine/cfg.h M agents/wnx/src/engine/cfg_details.h M agents/wnx/src/engine/cma_core.h M agents/wnx/src/engine/eventlog/eventlogbase.h M agents/wnx/src/engine/install_api.cpp M agents/wnx/src/engine/logger.h M agents/wnx/src/engine/modules.cpp M agents/wnx/src/engine/modules.h M agents/wnx/src/engine/providers/check_mk.h M agents/wnx/src/engine/service_processor.cpp M agents/wnx/src/engine/service_processor.h M agents/wnx/src/lwa/Configuration.cpp M agents/wnx/watest/test-cap.cpp M agents/wnx/watest/test-section_fileinfo.cpp M agents/wnx/watest/test-section_logwatchevent.cpp M agents/wnx/watest/test_tools.h Log Message: ----------- remove strange `\brief` from comment Change-Id: I962d4ece1c3e58eb3856d8113b81adedfbafc158

1 year, 3 months

[Checkmk/checkmk] f25b32: Extract collection related staticmethod from Folder

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: f25b3260642f87f31e68f8a82fc4ac9c36d6e1f4 https://github.com/Checkmk/checkmk/commit/f25b3260642f87f31e68f8a82fc4ac9c3… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/autocompleters.py M cmk/gui/fields/definitions.py M cmk/gui/plugins/openapi/endpoints/folder_config.py M cmk/gui/plugins/openapi/endpoints/host_config.py M cmk/gui/plugins/sidebar/virtual_host_tree.py M cmk/gui/plugins/sidebar/wato.py M cmk/gui/plugins/visuals/wato.py M cmk/gui/plugins/wato/bi_valuespecs.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/folders.py M cmk/gui/wato/pages/parentscan.py M cmk/gui/wato/pages/predefined_conditions.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/services.py M cmk/gui/wato/pages/sites.py M cmk/gui/wato/pages/tags.py M cmk/gui/watolib/_host_attributes.py M cmk/gui/watolib/automatic_host_removal.py M cmk/gui/watolib/bulk_discovery.py M cmk/gui/watolib/custom_attributes.py M cmk/gui/watolib/groups.py M cmk/gui/watolib/host_rename.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/network_scan.py M cmk/gui/watolib/rulesets.py M cmk/gui/watolib/sample_config.py M cmk/gui/watolib/sites.py M cmk/gui/watolib/tags.py M cmk/post_rename_site/plugins/actions/hosts_and_folders.py M cmk/update_config/plugins/actions/unused_host_attributes.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py M tests/unit/cmk/gui/watolib/test_automatic_host_removal.py M tests/unit/cmk/gui/watolib/test_gui_rulesets.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py M tests/unit/cmk/gui/watolib/test_services.py M tests/unit/cmk/gui/watolib/test_watolib_search.py M tests/unit/cmk/post_rename_site/plugins/actions/test_hosts_and_folders_action.py Log Message: ----------- Extract collection related staticmethod from Folder The folders, used to organize hosts, are represented in a tree. So far the logic for interfacing with the tree was implemented as staticmethods on the Folder class. Together with all the other code in the Folder class this created a hard to understand mess. This change now extracts these functions in order to separate the code for managing a tree of folders. It's still far from ideal. The state was previously held in a request global which we also need to do now to not end up with a huge change. In subsequent steps it might make sense to propagate the FolderTree object through the application. However, the goal for now is to simplify the Folder class by extracting functionality from it. Change-Id: Ie6651aaede27f02e87532a41680320c1ec5f4ac0 Commit: 059bb96562da52a31ee67d32c462eafc6e02bea3 https://github.com/Checkmk/checkmk/commit/059bb96562da52a31ee67d32c462eafc6… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/plugins/wato/utils/context_buttons.py M cmk/gui/wato/pages/bulk_discovery.py M cmk/gui/wato/pages/bulk_edit.py M cmk/gui/wato/pages/bulk_import.py M cmk/gui/wato/pages/fetch_agent_output.py M cmk/gui/wato/pages/folders.py M cmk/gui/wato/pages/host_diagnose.py M cmk/gui/wato/pages/host_rename.py M cmk/gui/wato/pages/hosts.py M cmk/gui/wato/pages/object_parameters.py M cmk/gui/wato/pages/parentscan.py M cmk/gui/wato/pages/pattern_editor.py M cmk/gui/wato/pages/random_hosts.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/search.py M cmk/gui/wato/pages/services.py M cmk/gui/watolib/bulk_discovery.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/rulesets.py Log Message: ----------- Extract current request related staticmethod from Folder The typing of folder_from_request is currently broken, because it can return other types than reported. This will be fixed in a follow up change. Change-Id: I87e06e466572e5513b55ae7da79434c0efbcb51d Compare: https://github.com/Checkmk/checkmk/compare/ca558b0aee57...059bb96562da

1 year, 3 months

[Checkmk/checkmk] 676e4c: make hierarchy Plugins correct

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 676e4cc5bf0ad6a2623d6ad655f352f8093a9f2e https://github.com/Checkmk/checkmk/commit/676e4cc5bf0ad6a2623d6ad655f352f80… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M agents/wnx/src/engine/providers/plugins.cpp M agents/wnx/src/engine/providers/plugins.h Log Message: ----------- make hierarchy Plugins correct Change-Id: I2f7b231643f2bf1896680023c7a2447d1e395090 Commit: 3cd86e73f3aebfe4f3700046649e3201fb3d8c0b https://github.com/Checkmk/checkmk/commit/3cd86e73f3aebfe4f3700046649e3201f… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M packages/livestatus/include/livestatus/LogEntry.h M packages/livestatus/src/LogEntry.cc Log Message: ----------- remove unnecessary clang-tidy suppressions Change-Id: I72e7df12d6fcfbfccd90475e7a0a670219cba568 Commit: ca558b0aee5775183412ab216938c9da463816b0 https://github.com/Checkmk/checkmk/commit/ca558b0aee5775183412ab216938c9da4… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M agents/wnx/src/common/wtools.cpp M agents/wnx/src/common/wtools.h M agents/wnx/watest/test-wtools_runas.cpp Log Message: ----------- refactor Windows agent wtools and corresponding testing code Change-Id: I7cd5348e8c826503ef4315f730e9d0921482ae22 Compare: https://github.com/Checkmk/checkmk/compare/c8bff7b926ae...ca558b0aee57

1 year, 3 months

[Checkmk/checkmk] c8bff7: Move test-site setup to a pytest fixture in plugin...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: c8bff7b926aec5796c9e56bdaf1828e716c9229e https://github.com/Checkmk/checkmk/commit/c8bff7b926aec5796c9e56bdaf1828e71… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M tests/plugins_integration/conftest.py M tests/plugins_integration/test_plugin.py Log Message: ----------- Move test-site setup to a pytest fixture in plugins test Change-Id: Id97b4d05bc1c4932ce69316d0f3a7eadf4b8c180

1 year, 3 months

← Newer
1
2
3
4
5
6
7
8
...
50
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits May 2023