Checkmk git commits April 2023

checkmk-commits@lists.checkmk.com

1 participants
433 discussions

[tribe29/checkmk] d9c563: Revert "14534 Add unit conversion support for graphs"

by anthonyh209

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: d9c563b8526e0da914439ae53c37ccc1574f6b1c https://github.com/tribe29/checkmk/commit/d9c563b8526e0da914439ae53c37ccc15… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/graph_templates.py M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/unit.py M cmk/gui/plugins/metrics/utils.py M cmk/gui/type_defs.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_graph_template.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Revert "14534 Add unit conversion support for graphs" We will instead implement this as a user setting. This reverts commit 19862e1d6840d045321e37fdff3aa044d3867feb. CMK-12958 Change-Id: I8d5616ae454b130272df6c776723b077f18730b5 Commit: 0a6ffc96cf11434fff7393a731a20e920946da7e https://github.com/tribe29/checkmk/commit/0a6ffc96cf11434fff7393a731a20e920… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/plugins/config/base.py M cmk/gui/plugins/openapi/endpoints/user_config.py M cmk/gui/plugins/openapi/restful_objects/request_schemas.py M cmk/gui/plugins/openapi/restful_objects/response_schemas.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/plugins/wato/check_parameters/temperature.py M cmk/gui/type_defs.py M cmk/gui/userdb/__init__.py M cmk/gui/userdb/user_attributes.py A cmk/gui/utils/temperate_unit.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_user.py M tests/unit/cmk/gui/test_gui_config.py M tests/unit/cmk/gui/watolib/test_watolib.py M tests/unit/cmk/update_config/plugins/actions/test_user_attributes.py Log Message: ----------- Make temperature unit configurable in user profile and global settings CMK-12958 Change-Id: I48d5c238d9d263d6273074747f9607f742e75aa2 Commit: c3707d2649cae682f4f578fd31038274b66455b5 https://github.com/tribe29/checkmk/commit/c3707d2649cae682f4f578fd31038274b… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/metrics.py M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_graph_template.py Log Message: ----------- Allow entries in unit_info to be Callables This allows for context-sensitive units, such as a user-configurable temperature unit. CMK-12958 Change-Id: I57d3ca30a9260e861c87b330631b187a18fab67b Commit: caf7a5fe23c056d80ac82850d3c8e9afa846c376 https://github.com/tribe29/checkmk/commit/caf7a5fe23c056d80ac82850d3c8e9afa… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M .werks/14534 A .werks/15660 M cmk/gui/plugins/metrics/unit.py M tests/testlib/users.py A tests/unit/cmk/gui/plugins/metrics/test_unit.py Log Message: ----------- 15660 Temperature unit in graphs and perfometers is now user-configurable CMK-12958 Change-Id: I1aa35247a94640bb45ab4e743d239ed14051e66b Commit: fd5aac289313cb3e13ea34b02db8e165917d20d9 https://github.com/tribe29/checkmk/commit/fd5aac289313cb3e13ea34b02db8e1659… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/views/perfometer/legacy_perfometers/check_mk.py Log Message: ----------- Remove some legacy temperature perfometers For these check plugins, we checked that the legacy temperature perfometer does not apply. CMK-12958 Change-Id: I045e1a776799d5c056f0ba9bbaf1335da421f77e Commit: 28c6e9d4b7268fa9dfc486301fbf8413a44795c7 https://github.com/tribe29/checkmk/commit/28c6e9d4b7268fa9dfc486301fbf8413a… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15553 M cmk/gui/plugins/openapi/endpoints/time_periods/request_schemas.py Log Message: ----------- 15553 FIX time_period: making time-related validation more strict Prior to this werk, the REST API was quite lenient when it came to specifying a time allowing the format hh:mm for some while asking the hh:mm:ss format for others. This werk targets the active_time_ranges field where now a hh:mm:ss format is enforced. Due to the introduction of the more strict pattern, user scripts must be adjusted accordingly to respect the new format. Change-Id: I97fa4c02f6a874a0146f0fa841e7df7988cdef3e Compare: https://github.com/tribe29/checkmk/compare/28ea1a65d3c1...28c6e9d4b726

1 year, 5 months

[tribe29/checkmk] f37c3f: agent_proxmox_ve: improve error handling: handle R...

by Lisa Pichler

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: f37c3f1a13bc86c11328e86566eb7a8fc29684d0 https://github.com/tribe29/checkmk/commit/f37c3f1a13bc86c11328e86566eb7a8fc… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/special_agents/agent_proxmox_ve.py Log Message: ----------- agent_proxmox_ve: improve error handling: handle ReadTimeout avoiding a crash report Change-Id: Ic524b8e96149769e12b64b442cb0f34edc2cfec2 Commit: f1c40e3eb07c8a62598ea835e70e6e0a575e4d08 https://github.com/tribe29/checkmk/commit/f1c40e3eb07c8a62598ea835e70e6e0a5… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/special_agents/agent_proxmox_ve.py Log Message: ----------- agent_proxmox_ve: improve error handling: handle ConnectionError which can occur even after successful connection Change-Id: I749857d2fbf1547528d1e288eb1dcbc9eb7dd458 Commit: 2e1a33175647554173a89bbbc9c8f84964700ce0 https://github.com/tribe29/checkmk/commit/2e1a33175647554173a89bbbc9c8f8496… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/13267 M cmk/utils/mailbox.py Log Message: ----------- 13267 FIX AttributeError: 'Namespace' object has no attribute 'fetch_client_id' in check_mail and check_mail_loop Trying to hide EWS related command line arguments from check_mail and check_mail_loop active checks (which don't support EWS yet) led to exceptions being raised due to invalid access to now non-existing arguments. This change makes those arguments visible again with a hint about EWS not being available. Change-Id: I51eb7c7c2294f882f076cfd670321ed59855b61a Commit: 2813872bd638e24c9c448a935872f4046f4f4ffd https://github.com/tribe29/checkmk/commit/2813872bd638e24c9c448a935872f4046… Author: Gav <gavin.mcguigan(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15600 M cmk/gui/plugins/openapi/endpoints/contact_group_config.py M cmk/gui/plugins/openapi/endpoints/host_group_config.py M cmk/gui/plugins/openapi/endpoints/service_group_config.py M cmk/gui/plugins/openapi/endpoints/utils.py M cmk/gui/plugins/openapi/restful_objects/response_schemas.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_group_config.py Log Message: ----------- group_config: return the correct collection response for host/service/contact_group endpoints This werk introduces a fix to collection responses for host, service and contact group_config endpoints. For bulk-create and bulk-update calls, the link object in the responses did not align with the expected schema. Now we return the expected schema. CMK-12326 Change-Id: I6282212e62251e7431e37b315036bde260e57e08 Commit: 28ea1a65d3c108973d51bf7b95b63a3d4b10fad5 https://github.com/tribe29/checkmk/commit/28ea1a65d3c108973d51bf7b95b63a3d4… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/login.py M locale/de/LC_MESSAGES/multisite.po M locale/es/LC_MESSAGES/multisite.po M locale/fr/LC_MESSAGES/multisite.po M locale/it/LC_MESSAGES/multisite.po M locale/ja/LC_MESSAGES/multisite.po M locale/nl/LC_MESSAGES/multisite.po M locale/pt_PT/LC_MESSAGES/multisite.po M locale/ro/LC_MESSAGES/multisite.po Log Message: ----------- login page: remove licence note CMK-12888 Change-Id: I79e8cda75c55d10251d56a2b3ea6660a35bca84d Compare: https://github.com/tribe29/checkmk/compare/bc28a2546fc9...28ea1a65d3c1

1 year, 5 months

[tribe29/checkmk] e7665e: add some tech debt comments

by anthonyh209

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e7665e77c44ad1666404a8df7e96ca436000feae https://github.com/tribe29/checkmk/commit/e7665e77c44ad1666404a8df7e96ca436… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M doc/documentation/arch-comp-core.rst Log Message: ----------- add some tech debt comments Change-Id: Ic5ea2e03e1210de1955323ee71b92ba5fc2e31e5 Commit: 940f7e933e5f1ea803830b98c1d2e15896530247 https://github.com/tribe29/checkmk/commit/940f7e933e5f1ea803830b98c1d2e1589… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/base/agent_based/checking/_checking.py M cmk/base/agent_based/discovery/utils.py M cmk/base/api/agent_based/register/check_plugins_legacy.py M cmk/base/api/agent_based/type_defs.py M cmk/checkers/__init__.py M cmk/checkers/_api.py M tests/unit/cmk/base/api/agent_based/test_checking_classes.py M tests/unit/cmk/base/plugins/agent_based/test_domino_tasks.py M tests/unit/cmk/base/plugins/agent_based/test_livestatus_status.py Log Message: ----------- Move `Parameters` to check engine CMK-12298 Change-Id: I0ad4aa9dd91e5c7ab7adec2bf9e873e8b9429be2 Commit: 56b366b157590abe6e30fea2c547686b0f26ec9c https://github.com/tribe29/checkmk/commit/56b366b157590abe6e30fea2c547686b0… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M packages/cmk-agent-ctl/src/configuration/config.rs M packages/cmk-agent-ctl/src/modes/delete_connection.rs M packages/cmk-agent-ctl/src/modes/import_connection.rs M packages/cmk-agent-ctl/src/modes/registration.rs M packages/cmk-agent-ctl/src/modes/renew_certificate.rs Log Message: ----------- rework unit tests in controller #2 Change-Id: Iccd6c6aeee2a9beebeabb656fdcd986a430d9e62 Commit: 81551bcdc92fdf4f26b9b482b72772069bd7c167 https://github.com/tribe29/checkmk/commit/81551bcdc92fdf4f26b9b482b72772069… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/graph_templates.py M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/unit.py M cmk/gui/plugins/metrics/utils.py M cmk/gui/type_defs.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_graph_template.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Revert "14534 Add unit conversion support for graphs" We will instead implement this as a user setting. This reverts commit 19862e1d6840d045321e37fdff3aa044d3867feb. CMK-12958 Change-Id: I8d5616ae454b130272df6c776723b077f18730b5 Commit: b4c81d72fe45ba6bcef18e02ed2fe9b5607d263a https://github.com/tribe29/checkmk/commit/b4c81d72fe45ba6bcef18e02ed2fe9b56… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/plugins/config/base.py M cmk/gui/plugins/openapi/endpoints/user_config.py M cmk/gui/plugins/openapi/restful_objects/request_schemas.py M cmk/gui/plugins/openapi/restful_objects/response_schemas.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/plugins/wato/check_parameters/temperature.py M cmk/gui/type_defs.py M cmk/gui/userdb/__init__.py M cmk/gui/userdb/user_attributes.py A cmk/gui/utils/temperate_unit.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_user.py M tests/unit/cmk/gui/test_gui_config.py M tests/unit/cmk/gui/watolib/test_watolib.py M tests/unit/cmk/update_config/plugins/actions/test_user_attributes.py Log Message: ----------- Make temperature unit configurable in user profile and global settings CMK-12958 Change-Id: I48d5c238d9d263d6273074747f9607f742e75aa2 Commit: 29cee414a1717b8acf6fb2144f22968db46d00e4 https://github.com/tribe29/checkmk/commit/29cee414a1717b8acf6fb2144f22968db… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/metrics.py M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_graph_template.py Log Message: ----------- Allow entries in unit_info to be Callables This allows for context-sensitive units, such as a user-configurable temperature unit. CMK-12958 Change-Id: I57d3ca30a9260e861c87b330631b187a18fab67b Commit: 0b521ffc47a4afaea3117e3e509a023adde7704a https://github.com/tribe29/checkmk/commit/0b521ffc47a4afaea3117e3e509a023ad… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M .werks/14534 A .werks/15660 M cmk/gui/plugins/metrics/unit.py M tests/testlib/users.py A tests/unit/cmk/gui/plugins/metrics/test_unit.py Log Message: ----------- 15660 Temperature unit in graphs and perfometers is now user-configurable CMK-12958 Change-Id: I1aa35247a94640bb45ab4e743d239ed14051e66b Commit: 7b6af049e20921c5fd0d9d8014253f40ca2e75d8 https://github.com/tribe29/checkmk/commit/7b6af049e20921c5fd0d9d8014253f40c… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/views/perfometer/legacy_perfometers/check_mk.py Log Message: ----------- Remove some legacy temperature perfometers For these check plugins, we checked that the legacy temperature perfometer does not apply. CMK-12958 Change-Id: I045e1a776799d5c056f0ba9bbaf1335da421f77e Commit: cfd8160fd96ca9b0ed1ecb87d1626eaa4c4fdba6 https://github.com/tribe29/checkmk/commit/cfd8160fd96ca9b0ed1ecb87d1626eaa4… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/base/agent_based/confcheckers.py M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/agent_based/discovery/_discovery.py M cmk/base/agent_based/discovery/_host_labels.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/discovery/preview.py M cmk/base/agent_based/discovery/utils.py M cmk/base/automations/check_mk.py M cmk/base/config.py M cmk/base/modes/check_mk.py M cmk/checkers/_api.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py Log Message: ----------- Remove more ConfigCache deps from the check engine Before, we had one attribute computed very late from three other, highly-coupled, known parameters. Let's hide these implementation details and only expose the result. Now, the plugins are reduced to one function plus its parameters, that is, it's a more callback. That's easy to understand and easy to test. This patch further separates the check engine stricto sensu from the computation of the rules. CMK-12298 Change-Id: Id396f9c337bbb8417bb6bb5868cf848e023749aa Commit: 7e7d009e08b280670d521b38c4197e65c0459bf9 https://github.com/tribe29/checkmk/commit/7e7d009e08b280670d521b38c4197e65c… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15553 M cmk/gui/plugins/openapi/endpoints/time_periods/request_schemas.py Log Message: ----------- 15553 FIX time_period: making time-related validation more strict Prior to this werk, the REST API was quite lenient when it came to specifying a time allowing the format hh:mm for some while asking the hh:mm:ss format for others. This werk targets the active_time_ranges field where now a hh:mm:ss format is enforced. Due to the introduction of the more strict pattern, user scripts must be adjusted accordingly to respect the new format. Change-Id: I97fa4c02f6a874a0146f0fa841e7df7988cdef3e Compare: https://github.com/tribe29/checkmk/compare/9c76bf4b396f...7e7d009e08b2

1 year, 5 months

[tribe29/checkmk] 5f1c19: 13266 FIX Wrong password propagation for check_mai...

by Frans Fürst

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 5f1c19a23772f7bfec1d798383c8d9940f8f55eb https://github.com/tribe29/checkmk/commit/5f1c19a23772f7bfec1d798383c8d9940… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/13266 M checks/check_mail M checks/check_mail_loop M tests/unit/checks/test_check_mail.py M tests/unit/checks/test_check_mail_loop.py Log Message: ----------- 13266 FIX Wrong password propagation for check_mail and check_mail_loop A new authentication data format shared among check_mail* active checks was not properly handled by check_mail and check_mail_loop argument generators, resulting in messages like WARNING: The stored password "('password', '<SOME_PASSWORD>')" used by service "<SERVICE-NAME>" on host "<HOST-NAME>" does not exist (anymore) This change applies these missing changes to the command line generators as already done in v2.2.0+ Change-Id: If329c6a9e85a6c3142aa44e285f253b6dc01eab8 Commit: 45c6dab3965d18abd55fcacea8d0b978bc5c20d7 https://github.com/tribe29/checkmk/commit/45c6dab3965d18abd55fcacea8d0b978b… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/13267 M cmk/utils/mailbox.py Log Message: ----------- 13267 FIX AttributeError: 'Namespace' object has no attribute 'fetch_client_id' in check_mail and check_mail_loop Trying to hide EWS related command line arguments from check_mail and check_mail_loop active checks (which don't support EWS yet) led to exceptions being raised due to invalid access to now non-existing arguments. This change makes those arguments visible again with a hint about EWS not being available. Change-Id: I51eb7c7c2294f882f076cfd670321ed59855b61a Compare: https://github.com/tribe29/checkmk/compare/1a431ce80204...45c6dab3965d

1 year, 5 months

[tribe29/checkmk] bc28a2: metrics/kube: group cron_job_status duration metri...

by anthonyh209

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: bc28a2546fc95d547554593dde19fa8b040f770b https://github.com/tribe29/checkmk/commit/bc28a2546fc95d547554593dde19fa8b0… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/kube.py Log Message: ----------- metrics/kube: group cron_job_status duration metrics to graph Change-Id: I2b48ab580644bf09fe924b5f8cd007be7289d3e1

1 year, 5 months

[tribe29/checkmk] 522dc8: discovery: Remove useless indirections

by Lisa Pichler

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 522dc8694416234ae81245d751291ec8e72cd7a1 https://github.com/tribe29/checkmk/commit/522dc8694416234ae81245d751291ec8e… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/agent_based/discovery/_host_labels.py R cmk/base/agent_based/discovery/_parameters.py M cmk/base/agent_based/discovery/utils.py Log Message: ----------- discovery: Remove useless indirections `get_discovery_parameters` and `get_host_label_parameters` only forwarded there arguments to `get_plugin_parameters`. Let's call this last function directly. CMK-12298 Change-Id: Ia0ef6c6afb4b5f2cdfb7ec52d5b7ebfbbea85fe8 Commit: 4de86e811db665d5fd9fb488516cecab932de468 https://github.com/tribe29/checkmk/commit/4de86e811db665d5fd9fb488516cecab9… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/base/agent_based/confcheckers.py M cmk/base/agent_based/discovery/_discovery.py M cmk/base/agent_based/discovery/_host_labels.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/discovery/preview.py M cmk/checkers/__init__.py M cmk/checkers/_api.py Log Message: ----------- host label plugins: nominal typing - nominal typing: This let's us perform some impedance-mismatch the interface. It would also be nice if, at some point, we had a generic plugin interface that's common to discovery, checking, host labels, and inventory. But then, structural typing wouldn't work very well anymore. - get rid of pseudo-namespace: This isn't C. CMK-12298 Change-Id: I7484405daae231ff7ca9a9cd510345ac23f86396 Commit: 3a56a41f2a238c241215de3b961e3640f2c923e0 https://github.com/tribe29/checkmk/commit/3a56a41f2a238c241215de3b961e3640f… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/base/agent_based/confcheckers.py M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/agent_based/discovery/_discovery.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/discovery/preview.py M cmk/base/config.py M cmk/checkers/__init__.py M cmk/checkers/_api.py M tests/unit/cmk/base/test_config.py Log Message: ----------- discovery plugins: nominal typing CMK-12298 Change-Id: I1f1575af814845c73897872eda6d28c7b8550967 Commit: 2a9a4da8162aaac74782736a42abc8409329faa3 https://github.com/tribe29/checkmk/commit/2a9a4da8162aaac74782736a42abc8409… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M tests/unit/cmk/base/plugins/agent_based/test_aws_status.py Log Message: ----------- Disabled broken test. Change-Id: I7182ade1225f70acbd7b9e06ab044e922e4e2c0d Commit: 16c7e5d4cf897ad54bac234ccee8408f0f0c8e1d https://github.com/tribe29/checkmk/commit/16c7e5d4cf897ad54bac234ccee8408f0… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M packages/cmk-agent-ctl/tests/test_pull.rs Log Message: ----------- add delay for windows to close socket before reconnect attempt - add custom message for flackiness diag Change-Id: I8da71a1057e43c466b511affe414fe42e0f9157d Commit: 865cf5d5e40f4ab3e16c62ac83b3ef1fbb34b571 https://github.com/tribe29/checkmk/commit/865cf5d5e40f4ab3e16c62ac83b3ef1fb… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M packages/cmk-agent-ctl/src/configuration/config.rs M packages/cmk-agent-ctl/src/modes/delete_connection.rs M packages/cmk-agent-ctl/src/modes/import_connection.rs M packages/cmk-agent-ctl/src/modes/registration.rs M packages/cmk-agent-ctl/src/modes/renew_certificate.rs M packages/cmk-agent-ctl/src/modes/status.rs Log Message: ----------- rework unit tests in controller #1 setup functionality moved to TestRegistry with a `build` pattern. Change-Id: Ib2c95ff18e9753ddc886ee94e9db0c75b193301d Commit: c5e2e2b7f2dce5483ec86aa33bffeee98dd33016 https://github.com/tribe29/checkmk/commit/c5e2e2b7f2dce5483ec86aa33bffeee98… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/13267 M cmk/utils/mailbox.py Log Message: ----------- 13267 FIX AttributeError: 'Namespace' object has no attribute 'fetch_client_id' in check_mail and check_mail_loop Trying to hide EWS related command line arguments from check_mail and check_mail_loop active checks (which don't support EWS yet) led to exceptions being raised due to invalid access to now non-existing arguments. This change makes those arguments visible again with a hint about EWS not being available. Change-Id: I51eb7c7c2294f882f076cfd670321ed59855b61a Commit: b0c832edc89d8074889537899a7edaa80eef7c10 https://github.com/tribe29/checkmk/commit/b0c832edc89d8074889537899a7edaa80… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/special_agents/agent_proxmox_ve.py Log Message: ----------- agent_proxmox_ve: improve error handling: handle ConnectionError which can occur even after successful connection Change-Id: I749857d2fbf1547528d1e288eb1dcbc9eb7dd458 Commit: 7db8eca7b038775b2b7379b4c75ce14ff216eb74 https://github.com/tribe29/checkmk/commit/7db8eca7b038775b2b7379b4c75ce14ff… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M scripts/run-bazel-build.sh Log Message: ----------- Print Bazel version before each build Change-Id: I477696c5439bf5cabce8bef1a21892c079fd7aea Commit: 4193522a2449704a27a246a4838598f3815b6212 https://github.com/tribe29/checkmk/commit/4193522a2449704a27a246a4838598f38… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15450 M agents/mk-job M agents/mk-job.aix M agents/mk-job.solaris M cmk/base/plugins/agent_based/job.py M tests/unit/cmk/base/plugins/agent_based/test_job.py Log Message: ----------- 15450 FIX mk-job: improvements to state file persistence - address race conditions due to non-atomic file operations - start removing complexity due to trivial string manipulation Change-Id: I787cfefa8016799604a48d53dba942f2597f0cf5 Commit: 9c76bf4b396f235ff16939d3fc0b7a46bed623b5 https://github.com/tribe29/checkmk/commit/9c76bf4b396f235ff16939d3fc0b7a46b… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15666 M agents/mk-job.solaris Log Message: ----------- 15666 FIX mk-job.solaris: do not add artificial metrics Change-Id: I4213dd965c9ca48597d906c35be5c728ccd968dc Compare: https://github.com/tribe29/checkmk/compare/bc397ec05071...9c76bf4b396f

1 year, 5 months

[tribe29/checkmk] d70f30: 14954 FIX Windows tasks plugin ignores only tasks ...

by scolakovic

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: d70f3067748259f8d149a008fe4585a19b4e04e5 https://github.com/tribe29/checkmk/commit/d70f3067748259f8d149a008fe4585a19… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/14954 M agents/windows/plugins/windows_tasks.ps1 Log Message: ----------- 14954 FIX Windows tasks plugin ignores only tasks from the Microsoft folder As a result of the change, the user will see some important, critical tasks, such as "Windows Edge update" task. Otherwise, the behavior of the plugin is the same: tasks related to internal processing of Microsoft applications will be ignored. Change-Id: I09a719b30224401fb21139514561fd41b4b79545 Commit: 56b2159a8b8df520a3e01845320001f8762feb10 https://github.com/tribe29/checkmk/commit/56b2159a8b8df520a3e01845320001f87… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M checkman/systemtime M cmk/gui/plugins/wato/check_parameters/systemtime.py Log Message: ----------- fix systemtime description - supports not only Windows host, but ESX CMK-4881 Change-Id: I20aa98ba5219c935fa63ee0693654f4f8f021dde Commit: 1a431ce802043b500de0645cfcf99e6a25255487 https://github.com/tribe29/checkmk/commit/1a431ce802043b500de0645cfcf99e6a2… Author: Sofia Colakovic <sofia.colakovic(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15463 M agents/cfg_examples/filestats.cfg M agents/plugins/mk_filestats.py Log Message: ----------- FIX 15463 mk_filestats: Make combination of file grouping and single file aggregation more usable This werk is incompatible for users that use file grouping and single file aggregation and have "%s" in the section name. It's now possible to define a name containing "%s" in both section and group names when using single file aggregation. In that case, the services of files that don't belong to a group will be named "<SECTION NAME> <FILE NAME>" and the services of grouped files "<SECTION NAME> <GROUP NAME> <FILE NAME>". CMK-12778 Change-Id: I7f523851cd5e3214ee087bb2a34962789c5a97f7 Compare: https://github.com/tribe29/checkmk/compare/69078151d718...1a431ce80204

1 year, 5 months

[tribe29/checkmk] beac93: 14954 FIX Windows tasks plugin ignores only tasks ...

by anthonyh209

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: beac939d25bf83f39cdbb05bc50a7104c3a5381e https://github.com/tribe29/checkmk/commit/beac939d25bf83f39cdbb05bc50a7104c… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/14954 M agents/windows/plugins/windows_tasks.ps1 Log Message: ----------- 14954 FIX Windows tasks plugin ignores only tasks from the Microsoft folder As a result of the change, the user will see some important, critical tasks, such as "Windows Edge update" task. Otherwise, the behavior of the plugin is the same: tasks related to internal processing of Microsoft applications will be ignored. Change-Id: I09a719b30224401fb21139514561fd41b4b79545 Commit: 55acdd776ec7d5c4c3bdf1e511c73e97913624b2 https://github.com/tribe29/checkmk/commit/55acdd776ec7d5c4c3bdf1e511c73e979… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M checkman/systemtime M cmk/gui/plugins/wato/check_parameters/systemtime.py Log Message: ----------- fix systemtime description - supports not only Windows host, but ESX CMK-4881 Change-Id: I20aa98ba5219c935fa63ee0693654f4f8f021dde Commit: a7942062ac4d83f6d7dba9a8f2b1bfd0b8ea53b3 https://github.com/tribe29/checkmk/commit/a7942062ac4d83f6d7dba9a8f2b1bfd0b… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/plugins/openapi/restful_objects/parameters.py Log Message: ----------- restful_objects/parameters: make 'GROUP_NAME_FIELD' description more explicit Change-Id: I73c93285701261527e91ebe11343e1622ab1f88f (cherry picked from commit b3db417ba2b6c1217b0ca5bd07b45b8a5f1b7fd8) Compare: https://github.com/tribe29/checkmk/compare/01d9581baf95...a7942062ac4d

1 year, 5 months

[tribe29/checkmk] 72a379: 14954 FIX Windows tasks plugin ignores only tasks ...

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 72a3796eeb11a369856bb7b84d3d6597f696a04b https://github.com/tribe29/checkmk/commit/72a3796eeb11a369856bb7b84d3d6597f… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/14954 M agents/windows/plugins/windows_tasks.ps1 Log Message: ----------- 14954 FIX Windows tasks plugin ignores only tasks from the Microsoft folder As a result of the change, the user will see some important, critical tasks, such as "Windows Edge update" task. Otherwise, the behavior of the plugin is the same: tasks related to internal processing of Microsoft applications will be ignored. Change-Id: I09a719b30224401fb21139514561fd41b4b79545 Commit: 0a4d09408094c7e02a8c15476889153e84c55310 https://github.com/tribe29/checkmk/commit/0a4d09408094c7e02a8c15476889153e8… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M checkman/systemtime M cmk/gui/plugins/wato/check_parameters/systemtime.py Log Message: ----------- fix systemtime description - supports not only Windows host, but ESX CMK-4881 Change-Id: I20aa98ba5219c935fa63ee0693654f4f8f021dde Commit: 0adbcbac944b8eab9754bd095cdc80b8a18db5ad https://github.com/tribe29/checkmk/commit/0adbcbac944b8eab9754bd095cdc80b8a… Author: Gav <gavin.mcguigan(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15600 M cmk/gui/plugins/openapi/endpoints/contact_group_config.py M cmk/gui/plugins/openapi/endpoints/host_group_config.py M cmk/gui/plugins/openapi/endpoints/service_group_config.py M cmk/gui/plugins/openapi/endpoints/utils.py M cmk/gui/plugins/openapi/restful_objects/response_schemas.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_group_config.py Log Message: ----------- group_config: return the correct collection response for host/service/contact_group endpoints This werk introduces a fix to collection responses for host, service and contact group_config endpoints. For bulk-create and bulk-update calls, the link object in the responses did not align with the expected schema. Now we return the expected schema. CMK-12326 Change-Id: I6282212e62251e7431e37b315036bde260e57e08 Commit: 768387a9925201d1b55167d4624daa3324000977 https://github.com/tribe29/checkmk/commit/768387a9925201d1b55167d4624daa332… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/plugins/openapi/restful_objects/parameters.py Log Message: ----------- restful_objects/parameters: make 'GROUP_NAME_FIELD' description more explicit Change-Id: I73c93285701261527e91ebe11343e1622ab1f88f Commit: cdf4b60714c0480d39c4e5e8392838586431384a https://github.com/tribe29/checkmk/commit/cdf4b60714c0480d39c4e5e8392838586… Author: Mazen Alkatlabee <mazen.alkatlabee(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M tsconfig.strict.json M web/htdocs/js/modules/activation.ts Log Message: ----------- add types to activation.ts Change-Id: I4147af52eee98016dc5cea3f63b81712bfb622a0 Commit: 958184ce92caac22df984614473edc3281b4ea17 https://github.com/tribe29/checkmk/commit/958184ce92caac22df984614473edc328… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/login.py M locale/de/LC_MESSAGES/multisite.po M locale/es/LC_MESSAGES/multisite.po M locale/fr/LC_MESSAGES/multisite.po M locale/it/LC_MESSAGES/multisite.po M locale/ja/LC_MESSAGES/multisite.po M locale/nl/LC_MESSAGES/multisite.po M locale/pt_PT/LC_MESSAGES/multisite.po M locale/ro/LC_MESSAGES/multisite.po Log Message: ----------- login page: remove licence note CMK-12888 Change-Id: I79e8cda75c55d10251d56a2b3ea6660a35bca84d Commit: eb631c9950e1060e6d9086418ccecc92834c4d46 https://github.com/tribe29/checkmk/commit/eb631c9950e1060e6d9086418ccecc928… Author: Konstantin Baikov <konstantin.baikov(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/mkeventd/wato.py M tests/unit/cmk/gui/mkeventd/test_wato.py Log Message: ----------- Add more types to EC Change-Id: Ic2777e38404245cd941570459373c5c71cf591f7 Commit: 8d12f40d643fcd602d1ce65a01a5e94796d659b2 https://github.com/tribe29/checkmk/commit/8d12f40d643fcd602d1ce65a01a5e9479… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/kube.py Log Message: ----------- metrics/kube: group cron_job_status duration metrics to graph Change-Id: I2b48ab580644bf09fe924b5f8cd007be7289d3e1 Commit: ac5621b452fb0271ece9356c9fb5c157e3b5cd89 https://github.com/tribe29/checkmk/commit/ac5621b452fb0271ece9356c9fb5c157e… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M tests/unit/cmk/base/api/agent_based/test_render_api.py Log Message: ----------- Nuked incorrectly typed test cases. Change-Id: Ib9563acacd81dd17914e1b0d5c85a0a036144f0a Commit: c0a95f28650a55b479a5f6116134a0b2734c6904 https://github.com/tribe29/checkmk/commit/c0a95f28650a55b479a5f6116134a0b27… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M tests/unit/cmk/base/api/agent_based/test_render_api.py M tests/unit/cmk/base/plugins/agent_based/test_livestatus_status.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_backup.py Log Message: ----------- Fixed various time zone problems. Change-Id: I7e926bd02d28de15b6bcd793e4419fe47b91f3a8 Commit: bc397ec05071c36c5741e96fb875f38fefd7cec3 https://github.com/tribe29/checkmk/commit/bc397ec05071c36c5741e96fb875f38fe… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M tests/Makefile Log Message: ----------- Randomize time zone in unit tests. If a test depends on the local time zone, something is wrong... Change-Id: I51f5dfb0e1c0a992e3cc1752124896c3f67cd62c Compare: https://github.com/tribe29/checkmk/compare/47281e80e1a3...bc397ec05071

1 year, 5 months

[tribe29/checkmk] fec3d6: FIX 15463 mk_filestats: Make combination of file g...

by Lars

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: fec3d693ce2510ff81b39af8701c0f343c7f495a https://github.com/tribe29/checkmk/commit/fec3d693ce2510ff81b39af8701c0f343… Author: Sofia Colakovic <sofia.colakovic(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15463 M agents/cfg_examples/filestats.cfg M agents/plugins/mk_filestats.py Log Message: ----------- FIX 15463 mk_filestats: Make combination of file grouping and single file aggregation more usable This werk is incompatible for users that use file grouping and single file aggregation and have "%s" in the section name. It's now possible to define a name containing "%s" in both section and group names when using single file aggregation. In that case, the services of files that don't belong to a group will be named "<SECTION NAME> <FILE NAME>" and the services of grouped files "<SECTION NAME> <GROUP NAME> <FILE NAME>". CMK-12778 Change-Id: I7f523851cd5e3214ee087bb2a34962789c5a97f7 Commit: 5c72a8971593239f9dc0b4869cf869cbb3242d4f https://github.com/tribe29/checkmk/commit/5c72a8971593239f9dc0b4869cf869cbb… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/update_config/main.py Log Message: ----------- Improve output of cmk-update-config Change-Id: I86d27ce0f14bb134f05372afed4da81e4c32adef Commit: 01d9581baf95d09acd0482fff3e8f4f279f1b0f8 https://github.com/tribe29/checkmk/commit/01d9581baf95d09acd0482fff3e8f4f27… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- omd helper scripts: Process stdout and stderr as pty This enables the subprocesses, like cmk-update-config, to provide colored output using tty control characters. Change-Id: Ibfb3514367eed8cdbab4d3ec618d2ab9a0c8212f Compare: https://github.com/tribe29/checkmk/compare/8488978077ec...01d9581baf95

1 year, 5 months

← Newer
1
...
20
21
22
23
24
25
26
...
44
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits April 2023