Branch: refs/heads/2.2.0
Home: https://github.com/tribe29/checkmk
Commit: 4abc9e37d74199ebefb76e27b994348a7cf42296
https://github.com/tribe29/checkmk/commit/4abc9e37d74199ebefb76e27b994348a7…
Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M agents/wnx/build_release.cmd
M agents/wnx/msb.ps1
M buildscripts/scripts/utils/windows.groovy
R packages/cmk-agent-ctl/cargo_build.cmd
A packages/cmk-agent-ctl/run.cmd
M packages/cmk-agent-ctl/scripts/cargo_build_core.cmd
M packages/cmk-agent-ctl/scripts/shorten_dir_and_call.ps1
Log Message:
-----------
unify build scripts
Windows run.cmd is similar to Linux run
2.2.0
Change-Id: I0ca865a42dd506b6315da2ba9250647cfae76221
Commit: 65765d206622a875a3c26cfc2d6b037ad7d186dd
https://github.com/tribe29/checkmk/commit/65765d206622a875a3c26cfc2d6b037ad…
Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_INST_BLOCKED_regression.py
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_INST_NO_BLOCKED_regression.py
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_NO_INST_BLOCKED_regression.py
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_NO_INST_NO_BLOCKED_regression.py
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_clustered.py
A tests/unit/cmk/base/plugins/agent_based/test_mssql_blocked_sessions.py
Log Message:
-----------
Prepare migration of mssql_blocked_sessions
add tests
Change-Id: I9df20dd717661433965cda725dae8cb63110f46b
Commit: 9cb0127df5b17076072642961e073d8223c0fd0b
https://github.com/tribe29/checkmk/commit/9cb0127df5b17076072642961e073d822…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M checks/mssql_blocked_sessions
Log Message:
-----------
replace collections NamedTuple
Change-Id: I5f25a9a9949e7aa102e3d0b40ee52b911938d9c1
Commit: 6cd17283ca5829576e363c833e1ceaac7b3507c2
https://github.com/tribe29/checkmk/commit/6cd17283ca5829576e363c833e1ceaac7…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M checks/mssql_blocked_sessions
Log Message:
-----------
add some type annotations
Change-Id: I5f56ffdc03582d9be91b4fffa345f3ac03a6edb3
Commit: 542bfbb3ba7cab8f81b46a92c55e105fbe3c5c28
https://github.com/tribe29/checkmk/commit/542bfbb3ba7cab8f81b46a92c55e105fb…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M checkman/mssql_blocked_sessions
R checks/mssql_blocked_sessions
M cmk/base/api/agent_based/clusterize.py
A cmk/base/plugins/agent_based/mssql_blocked_sessions.py
M tests/unit/checks/test_generic_legacy_conversion.py
M tests/unit/cmk/base/plugins/agent_based/test_mssql_blocked_sessions.py
Log Message:
-----------
Migrate mssql_blocked_sessions to new check api
Change-Id: I2d28a27f0e73445a16cac0ce5705a2bb10e5a976
Commit: 8c0df67025570f87130b3b4508ac87a3c1d6a5c6
https://github.com/tribe29/checkmk/commit/8c0df67025570f87130b3b4508ac87a3c…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M cmk/base/plugins/agent_based/mssql_blocked_sessions.py
Log Message:
-----------
drop useless comment
Change-Id: I95a86d65190c9e81ed8f32e9387892c7db0df459
Commit: 58961062a79109d52fb5ee40356cc8fb6c39c00e
https://github.com/tribe29/checkmk/commit/58961062a79109d52fb5ee40356cc8fb6…
Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
A .werks/15281
M cmk/base/plugins/agent_based/mssql_blocked_sessions.py
M cmk/gui/plugins/wato/check_parameters/mssql_instance_blocked_sessions.py
M tests/unit/cmk/base/plugins/agent_based/test_mssql_blocked_sessions.py
Log Message:
-----------
15281 FIX mssql_blocked_sessions: Levels now overwrite state
The inline-help of the parameter "Levels for wait" of the rule "MSSQL
Blocked Sessions" mentions:
"The thresholds for wait_duration_ms. Will overwrite the default state
set above."
This was not right. If only the levels were set, the check would go to
CRIT regardless of the wait_duration_ms.
After setting "Levels for wait" all sessions that wait for a shorter
duration than the warning level of "Levels for wait" will not affect the
check result. The check result is then controlled by wait_duration_ms
being greater than the levels defined.
If "Levels for wait" is not set (the default), the behaviour is not
altered.
SUP-13208
Change-Id: I16e557e2319ba99eefb1a982b243883d8f64e0fd
Commit: 951cd21a6ea9f495d6b5a860975ea871accf35ca
https://github.com/tribe29/checkmk/commit/951cd21a6ea9f495d6b5a860975ea871a…
Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M .werks/15421
Log Message:
-----------
agent deployment: Handle missing signatures from central bakery
Don't handle missing signatures from the central bakery as an error
on remote site/bakery.
It's the task of the agent bakery to abort the update when missing
signatures in status response.
Change-Id: Iafd71ff9e647abe39ce79dfea282b75856adb5a3
(cherry picked from commit dd83ae1117a715e70b1f9388ea75904278be151f)
Compare: https://github.com/tribe29/checkmk/compare/61dccf5da3ad...951cd21a6ea9
Branch: refs/heads/2.2.0
Home: https://github.com/tribe29/checkmk
Commit: 61dccf5da3ad1d06836a5fac856ab8798bb7ad6c
https://github.com/tribe29/checkmk/commit/61dccf5da3ad1d06836a5fac856ab8798…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M cmk/base/plugins/agent_based/logwatch_ec.py
M cmk/gui/plugins/wato/check_parameters/logwatch_ec.py
M tests/unit/cmk/base/plugins/agent_based/test_logwatch_ec.py
M tests/unit/cmk/gui/plugins/wato/check_parameters/test_plugin_vs_wato.py
Log Message:
-----------
Fixup logatch_ec rule
Make the remaining keys optional, so that we can
read/render the discovered parameters.
OTOH, make sure the keys are present at runtime
by adding them to the default parameters.
CMK-12829
Change-Id: I3d7b921dc113189b79c7e268ab06f30ddd69fb03
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 965473fc444b45695f392e6544c54dd110b0e4a7
https://github.com/tribe29/checkmk/commit/965473fc444b45695f392e6544c54dd11…
Author: Mazen Alkatlabee <mazen.alkatlabee(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M tsconfig.strict.json
M web/htdocs/js/modules/password_meter.ts
Log Message:
-----------
add types to password_meter.ts
Change-Id: I17d4c668737c2bcbc5c9083aecb272f4f969959d
Commit: 1d7cf3f23535a33234c30d09c0629a9816bfbeae
https://github.com/tribe29/checkmk/commit/1d7cf3f23535a33234c30d09c0629a981…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M cmk/base/plugins/agent_based/logwatch_ec.py
M cmk/gui/plugins/wato/check_parameters/logwatch_ec.py
M tests/unit/cmk/base/plugins/agent_based/test_logwatch_ec.py
M tests/unit/cmk/gui/plugins/wato/check_parameters/test_plugin_vs_wato.py
Log Message:
-----------
Fixup logatch_ec rule
Make the remaining keys optional, so that we can
read/render the discovered parameters.
OTOH, make sure the keys are present at runtime
by adding them to the default parameters.
CMK-12829
Change-Id: I3d7b921dc113189b79c7e268ab06f30ddd69fb03
Commit: 2ce6b069b707cbe58a2306a0e4f5cf9760033994
https://github.com/tribe29/checkmk/commit/2ce6b069b707cbe58a2306a0e4f5cf976…
Author: Mazen Alkatlabee <mazen.alkatlabee(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M package-lock.json
M package.json
Log Message:
-----------
delete whatwg-fetch from package.json
since we don't support browsers that don't support fetch
we don't need this dependency.
Change-Id: I1ba48737e9718761d0a0bebdb10bfdc0ae6da59e
Commit: f693af91a954bb01318e6c569bef70dc3bb2e07c
https://github.com/tribe29/checkmk/commit/f693af91a954bb01318e6c569bef70dc3…
Author: Mazen Alkatlabee <mazen.alkatlabee(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M web/htdocs/js/modules/valuespecs.ts
Log Message:
-----------
fix eslint warnings in valuespecs.ts
Change-Id: I2c635e166406c3c31a9e51a8817a9151fc35fc97
Commit: def46e916cf916c9f1cdb1c9507d39050aabd554
https://github.com/tribe29/checkmk/commit/def46e916cf916c9f1cdb1c9507d39050…
Author: Mazen Alkatlabee <mazen.alkatlabee(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M .eslintignore
R web/htdocs/js/modules/dashboard.js
A web/htdocs/js/modules/dashboard.ts
Log Message:
-----------
fix ts errors in dashboard.ts
Change-Id: Id8dd6544d2588b00000000007456a422140cab8e
Commit: 7d0b6fab18b089c7515230d5c29eb1e217f79610
https://github.com/tribe29/checkmk/commit/7d0b6fab18b089c7515230d5c29eb1e21…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M cmk/gui/availability.py
M cmk/gui/utils/__init__.py
M cmk/gui/utils/script_helpers.py
M cmk/gui/views/__init__.py
M cmk/gui/views/sorter/__init__.py
M cmk/gui/views/sorter/helpers.py
M cmk/gui/views/sorter/sorters.py
Log Message:
-----------
Break one import cycle in the GUI.
Previous cycle:
* cmk.gui.availability
* cmk.gui.views.__init__
* cmk.gui.views.page_show_view
Change-Id: Idd26c8168ecf39159929fc0a4c631f91dfe6d5c2
Commit: dd83ae1117a715e70b1f9388ea75904278be151f
https://github.com/tribe29/checkmk/commit/dd83ae1117a715e70b1f9388ea7590427…
Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M .werks/15421
Log Message:
-----------
agent deployment: Handle missing signatures from central bakery
Don't handle missing signatures from the central bakery as an error
on remote site/bakery.
It's the task of the agent bakery to abort the update when missing
signatures in status response.
Change-Id: Iafd71ff9e647abe39ce79dfea282b75856adb5a3
Compare: https://github.com/tribe29/checkmk/compare/feec9640f011...dd83ae1117a7
Branch: refs/heads/2.1.0
Home: https://github.com/tribe29/checkmk
Commit: 8777fa840970f7f2f23be02fad59e563b6f4aca6
https://github.com/tribe29/checkmk/commit/8777fa840970f7f2f23be02fad59e563b…
Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_INST_BLOCKED_regression.py
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_INST_NO_BLOCKED_regression.py
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_NO_INST_BLOCKED_regression.py
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_NO_INST_NO_BLOCKED_regression.py
R tests/unit/checks/generictests/datasets/mssql_blocked_sessions_clustered.py
A tests/unit/cmk/base/plugins/agent_based/test_mssql_blocked_sessions.py
Log Message:
-----------
Prepare migration of mssql_blocked_sessions
add tests
Change-Id: I9df20dd717661433965cda725dae8cb63110f46b
Commit: 305a2479f5d2fc000139a63a4b80bcafe1049939
https://github.com/tribe29/checkmk/commit/305a2479f5d2fc000139a63a4b80bcafe…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M checks/mssql_blocked_sessions
Log Message:
-----------
replace collections NamedTuple
Change-Id: I5f25a9a9949e7aa102e3d0b40ee52b911938d9c1
Commit: 311aad7a5494f7a811f7359b5a3e4ba129f787a9
https://github.com/tribe29/checkmk/commit/311aad7a5494f7a811f7359b5a3e4ba12…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M checks/mssql_blocked_sessions
Log Message:
-----------
add some type annotations
Change-Id: I5f56ffdc03582d9be91b4fffa345f3ac03a6edb3
Commit: a9b72d543d9708848cf8d71d8ff0d9255d55ffe6
https://github.com/tribe29/checkmk/commit/a9b72d543d9708848cf8d71d8ff0d9255…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M checkman/mssql_blocked_sessions
R checks/mssql_blocked_sessions
M cmk/base/api/agent_based/clusterize.py
A cmk/base/plugins/agent_based/mssql_blocked_sessions.py
M tests/unit/checks/test_generic_legacy_conversion.py
M tests/unit/cmk/base/plugins/agent_based/test_mssql_blocked_sessions.py
Log Message:
-----------
Migrate mssql_blocked_sessions to new check api
Change-Id: I2d28a27f0e73445a16cac0ce5705a2bb10e5a976
Commit: 5264633321bff0290353035527cc2feb71a5bcd5
https://github.com/tribe29/checkmk/commit/5264633321bff0290353035527cc2feb7…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M cmk/base/plugins/agent_based/mssql_blocked_sessions.py
Log Message:
-----------
drop useless comment
Change-Id: I95a86d65190c9e81ed8f32e9387892c7db0df459
Commit: f675c383cec787bc7829f5f4a093bf8fd5b99f8a
https://github.com/tribe29/checkmk/commit/f675c383cec787bc7829f5f4a093bf8fd…
Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
A .werks/15281
M cmk/base/plugins/agent_based/mssql_blocked_sessions.py
M cmk/gui/plugins/wato/check_parameters/mssql_instance_blocked_sessions.py
M tests/unit/cmk/base/plugins/agent_based/test_mssql_blocked_sessions.py
Log Message:
-----------
15281 FIX mssql_blocked_sessions: Levels now overwrite state
The inline-help of the parameter "Levels for wait" of the rule "MSSQL
Blocked Sessions" mentions:
"The thresholds for wait_duration_ms. Will overwrite the default state
set above."
This was not right. If only the levels were set, the check would go to
CRIT regardless of the wait_duration_ms.
After setting "Levels for wait" all sessions that wait for a shorter
duration than the warning level of "Levels for wait" will not affect the
check result. The check result is then controlled by wait_duration_ms
being greater than the levels defined.
If "Levels for wait" is not set (the default), the behaviour is not
altered.
SUP-13208
Change-Id: I16e557e2319ba99eefb1a982b243883d8f64e0fd
Compare: https://github.com/tribe29/checkmk/compare/7626e74395f4...f675c383cec7
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 31c8b4a105d57389b7e91122988db43471ff2c5c
https://github.com/tribe29/checkmk/commit/31c8b4a105d57389b7e91122988db4347…
Author: Matteo Stifano <matteo.stifano(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M buildscripts/scripts/test-update.groovy
Log Message:
-----------
Modify test-update.groovy to use the daily build
Our aim is to make test-update run once a day with the daily build as
target-version. To do so, we adapt the groovy file accordingly.
Change-Id: Iff70208e345dcf0de7da07fd7de00229c0564db4
Commit: dcdd3b7d8b3dcf7eef2850134c501dc6e65b99ae
https://github.com/tribe29/checkmk/commit/dcdd3b7d8b3dcf7eef2850134c501dc6e…
Author: Matteo Stifano <matteo.stifano(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M tests/update/conftest.py
Log Message:
-----------
Avoid hard-coded site name in data-retrieval method
We here use site.id instead of hard-coding the site name in
get_host_data method.
Change-Id: I39e872ef299ffeeadee9969e509a105933618901
Commit: 9cc1e6bd0c3f45d754ef3f04ea303ad1e59b2112
https://github.com/tribe29/checkmk/commit/9cc1e6bd0c3f45d754ef3f04ea303ad1e…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M tests/testlib/snmp.py
Log Message:
-----------
testlib/snmp: Remove unused global variable
CMK-12511
Change-Id: I4b09b8db8437248823105d81d01506c6c66395ad
Commit: feec9640f01179b81cf4c62d7cc7fb5c5bf3d16d
https://github.com/tribe29/checkmk/commit/feec9640f01179b81cf4c62d7cc7fb5c5…
Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M cmk/base/plugins/agent_based/checkmk_agent.py
M tests/unit/cmk/base/plugins/agent_based/test_checkmk_agent.py
Log Message:
-----------
split error for Result into summary and details
summary can't have '\n' chars -> now it contains
either a first line of error(predefined text if
first line is empty) or whole error.
BACKGROUND: switch to the json format('\n' replaced with "\\n")
in the agent updater has disabled patching '\n' by checker code.
Finally, the Result gets '\n' from the agent updater output,
which leads to inevitable crash.
TESTS: manual in GUI with simulated input from attached agent
output.
CMK-12608
Change-Id: I0bca482b53426d976e75980b880f6a51d02cdc61
Compare: https://github.com/tribe29/checkmk/compare/50f43e324be4...feec9640f011
Branch: refs/heads/2.2.0
Home: https://github.com/tribe29/checkmk
Commit: 91dfea07f22029243ce5f6145c370253a4a72176
https://github.com/tribe29/checkmk/commit/91dfea07f22029243ce5f6145c370253a…
Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M .werks/13860
Log Message:
-----------
fix werk's typo in port value
Change-Id: I58284648b8adc95d34cdfc3d2755683f7cae23c9
Commit: 06a4a97bc70139448535deed40687c269eb8b281
https://github.com/tribe29/checkmk/commit/06a4a97bc70139448535deed40687c269…
Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M cmk/base/plugins/agent_based/checkmk_agent.py
M tests/unit/cmk/base/plugins/agent_based/test_checkmk_agent.py
Log Message:
-----------
split error for Result into summary and details
summary can't have '\n' chars -> now it contains
either a first line of error(predefined text if
first line is empty) or whole error.
BACKGROUND: switch to the json format('\n' replaced with "\\n")
in the agent updater has disabled patching '\n' by checker code.
Finally, the Result gets '\n' from the agent updater output,
which leads to inevitable crash.
TESTS: manual in GUI with simulated input from attached agent
output.
CMK-12608
Change-Id: I0bca482b53426d976e75980b880f6a51d02cdc61
Compare: https://github.com/tribe29/checkmk/compare/bf1de7c68d51...06a4a97bc701
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 6a388fec2ff230f954a5da1ba3e3bf883d691533
https://github.com/tribe29/checkmk/commit/6a388fec2ff230f954a5da1ba3e3bf883…
Author: Gav <gavin.mcguigan(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
A .werks/15438
M cmk/gui/watolib/site_management.py
Log Message:
-----------
15438 FIX site_connection: Wrong configuration was being set when creating a site with livestatus proxy daemon
This werk fixes an issue with the create a site connection endpoint. Previously when
configuring a proxy with encryption disabled, a wrong config was being saved. This
werk addresses this by writing the correct config to file.
CMK-12654, CMK-12658
Change-Id: I752f034fa5ab40abe3fd7cab1db6e994be126842
Commit: b7e9bfc41427e9bcd01b5725afc01a38d0c3fd65
https://github.com/tribe29/checkmk/commit/b7e9bfc41427e9bcd01b5725afc01a38d…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2023-03-29 (Wed, 29 Mar 2023)
Changed paths:
M cmk/ec/export.py
M cmk/ec/rule_matcher.py
M cmk/gui/mkeventd/rule_matching.py
M tests/unit/cmk/ec/test_rule_matching.py
Log Message:
-----------
Use MatchGroups() instead of dict literals.
This improved readability quite a bit and makes construction sites much
easier to find. In addition, this will also come in handy when we switch to
a dataclass.
Change-Id: I320c4ad373eebc2221929bfbc4583b8391f8dde6
Compare: https://github.com/tribe29/checkmk/compare/2f940b6e8c31...b7e9bfc41427