Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 757dcf9ed7c0441ffc07444df233f11c1f2b4ec5
https://github.com/Checkmk/checkmk/commit/757dcf9ed7c0441ffc07444df233f11c1…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
A .werks/15976
M agents/windows/plugins/mssql.vbs
M cmk/base/plugins/agent_based/mssql_backup.py
M tests/unit/cmk/base/plugins/agent_based/test_mssql_backup.py
Log Message:
-----------
15976 FIX mssql_backup: Correct timezone difference for last backup date
This werk is relevant for users monitoring the age of the last backup
time of mssql databases in different timezones.
The date/time of the last backup of a mssql database is currently stored
in local host time without the information about the host timezone. When
this time is used to check the age of the last backup, it is interpreted
in the Checkmk server timezone.
When using different timezones, this leads to incorrect values for "Age
of last database backup" and if the age is negative, in newer Checkmk
versions to the warning "Cannot reasonably calculate time since last
backup (hosts time running ahead)".
The mssql agent plugin will now store the time in UTC and the
mssql_backup check will interpret the time accordingly.
You will need to update the agent plugin mssql.vbs to receive the
corrected times.
SUP-14924
SUP-15900
SUP-15976
Co-authored-by: Benedikt Seidl <benedikt.seidl(a)checkmk.com>
Change-Id: I6e6e9192632d1f35ff1516b6a3f123b74fb4cd89
Branch: refs/heads/2.2.0
Home: https://github.com/Checkmk/checkmk
Commit: 79d1bc7fdadb9eca26f67d08e50354ef5c78a22c
https://github.com/Checkmk/checkmk/commit/79d1bc7fdadb9eca26f67d08e50354ef5…
Author: Benedikt Seidl <benedikt.seidl(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/test_mssql_backup.py
Log Message:
-----------
remove pytest fixture, use function instead
as soon as you set the environment variable `TZ` to something, the
skipped test started to fail. the problem was, that the fixture (parsing
the section) was outside the `with on_time` block setting the timezone.
So the section was parsed with the timezone of the system which is
randomized when executed via `make test-unit`.
Change-Id: I740a7ea8cd83c9680fb355a3e5eb8ea71bfc17f1
Commit: 99d7681bc843d2e9735cdb0c5d3ffecd8c3c8697
https://github.com/Checkmk/checkmk/commit/99d7681bc843d2e9735cdb0c5d3ffecd8…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
A .werks/15976
M agents/windows/plugins/mssql.vbs
M cmk/base/plugins/agent_based/mssql_backup.py
M tests/unit/cmk/base/plugins/agent_based/test_mssql_backup.py
Log Message:
-----------
15976 FIX mssql_backup: Correct timezone difference for last backup date
This werk is relevant for users monitoring the age of the last backup
time of mssql databases in different timezones.
The date/time of the last backup of a mssql database is currently stored
in local host time without the information about the host timezone. When
this time is used to check the age of the last backup, it is interpreted
in the Checkmk server timezone.
When using different timezones, this leads to incorrect values for "Age
of last database backup" and if the age is negative, in newer Checkmk
versions to the warning "Cannot reasonably calculate time since last
backup (hosts time running ahead)".
The mssql agent plugin will now store the time in UTC and the
mssql_backup check will interpret the time accordingly.
You will need to update the agent plugin mssql.vbs to receive the
corrected times.
SUP-14924
SUP-15900
SUP-15976
Co-authored-by: Benedikt Seidl <benedikt.seidl(a)checkmk.com>
Change-Id: I6e6e9192632d1f35ff1516b6a3f123b74fb4cd89
Compare: https://github.com/Checkmk/checkmk/compare/a2ea55fa4ecf...99d7681bc843
Branch: refs/heads/2.1.0
Home: https://github.com/Checkmk/checkmk
Commit: 74a37eed03541af7f359b96fc054c6e01ba34152
https://github.com/Checkmk/checkmk/commit/74a37eed03541af7f359b96fc054c6e01…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
A .werks/15976
M agents/windows/plugins/mssql.vbs
M checks/mssql_backup
Log Message:
-----------
15976 FIX mssql_backup: Correct timezone difference for last backup date
This werk is relevant for users monitoring the age of the last backup
time of mssql databases in different timezones.
The date/time of the last backup of a mssql database is currently stored
in local host time without the information about the host timezone. When
this time is used to check the age of the last backup, it is interpreted
in the Checkmk server timezone.
When using different timezones, this leads to incorrect values for "Age
of last database backup" and if the age is negative, in newer Checkmk
versions to the warning "Cannot reasonably calculate time since last
backup (hosts time running ahead)".
The mssql agent plugin will now store the time in UTC and the
mssql_backup check will interpret the time accordingly.
You will need to update the agent plugin mssql.vbs to receive the
corrected times.
SUP-14924
SUP-15900
SUP-15976
Change-Id: I6e6e9192632d1f35ff1516b6a3f123b74fb4cd89
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 94b18d2f575e5599c5e56a8f5d3c5835df5a0452
https://github.com/Checkmk/checkmk/commit/94b18d2f575e5599c5e56a8f5d3c5835d…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
M packages/check-cert/src/check.rs
M packages/check-cert/src/checker.rs
Log Message:
-----------
check-cert: Change levels.check into CheckResult::from_level
That's prefering "from" to "into" and seems more logical.
CMK-14683
Change-Id: Ie67886a16fa68472bc507e8a4c4d43d92124b34c
Commit: 3dc27da79da91bab66b9cb7ebfd5ba717b32d9a7
https://github.com/Checkmk/checkmk/commit/3dc27da79da91bab66b9cb7ebfd5ba717…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
M packages/check-cert/src/checker.rs
M packages/check-cert/src/main.rs
Log Message:
-----------
check-cert: Inline response_time check
It doesn't check the certificate per se. So let's keep it separate.
CMK-14683
Change-Id: Ib8be248a0a533e88907fb378335684bb9ebaf239
Commit: 8de5934bc045a6fb8b7703832e45bce64755a6d9
https://github.com/Checkmk/checkmk/commit/8de5934bc045a6fb8b7703832e45bce64…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
M packages/check-cert/src/check.rs
Log Message:
-----------
check-cert: derive Debug for all public types
Good practice, see:
https://doc.rust-lang.org/std/fmt/index.html#fmtdisplay-vs-fmtdebug
"""
fmt::Debug implementations should be implemented for all public types.
Output will typically represent the internal state as faithfully as
possible. The purpose of the Debug trait is to facilitate debugging Rust
code. In most cases, using #[derive(Debug)] is sufficient and
recommended.
"""
CMK-14683
Change-Id: I8347792e645245df38a5a121783bbb7caa9de975
Commit: 9accb9f719d2c35936a495ba6b93d656943c4e48
https://github.com/Checkmk/checkmk/commit/9accb9f719d2c35936a495ba6b93d6569…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
M packages/check-cert/src/main.rs
Log Message:
-----------
check-cert: Import structs w/o namespace and fn with
idiomatic:
https://doc.rust-lang.org/book/ch07-04-bringing-paths-into-scope-with-the-u…
CMK-14683
Change-Id: I2d021ded62ea577723d0e797d3b11f44cb0dc073
Commit: 4fb26bda9270d94e8f21a14e66f6155979735de9
https://github.com/Checkmk/checkmk/commit/4fb26bda9270d94e8f21a14e66f615597…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
M packages/check-cert/src/check.rs
Log Message:
-----------
check-cert: Add Bounds display test
CMK-14683
Change-Id: I3ca55730a3ccc75b4f669a0e757ec5c039afe22b
Compare: https://github.com/Checkmk/checkmk/compare/1ee006fdc2af...4fb26bda9270
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: caddc06428c507e30e7d53971201c9d2ffce93c3
https://github.com/Checkmk/checkmk/commit/caddc06428c507e30e7d53971201c9d2f…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
R livestatus/.f12
R livestatus/.gitignore
R livestatus/.vscode/c_cpp_properties.json
R livestatus/api/c++/.f12
R livestatus/api/c++/.gitignore
R livestatus/api/c++/Livestatus.cc
R livestatus/api/c++/Livestatus.h
R livestatus/api/c++/Makefile
R livestatus/api/c++/demo.cc
R livestatus/api/perl/Changes
R livestatus/api/perl/MANIFEST
R livestatus/api/perl/META.yml
R livestatus/api/perl/Makefile.PL
R livestatus/api/perl/README
R livestatus/api/perl/examples/dump.pl
R livestatus/api/perl/examples/test.pl
R livestatus/api/perl/inc/Module/AutoInstall.pm
R livestatus/api/perl/inc/Module/Install.pm
R livestatus/api/perl/inc/Module/Install/AutoInstall.pm
R livestatus/api/perl/inc/Module/Install/Base.pm
R livestatus/api/perl/inc/Module/Install/Can.pm
R livestatus/api/perl/inc/Module/Install/Fetch.pm
R livestatus/api/perl/inc/Module/Install/Include.pm
R livestatus/api/perl/inc/Module/Install/Makefile.pm
R livestatus/api/perl/inc/Module/Install/Metadata.pm
R livestatus/api/perl/inc/Module/Install/Win32.pm
R livestatus/api/perl/inc/Module/Install/WriteAll.pm
R livestatus/api/perl/lib/Monitoring/Livestatus.pm
R livestatus/api/perl/lib/Monitoring/Livestatus/INET.pm
R livestatus/api/perl/lib/Monitoring/Livestatus/MULTI.pm
R livestatus/api/perl/lib/Monitoring/Livestatus/UNIX.pm
R livestatus/api/perl/t/01-Monitoring-Livestatus-basic_tests.t
R livestatus/api/perl/t/02-Monitoring-Livestatus-internals.t
R livestatus/api/perl/t/03-Monitoring-Livestatus-MULTI-internals.t
R livestatus/api/perl/t/20-Monitoring-Livestatus-test_socket.t
R livestatus/api/perl/t/21-Monitoring-Livestatus-INET.t
R livestatus/api/perl/t/22-Monitoring-Livestatus-UNIX.t
R livestatus/api/perl/t/30-Monitoring-Livestatus-live-test.t
R livestatus/api/perl/t/31-Monitoring-Livestatus-MULTI-live-test.t
R livestatus/api/perl/t/32-Monitoring-Livestatus-backend-test.t
R livestatus/api/perl/t/33-Monitoring-Livestatus-test_socket_timeout.t
R livestatus/api/perl/t/34-Monitoring-Livestatus-utf8_support.t
R livestatus/api/perl/t/35-Monitoring-Livestatus-callbacks_support.t
R livestatus/api/perl/t/97-Pod.t
R livestatus/api/perl/t/98-Pod-Coverage.t
R livestatus/api/perl/t/99-Perl-Critic.t
R livestatus/api/perl/t/perlcriticrc
R livestatus/api/python/make_nagvis_map.py
Log Message:
-----------
Remove dead code
Change-Id: I5778da8571f1d83b9bfc0330105320eb33b97978
Commit: 6aa824dffda1199149cbcae2ff2d8f0a427be678
https://github.com/Checkmk/checkmk/commit/6aa824dffda1199149cbcae2ff2d8f0a4…
Author: Lars Michelsen <lm(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
M .pylintrc
M Makefile
M Pipfile
M Pipfile.lock
M buildscripts/scripts/stages.yml
M cmk/utils/livestatus_helpers/testing.py
R livestatus.py
R livestatus/api/python/.f12
R livestatus/api/python/.gitignore
R livestatus/api/python/README
R livestatus/api/python/example_multisite.py
R livestatus/api/python/example_singlesite.py
R livestatus/api/python/livestatus.py
M omd/packages/mk-livestatus/mk-livestatus.make
M omd/packages/python3-modules/BUILD
M packages/BUILD
A packages/cmk-livestatus-client/.f12
A packages/cmk-livestatus-client/.gitignore
A packages/cmk-livestatus-client/Pipfile
A packages/cmk-livestatus-client/Pipfile.lock
A packages/cmk-livestatus-client/README
A packages/cmk-livestatus-client/cmk/livestatus_client/__init__.py
A packages/cmk-livestatus-client/cmk/livestatus_client/py.typed
A packages/cmk-livestatus-client/example_multisite.py
A packages/cmk-livestatus-client/example_singlesite.py
A packages/cmk-livestatus-client/livestatus/__init__.py
A packages/cmk-livestatus-client/livestatus/py.typed
A packages/cmk-livestatus-client/pyproject.toml
A packages/cmk-livestatus-client/run
A packages/cmk-livestatus-client/setup.cfg
A packages/cmk-livestatus-client/tests/.gitignore
M scripts/find-python-files
M tests/code_quality/test_pipfile.py
M tests/testlib/site.py
M tests/unit/livestatus/test_livestatus_unit.py
Log Message:
-----------
Move livestatus client to a dedicated package
Change-Id: Ie4b6be54d212ba4cb37a6eed9ab4c5a7ff3f2d5d
Commit: 262cd9c983d2e68d6617e2c19559d2e87bc5fc6d
https://github.com/Checkmk/checkmk/commit/262cd9c983d2e68d6617e2c19559d2e87…
Author: Matteo Stifano <matteo.stifano(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
M tests/update/test_update_from_backup.py
Log Message:
-----------
test_update_from_backup: Temporary skip tests
Restored test-site should have cmk version >= 2.2.0p8. The backup-files
should then be re-generated.
Until then, we temporary skip these tests.
Change-Id: Iff66e0a407b5c5b831e50b44ff22297b8829d542
Compare: https://github.com/Checkmk/checkmk/compare/3803ef218f49...262cd9c983d2
Branch: refs/heads/2.1.0
Home: https://github.com/Checkmk/checkmk
Commit: ce5840ec1cba4f171e4a8fbdf18def30735be6b8
https://github.com/Checkmk/checkmk/commit/ce5840ec1cba4f171e4a8fbdf18def307…
Author: David Gervasoni <david.gervasoni(a)checkmk.com>
Date: 2023-11-20 (Mon, 20 Nov 2023)
Changed paths:
A .werks/16294
M checks/ibm_imm_temp
Log Message:
-----------
16294 FIX ibm_imm_temp: Fix error due to "empty string" sensor data
The check plugin ibm_imm_temp crashed in case of "empty string" presence in input data.
With this werk, the corresponding services correctly show states and information.
CMK-15195
Change-Id: I4ce7d15198b08ed9ef04110ee025dc87eed6e74b