Checkmk git commits September 2022

checkmk-commits@lists.checkmk.com

1 participants
607 discussions

[tribe29/checkmk] 94b7ac: ProgramSource: Remove code duplication

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 94b7ac78832a568024e91dae4e9a22d0d3d5f84a https://github.com/tribe29/checkmk/commit/94b7ac78832a568024e91dae4e9a22d0d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/sources/programs.py M tests/unit/cmk/base/agent_based/test_data_provider_collect_host_sections.py Log Message: ----------- ProgramSource: Remove code duplication CMK-10515 Change-Id: Icfe2fc0456cd52f4b11d4c1e3ef97a1d4aa41538

1 year, 9 months

[tribe29/checkmk] 5d7501: 13428 FIX REST API: Fix network scan related schemas

by Benedikt Seidl

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5d7501aac18873587732813aa1d4a278c7735edf https://github.com/tribe29/checkmk/commit/5d7501aac18873587732813aa1d4a278c… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: A .werks/13428 M cmk/gui/fields/attributes.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_folder_config.py Log Message: ----------- 13428 FIX REST API: Fix network scan related schemas A Folder with configured network scan with an "IP Network" as "IP ranges to scan" could not be returned by the REST API. An error with status code 500 was returned. CMK-11260 Change-Id: Id1714c3d964ef76880de559230b49dfb28bdff94

1 year, 9 months

[tribe29/checkmk] f99f27: Improved typing

by Maximilian

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f99f27b53d91bbe1cb66afcedc16f8cb05781433 https://github.com/tribe29/checkmk/commit/f99f27b53d91bbe1cb66afcedc16f8cb0… Author: Maximilian Wirtz <maximilian.wirtz(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M tests/docker/test_docker.py Log Message: ----------- Improved typing Change-Id: I9bcbf1013e79b3704052f9da939ae3929adf4ec0

1 year, 9 months

[tribe29/checkmk] d8e2da: Refactor tolerance_check to avoid repeated call to...

by Lars

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: d8e2dac91a12b70630d70bfafa7eff0eb7c45481 https://github.com/tribe29/checkmk/commit/d8e2dac91a12b70630d70bfafa7eff0eb… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M cmk/base/plugins/agent_based/ntp.py M cmk/base/plugins/agent_based/timesyncd.py M cmk/base/plugins/agent_based/utils/timesync.py M tests/unit/cmk/base/plugins/agent_based/utils/test_timesync.py Log Message: ----------- Refactor tolerance_check to avoid repeated call to check current time First call only stored the time if given, only second call checked it. Changed to check immediately. CMK-11089 Change-Id: Ib904f30d4e6543a6ec7778609edace08d9864abc Commit: da51221fdc5c9c2aaca3be2a199d2de992c8978f https://github.com/tribe29/checkmk/commit/da51221fdc5c9c2aaca3be2a199d2de99… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M cmk/base/plugins/agent_based/utils/timesync.py M cmk/gui/plugins/metrics/network.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py M tests/unit/cmk/base/plugins/agent_based/utils/test_timesync.py Log Message: ----------- Display time since last sync over time CMK-11089 Change-Id: I0c9ea9484b8e0015514f15a69ba183a93a07a302 Commit: 07c9880e82dbb15b0fe4d3e1f7ec0633ba8ce9b8 https://github.com/tribe29/checkmk/commit/07c9880e82dbb15b0fe4d3e1f7ec0633b… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M cmk/base/plugins/agent_based/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Do not set check limits for time since last sync per default Since the time can not reliably be used to check if sync occured (limited error messages when adjusting system clock depending on systemd version). Main focus should be on monitoring time offset CMK-11089 Change-Id: I8c2fcdec65c44f06b51a7573c1e644ea9e7cc614 Commit: 32d3a1903f599c02d669ecb6839897b9b2a6d019 https://github.com/tribe29/checkmk/commit/32d3a1903f599c02d669ecb6839897b9b… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: A .werks/14863 Log Message: ----------- 14863 Timesyncd check plugin: Change time since last sync check behavior This werk removes the default threshold for the allowed duration since last synchronization of the systemd timesyncd. The time since last synchronization reported by the modification time of /var/lib/systemd/timesync/clock can at times be unsuitable to monitor when synchronization occurred. Instead of applying thresholds per default, the time since last synchronization is now available as a metric to support monitoring when a time offset occurs. If you want to apply thresholds to the time since last synchronization you now have to enable the rule manually. Additionally, the rendering of the jitter was corrected to show a time span instead of a date. CMK-11089 Change-Id: Ieb4caa96dc38e92033f30a336bd7dbac1b7995df Compare: https://github.com/tribe29/checkmk/compare/2f32174c7740...32d3a1903f59

1 year, 9 months

[tribe29/checkmk] 7cfea0: Use correct rendering for jitter metric

by Lars

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 7cfea03eabee10b149dfef0160231c3d584c0979 https://github.com/tribe29/checkmk/commit/7cfea03eabee10b149dfef0160231c3d5… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M cmk/base/plugins/agent_based/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Use correct rendering for jitter metric CMK-11089 Change-Id: Ib197029c90d621eab01853eaa227547f0ae1b1b1 Commit: 2f32174c774084d0b33b7f40536afd5d2b3ffbff https://github.com/tribe29/checkmk/commit/2f32174c774084d0b33b7f40536afd5d2… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M tests/unit/cmk/base/plugins/agent_based/utils/test_timesync.py Log Message: ----------- Increase test coverage for upcoming refactoring CMK-11089 Change-Id: I924ffe8402ccfb3862e35e99582d94ec35bb6afb Compare: https://github.com/tribe29/checkmk/compare/087b5700cf05...2f32174c7740

1 year, 9 months

[tribe29/checkmk] df7483: 14877 FIX host_config: change community for snmp_c...

by anthonyh209

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: df7483aa3c00ad54d55067cb44c51c62cf5a1801 https://github.com/tribe29/checkmk/commit/df7483aa3c00ad54d55067cb44c51c62c… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: A .werks/14877 M cmk/gui/fields/attributes.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py Log Message: ----------- 14877 FIX host_config: change community for snmp_community attribute to required Previously, the create host config endpoint returned a 500 error when the community field within the snmp_community attribute was missing. This werk resolves by making this field required. Change-Id: I62b6f3855017770431c44ab918fa862c41caa7a8

1 year, 9 months

[tribe29/checkmk] 643ce0: Remove HostConfig from SNMP source

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 643ce01cadb6e4990f7a951437a7cbdf24f76d2d https://github.com/tribe29/checkmk/commit/643ce01cadb6e4990f7a951437a7cbdf2… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M cmk/base/sources/_checkers.py M cmk/base/sources/snmp.py M tests/unit/cmk/base/agent_based/test_data_provider_collect_host_sections.py M tests/unit/cmk/base/sources/test_cmd_caching.py M tests/unit/cmk/base/sources/test_snmp_data_source.py Log Message: ----------- Remove HostConfig from SNMP source CMK-10515 Change-Id: Ib927b89148c887f1ef5cdb0c55cf37e3d4bfbd21 Commit: f84f26704b9b354848d906becce70846f5d57993 https://github.com/tribe29/checkmk/commit/f84f26704b9b354848d906becce70846f… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M cmk/base/sources/_checkers.py Log Message: ----------- Remove HostConfig from PushAgent source CMK-10515 Change-Id: I49bbb0fd2df4df164808b65d41f03687afba3d27 Compare: https://github.com/tribe29/checkmk/compare/ec710f35967d...f84f26704b9b

1 year, 9 months

[tribe29/checkmk] 087b57: 14353 FIX Fix cmcii_lcp_water temperature check

by Max Linke

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 087b5700cf053cbfc6deb080b9f77bdb3610fc59 https://github.com/tribe29/checkmk/commit/087b5700cf053cbfc6deb080b9f77bdb3… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: A .werks/14353 M checks/cmciii_lcp_water Log Message: ----------- 14353 FIX Fix cmcii_lcp_water temperature check Fix broken check closes: #465 Change-Id: Ie02cb5b10cdf9f19eecbff680f1c3eebddd2a095

1 year, 9 months

[tribe29/checkmk] d12091: Fix creating combined graph via element editor

by Lars

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: d1209174fac7d3b446e828fdb88110dac0eaf3e9 https://github.com/tribe29/checkmk/commit/d1209174fac7d3b446e828fdb88110dac… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: A .werks/14295 Log Message: ----------- Fix creating combined graph via element editor Change-Id: I9c506f5e6660ad6befeb86e150eced7cfe76accb Commit: 76c05bad3d49a242272f420b69009c9c16b7adcc https://github.com/tribe29/checkmk/commit/76c05bad3d49a242272f420b69009c9c1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: A .werks/14296 M cmk/gui/visuals.py Log Message: ----------- 14296 FIX Edit roles: Fix missing custom views, dashboard and report permissions In some cases the "Edit role" page could miss the permissions of custom views, dashboards or reports in the list of permissions. Dependent on the previously loaded pages the permissions in question could be available or not. Change-Id: Ia52ede8c191707e2b4b3d22a281801a036ddfae4 Compare: https://github.com/tribe29/checkmk/compare/b8d496fe9e23...76c05bad3d49

1 year, 9 months

[tribe29/checkmk] 7abcbb: Do not set check limits for time since last sync p...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7abcbb2b745cf0418fa3223dc7147ca448e61d00 https://github.com/tribe29/checkmk/commit/7abcbb2b745cf0418fa3223dc7147ca44… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: M cmk/base/plugins/agent_based/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Do not set check limits for time since last sync per default Since the time can not reliably be used to check if sync occured (limited error messages when adjusting system clock depending on systemd version). Main focus should be on monitoring time offset CMK-11089 Change-Id: I8c2fcdec65c44f06b51a7573c1e644ea9e7cc614 Commit: ec710f35967d1b717908051d262f8ef5558a7881 https://github.com/tribe29/checkmk/commit/ec710f35967d1b717908051d262f8ef55… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-09-29 (Thu, 29 Sep 2022) Changed paths: A .werks/14863 Log Message: ----------- 14863 Timesyncd check plugin: Change time since last sync check behavior This werk removes the default threshold for the allowed duration since last synchronization of the systemd timesyncd. The time since last synchronization reported by the modification time of /var/lib/systemd/timesync/clock can at times be unsuitable to monitor when synchronization occurred. Instead of applying thresholds per default, the time since last synchronization is now available as a metric to support monitoring when a time offset occurs. If you want to apply thresholds to the time since last synchronization you now have to enable the rule manually. Additionally, the rendering of the jitter was corrected to show a time span instead of a date. CMK-11089 Change-Id: Ieb4caa96dc38e92033f30a336bd7dbac1b7995df Compare: https://github.com/tribe29/checkmk/compare/1505e4f9c8d5...ec710f35967d

1 year, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2022