Checkmk git commits August 2022

checkmk-commits@lists.checkmk.com

1 participants
525 discussions

[tribe29/checkmk] b152a1: datastructures: move denilled from plugin to cmk.u...

by Christoph Rauch

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b152a13c81c96c7a665e81d4396839ff8d44a374 https://github.com/tribe29/checkmk/commit/b152a13c81c96c7a665e81d4396839ff8… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/rule/__init__.py M cmk/gui/plugins/openapi/restful_objects/datastructures.py M cmk/gui/plugins/openapi/restful_objects/params.py M cmk/utils/datastructures.py Log Message: ----------- datastructures: move denilled from plugin to cmk.utils Change-Id: I84805e094dd63d38e7ca3708b2203ebee072f55c

2 years, 1 month

[tribe29/checkmk] 5c476a: siplify skip_sid

by Christoph Rauch

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5c476ab4b46ad1ac53d2cc6b893cd9912428ba22 https://github.com/tribe29/checkmk/commit/5c476ab4b46ad1ac53d2cc6b893cd9912… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M agents/plugins/mk_oracle M tests/unit-shell/agents/plugins/test_mk_oracle.sh Log Message: ----------- siplify skip_sid Change-Id: Ia5a6b932b814c8bc18bcab33bcb171402efa3c6e Commit: 67c6c0ca1d75c6089da084106d597bd2ac2ae73d https://github.com/tribe29/checkmk/commit/67c6c0ca1d75c6089da084106d597bd2a… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M tests/code_quality/test_pipfile.py Log Message: ----------- test_pipfile: fix typo _typesched / _typeshed Change-Id: I6b6e6e438798e1830ddb50c1024f51ebe2925715 Compare: https://github.com/tribe29/checkmk/compare/8b25864ae605...67c6c0ca1d75

2 years, 1 month

[tribe29/checkmk] 8b2586: Mega menu: Fix 'show more' for single-column menu

by Kenneth

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8b25864ae605d85ab333beab6dee1f5010724ac7 https://github.com/tribe29/checkmk/commit/8b25864ae605d85ab333beab6dee1f501… Author: Kenneth Okoh <kenneth.okoh(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M web/htdocs/themes/facelift/scss/_mega_menu.scss Log Message: ----------- Mega menu: Fix 'show more' for single-column menu When the 'Monitor' or 'Setup' menu was displayed as a single column (monitors of great height), the 'show more' button was rendered outside of the menu. Change-Id: I094755d64e0375bfee7713b03ad20011aa9365e6

2 years, 1 month

[tribe29/checkmk] 5c84ba: remove dead code

by Christoph Rauch

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5c84ba535363ea74dbbc72bc78b92609161a782d https://github.com/tribe29/checkmk/commit/5c84ba535363ea74dbbc72bc78b926091… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: R tests/unit/checks/generictests/conftest.py R tests/unit/checks/generictests/crashtest.py R tests/unit/checks/generictests/regression.py M tests/unit/checks/generictests/run.py Log Message: ----------- remove dead code Change-Id: I0c24bb69bbd692d3485b999ad93a28e46a84152d Commit: 5888edf15fd04eba14f6200e9c9d26ac84bf8dcc https://github.com/tribe29/checkmk/commit/5888edf15fd04eba14f6200e9c9d26ac8… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M Makefile R doc/helpers/headrify Log Message: ----------- Removed headrify, we don't need it anymore. Change-Id: I3b57b6279b9ba0cabda00a6753e44f654b003456 Commit: 27fec11d45e0a87d73a6810ac5783d739863fab1 https://github.com/tribe29/checkmk/commit/27fec11d45e0a87d73a6810ac5783d739… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/decorators.py M cmk/gui/wsgi/applications/checkmk.py M cmk/gui/wsgi/applications/helper_apps.py M cmk/gui/wsgi/applications/rest_api.py M cmk/gui/wsgi/middleware.py M cmk/gui/wsgi/routing.py M cmk/gui/wsgi/type_defs.py M tests/code_quality/test_pipfile.py M tests/unit/cmk/gui/utils/test_timeout_manager.py Log Message: ----------- wsgi middleware: typing We need to import "_typesched.wsgi" because this is the type that allows us to safely interface with external libraries using the same type. mypy doesn't understand when you define the exact same type in separate locations. For mypy cmk.gui.wsg.type_defs.WSGIApplication is different to _typesched.wsgi.WSGIApplication, even though it is a verbatim copy-paste. Change-Id: I7dd1e903b7220c75ff861242b047ee3e7856a2dc Compare: https://github.com/tribe29/checkmk/compare/d7f3c19dbf88...27fec11d45e0

2 years, 1 month

[tribe29/checkmk] 7f0d8b: 14490 Limit number of checkers to number of availa...

by Kenneth

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 7f0d8b3ab4b3ca1d2e02ee06c557bd08fbfa611c https://github.com/tribe29/checkmk/commit/7f0d8b3ab4b3ca1d2e02ee06c557bd08f… Author: Kenneth Okoh <kenneth.okoh(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: A .werks/14490 Log Message: ----------- 14490 Limit number of checkers to number of available CPUs When the global setting "Maximum concurrent Checkmk checkers" (topic "Monitoring core") is set to a value greater than the number of available CPUs, the number of actual checkers is limited to the number of CPUs. This is done because the checker processes are most effective when each checker gets a dedicated CPU. When the number of checkers is limited, a warning is displayed in the UI upon an activation of pending changes. Change-Id: Ic8e5a2b69ffdb7146104d43acf70940a2a84bb5e

2 years, 1 month

[tribe29/checkmk] 1b6eae: 14645 FIX storcli_physical_disks: Crash upon unkno...

by max

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 1b6eae39617589723c5162d2a72001c90f52e24c https://github.com/tribe29/checkmk/commit/1b6eae39617589723c5162d2a72001c90… Author: Maximilian Hill <mhill(a)inett.de> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: A .werks/14645 M cmk/base/plugins/agent_based/storcli_physical_disks.py Log Message: ----------- 14645 FIX storcli_physical_disks: Crash upon unknown failure count Closes #496. Change-Id: I919bdb63927df8082daaa2f23a1b2cd98db065c3

2 years, 1 month

[tribe29/checkmk] f04f09: 14645 FIX storcli_physical_disks: Crash upon unkno...

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f04f09538a762d6110e7f324a167a48181f1b496 https://github.com/tribe29/checkmk/commit/f04f09538a762d6110e7f324a167a4818… Author: Maximilian Hill <mhill(a)inett.de> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: A .werks/14645 M cmk/base/plugins/agent_based/storcli_physical_disks.py Log Message: ----------- 14645 FIX storcli_physical_disks: Crash upon unknown failure count Closes #496. Change-Id: I919bdb63927df8082daaa2f23a1b2cd98db065c3 Commit: d7f3c19dbf88c914be048270ba0dda68e8a79ce8 https://github.com/tribe29/checkmk/commit/d7f3c19dbf88c914be048270ba0dda68e… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/check_table.py M cmk/base/config.py M tests/unit/cmk/base/test_config.py Log Message: ----------- move computation of check parameters Note that for enforced services, the effective and the configured parmaeters are the same, since no further rules are applied. Change-Id: I915e427baca64bf2e16d9b7ebcc60564b5df2c42 Compare: https://github.com/tribe29/checkmk/compare/21ec138ce1fb...d7f3c19dbf88

2 years, 1 month

[tribe29/checkmk] 6c8a7e: Added an mkautomation exception to stop constant t...

by Christoph Rauch

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6c8a7e34beb5908ee62b3ca610629c953362b02f https://github.com/tribe29/checkmk/commit/6c8a7e34beb5908ee62b3ca610629c953… Author: Gav <gavin.mcguigan(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M cmk/gui/watolib/host_label_sync.py Log Message: ----------- Added an mkautomation exception to stop constant tracebacks in the weblog Change-Id: I0940bf2ce5d13e96764762437b35043ce7a7aa53 Commit: 21ec138ce1fb37b3903d0f3d16c1f11c902943ee https://github.com/tribe29/checkmk/commit/21ec138ce1fb37b3903d0f3d16c1f11c9… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M cmk/gui/sidebar/__init__.py M cmk/gui/utils/theme.py M cmk/gui/wsgi/applications/utils.py M cmk/gui/wsgi/auth.py Log Message: ----------- typos and grammar Change-Id: Ib98faa84c2e2de88ea01cc69dd117aa88afb66cf Compare: https://github.com/tribe29/checkmk/compare/3b42b56f6848...21ec138ce1fb

2 years, 1 month

[tribe29/checkmk] c94cca: Consolidate system apache related logic

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: c94cca5b540cf464c4b16514805849306e6ede0a https://github.com/tribe29/checkmk/commit/c94cca5b540cf464c4b16514805849306… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- Consolidate system apache related logic Extracted the logic for writing the apache config hook and applying it to the system apache to separate functions. Preparte to move them over to a separate module in the next step. Change-Id: I6a9e1d81450111ea3f6c024b946d7c1c24d5c4c6 Commit: 639fe9c903a6612ae298ee205a35e8cd553414b0 https://github.com/tribe29/checkmk/commit/639fe9c903a6612ae298ee205a35e8cd5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: A omd/packages/omd/omdlib/console.py M omd/packages/omd/omdlib/main.py A omd/packages/omd/omdlib/system_apache.py M omd/packages/omd/omdlib/tmpfs.py M omd/packages/omd/omdlib/utils.py Log Message: ----------- Move system apache to separate module Change-Id: I2745c2b094f420b647aa915b4ebf5e167a262b1d Commit: 84f1021359f13a853dc27486c917ddbf40b09b8b https://github.com/tribe29/checkmk/commit/84f1021359f13a853dc27486c917ddbf4… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M tests/unit/omdlib/conftest.py M tests/unit/omdlib/test_omdlib_main.py M tests/unit/omdlib/test_site_context.py Log Message: ----------- Generalize fixtures Change-Id: I04a498c76564cae8ece6d143d315a01bd55bd6af Commit: aeb33f665fefae04f18b2c20fd7cadba17132d4c https://github.com/tribe29/checkmk/commit/aeb33f665fefae04f18b2c20fd7cadba1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: A .werks/14281 M omd/packages/apache-omd/APACHE_TCP_ADDR M omd/packages/apache-omd/APACHE_TCP_PORT M omd/packages/omd/hooks/APACHE_MODE M omd/packages/omd/omd.8 M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/system_apache.py A tests/unit/omdlib/test_system_apache.py Log Message: ----------- 14281 SEC Fix local privilege escalation from site users Each Checkmk site provides it's HTTP services (UI, APIs) using it's own site Apache process. Global access to this site Apache is provided via the system Apache which is opening the 80 and 443 ports for external requests, depending on your system configuration. To learn about the site Apache, the system Apache reads a reverse proxy configuration provided by the site user. This could be used by a site user to make the system Apache execute code as root user, since the System Apache is typically started initially with root privileges. To close this gap, we now need to separate the system Apache configuration from the site user access. To eliminate the privilege escalation, you will have to execute the command <tt>omd update-apache-config [SITE]</tt> once for each of your sites after the <tt>omd update</tt> command. Besides the one-time fix, this change has a consequence for the use of <tt>omd config</tt> and <tt>omd update</tt>. There are two situations where this is relevant: a) If you change the options APACHE_TCP_ADDR, APACHE_TCP_PORT or APACHE_MODE You will have to call <tt>omd update-apache-config [SITE]</tt> as root user after changing one of the site configuration options APACHE_TCP_ADDR, APACHE_TCP_PORT or APACHE_MODE. This needs to be done to update and apply the system Apache configuration. If you don't do this and start your site, your UI may be not available anymore. The <tt>omd config</tt> command will output a warning to notify you about this necessary step in the future. b) If you execute <tt>omd update</tt> and the proxy configuration changes The update is performed as site user. Which means that, after this werk, we can not update and apply the system apache configuration anymore automatically. To apply the latest apache configuration, the command <tt>omd update-apache-config [SITE]</tt> needs to be executed after the update. The <tt>omd update</tt> will automatically detect the need for this additional step and show you a confirmation dialog before starting the update to notify you about this necessary step and giving you the chance to interrupt the procedure in case you don't have the option to execute the command as root user. All maintained versions (>=1.6) are subject to this vulnerability. It is likely that also previous versions were vulnerable. Users of previous versions are highly recommended to update or consider other mitigations. We thank Jan-Philipp Litza (PLUTEX GmbH) for reporting this issue! Change-Id: I03058d515dc4f53b3e998efd7b9e54389bf5656c Commit: 5caf25510a9720c861b291ad595f1746fd65ba56 https://github.com/tribe29/checkmk/commit/5caf25510a9720c861b291ad595f1746f… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/system_apache.py M tests/unit/omdlib/test_system_apache.py Log Message: ----------- 14288 FIX Fix Apache error message in case site Apache is not started With 2.1.0p7 and werk #14281 we changed the system Apache configuration which broke the System Apache error page that is shown to the user in case the site Apache is not running. It showed a 'Service Unavailable' message instead of the intended 'Checkmk: Site Not Started'. To apply this fix, you will have to execute <tt>omd update-apache-config [site]</tt> as root user after executing <tt>omd update</tt>. Change-Id: If13a0323885ae8993e6a655f53c4badc3071033d Commit: 407c913a3fd38ec706267682d44a7142a7dd76e2 https://github.com/tribe29/checkmk/commit/407c913a3fd38ec706267682d44a7142a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/system_apache.py M tests/unit/omdlib/test_system_apache.py Log Message: ----------- 14289 FIX Fix PermissionError during 'omd update' related to '/omd/apache' files When performing 'omd update' to 2.1.0p7 or newer, a PermissionError could occur, depending on the umask settings of your system. A traceback like this was visible in this situation: C+: Traceback (most recent call last): File "/omd/versions/2.1.0p8.cee/bin/omd", line 63, in <module> omdlib.main.main() File "/omd/versions/2.1.0p8.cee/lib/python3/omdlib/main.py", line 4665, in main command.handler(version_info, site, global_opts, args, command_options) File "/omd/versions/2.1.0p8.cee/lib/python3/omdlib/main.py", line 2726, in main_update not is_apache_hook_up_to_date(site) File "/omd/versions/2.1.0p8.cee/lib/python3/omdlib/system_apache.py", line 72, in is_apache_hook_up_to_date with open(os.path.join(omdlib.utils.omd_base_path(), "omd/apache/%s.conf" % site.name)) as f: PermissionError: [Errno 13] Permission denied: '/omd/apache/checkmk_test.conf' C-: The issue is fixed with as of this relase. However, you can workaround this issue by executing <tt>chmod o+r /omd/apache/*.conf</tt> as root before executing 'omd update'. Change-Id: I34692032f8d2e8536c603668c8b9e476b6ccb99d Commit: 2629db2aed8cfe67f4f872f6ee5fd952d093e8c3 https://github.com/tribe29/checkmk/commit/2629db2aed8cfe67f4f872f6ee5fd952d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M omd/packages/omd/omdlib/main.py R omd/packages/omd/skel/etc/apache/apache-own.conf Log Message: ----------- 14290 FIX Improve 'omd update' apache config handling The intended update warning that should be shown in case the Apache hook was not up-to-date was not shown correctly in 2.1.0p9. And during update a update warning <tt>Unwanted etc/apache/apache-own.conf (unchanged, deleted by you)</tt> was shown which could lead to confusions. This warning has been removed. Change-Id: I6b4a23d070ff2b9a38d6004790443869da019d32 Compare: https://github.com/tribe29/checkmk/compare/b89b74b4815e...2629db2aed8c

2 years, 1 month

[tribe29/checkmk] 80cb50: Update werk #13903 information regarding downgrades

by anthonyh209

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 80cb50df2e71ae17576bba1a338f87aa7bfeecbb https://github.com/tribe29/checkmk/commit/80cb50df2e71ae17576bba1a338f87aa7… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: M .werks/13903 Log Message: ----------- Update werk #13903 information regarding downgrades Change-Id: Ib785a2f5a9b47c2e585c1d1b0412fa32b0fabb86 Commit: 3b42b56f68481f88e4e41a92f32e4a908f54a6d3 https://github.com/tribe29/checkmk/commit/3b42b56f68481f88e4e41a92f32e4a908… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-08-03 (Wed, 03 Aug 2022) Changed paths: A .werks/14657 M cmk/gui/plugins/openapi/endpoints/service_discovery.py M tests/testlib/openapi_session.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_service_discovery.py Log Message: ----------- 14657 service_discovery: addition of tabula_rasa mode This werk adds the tabula_rasa mode to the execute service discovery endpoint. Change-Id: Iaca3d32cf439cd0540a507cac143808b6cdc82c4 Compare: https://github.com/tribe29/checkmk/compare/99bddb6f22bf...3b42b56f6848

2 years, 1 month

← Newer
1
...
42
43
44
45
46
47
48
...
53
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2022