Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: a8f8230e6fd4680e0286cf166f755521d11d0257
https://github.com/tribe29/checkmk/commit/a8f8230e6fd4680e0286cf166f755521d…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/gui/pagetypes.py
M cmk/gui/plugins/sidebar/bookmarks.py
M cmk/gui/sidebar/__init__.py
Log Message:
-----------
Pagetypes typing #1
Type hint "internal representation" dict of pagetype classes
Change-Id: I0c74114d585ac9027224c3c508c9522b52d53bd4
Commit: c713895b51c0041653b46cf4e10a74dc83ce068a
https://github.com/tribe29/checkmk/commit/c713895b51c0041653b46cf4e10a74dc8…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/gui/pagetypes.py
Log Message:
-----------
Move Overridable specific members from Base to Overridable
Change-Id: Ie5ca56445c341e3c6f9d33a6de9cd4476270e359
Commit: 75ec667f82de6679ef00c050bb3627c691d7c6a3
https://github.com/tribe29/checkmk/commit/75ec667f82de6679ef00c050bb3627c69…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/gui/pagetypes.py
M cmk/gui/plugins/sidebar/bookmarks.py
M cmk/gui/sidebar/__init__.py
Log Message:
-----------
Pagetypes typing #2
Add type hints to methods holding the instances of the overridables.
These should clearly be managed in a container object instead of a
class member variable. But that's something for a separate cleanup.
Change-Id: Ied9ca60759b6f5af7ab7b5b2b3f2daac55bf2b12
Commit: 460a984e4eb4aeea3203b51ea46acc177de26b81
https://github.com/tribe29/checkmk/commit/460a984e4eb4aeea3203b51ea46acc177…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/gui/pagetypes.py
M cmk/gui/plugins/sidebar/bookmarks.py
M cmk/gui/plugins/sidebar/utils.py
M cmk/gui/sidebar/__init__.py
Log Message:
-----------
Pagetypes typing #3
Spread type hints in all base and specific class methods. Especially in
the graphing related page types we still miss a lot of type hints since
there is much more than just the page type logic inside (e.g. the
implementation of the graph editors)
Change-Id: I2c6023edef23b6a5d18d7da0b3a16e49f6ecd307
Commit: f440e6d997e4d26bce7ed3f40e136d42a67dfdc5
https://github.com/tribe29/checkmk/commit/f440e6d997e4d26bce7ed3f40e136d42a…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/gui/pagetypes.py
Log Message:
-----------
pagetypes: Add abc
And fix the uncovered bug.
Change-Id: Ic79ece6c4d4c2913c5b9b9cbe7373367f7bb9d02
Commit: 82b226a9936a617977d6f248a032b9cc584ec693
https://github.com/tribe29/checkmk/commit/82b226a9936a617977d6f248a032b9cc5…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/gui/pagetypes.py
M cmk/gui/sidebar/__init__.py
Log Message:
-----------
Pagetypes typing #4
Add some more type hints and remove one dead function
Change-Id: Ibfd9e22b8eb83833ffa56be78c7fe054151b9ae1
Commit: 5cdd3a7bbf7997a78a06de5defc594542d72a5ef
https://github.com/tribe29/checkmk/commit/5cdd3a7bbf7997a78a06de5defc594542…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/gui/pagetypes.py
Log Message:
-----------
Pagetypes typing #5
Add remaining type hints and enforce all functions to be typed
on module level.
Change-Id: I8c75e401af45b043bae17be514e3d4d4e9f8908f
Compare: https://github.com/tribe29/checkmk/compare/9f4a439d95d7...5cdd3a7bbf79
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: a0ac50c1d7e888a85646ee58c99e5dc74cde6a10
https://github.com/tribe29/checkmk/commit/a0ac50c1d7e888a85646ee58c99e5dc74…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/gui/pagetypes.py
Log Message:
-----------
Move class to the bottom
Change-Id: I7df2523ef54a8bfec0a7b846a65a0d518a5622e5
Commit: 9f4a439d95d747f4b495445db8f47736fafb2b20
https://github.com/tribe29/checkmk/commit/9f4a439d95d747f4b495445db8f47736f…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/gui/pagetypes.py
Log Message:
-----------
Simplify pagetypes class hierarchy
The previous implementation was based on mixins and multiple inheritance
which made it quite hard to understand. In fact we only have two
variants we need to support:
CustomGraphPage(pagetypes.PageRenderer, pagetypes.OverridableContainer)
ForecastGraph(pagetypes.PageRenderer, pagetypes.OverridableContainer)
GraphCollection(pagetypes.PageRenderer, pagetypes.OverridableContainer)
CustomSnapins(pagetypes.Overridable)
BookmarkList(pagetypes.Overridable)
GraphTuning(pagetypes.Overridable)
SLAPagetype(pagetypes.Overridable)
PagetypeTopics(pagetypes.Overridable)
This change is now transforming the previous hierarchy to a cleaner
class hierarchy.
Change-Id: I575926042e868158f8c4098476847507f40a3f5b
Compare: https://github.com/tribe29/checkmk/compare/a275df931653...9f4a439d95d7
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: a275df9316534ca0850ea096f6caaaa2a08f300e
https://github.com/tribe29/checkmk/commit/a275df9316534ca0850ea096f6caaaa2a…
Author: Wontek Hong <wontek.hong(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
A .werks/14656
M cmk/gui/plugins/openapi/endpoints/service_discovery.py
M tests/testlib/openapi_session.py
M tests/unit/cmk/gui/plugins/openapi/test_openapi_service_discovery.py
Log Message:
-----------
14656 service discovery: addition of wait for completion endpoint
This werk introduces the wait for completion endpoint for
a service discovery run. The current redirect link in the
"Execute a service discovery on a host" with mode "refresh"
which previously linked to the service_discovery_run
object will be replaced by this newly introduced endpoint.
Change-Id: I0c03883c7650261e93350d80a58ef8c3a9785145
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 6b537f0e93dc00b38110f6a0e44277bcef122876
https://github.com/tribe29/checkmk/commit/6b537f0e93dc00b38110f6a0e44277bce…
Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/special_agents/utils_kubernetes/transform.py
Log Message:
-----------
transform: fix broken if-branch
api.PodSpec cannot be initialized without the missing fields.
However, the corresponding if-branch would never be entered.
The pydantic.mypy plugin can detect this issue (see ticket).
CMK-10333
Change-Id: Ifd5fe0eb4f9d1d1a1839848114f1c331b2e749b6
Commit: 490d3d3d8e989b5e44eafed01ab8bc0690d01057
https://github.com/tribe29/checkmk/commit/490d3d3d8e989b5e44eafed01ab8bc069…
Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M cmk/special_agents/utils_kubernetes/transform_json.py
Log Message:
-----------
transform_json: use NotRequired
PEP 589 specified inheritance as the way to achieve a mix of optional
and mandatory keys in a TypedDict. However, with python 3.11 a newer
syntax is becoming available, which avoids defining multiple TypedDicts'
and therefore makes it possible to keys belonging to one definition. We
can access this new syntax via typing_extensions.
Change-Id: Ie3a754c9fb65d48d59fd4af37f521b4e0e56fa3b
Compare: https://github.com/tribe29/checkmk/compare/59b740bde1e4...490d3d3d8e98
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 8a9c3bda2445bd2b16b3591bdb6b2041ccf833a7
https://github.com/tribe29/checkmk/commit/8a9c3bda2445bd2b16b3591bdb6b2041c…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M livestatus/src/MonitoringCore.h
M livestatus/src/NagiosCore.cc
M livestatus/src/NagiosCore.h
M livestatus/src/test/test_Table.cc
Log Message:
-----------
We always have a (Monitoring)Core.
The previous nullptr hacks were just for the sake of testing, but we can do
this differently by using a dummy (Monitoring)Core.
Change-Id: Ie87f0a7f0db4673b5f72cc3003179c102cc802ab
Commit: 59b740bde1e478e7f2401bd2813480b2cfde4a5d
https://github.com/tribe29/checkmk/commit/59b740bde1e478e7f2401bd2813480b2c…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2022-07-27 (Wed, 27 Jul 2022)
Changed paths:
M livestatus/src/test/test_Table.cc
Log Message:
-----------
Use a real LogCache for testing.
Change-Id: If3837fc5b686d6223954c59a69e0fc4c44834149
Compare: https://github.com/tribe29/checkmk/compare/75370e85a48c...59b740bde1e4