Checkmk git commits May 2022

checkmk-commits@lists.checkmk.com

1 participants
664 discussions

[tribe29/checkmk] d31642: Add timing to the build script win agent

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d31642b7ef2db73290baf2b51a3820fbc96942e7 https://github.com/tribe29/checkmk/commit/d31642b7ef2db73290baf2b51a3820fbc… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M agents/wnx/build_release.cmd Log Message: ----------- Add timing to the build script win agent Change-Id: Ibcfd1b404a3ef38c3d35d1d1aefa26dd74443170

2 years, 4 months

[tribe29/checkmk] 323f38: Fix typing around microcore_config.py #1

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 323f38a8f9a35d642b2414ebf23093d7f58174e8 https://github.com/tribe29/checkmk/commit/323f38a8f9a35d642b2414ebf23093d7f… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M cmk/utils/rulesets/ruleset_matcher.py Log Message: ----------- Fix typing around microcore_config.py #1 Change-Id: Ic15fc9b0d3a652ca971d7fbbc5c6a52463c28849

2 years, 4 months

[tribe29/checkmk] 29675f: Use language neutral API to get perf counter

by Sergey Kipnis

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 29675f91cb2b13c06f8bb831179406e7a884671b https://github.com/tribe29/checkmk/commit/29675f91cb2b13c06f8bb831179406e7a… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M agents/wnx/src/engine/providers/perf_cpuload.cpp Log Message: ----------- Use language neutral API to get perf counter Change-Id: I20b22308341bec13e379e9a9f5b853c98fb15913

2 years, 4 months

[tribe29/checkmk] deb4de: Fixed type of canvas attributes.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: deb4de78fbb2dc89d28b213817aa269a29f1637c https://github.com/tribe29/checkmk/commit/deb4de78fbb2dc89d28b213817aa269a2… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M cmk/gui/plugins/metrics/html_render.py Log Message: ----------- Fixed type of canvas attributes. NOTE: Our metrics-related code is still completely untyped, so passing wrong values to e.g. HTML rendering code is not detected by mypy. Change-Id: I85819f14d759c80b17a2209a89f6683c9b796bb1 Commit: 37599628a948897378edbed0f1b08e191c9177f6 https://github.com/tribe29/checkmk/commit/37599628a948897378edbed0f1b08e191… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M cmk/gui/htmllib/html.py M cmk/gui/htmllib/tag_rendering.py M cmk/gui/page_state.py M cmk/gui/table.py M tests/unit/cmk/gui/htmllib/test_tag_rendering.py Log Message: ----------- Simplify/remove dispatch code after CSSSpec simplifications. Change-Id: I121a781fda6e02e5ad57bc0969221c08f25189e7 Compare: https://github.com/tribe29/checkmk/compare/e413a0e012a0...37599628a948

2 years, 4 months

[tribe29/checkmk] e413a0: 13420 FIX section parsing with different separators

by Benedikt Seidl

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e413a0e012a0908d80ef20eb4ac74f9dad9f0967 https://github.com/tribe29/checkmk/commit/e413a0e012a0908d80ef20eb4ac74f9da… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: A .werks/13420 M cmk/core_helpers/agent.py M tests/unit/cmk/core_helpers/test_parsers.py Log Message: ----------- 13420 FIX section parsing with different separators In checkmk it's possible to transport a single section with different separators: <<<section:sep(44)>>> a,1 <<<section:sep(124)>>> b|2 <<<section:sep(44)>>> c,3 Up until this werk, the ordering of the lines where not preserved, the check function would have received them as a,1 c,3 b,2 On a technical level previous to this commit all sections with the same header (name, separator, caching etc.) where merged into a single section. This means for the example above: "c,3" with "<<<section:sep(44)>>>" was merged to the section "a,1" because they share the same section header. But this would lead to a wrong ordering: a,1 c,3 b,2 This was done with the help of a dictionary. This dictionary was replaced by a list and merging only takes place between the last and the current section (if they share the same header). CMK-10492 Change-Id: I89db1af35aa23cff72a9dc2f15cb0e4c233c0bfc

2 years, 4 months

[tribe29/checkmk] 915c6f: 14094 FIX Permission error during agent controller...

by PhilippSiegmantel

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 915c6f92b37d25d1b50fe59662d7a4a2df17a427 https://github.com/tribe29/checkmk/commit/915c6f92b37d25d1b50fe59662d7a4a2d… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: A .werks/14094 M agents/scripts/cmk-agent-useradd.sh Log Message: ----------- 14094 FIX Permission error during agent controller installation A regression in Checkmk 2.1.0b9 could lead to a permission error during the installation of the Checkmk agent. Change-Id: I16ddb8b59cf8b0cb99fb08b57705b73a7649d555 Commit: e620949b59142ee328bd592fd6b0d2134b9ef02f https://github.com/tribe29/checkmk/commit/e620949b59142ee328bd592fd6b0d2134… Author: Philipp Siegmantel <philipp.siegmantel(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: A .werks/13948 M active_checks/check_bi_aggr M cmk/gui/plugins/openapi/endpoints/bi.py M cmk/gui/plugins/openapi/restful_objects/type_defs.py M cmk/gui/plugins/wato/active_checks.py M cmk/special_agents/agent_bi.py M tests/testlib/openapi_session.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_bi.py Log Message: ----------- 13948 Switch BI check and agent to the REST API The BI active check and agent will now use the REST API to retrive data. This also means that cookie authentication mode in the active check is no longer supported. You can use the header mode (the new default) instead. CMK-10262 Change-Id: I004941ec39e35dbcf5cd02bf9b0ab0e49297e2d0 Compare: https://github.com/tribe29/checkmk/compare/b224e10a0401...e620949b5914

2 years, 4 months

[tribe29/checkmk] 9a4dbf: 14094 FIX Permission error during agent controller...

by PhilippSiegmantel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9a4dbfb9715322a9b6fcac5f03c86d1b8f9a261b https://github.com/tribe29/checkmk/commit/9a4dbfb9715322a9b6fcac5f03c86d1b8… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: A .werks/14094 M agents/scripts/cmk-agent-useradd.sh Log Message: ----------- 14094 FIX Permission error during agent controller installation A regression in Checkmk 2.1.0b9 could lead to a permission error during the installation of the Checkmk agent. Change-Id: I16ddb8b59cf8b0cb99fb08b57705b73a7649d555 Commit: f5466174eac5b58415d0e40d0d89bac71827d6a1 https://github.com/tribe29/checkmk/commit/f5466174eac5b58415d0e40d0d89bac71… Author: Philipp Siegmantel <philipp.siegmantel(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: A .werks/13944 M web/htdocs/themes/facelift/scss/_dashboard.scss Log Message: ----------- Long text in the inventory dashlet will now break into multiple lines Instead of rendering the text of the inventory dashlet on one line, the text will now break into multiple lines if not enough space is there. CMK-9893 Change-Id: Ia502d349263ca43a28121c46eaae796b99456795 Compare: https://github.com/tribe29/checkmk/compare/af892d2fd42a...f5466174eac5

2 years, 4 months

[tribe29/checkmk] ae3de3: Update incorrect werk text

by Benedikt Seidl

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: ae3de3da50ae676ce412e36a64eba4f0ea4f6b72 https://github.com/tribe29/checkmk/commit/ae3de3da50ae676ce412e36a64eba4f0e… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M .werks/14128 Log Message: ----------- Update incorrect werk text There is no default RegExp in checkmk. Change-Id: I287e2866c80854edd94210e882511e0ad81dd540 Commit: b224e10a0401105b3731d0e8323a3857cb93c850 https://github.com/tribe29/checkmk/commit/b224e10a0401105b3731d0e8323a3857c… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: A .werks/13420 M cmk/core_helpers/agent.py M tests/unit/cmk/core_helpers/test_parsers.py Log Message: ----------- 13420 FIX section parsing with different separators In checkmk it's possible to transport a single section with different separators: <<<section:sep(44)>>> a,1 <<<section:sep(124)>>> b|2 <<<section:sep(44)>>> c,3 Up until this werk, the ordering of the lines where not preserved, the check function would have received them as a,1 c,3 b,2 On a technical level previous to this commit all sections with the same header (name, separator, caching etc.) where merged into a single section. This means for the example above: "c,3" with "<<<section:sep(44)>>>" was merged to the section "a,1" because they share the same section header. But this would lead to a wrong ordering: a,1 c,3 b,2 This was done with the help of a dictionary. This dictionary was replaced by a list and merging only takes place between the last and the current section (if they share the same header). CMK-10492 Change-Id: I89db1af35aa23cff72a9dc2f15cb0e4c233c0bfc Compare: https://github.com/tribe29/checkmk/compare/d12e3c6bbde7...b224e10a0401

2 years, 4 months

[tribe29/checkmk] af892d: 13724 SEC Remove legacy macro expansion in Event C...

by Maximilian

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: af892d2fd42af68b4a611116495191a59a51c8c7 https://github.com/tribe29/checkmk/commit/af892d2fd42af68b4a611116495191a59… Author: Maximilian Wirtz <maximilian.wirtz(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: A .werks/13724 M cmk/ec/actions.py M cmk/gui/wato/mkeventd.py M cmk/update_config.py Log Message: ----------- 13724 SEC Remove legacy macro expansion in Event Console script actions The Event Console is able to execute actions, e.g. shell scripts, when opening or cancelling events. Details of the events are available to the script via environment variables <tt>CMK_</tt> as described in the user manual (https://docs.checkmk.com/latest/en/ec.html#_shell_scripts_and_emails). This mechanism will keep working as before. However, there is a second undocumented mechanism which relies on macro expansion in the shell scripts. Previously it was possible to use macros (e.g. <tt>$HOST$</tt>) in the <i>Event Console</i> scripts. These were replaced before executing the script. The values of these macros can be untrusted input and lead to command injections. You are only affected by this issue, if your scripts use the macro expansion. With this incompatible change we remove the macro expansion mechanism for security reasons. The site update mechanism tries to detect Event Console actions using these macros, disables the actions and informs you about this change. The output of an <tt>omd update</tt> for a rule being disabled would look like this: C+: "Script 'some_action_id' uses macros. We disable it. Please replace the macros with proper variables before enabling it again!" C-: If you use the <i>Event Console</i> with shell script actions you should check your scripts for macros and replace them with the documented environment variable approach (Setup > Events > Event Console rule packs > Event Console configuration > Event Console configuration). You can access all macro values with environment variables (they are prefixed with <tt>CMK_</tt>). Change-Id: Ia587b19575003c6f501dc4fe5066af1781a7fef8

2 years, 4 months

[tribe29/checkmk] efc22b: 13545 FIX HW/SW Inventory: Fix loading paint funct...

by Max Linke

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: efc22ba8c39865033a63c2dec47d919e63b5dbfa https://github.com/tribe29/checkmk/commit/efc22ba8c39865033a63c2dec47d919e6… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: A .werks/13545 M cmk/gui/views/__init__.py M cmk/gui/views/inventory.py Log Message: ----------- 13545 FIX HW/SW Inventory: Fix loading paint function from local display hints Change-Id: Iaeb89e4549e0cd24cdb1067fe34214b73d2b3592 Commit: 2b3043c3ee40d2c29941837ff15c2f5dc547be20 https://github.com/tribe29/checkmk/commit/2b3043c3ee40d2c29941837ff15c2f5dc… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M checks/heartbeat_crm M tests/unit/cmk/base/plugins/agent_based/test_section_properties.py Log Message: ----------- towards section definiton 4 Only parse once. Raising in the parse function will make the Check_MK service go to warning, and create a crash report. Change-Id: Ib4c8a09d5b5b7f48d523a55e356db9416460288f Commit: 2414132976d3e066b6a2124bd4166c048226a99f https://github.com/tribe29/checkmk/commit/2414132976d3e066b6a2124bd4166c048… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M checks/heartbeat_crm M cmk/gui/plugins/wato/check_parameters/heartbeat_crm.py Log Message: ----------- drop unneeded transform Change-Id: I0fe7514630ed062e4943a24a3649b72b005b8beb Commit: 59aab461a4d2c3ae8fd08a7ecce95f503d547c5b https://github.com/tribe29/checkmk/commit/59aab461a4d2c3ae8fd08a7ecce95f503… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M checks/heartbeat_crm Log Message: ----------- improve typing & names Change-Id: I3deebeb8535651d88c602d4a5f20883bac723e96 Commit: d1000783bf428c690085ffe328c9352e9ecc094b https://github.com/tribe29/checkmk/commit/d1000783bf428c690085ffe328c9352e9… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M checks/heartbeat_crm M cmk/gui/plugins/wato/check_parameters/heartbeat_crm_resources.py M tests/unit/checks/generictests/datasets/heartbeat_crm.py M tests/unit/checks/generictests/datasets/heartbeat_crm_failed_actions.py M tests/unit/cmk/gui/plugins/wato/check_parameters/test_plugin_vs_wato.py Log Message: ----------- make parameters a dict Change-Id: I20ebaaaa8535835275ba20728c09ec61942afeb3 Commit: 6d8cbc44debfa3712657651edd4cb72d80a61970 https://github.com/tribe29/checkmk/commit/6d8cbc44debfa3712657651edd4cb72d8… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Improve valuespec typing Change-Id: I072d27db9ff12e8129d130b99f8f9e5266b86d35 Compare: https://github.com/tribe29/checkmk/compare/e75fd901a10b...6d8cbc44debf

2 years, 4 months

← Newer
1
...
20
21
22
23
24
25
26
...
67
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits May 2022