Checkmk git commits March 2022

checkmk-commits@lists.checkmk.com

1 participants
733 discussions

[tribe29/checkmk] 6e01cf: Small cleanup in logwatch unit tests

by Jörg Herbel

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 6e01cff54ab89d27ab40c2e8f9852ce26d4a27c5 https://github.com/tribe29/checkmk/commit/6e01cff54ab89d27ab40c2e8f9852ce26… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M tests/unit/cmk/base/plugins/agent_based/test_logwatch.py Log Message: ----------- Small cleanup in logwatch unit tests Change-Id: Ided11a92f183190941e8a328be78ca446393c7ad Commit: 1943f55f66a3e86626acb57b3349d675f89ed0d2 https://github.com/tribe29/checkmk/commit/1943f55f66a3e86626acb57b3349d675f… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/base/plugins/agent_based/logwatch.py M tests/unit/cmk/base/plugins/agent_based/test_logwatch.py Log Message: ----------- logwatch: add some unit tests Also includes a tiny refactoring to make the logwatch code more testable. This is a preparation for a bugfix. Change-Id: I1ef5d5758a34e99805ab3abe0b9fccce0372365c Commit: dec0153c18a1a260d9970688a68e9531a20ce434 https://github.com/tribe29/checkmk/commit/dec0153c18a1a260d9970688a68e9531a… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: A .werks/13759 M cmk/base/plugins/agent_based/logwatch.py M tests/unit/cmk/base/plugins/agent_based/test_logwatch.py Log Message: ----------- 13759 FIX logwatch: Fix persistance of transferred log lines in Checkmk site Change-Id: I7669b5ed32679bc9f2dcbb815eb274494c418272 Compare: https://github.com/tribe29/checkmk/compare/56ded88537c8...dec0153c18a1

2 years, 6 months

[tribe29/checkmk] 244ae1: Small cleanup in logwatch unit tests

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 244ae1bf9c1e6a88d9776cca9c7d8847b7d165a0 https://github.com/tribe29/checkmk/commit/244ae1bf9c1e6a88d9776cca9c7d8847b… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M tests/unit/cmk/base/plugins/agent_based/test_logwatch.py Log Message: ----------- Small cleanup in logwatch unit tests Change-Id: Ided11a92f183190941e8a328be78ca446393c7ad Commit: d2e76bca985c7b7c2d66dcf35b4dee9508c7b547 https://github.com/tribe29/checkmk/commit/d2e76bca985c7b7c2d66dcf35b4dee950… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/base/plugins/agent_based/logwatch.py M tests/unit/cmk/base/plugins/agent_based/test_logwatch.py Log Message: ----------- logwatch: add some unit tests Also includes a tiny refactoring to make the logwatch code more testable. This is a preparation for a bugfix. Change-Id: I1ef5d5758a34e99805ab3abe0b9fccce0372365c Commit: 6cf3c1cf1aa6dcbe7296ad9d0e5f32f994508cd0 https://github.com/tribe29/checkmk/commit/6cf3c1cf1aa6dcbe7296ad9d0e5f32f99… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/base/plugins/agent_based/logwatch.py M tests/unit/cmk/base/plugins/agent_based/test_logwatch.py Log Message: ----------- logwatch: Fix persistance of transferred log lines in Checkmk site Change-Id: I7669b5ed32679bc9f2dcbb815eb274494c418272 Compare: https://github.com/tribe29/checkmk/compare/7ad0301e434f...6cf3c1cf1aa6

2 years, 6 months

[tribe29/checkmk] 032bf8: 13315 Add support for Checkmk Appliance 1.5+

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 032bf87f3d3df9025765df1cc56b718effdc2586 https://github.com/tribe29/checkmk/commit/032bf87f3d3df9025765df1cc56b718ef… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: A .werks/13315 A buildscripts/infrastructure/build-nodes/cma-3 M omd/Makefile Log Message: ----------- 13315 Add support for Checkmk Appliance 1.5+ Change-Id: Ib8b2f0810184ae2c7b7a78be121341f9f3b3d464

2 years, 6 months

[tribe29/checkmk] 14b107: kube_node_conditions: move condition summary and d...

by anthonyh209

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 14b107a135fa08c8c13964bad3bb1a6ec1a10271 https://github.com/tribe29/checkmk/commit/14b107a135fa08c8c13964bad3bb1a6ec… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/base/plugins/agent_based/kube_node_conditions.py M cmk/base/plugins/agent_based/utils/kube.py Log Message: ----------- kube_node_conditions: move condition summary and details parser to utils/kube Change-Id: Ia098e2a49921c184a13e2aa71b2615b300d5302f Commit: fcf5a2fece8ea9b53784f4fe1b74b80fcfb16b9a https://github.com/tribe29/checkmk/commit/fcf5a2fece8ea9b53784f4fe1b74b80fc… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/base/plugins/agent_based/kube_pod_conditions.py M tests/unit/cmk/base/plugins/agent_based/test_kube_pod_conditions.py Log Message: ----------- KUBE kube_pod_conditions: unify condition checks Change-Id: I089ec52ce749aa1f2359b6b6531ac05a32f4d954 Commit: 7ad0301e434f7b32c5b3e92453908be9b7330640 https://github.com/tribe29/checkmk/commit/7ad0301e434f7b32c5b3e92453908be9b… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/base/plugins/agent_based/kube_deployment_conditions.py M tests/unit/cmk/base/plugins/agent_based/test_kube_deployment_conditions.py Log Message: ----------- KUBE kube_deployment_conditions: unify condition checks Change-Id: I13a68864c8f4bd56f6644f7ad2ad9b7d49c49312 Compare: https://github.com/tribe29/checkmk/compare/fc9272b0576e...7ad0301e434f

2 years, 6 months

[tribe29/checkmk] 1db2eb: 13411 FIX Cisco Prime: Add host options

by Benedikt Seidl

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 1db2eb66c80d27b8b6b687d38c6194c478baefd0 https://github.com/tribe29/checkmk/commit/1db2eb66c80d27b8b6b687d38c6194c47… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: A .werks/13411 M checks/agent_cisco_prime M cmk/gui/plugins/wato/datasource_programs.py M tests/unit/checks/test_agent_cisco_prime.py Log Message: ----------- 13411 FIX Cisco Prime: Add host options Before this change the ip address was used to connect to the Cisco Prime server. This could lead to problems if a TLS connection was used and the certificate was only valid for the domain and not for the ip address. Now it's possible to choose whether the ip address, the host name or a custom host should be used. SUP-9637 Change-Id: Ic6e734c3f04282e617b64b7b81398eed023ecc57

2 years, 6 months

[tribe29/checkmk] fc9272: remove some monkeypatching

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: fc9272b0576edc52310aefc1f7ab58e6ea7e2aca https://github.com/tribe29/checkmk/commit/fc9272b0576edc52310aefc1f7ab58e6e… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/base/plugins/agent_based/kube_pod_restarts.py M cmk/base/plugins/agent_based/kube_replicas.py M tests/unit/cmk/base/plugins/agent_based/test_kube_pod_restarts.py M tests/unit/cmk/base/plugins/agent_based/test_kube_replicas.py Log Message: ----------- remove some monkeypatching Change-Id: Ia5c9007dc08868a502157a3f05e637ab9a35ff9d

2 years, 6 months

[tribe29/checkmk] 56ded8: remove some monkeypatching

by Moritz

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 56ded88537c80008f6247f3c836bd1d0c3f4e387 https://github.com/tribe29/checkmk/commit/56ded88537c80008f6247f3c836bd1d0c… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/base/plugins/agent_based/kube_pod_restarts.py M cmk/base/plugins/agent_based/kube_replicas.py M tests/unit/cmk/base/plugins/agent_based/test_kube_pod_restarts.py M tests/unit/cmk/base/plugins/agent_based/test_kube_replicas.py Log Message: ----------- remove some monkeypatching Change-Id: Ia5c9007dc08868a502157a3f05e637ab9a35ff9d

2 years, 6 months

[tribe29/checkmk] 805ead: Fix bad interaction between chrony and systemd-tim...

by Moritz Schlarb

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 805eadb33310b59905a9f3dfb6a38cb76da74a44 https://github.com/tribe29/checkmk/commit/805eadb33310b59905a9f3dfb6a38cb76… Author: Moritz Schlarb <schlarbm(a)uni-mainz.de> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: A .werks/13816 M agents/check_mk_agent.linux Log Message: ----------- Fix bad interaction between chrony and systemd-timesyncd Actually calling `timedatectl timesync-status` otherwise leads to the chronyd service being stopped... The real systemd condition list can be seen here: https://sources.debian.org/src/systemd/241-7%7Edeb10u8/debian/extra/units/s… Signed-off-by: Max Linke <max.linke(a)tribe29.com> Change-Id: I450618df2f655defddf1f5663018a583d7ea2725

2 years, 6 months

[tribe29/checkmk] 790193: 13093 Various ValueSpec-related API cleanups

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7901938bfd82a9b974895df8d98a3675f8b92305 https://github.com/tribe29/checkmk/commit/7901938bfd82a9b974895df8d98a3675f… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M .werks/13093 Log Message: ----------- 13093 Various ValueSpec-related API cleanups Various changes have been done to <tt>ValueSpec</tt> and its subclasses, improving maintainability and robustness. If you don't write your own complicated <tt>ValueSpec</tt> subclasses and you don't have any self-written complicated check parameters, you are probably not affected. <ul> <li> <tt>ValueSpec</tt>'s constructor doesn't accept any random unspecifed keyword arguments anymore. It is better to raise an exception at the incorrect call site than silently accepting every typo. To fix any problems with this change, just remove the offending keyword arguments, they served no purpose after all. </li> <li> <tt>ValueSpec.canonical_value()</tt> is an abstract method now, otherwise we force lots of places to handle <tt>None</tt>. Previously quite a few things worked only more or less by accident. If you implement your own <tt>ValueSpec</tt> subclass, you have to implement that method now, unless an intermediate class already does it for you. </li> <li> <tt>DropdownChoice</tt> and <tt>CascadingDropdown</tt> don't have a <tt>no_preselect</tt> keyword argument anymore. It was redundant, because <tt>no_preselect_title</tt> is enough: If this keyword argument is not <tt>None</tt>, <tt>no_preselect=True</tt> is implied. Previously one could specify nonsensical combinations of those arguments. To fix any problems with this change, just drop the <tt>no_preselect</tt> keyword argument. </li> <li> <tt>Alternative</tt>, <tt>UploadOrPasteTextFile</tt>, <tt>TextOrRegExp</tt>, and <tt>CAorCAChain</tt> don't have a <tt>style</tt> keyword argument anymore. It didn't serve any purpose since Checkmk 2.0. Just remove it. </li> </ul> Change-Id: Ie1b183f941a45a913bc741541aaae123231f9808 Commit: 6ac0f5049bb61b996562222476a98adcbe170b6b https://github.com/tribe29/checkmk/commit/6ac0f5049bb61b996562222476a98adcb… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M .werks/13093 Log Message: ----------- Revert "13093 Various ValueSpec-related API cleanups" Somehow the werks numbers clashed... :-/ This reverts commit 7901938bfd82a9b974895df8d98a3675f8b92305. Commit: 0b29e49748da3f4902dc907b57b7139f63a10762 https://github.com/tribe29/checkmk/commit/0b29e49748da3f4902dc907b57b7139f6… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: A .werks/13094 Log Message: ----------- 13094 Various ValueSpec-related API cleanups Various changes have been done to <tt>ValueSpec</tt> and its subclasses, improving maintainability and robustness. If you don't write your own complicated <tt>ValueSpec</tt> subclasses and you don't have any self-written complicated check parameters, you are probably not affected. <ul> <li> <tt>ValueSpec</tt>'s constructor doesn't accept any random unspecifed keyword arguments anymore. It is better to raise an exception at the incorrect call site than silently accepting every typo. To fix any problems with this change, just remove the offending keyword arguments, they served no purpose after all. </li> <li> <tt>ValueSpec.canonical_value()</tt> is an abstract method now, otherwise we force lots of places to handle <tt>None</tt>. Previously quite a few things worked only more or less by accident. If you implement your own <tt>ValueSpec</tt> subclass, you have to implement that method now, unless an intermediate class already does it for you. </li> <li> <tt>DropdownChoice</tt> and <tt>CascadingDropdown</tt> don't have a <tt>no_preselect</tt> keyword argument anymore. It was redundant, because <tt>no_preselect_title</tt> is enough: If this keyword argument is not <tt>None</tt>, <tt>no_preselect=True</tt> is implied. Previously one could specify nonsensical combinations of those arguments. To fix any problems with this change, just drop the <tt>no_preselect</tt> keyword argument. </li> <li> <tt>Alternative</tt>, <tt>UploadOrPasteTextFile</tt>, <tt>TextOrRegExp</tt>, and <tt>CAorCAChain</tt> don't have a <tt>style</tt> keyword argument anymore. It didn't serve any purpose since Checkmk 2.0. Just remove it. </li> </ul> Change-Id: I7cb1aad259b3a0c79594b6bf22e08acea7ed8220 Compare: https://github.com/tribe29/checkmk/compare/2061a88817a7...0b29e49748da

2 years, 6 months

[tribe29/checkmk] 6feabf: Removed an unused keyword argument.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6feabf5c7de09c1ccc9344116a9ea6434627c7e8 https://github.com/tribe29/checkmk/commit/6feabf5c7de09c1ccc9344116a9ea6434… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/gui/plugins/wato/bi_config.py M cmk/gui/plugins/wato/bi_valuespecs.py M cmk/gui/valuespec.py Log Message: ----------- Removed an unused keyword argument. It was effectively dead for 2 releases already. Change-Id: I397518a7ef3e4c4ae7b4c1e62724e0c368d57ac2 Commit: 2061a88817a75b54985ed8f125bdd246069c84aa https://github.com/tribe29/checkmk/commit/2061a88817a75b54985ed8f125bdd2460… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-03-10 (Thu, 10 Mar 2022) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Revert enforcing keyword-only arguments for ValueSpecs constructors. Although our own code is clean regarding this change, and the change itself is very desirable: It would probably break too many checks out in the wild. We really need some deprecation/migration strategy for things like this, maintaining a horrible API forever just doesn't work... Change-Id: I9fb3da41f496135deb132b78a9c88e353014a62c Compare: https://github.com/tribe29/checkmk/compare/bf396233c649...2061a88817a7

2 years, 6 months

← Newer
1
...
43
44
45
46
47
48
49
...
74
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits March 2022