Checkmk git commits November 2022

checkmk-commits@lists.checkmk.com

1 participants
706 discussions

[tribe29/checkmk] 4bda0b: 14967 Timesyncd check plugin: Include metrics for ...

by rseltmann

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4bda0b0a919a116506003434b91def1b7778cf0d https://github.com/tribe29/checkmk/commit/4bda0b0a919a116506003434b91def1b7… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: A .werks/14967 Log Message: ----------- 14967 Timesyncd check plugin: Include metrics for sync times, change check behavior when NTP server not reachable and future-proofing Since at least systemd v250 <tt>/var/lib/systemd/timesync/clock</tt> should no longer be used to determine the time since the last synchronisation, instead the modification time of <tt>/run/systemd/timesync/synchronized</tt> is now used. To monitor the reliability of this time, this werk also introduces two new metrics: LI: Time since last synchronisation: The modification time of <tt>/run/systemd/timesync/synchronized</tt> if available, otherwise <tt>/var/lib/systemd/timesync/clock</tt>. LI: Time since last NTPMessage: When the last message from the NTP server was received. To have these metrics available, the Checkmk linux agent needs to be updated, otherwise only the time since last synchronisation based on <tt>/var/lib/systemd/timesync/clock</tt> will be shown. Since the modification time of /var/lib/systemd/timesync/clock can at times be unsuitable to monitor when synchronization occurred (due to limited error handling in earlier systemd version), the default threshold for the allowed duration since last synchronisation has been removed. If you want to apply thresholds to the time since last synchronisation you now have to enable the rule manually. The default thresholds for the allowed duration since last NTPMessage have been set to 1h (WARN) and 2h (CRIT). Additionally, the behavior of the check was changed to go to CRIT when the NTP server could not be reached for synchronisation. In the course of the werk the rendering of the jitter was also corrected to show a time span instead of a date. CMK-11089 Change-Id: Iffa13ab0851e557e785905b09739ef421b73538a

1 year, 8 months

[tribe29/checkmk] 596b5c: Do not set check limits for time since last sync p...

by rseltmann

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 596b5c923b73d4e7d1eaf2258c6ea821dbf7bbc9 https://github.com/tribe29/checkmk/commit/596b5c923b73d4e7d1eaf2258c6ea821d… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Do not set check limits for time since last sync per default Since the time can not reliably be used to check if sync occurred (limited error messages when adjusting system clock depending on systemd version). Main focus should be on monitoring time offset CMK-11089 Change-Id: I5d860a51eb5df32058f89c4fda583261698a22cc

1 year, 8 months

[tribe29/checkmk] 383c63: Add NTPMessage from timedatectl to linux agent

by rseltmann

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 383c63568858593c4ef6567ff14d1398c74468b1 https://github.com/tribe29/checkmk/commit/383c63568858593c4ef6567ff14d1398c… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M agents/check_mk_agent.linux M cmk/base/plugins/agent_based/timesyncd.py M cmk/gui/plugins/metrics/network.py M cmk/gui/plugins/wato/check_parameters/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Add NTPMessage from timedatectl to linux agent and monitor time since last NTPMessage CMK-11089 Change-Id: I2de33943ffcdff63f69b5c868baa3873a1ba4db2 Commit: 77c09a31589161a866b2e9398e1554817ae82c52 https://github.com/tribe29/checkmk/commit/77c09a31589161a866b2e9398e1554817… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M agents/check_mk_agent.linux Log Message: ----------- Use /run/systemd/timesync/synchronized to get last sync time if available instead of /var/lib/systemd/timesync/clock which will not be available in newer systemd versions CMK-11089 Change-Id: I7287f95e77617d6c7934a90203ed0fb9430bef1f Compare: https://github.com/tribe29/checkmk/compare/562208292740...77c09a315891

1 year, 8 months

[tribe29/checkmk] 562208: Let timesyncd service become CRIT if NTP server no...

by rseltmann

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5622082927409d2ce0f08010e7974c116f6e324a https://github.com/tribe29/checkmk/commit/5622082927409d2ce0f08010e7974c116… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Let timesyncd service become CRIT if NTP server not reachable to synchronize CMK-11089 Change-Id: Ia045d81b9cd5bd859719def7affc991642515ef4

1 year, 8 months

[tribe29/checkmk] 48de0a: Refactor tolerance_check to allow checking differe...

by rseltmann

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 48de0ab84dd7678e82229d1c18ebda44e166867f https://github.com/tribe29/checkmk/commit/48de0ab84dd7678e82229d1c18ebda44e… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/ntp.py M cmk/base/plugins/agent_based/timesyncd.py M cmk/base/plugins/agent_based/utils/timesync.py M tests/unit/cmk/base/plugins/agent_based/test_ntp.py M tests/unit/cmk/base/plugins/agent_based/utils/test_timesync.py Log Message: ----------- Refactor tolerance_check to allow checking different metrics CMK-11089 Change-Id: I8c99c41d720b3ae3f526c2de41d897bc1cc79738 Commit: e558eca99bf11a43f24ac9d4d40e20226ba34c7b https://github.com/tribe29/checkmk/commit/e558eca99bf11a43f24ac9d4d40e20226… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Let timesyncd service become CRIT if NTP server not reachable to synchronize CMK-11089 Change-Id: Ia045d81b9cd5bd859719def7affc991642515ef4 Commit: dcde7e59e0ef8dce0bb023d7947cb2f57c290ba1 https://github.com/tribe29/checkmk/commit/dcde7e59e0ef8dce0bb023d7947cb2f57… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M agents/check_mk_agent.linux M cmk/base/plugins/agent_based/timesyncd.py M cmk/gui/plugins/metrics/network.py M cmk/gui/plugins/wato/check_parameters/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Add NTPMessage from timedatectl to linux agent and monitor time since last NTPMessage CMK-11089 Change-Id: I2de33943ffcdff63f69b5c868baa3873a1ba4db2 Commit: b790a7be625485eea120242ecd1aa7b03e9f4c24 https://github.com/tribe29/checkmk/commit/b790a7be625485eea120242ecd1aa7b03… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M agents/check_mk_agent.linux Log Message: ----------- Use /run/systemd/timesync/synchronized to get last sync time if available instead of /var/lib/systemd/timesync/clock which will not be available in newer systemd versions CMK-11089 Change-Id: I7287f95e77617d6c7934a90203ed0fb9430bef1f Commit: e4bd9472d5e456c72bfe1218f21ac74f2d1750cd https://github.com/tribe29/checkmk/commit/e4bd9472d5e456c72bfe1218f21ac74f2… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/timesyncd.py M tests/unit/cmk/base/plugins/agent_based/test_timesyncd.py Log Message: ----------- Do not set check limits for time since last sync per default Since the time can not reliably be used to check if sync occurred (limited error messages when adjusting system clock depending on systemd version). Main focus should be on monitoring time offset CMK-11089 Change-Id: I5d860a51eb5df32058f89c4fda583261698a22cc Commit: 4d2bc335d81e3dcc8e664ee6d63b41864fc7f028 https://github.com/tribe29/checkmk/commit/4d2bc335d81e3dcc8e664ee6d63b41864… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: A .werks/14967 Log Message: ----------- 14967 Timesyncd check plugin: Include metrics for sync times, change check behavior when NTP server not reachable and future-proofing Since at least systemd v250 <tt>/var/lib/systemd/timesync/clock</tt> should no longer be used to determine the time since the last synchronisation, instead the modification time of <tt>/run/systemd/timesync/synchronized</tt> is now used. To monitor the reliability of this time, this werk also introduces two new metrics: LI: Time since last synchronisation: The modification time of <tt>/run/systemd/timesync/synchronized</tt> if available, otherwise <tt>/var/lib/systemd/timesync/clock</tt>. LI: Time since last NTPMessage: When the last message from the NTP server was received. To have these metrics available, the Checkmk linux agent needs to be updated, otherwise only the time since last synchronisation based on <tt>/var/lib/systemd/timesync/clock</tt> will be shown. Since the modification time of /var/lib/systemd/timesync/clock can at times be unsuitable to monitor when synchronization occurred (due to limited error handling in earlier systemd version), the default threshold for the allowed duration since last synchronisation has been removed. If you want to apply thresholds to the time since last synchronisation you now have to enable the rule manually. The default thresholds for the allowed duration since last NTPMessage have been set to 1h (WARN) and 2h (CRIT). Additionally, the behavior of the check was changed to go to CRIT when the NTP server could not be reached for synchronisation. In the course of the werk the rendering of the jitter was also corrected to show a time span instead of a date. CMK-11089 Change-Id: Iffa13ab0851e557e785905b09739ef421b73538a Compare: https://github.com/tribe29/checkmk/compare/431dde1c9e4d...4d2bc335d81e

1 year, 8 months

[tribe29/checkmk] f74dae: Fix typos

by rseltmann

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f74dae72544c6e8787f9432e78d93283601b17f8 https://github.com/tribe29/checkmk/commit/f74dae72544c6e8787f9432e78d932836… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/gui/plugins/wato/check_parameters/gcp_gcs.py Log Message: ----------- Fix typos Change-Id: I096878de9da69bd1e6358432c01decd3ed6e9832 Commit: f0f542bf85cc0b4bd536df10701f44474bea590e https://github.com/tribe29/checkmk/commit/f0f542bf85cc0b4bd536df10701f44474… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/ntp.py M cmk/base/plugins/agent_based/timesyncd.py M cmk/base/plugins/agent_based/utils/timesync.py M tests/unit/cmk/base/plugins/agent_based/test_ntp.py M tests/unit/cmk/base/plugins/agent_based/utils/test_timesync.py Log Message: ----------- Refactor tolerance_check to allow checking different metrics CMK-11089 Change-Id: I8c99c41d720b3ae3f526c2de41d897bc1cc79738 Compare: https://github.com/tribe29/checkmk/compare/bc2d66dbb960...f0f542bf85cc

1 year, 8 months

[tribe29/checkmk] 91f8af: Fix comments

by Benedikt Seidl

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 91f8af6e1911f3aafd1bb210daa6382b655b5f3f https://github.com/tribe29/checkmk/commit/91f8af6e1911f3aafd1bb210daa6382b6… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M tests/unit/cmk/gui/plugins/openapi/test_openapi_bi.py Log Message: ----------- Fix comments Change-Id: Id9baecc67e2ec573819dcdd425a20571565266c6 Commit: c88b7e2680588f3713603e15fcc5f25f1ec459b2 https://github.com/tribe29/checkmk/commit/c88b7e2680588f3713603e15fcc5f25f1… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/decorators.py M tests/unit/cmk/gui/plugins/openapi/test_endpoint.py Log Message: ----------- Also check exceptions when checking status codes Before this change only responses where checked for status code mismatches. Now also ProblemException are considered. Change-Id: Ie8e0234537d60b2b2897e123fef3d11959867f53 Commit: 4694633593072451ba4e2127279863150b8c883d https://github.com/tribe29/checkmk/commit/4694633593072451ba4e2127279863150… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: A .werks/13435 M cmk/bi/packs.py M cmk/gui/plugins/openapi/endpoints/bi.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_bi.py Log Message: ----------- 13435 FIX Fix 500 errors on BI rule endpoints Deleting a rule which is a dependency of another rule returned a 500 status code, now returns 409 Deleting a rule returned a 500 status code "permission mismatch", now returns 204 Deleting a non existing rule returned a 500 status code, now returns 404 SUP-12079 Change-Id: I7592d0f46010b7772a69147ddb7fa60909e2c905 Commit: bc2d66dbb960214aad7136ebff32d9a3d5289d48 https://github.com/tribe29/checkmk/commit/bc2d66dbb960214aad7136ebff32d9a3d… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: A .werks/13436 M cmk/bi/packs.py M cmk/gui/plugins/openapi/endpoints/bi.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_bi.py Log Message: ----------- 13436 FIX Fix 500 errors on BI aggregation endpoints Deleting a aggregation returned 500 status code "permission mismatch" Deleting a non existing aggregation returned 500 status code, now returns 404 SUP-12079 Change-Id: I50914e343e3bb01074cb6c9feef158bcafb2a26b Compare: https://github.com/tribe29/checkmk/compare/f5efc6d0d2ac...bc2d66dbb960

1 year, 8 months

[tribe29/checkmk] e5186a: Ruleset to configure the automatic removal of hosts

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e5186a416cff56fb471774a09cff988266a71867 https://github.com/tribe29/checkmk/commit/e5186a416cff56fb471774a09cff98826… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/default_config/base.py M cmk/gui/plugins/wato/check_mk_configuration.py Log Message: ----------- Ruleset to configure the automatic removal of hosts For now, configuring this ruleset has no effect. The actual removal will be implemented in later commits. CMK-11314 Change-Id: I31613e8ea43aa2ebb221c8fdee77dd0b63bece5a Commit: f5efc6d0d2ac07fd2c09beac2900acae8ca9804c https://github.com/tribe29/checkmk/commit/f5efc6d0d2ac07fd2c09beac2900acae8… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/gui/watolib/__init__.py A cmk/gui/watolib/automatic_host_removal.py M tests/unit/cmk/gui/test_background_job.py M tests/unit/cmk/gui/test_cron.py A tests/unit/cmk/gui/watolib/test_automatic_host_removal.py M tests/unit/cmk/gui/watolib/test_watolib.py Log Message: ----------- Background job for automatic host removal CMK-11314 Change-Id: I2c104401ced0e1ad6c952588bb5bcf9d7c1b64d1 Compare: https://github.com/tribe29/checkmk/compare/45463e99168e...f5efc6d0d2ac

1 year, 8 months

[tribe29/checkmk] 45463e: df: fix broken perfometer

by SoloJacobs

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 45463e99168ea8a86f3aff197a4cba447dd4fc60 https://github.com/tribe29/checkmk/commit/45463e99168ea8a86f3aff197a4cba447… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/base/plugins/agent_based/utils/df.py M tests/unit/checks/generictests/datasets/db2_logsizes_regression.py M tests/unit/checks/generictests/datasets/emc_isilon_ifs_regression.py M tests/unit/checks/generictests/datasets/esx_vsphere_datastores_division_regression.py M tests/unit/checks/generictests/datasets/esx_vsphere_datastores_regression.py M tests/unit/checks/generictests/datasets/fast_lta_volumes.py M tests/unit/checks/generictests/datasets/hp_msa_volume_division_regression.py M tests/unit/checks/generictests/datasets/hp_msa_volume_regression.py M tests/unit/checks/generictests/datasets/ibm_svc_mdiskgrp_regression.py M tests/unit/checks/generictests/datasets/netapp_api_aggr_2019-07-22_08-45-28_5d355b88b0157_regression.py M tests/unit/checks/generictests/datasets/netapp_api_aggr_regression.py M tests/unit/checks/test_3par_volumes.py M tests/unit/checks/test_hp_msa_volume.py M tests/unit/cmk/base/check_legacy_includes/test_df.py M tests/unit/cmk/base/plugins/agent_based/test_df_check.py M tests/unit/cmk/base/plugins/agent_based/test_df_netscaler.py M tests/unit/cmk/base/plugins/agent_based/test_emc_isilon_quota.py M tests/unit/cmk/base/plugins/agent_based/test_fast_lta_volumes.py M tests/unit/cmk/base/plugins/agent_based/test_netapp_api_luns.py M tests/unit/cmk/base/plugins/agent_based/test_netapp_api_volumes.py M tests/unit/cmk/base/plugins/agent_based/test_oracle_asm_diskgroup.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_data_volume.py M tests/unit/cmk/base/plugins/agent_based/test_storeonce4x_appliances.py M tests/unit/cmk/base/plugins/agent_based/test_storeonce_servicesets.py M tests/unit/cmk/base/plugins/agent_based/test_threepar_capacity.py M tests/unit/cmk/base/plugins/agent_based/utils/test_df.py Log Message: ----------- df: fix broken perfometer This regression was introduced by Change-Id: I884a59d0a755aa120faa1b3c8aa18945ae162ece CMK-11391 Change-Id: I9fcdd34228acb686e49e5af3b7d1dc6accfce257

1 year, 8 months

[tribe29/checkmk] 3300ca: Fixed a few pylint findings.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 3300cab926913b273e8abbb390df6bbfdc1b638e https://github.com/tribe29/checkmk/commit/3300cab926913b273e8abbb390df6bbfd… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-11-03 (Thu, 03 Nov 2022) Changed paths: M cmk/snmplib/type_defs.py M cmk/utils/datastructures.py M cmk/utils/encoding.py M cmk/utils/livestatus_helpers/testing.py M cmk/utils/memoize.py M cmk/utils/notify.py M cmk/utils/store/_locks.py M cmk/utils/version.py Log Message: ----------- Fixed a few pylint findings. Change-Id: I9be986f6346b66f037d79a5bb1272d17c7afac4c

1 year, 8 months

← Newer
1
...
63
64
65
66
67
68
69
70
71
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits November 2022