Checkmk git commits November 2022

checkmk-commits@lists.checkmk.com

1 participants
706 discussions

[tribe29/checkmk] 6fc99a: 14630 FIX 3par_hosts: Check plugin would crash if ...

by Luka Racic

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6fc99aa77b8a5260dcbbd06549a7129ea0f33804 https://github.com/tribe29/checkmk/commit/6fc99aa77b8a5260dcbbd06549a7129ea… Author: LukaRacic <luka.racic(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: A .werks/14630 M checks/3par_hosts Log Message: ----------- 14630 FIX 3par_hosts: Check plugin would crash if no FC paths or no iSCSI paths were available The check plugin used to crash if there were no FC paths or no iSCSI paths available in the output. This has now been fixed. Change-Id: I076bcde7684e75344c729eb08679f930efc76df8

1 year, 10 months

[tribe29/checkmk] 62177b: 14983 FIX Extension packages: "Internal error: Pac...

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 62177b60faee28dca1d0f0e36caed919eb42a3d8 https://github.com/tribe29/checkmk/commit/62177b60faee28dca1d0f0e36caed919e… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: A .werks/14983 M cmk/utils/packaging/__init__.py M tests/unit/cmk/utils/test_packaging.py Log Message: ----------- 14983 FIX Extension packages: "Internal error: Package is not enabled" Change-Id: I81a38f6c4bd016abc4e336797905ea9d68e5e171 Commit: 97c09c56f0b70a656200bc16ac9585d267e20057 https://github.com/tribe29/checkmk/commit/97c09c56f0b70a656200bc16ac9585d26… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M cmk/utils/packaging/__init__.py Log Message: ----------- Fix update logic ... for multiple versions of the same package. In versions before 2.0.0p29 it was not possible to have more than one version per package, and if you have more than one now, you luckily have not yet run an upgrade. Change-Id: Ibc8ba838c6a5e1999035f6104749d83626fcb752 Compare: https://github.com/tribe29/checkmk/compare/8f486eddd740...97c09c56f0b7

1 year, 10 months

[tribe29/checkmk] 97ab8d: 14983 FIX Extension packages: "Internal error: Pac...

by Moritz

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 97ab8dfdf6b88353f4f47495b52e53de827efbc2 https://github.com/tribe29/checkmk/commit/97ab8dfdf6b88353f4f47495b52e53de8… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: A .werks/14983 M cmk/utils/packaging.py M tests/unit/cmk/utils/test_packaging.py Log Message: ----------- 14983 FIX Extension packages: "Internal error: Package is not enabled" Change-Id: I81a38f6c4bd016abc4e336797905ea9d68e5e171 Commit: 9a57aef5b0d0eb849d0acdc058a633b49c174c01 https://github.com/tribe29/checkmk/commit/9a57aef5b0d0eb849d0acdc058a633b49… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M cmk/utils/packaging.py Log Message: ----------- Fix update logic ... for multiple versions of the same package. In versions before 2.0.0p29 it was not possible to have more than one version per package, and if you have more than one now, you luckily have not yet run an upgrade. Change-Id: Ibc8ba838c6a5e1999035f6104749d83626fcb752 Compare: https://github.com/tribe29/checkmk/compare/d65a0a42d0db...9a57aef5b0d0

1 year, 10 months

[tribe29/checkmk] db6b0a: 14983 FIX Extension packages: "Internal error: Pac...

by Moritz

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: db6b0afb8b9dea2f4a66dfcdeb2048204b17436e https://github.com/tribe29/checkmk/commit/db6b0afb8b9dea2f4a66dfcdeb2048204… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: A .werks/14983 M cmk/utils/packaging.py M tests/unit/cmk/utils/test_packaging.py Log Message: ----------- 14983 FIX Extension packages: "Internal error: Package is not enabled" This fixes a regression in Checkmk versions 2.0.0p29 and Checkmk version 2.1.0p16, where after an upgrade packages could not be disabled. Change-Id: I81a38f6c4bd016abc4e336797905ea9d68e5e171 Commit: c57f183de693f0b1dc3fae08192a550ee8462b2e https://github.com/tribe29/checkmk/commit/c57f183de693f0b1dc3fae08192a550ee… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M cmk/utils/packaging.py Log Message: ----------- Fix update logic ... for multiple versions of the same package. In versions before 2.0.0p29 it was not possible to have more than one version per package, and if you have more than one now, you luckily have not yet run an upgrade. Change-Id: Ibc8ba838c6a5e1999035f6104749d83626fcb752 Compare: https://github.com/tribe29/checkmk/compare/eb44a22520c6...c57f183de693

1 year, 10 months

[tribe29/checkmk] 053d69: pyupgraded cmk/cee.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 053d6902cbefa8f5db14a51ed1cf9678b3112a3f https://github.com/tribe29/checkmk/commit/053d6902cbefa8f5db14a51ed1cf9678b… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M cmk/bi/trees.py Log Message: ----------- pyupgraded cmk/cee. Change-Id: If12560e035acf111a368683555d5ab87ececf35f Commit: 8f486eddd740e8b3a7f82c02b37c2f584a9bb758 https://github.com/tribe29/checkmk/commit/8f486eddd740e8b3a7f82c02b37c2f584… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M cmk/base/default_config/notify.py M cmk/gui/table.py M cmk/gui/utils/escaping.py M cmk/gui/views/availability.py M cmk/gui/watolib/network_scan.py Log Message: ----------- Small typing tweaks. Change-Id: I5cb0c6eaa5782c531a861fdd6c1e3523829ca257 Compare: https://github.com/tribe29/checkmk/compare/31c139632a8d...8f486eddd740

1 year, 10 months

[tribe29/checkmk] d65a0a: 14566 FIX datadog_monitors: Allow empty custom mes...

by SoloJacobs

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: d65a0a42d0dbe99bd08cc256c61499a52c78380e https://github.com/tribe29/checkmk/commit/d65a0a42d0dbe99bd08cc256c61499a52… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: A .werks/14566 M cmk/base/plugins/agent_based/datadog_monitors.py M tests/unit/cmk/base/plugins/agent_based/test_datadog_monitors.py Log Message: ----------- 14566 FIX datadog_monitors: Allow empty custom messages Previously, the check datadog_monitors would crash with a `ValueError` if there were any Datadog monitors with an empty message. With this werk, `No message` is shown if the message is empty. SUP-12222 Change-Id: Ia275080f94e3b76cc925eda4961d6a0782533608

1 year, 10 months

[tribe29/checkmk] 34433b: Parameterized sorters: Move URL special case to UR...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 34433b24bae54a8e427e594d82dfcc6aa01cccb2 https://github.com/tribe29/checkmk/commit/34433b24bae54a8e427e594d82dfcc6aa… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M cmk/gui/mobile.py M cmk/gui/painters/v0/base.py M cmk/gui/plugins/dashboard/view.py M cmk/gui/type_defs.py M cmk/gui/view.py M cmk/gui/views/page_show_view.py M tests/unit/cmk/gui/plugins/views/test_views_utils.py Log Message: ----------- Parameterized sorters: Move URL special case to URL parsing When a user clicks on a column header to change the configured sorting, the parameterized sorters (currently known as derived column sorters) need to be handled in a special way. This is now moved to the other URL parameter parsing code. It now happens earlier at a place you would expect and reduces the variances during execution. Change-Id: I6135db78dd0d073dda43220d9f6f2b5822a9131e Commit: 892d8d2a3edbce1d8d3939c8c7e64bee6a3823a5 https://github.com/tribe29/checkmk/commit/892d8d2a3edbce1d8d3939c8c7e64bee6… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: R cmk/gui/derived_columns_sorter.py M cmk/gui/painters/v0/base.py M cmk/gui/plugins/views/crash_reporting.py M cmk/gui/plugins/views/perfometer.py M cmk/gui/plugins/views/sorters.py M cmk/gui/plugins/views/wato.py M cmk/gui/sorter.py M cmk/gui/view.py M cmk/gui/views/__init__.py M cmk/gui/views/page_edit_view.py M cmk/gui/views/page_show_view.py M tests/unit/cmk/gui/plugins/views/test_perfometer.py Log Message: ----------- Rework DerivedColumnsSorter to ParameterizedSorter With this change the odd derived columns sorter which was not working as intended in some cases has been cleaned cleaned up. * The "Host custom attribute" could only be used as configured sorter in the view. Sorting by clicking on a "Host custom attribute" column did not work as intended. * Vice versa for Metric history and forecast sorters. They could be configured in the view editor as a dedicated sorter, but it was not clear by which column they would sort. Actually they always selected the first configured column of that type and sorted by that one. Now it is an explicit parameter of that sorter to select one of the previously configured columns. The relation is now configured explicitly which makes it easier to understand. In case such a referenced column is removed while the sorter is kept, this is now also validated. Interactive sorting by a column while displaying a view already worked before. * The name was related to the "derived columns" feature which is used by the "Metric history" painter and "forecast sorters" while it is a more generic feature: Enabling sorters to have parameters. The feature has now been renamed to "Parameterized sorters". This concept is similar to the parameters which painters can have. In case of the "Metric history" and "Metric forecast" the painter and sorter parameters are the same. The parameters are only used by the cmp method of the Sorters and are individual for each specific sorter. So the information is now handed over to the cmp method instead of being stored as a member attribute which makes the data flow easier to understand. This change removes many explicit references to the concrete svc_metrics_hist, svc_metrics_forecast and host_custom_variable sorters in the generic code. Along the way it decouples these sorters from the dependency on Cell, which enables us to clean up the module hierarchy a bit better. We could do more here to improve the situation even further: * Cleanup the sorter attribute of SorterSpec to only contain the sorter name and separate the parameters into a dedicated attribute * Move computation of URL encoded sorter references from the generic code to the ParameterizedSorter classes. Change-Id: Id641b22e7539b0168981be795274cbb84fda06df Commit: 0d575c3f573433efdc4ee3db016f41a9dfc25679 https://github.com/tribe29/checkmk/commit/0d575c3f573433efdc4ee3db016f41a9d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M cmk/gui/painters/v0/base.py M cmk/gui/plugins/views/mkeventd.py M cmk/gui/plugins/views/sorters.py M cmk/gui/sorter.py M cmk/gui/view.py M cmk/gui/views/__init__.py M cmk/gui/views/inventory.py M cmk/gui/views/layout/layouts.py M cmk/gui/views/page_edit_view.py A cmk/gui/views/sort_url.py M tests/unit/cmk/gui/plugins/views/test_views_utils.py M tests/unit/cmk/gui/views/test_views.py Log Message: ----------- Cleanup dependency between Cell and sorters The sorters are only needed for rendering the sort URL to be used in the header of a column. To have the computation in Cell required us to make the view spec and sorter implementation available to Cell. Now the sort URL is computed by the call sites which now simplifies the relation between Cell and the sorters. This also improves testability of Cell. Change-Id: Ibbaf5ba5c533fcde99d191ef336243e1ad69d6dd Commit: 31c139632a8d1236f4ed4faf177b025071cc3270 https://github.com/tribe29/checkmk/commit/31c139632a8d1236f4ed4faf177b02507… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M cmk/gui/availability.py M cmk/gui/plugins/views/crash_reporting.py M cmk/gui/plugins/views/mkeventd.py M cmk/gui/plugins/views/perfometer.py R cmk/gui/plugins/views/sorters.py M cmk/gui/plugins/views/wato.py M cmk/gui/raw/plugins/main_modules/registration.py R cmk/gui/sorter.py M cmk/gui/view.py M cmk/gui/views/__init__.py M cmk/gui/views/host_tag_plugins.py M cmk/gui/views/inventory.py M cmk/gui/views/page_edit_view.py M cmk/gui/views/page_show_view.py M cmk/gui/views/sort_url.py A cmk/gui/views/sorter/__init__.py A cmk/gui/views/sorter/base.py A cmk/gui/views/sorter/helpers.py A cmk/gui/views/sorter/registry.py A cmk/gui/views/sorter/sorters.py M tests/unit/cmk/gui/views/test_views.py Log Message: ----------- Consolidate view sorter code * Move plugins to regular hierarchy * Rework sorter registration to the scheme we want to use in the future * Consolidate sorter code below views (it's view feature) * Clarify external API of cmk.gui.views.sorter Change-Id: I8be0f4a31baf18e4b20133d42c53e0ba706aa62e Compare: https://github.com/tribe29/checkmk/compare/8a37dac941b2...31c139632a8d

1 year, 10 months

[tribe29/checkmk] 736c7e: 14565 FIX inv_if: Fix crash on innovaphone IP811

by SoloJacobs

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 736c7e2cf9ef518d25c6cb6cddea47f962e8a902 https://github.com/tribe29/checkmk/commit/736c7e2cf9ef518d25c6cb6cddea47f96… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: A .werks/14565 M cmk/base/plugins/agent_based/inv_if.py Log Message: ----------- 14565 FIX inv_if: Fix crash on innovaphone IP811 Previously, the inventory plugin inv_if would crash while inventorizing interfaces on a innovaphone IP811 with the message `Parsing of section inv_if failed`. This could potentially happen on other devices, if they report 'NULL' to indicate missing values. With this werk, interfaces with this kind of missing information are omitted. SUP-12228 Change-Id: I4e33cb680878852ffb7a341f7374549f96d19286

1 year, 10 months

[tribe29/checkmk] eb44a2: 14565 FIX inv_if: Fix crash on innovaphone IP811

by SoloJacobs

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: eb44a22520c621891375e45a7026aaff8315096c https://github.com/tribe29/checkmk/commit/eb44a22520c621891375e45a7026aaff8… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: A .werks/14565 M cmk/base/plugins/agent_based/inv_if.py Log Message: ----------- 14565 FIX inv_if: Fix crash on innovaphone IP811 Previously, the inventory plugin inv_if would crash while inventorizing interfaces on a innovaphone IP811 with the message `Parsing of section inv_if failed`. This could potentially happen on other devices, if they report 'NULL' to indicate missing values. With this werk, interfaces with this kind of missing information are omitted. SUP-12228 Change-Id: I4e33cb680878852ffb7a341f7374549f96d19286

1 year, 10 months

[tribe29/checkmk] 8a37da: Fixup default IPv6 address

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8a37dac941b2f18ede2b1e432b28735cb882a266 https://github.com/tribe29/checkmk/commit/8a37dac941b2f18ede2b1e432b28735cb… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M cmk/base/ip_lookup.py Log Message: ----------- Fixup default IPv6 address Change-Id: I2499142adcd26aa5bd151b6bb007ef4a3794b4d6

1 year, 10 months

← Newer
1
...
37
38
39
40
41
42
43
...
71
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits November 2022