Checkmk git commits October 2022

checkmk-commits@lists.checkmk.com

1 participants
575 discussions

[tribe29/checkmk] e7c3e2: fix ordering of scrips

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e7c3e2b0f27db6ac29844d6d4f64538305e42a66 https://github.com/tribe29/checkmk/commit/e7c3e2b0f27db6ac29844d6d4f6453830… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-10-18 (Tue, 18 Oct 2022) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- fix ordering of scrips As suggested by the current contents of omd/packages/check_mk/scripts/, the scripts should be executed in the order determined by their names. Change-Id: Iaf6873abbfdcddfa4b9751f1dbf8214a7c2645e3

1 year, 11 months

[tribe29/checkmk] 3eb5f5: fix ordering of hooks

by Moritz

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 3eb5f5ca54d3492fda5c93289b14c1ef119fea98 https://github.com/tribe29/checkmk/commit/3eb5f5ca54d3492fda5c93289b14c1ef1… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- fix ordering of hooks As suggested by the current contents of omd/packages/check_mk/scripts/, the hooks should be executed in the order determined by their names. Change-Id: Iaf6873abbfdcddfa4b9751f1dbf8214a7c2645e3

1 year, 11 months

[tribe29/checkmk] 760e4c: fix ordering of hooks

by Moritz

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 760e4cd95d50b81f38b71d6b03ef8f46438d6beb https://github.com/tribe29/checkmk/commit/760e4cd95d50b81f38b71d6b03ef8f464… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-10-18 (Tue, 18 Oct 2022) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- fix ordering of hooks As suggested by the current contents of omd/packages/check_mk/scripts/, the hooks should be executed in the order determined by their names. Change-Id: Iaf6873abbfdcddfa4b9751f1dbf8214a7c2645e3

1 year, 11 months

[tribe29/checkmk] 31a4ab: FIX 14812 systemd UTF-8 handling

by Max Linke

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 31a4ab446703e72ec179d699569942319d9bdad5 https://github.com/tribe29/checkmk/commit/31a4ab446703e72ec179d699569942319… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: A .werks/14812 Log Message: ----------- FIX 14812 systemd UTF-8 handling The werk was originally missing. Change-Id: I824313ce03ffdcb4828b250dc1d398344c0b9519 Closes: #457

1 year, 11 months

[tribe29/checkmk] 95d4a5: 14936 logwatch: fix validation for REWRITE state

by Lars

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 95d4a5775d18b26f66d16dff67c4e8435becac47 https://github.com/tribe29/checkmk/commit/95d4a5775d18b26f66d16dff67c4e8435… Author: Giordano Tomassorri <giordano.tomassorri(a)tribe29.com> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: A .werks/14936 Log Message: ----------- 14936 logwatch: fix validation for REWRITE state The validation fot the REWRITE state in the Text logfiles rule (logwatch plugin) was erroring out when the patterns contained a reference to the previously matched groups. This commit fixes the issue. SUP-11802 Change-Id: I804b57b0732de693b51eec7a2017a7e5dc40cb4f

1 year, 11 months

[tribe29/checkmk] 0e3385: agent_kube: add typing to argparse collector args

by SoloJacobs

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 0e3385da0149b8cd847eb38ca90a873a9d5b7a41 https://github.com/tribe29/checkmk/commit/0e3385da0149b8cd847eb38ca90a873a9… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M cmk/special_agents/agent_kube.py A cmk/special_agents/utils_kubernetes/query.py Log Message: ----------- agent_kube: add typing to argparse collector args CMK-11387 Change-Id: Ib71f32a1c7a9ca5c1073f1cf56e554456666a4c3 Commit: b2a457b61f9277349a2613e98ec1b6b5c3981c5e https://github.com/tribe29/checkmk/commit/b2a457b61f9277349a2613e98ec1b6b5c… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M cmk/special_agents/agent_kube.py Log Message: ----------- agent_kube: remove Any from cluster_response Change-Id: I4c47f79a5ef3c9d807992b4df292971ecef7c12e Commit: 778483f2aa0e0af0166dc5d65a4679498474d856 https://github.com/tribe29/checkmk/commit/778483f2aa0e0af0166dc5d65a4679498… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M cmk/special_agents/agent_kube.py M cmk/special_agents/utils_kubernetes/query.py Log Message: ----------- agent_kube: use session object for cluster collector request CMK-11387 Change-Id: I878347b20a3a209237a6eb4521193e71323ecb79 Compare: https://github.com/tribe29/checkmk/compare/77c4e5a65c6d...778483f2aa0e

1 year, 11 months

[tribe29/checkmk] 77c4e5: Typo: Deamon -> Daemon

by Jay2k1

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 77c4e5a65c6dba0704e4cbf780e75daadd5ffc01 https://github.com/tribe29/checkmk/commit/77c4e5a65c6dba0704e4cbf780e75daad… Author: Jay2k1 <github(a)jay2k1.com> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M checkman/isc_dhcpd M checkman/mysql M checkman/mysql_ping M checks/mysql_ping M tests/unit/checks/generictests/datasets/mysql_ping_1_regression.py Log Message: ----------- Typo: Deamon -> Daemon Change-Id: I31327a0f08668382a36e9c71dd3b95439738d35f closes: #520

1 year, 11 months

[tribe29/checkmk] d48a45: Typo: Deamon -> Daemon

by Jay2k1

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: d48a4552392a4aa431fd657e7527133ceb7c853d https://github.com/tribe29/checkmk/commit/d48a4552392a4aa431fd657e7527133ce… Author: Jay2k1 <github(a)jay2k1.com> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M checkman/isc_dhcpd M checkman/mysql M checkman/mysql_ping M checks/mysql_ping M tests/unit/checks/generictests/datasets/mysql_ping_1_regression.py Log Message: ----------- Typo: Deamon -> Daemon Change-Id: I31327a0f08668382a36e9c71dd3b95439738d35f closes: #520

1 year, 11 months

[tribe29/checkmk] 9b5f0d: Typo: Deamon -> Daemon

by Jay2k1

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 9b5f0d53c5be79dd822172615a026b6e8025e21a https://github.com/tribe29/checkmk/commit/9b5f0d53c5be79dd822172615a026b6e8… Author: Jay2k1 <github(a)jay2k1.com> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M checkman/isc_dhcpd M checkman/mysql M checkman/mysql_ping M checks/mysql_ping M tests/unit/checks/generictests/datasets/mysql_ping_1_regression.py Log Message: ----------- Typo: Deamon -> Daemon Change-Id: I31327a0f08668382a36e9c71dd3b95439738d35f closes: #520

1 year, 11 months

[tribe29/checkmk] df0af3: check_mk_agent.linux / systemctl: properly handle ...

by Michael Prokop

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: df0af30ad2ec72cb6ca8a00e2bfaf10b4c91397a https://github.com/tribe29/checkmk/commit/df0af30ad2ec72cb6ca8a00e2bfaf10b4… Author: Michael Prokop <michael.prokop(a)synpro.solutions> Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M agents/check_mk_agent.linux Log Message: ----------- check_mk_agent.linux / systemctl: properly handle units marked with bullet circles systemd uses the so called bullet circle (SPECIAL_GLYPH_BLACK_CIRCLE) to mark units in special states (not-found, inactive, dead,... but also failed). By default, and when running in a UTF-8 capable environment, systemd uses the "●" character for the bullet circle, only in ASCII fallback mode it uses "*" instead. When C.UTF-8 is available, check_mk_agent uses it as its LC_ALL setting though, returning something like: | % LC_ALL="C.utf8" systemctl --all --no-pager | sed '/^$/q' | tr -s ' ' | grep restic-backup | restic-backup-fileserver01-data-prune.service loaded inactive dead Restic backup prune of fileserver01-data | ● restic-backup-mail01-data-prune.service loaded failed failed Restic backup prune of mail01-data | restic-backup-fileserver01-data-prune.timer loaded active waiting Weekly restic backup prune of fileserver01-data | restic-backup-mail01-data-prune.timer loaded active waiting Weekly restic backup prune of mail01-data But such a failed unit isn't detected and handled by checkmk's systemd_units then (as observed with checkmk v2.0.0p22): | OK Systemd Service Summary Total: 102, Disabled: 9, Failed: 0 But when using an environment *without* UTF-8 support, systemd's systemctl would behave as expected by checkmk. Corresponding output: | % LC_ALL=C systemctl --all --no-pager | sed '/^$/q' | tr -s ' ' | grep restic-backup | restic-backup-fileserver01-data-prune.service loaded inactive dead Restic backup prune of fileserver01-data | * restic-backup-mail01-data-prune.service loaded failed failed Restic backup prune of mail01-data | restic-backup-fileserver01-data-prune.timer loaded active waiting Weekly restic backup prune of fileserver01-data | restic-backup-mail01-data-prune.timer loaded active waiting Weekly restic backup prune of mail01-data The proper solution though is to use the options `--no-legend --no-pager --plain` instead, quoting from systemd upstream commit 1cabd2d0c56b7: | systemctl: hide first column with --plain instead of --no-legend | | Hiding the first column, which may contain bullet circles, with --no-legend | is undocumented and potentially unexpected. On the other hand, not printing | bullet circles with --plain is documented so hiding the column with that | switch is sensible. | | The combination "--full --no-legend --no-pager --plain" is appropriate for | automated processing of systemctl output. And indeed, this behaves as expected then and also checkmk handles it properly then: | synpromika@backup ~ % LC_ALL="C.utf8" systemctl --all --no-legend --no-pager --plain | sed '/^$/q' | tr -s ' ' | grep restic-backup | restic-backup-fileserver01-data-prune.service loaded inactive dead Restic backup prune of fileserver01-data | restic-backup-mail01-data-prune.service loaded failed failed Restic backup prune of mail01-data | restic-backup-fileserver01-data-prune.timer loaded active waiting Weekly restic backup prune of fileserver01-data | restic-backup-mail01-data-prune.timer loaded active waiting Weekly restic backup prune of mail01-data And also checkmk handles it properly then: | CRIT Systemd Service Summary Total: 125, Disabled: 9, Failed: 1, 1 static service failed (restic-backup-mail01-data-prune) Verified systemctl behavior on systemd v232-25 (Debian/stretch), v241-7 (Debian/buster), v247.3 (Debian/bullseye) and v250.4 (Debian/unstable as of 2022-04-21). FTR: the --plain option isn't relevant for the new `systemctl status` handling that got introduced in commit e5d0b1c852. Quoting from systemctl(1) section about `status` unit command: | This function is intended to generate human-readable output. | If you are looking for computer-parsable output, use show instead. Closes: #457 Signed-off-by: Michael Prokop <tribe29(a)michael-prokop.at> Change-Id: I265ab6a906659c1fc8731f3b32a4b018436832a2

1 year, 11 months

← Newer
1
...
27
28
29
30
31
32
33
...
58
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2022