Checkmk git commits January 2022

checkmk-commits@lists.checkmk.com

1 participants
506 discussions

[tribe29/checkmk] bd9f33: Use only the Logfile part of the dereferenced iter...

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: bd9f331c3079d328b33ac60312055dad6b137b86 https://github.com/tribe29/checkmk/commit/bd9f331c3079d328b33ac60312055dad6… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M livestatus/src/TableLog.cc M livestatus/src/TableStateHistory.cc Log Message: ----------- Use only the Logfile part of the dereferenced iterators. The LogCache's map contains time_point/Logfile pairs, where the time_point is always the Logfile's since(), so there is no need for the first part of the iterator data. This is a tiny cleanup step towards a simpler iteration: We effectively need only a range of Logfiles. If we only had ranges... :-/ Change-Id: I62d827dde12650de889abc071d70a2393dcf339b

2 years, 8 months

[tribe29/checkmk] ef828a: Refactoring of Windows agent according to guidelin...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ef828ace43d2f73517f4b33ab990d2ef88145ce9 https://github.com/tribe29/checkmk/commit/ef828ace43d2f73517f4b33ab990d2ef8… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M agents/wnx/src/engine/cfg.cpp M agents/wnx/src/engine/cfg_details.h M agents/wnx/src/engine/cma_core.cpp M agents/wnx/src/engine/encryption.cpp M agents/wnx/src/engine/providers/check_mk.cpp M agents/wnx/src/engine/providers/plugins.cpp M agents/wnx/src/engine/providers/ps.cpp Log Message: ----------- Refactoring of Windows agent according to guideline(mechanical) Change-Id: I3e7cf3b7029fcfcf06ef61c26bb96eb94664e046

2 years, 8 months

[tribe29/checkmk] aca8e7: remove unneeded try/except

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: aca8e788ce703e4b4b3c9604495133ca36625000 https://github.com/tribe29/checkmk/commit/aca8e788ce703e4b4b3c9604495133ca3… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/special_agents/agent_fritzbox.py Log Message: ----------- remove unneeded try/except Change-Id: I72693218ac27512c49d32eb2d9aaba2395e17102

2 years, 8 months

[tribe29/checkmk] 8500ac: Make recent valgrind available in all CI containers

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8500ac377be5b5cf44d536c00afa98f7a1756a98 https://github.com/tribe29/checkmk/commit/8500ac377be5b5cf44d536c00afa98f7a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M buildscripts/infrastructure/build-nodes/centos-7/Dockerfile M buildscripts/infrastructure/build-nodes/centos-8/Dockerfile M buildscripts/infrastructure/build-nodes/debian-10/Dockerfile M buildscripts/infrastructure/build-nodes/debian-11/Dockerfile M buildscripts/infrastructure/build-nodes/debian-9/Dockerfile M buildscripts/infrastructure/build-nodes/scripts/build_lib.sh M buildscripts/infrastructure/build-nodes/scripts/install-python.sh A buildscripts/infrastructure/build-nodes/scripts/install-valgrind.sh M buildscripts/infrastructure/build-nodes/sles-12sp3/Dockerfile M buildscripts/infrastructure/build-nodes/sles-12sp4/Dockerfile M buildscripts/infrastructure/build-nodes/sles-12sp5/Dockerfile M buildscripts/infrastructure/build-nodes/sles-15/Dockerfile M buildscripts/infrastructure/build-nodes/sles-15sp1/Dockerfile M buildscripts/infrastructure/build-nodes/sles-15sp2/Dockerfile M buildscripts/infrastructure/build-nodes/sles-15sp3/Dockerfile M buildscripts/infrastructure/build-nodes/ubuntu-16.04/Dockerfile M buildscripts/infrastructure/build-nodes/ubuntu-18.04/Dockerfile M buildscripts/infrastructure/build-nodes/ubuntu-19.04/Dockerfile M buildscripts/infrastructure/build-nodes/ubuntu-20.04/Dockerfile M buildscripts/infrastructure/build-nodes/ubuntu-21.04/Dockerfile M buildscripts/infrastructure/build-nodes/ubuntu-21.10/Dockerfile Log Message: ----------- Make recent valgrind available in all CI containers We need a valgrind in all CI Containers which is actually usable for our needs. With older system-provided valgrinds there are a few issues: - --error-exitcode is supported in valgrind >=3.2.0 (June 2006), so this shouldn't be an issue with the currently supported distros. But it's mentioned here for completeness. - --exit-on-first_error is supported in valgrind >=3.14.0 (October 2018). This is quite handy to stop any long jobs which will fail, anyway. And any results after the initial finding are useless, too. - Support for the DWARF 5 debug info (generated by GCC >=11.1) is in valgrind >=3.17 (March 2021) - In general: We use a very recent C++-Compiler, which might emit machine instructions older valgrinds don't understand. This could lead to fun like this: https://bugs.kde.org/show_bug.cgi?id=353370 So we are more or less forced to keep valgrind up-to-date, too. CMK-9357 Change-Id: I6c4c1e4c99077a046d4ae95ec845365b7e91fdde

2 years, 8 months

[tribe29/checkmk] 2c8486: Introduce a LogFiles class.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2c8486028fb96e8b1cee8f3259c41660a65c08f8 https://github.com/tribe29/checkmk/commit/2c8486028fb96e8b1cee8f3259c41660a… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M livestatus/src/LogCache.h M livestatus/src/Store.cc M livestatus/src/TableLog.cc M livestatus/src/TableLog.h M livestatus/src/TableStateHistory.cc M livestatus/src/TableStateHistory.h Log Message: ----------- Introduce a LogFiles class. This makes the fact explicit that one *must* use LogCache::apply() to access the log files in the cache. Things like this are a good idea in general, see e.g. https://doc.rust-lang.org/std/sync/struct.Mutex.html#method.lock where one *must* use lock (or try_lock) to access the protected data. Change-Id: Ie082e4954500325b3d1208212c63130a1f340efa

2 years, 8 months

[tribe29/checkmk] 5311d2: Add tests.unit to known isort sections to avoid py...

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5311d2b6deb35756cda344ab59263de887b0a7db https://github.com/tribe29/checkmk/commit/5311d2b6deb35756cda344ab59263de88… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M pyproject.toml M tests/unit/checks/test_datapower_fan_legacy.py M tests/unit/checks/test_docker_container_diskstat.py M tests/unit/checks/test_mem_win.py M tests/unit/cmk/base/plugins/agent_based/test_netapp_api_qtree_quota.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_acknowledgement.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_activate_changes.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_downtime.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_folder_config.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_group_config.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_host.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_internal.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_service.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_service_discovery.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_user.py M tests/unit/cmk/gui/plugins/openapi/test_wato_disabled.py M tests/unit/cmk/test_update_config.py Log Message: ----------- Add tests.unit to known isort sections to avoid pylint: ungrouped-imports Change-Id: Ic46448df9e22e34c820eae6890f65822d3cce2b0

2 years, 8 months

[tribe29/checkmk] 01d5fd: kube_cpu_usage: Wrap up check revamp and cleanup l...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 01d5fd468b5d5e75c428e44a994c5bb722268ca3 https://github.com/tribe29/checkmk/commit/01d5fd468b5d5e75c428e44a994c5bb72… Author: Pablo Santiago Blum de Aguiar <pablo.blum(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: R checkman/kube_cpu_resources M cmk/base/plugins/agent_based/kube_cpu_usage.py M tests/unit/cmk/base/plugins/agent_based/test_kube_cpu_usage.py Log Message: ----------- kube_cpu_usage: Wrap up check revamp and cleanup leftovers Change-Id: I34fbe08cce326d0af92b6c28a5bf30eceaa8c3bb

2 years, 8 months

[tribe29/checkmk] 16bace: Fix logging

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 16bacecf0f7df9b9e44a673e2cb0a1cc0981e596 https://github.com/tribe29/checkmk/commit/16bacecf0f7df9b9e44a673e2cb0a1cc0… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/plugins/config/base.py Log Message: ----------- Fix logging Change-Id: Ie5c0d8931d89e5c1b4c1ea87a80773bb3af21eb8 Commit: 17580ab2acf2f488fa966e9b3d8dc6cc820acef3 https://github.com/tribe29/checkmk/commit/17580ab2acf2f488fa966e9b3d8dc6cc8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/wato/__init__.py M web/htdocs/js/modules/webauthn.js Log Message: ----------- webauthn: Improve error handling and fix page loading issue Change-Id: I00f65809b70f3e03662df0f2870a92a0ac1a3809 Compare: https://github.com/tribe29/checkmk/compare/7fcde450d563...17580ab2acf2

2 years, 8 months

[tribe29/checkmk] 7552ee: Move user_profile and split into package

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7552ee4fa2f1b2ec4d1c40f54e7a84a9187733ca https://github.com/tribe29/checkmk/commit/7552ee4fa2f1b2ec4d1c40f54e7a84a91… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/notifications.py M cmk/gui/wato/pages/notifications.py A cmk/gui/wato/pages/user_profile/__init__.py A cmk/gui/wato/pages/user_profile/async_replication.py A cmk/gui/wato/pages/user_profile/page_menu.py R cmk/gui/wato/user_profile.py Log Message: ----------- Move user_profile and split into package The correct location for pages is below cmk/gui/wato/pages. And since there is also functionality needed by other pages, we separate these parts into dedicated modules. A little more spearation will follow. Change-Id: I6572c0d8b99a828bf4eb9a2383ab3194e1a200cb Commit: a5cc338d1728067315364e51da35c7cab54c523b https://github.com/tribe29/checkmk/commit/a5cc338d1728067315364e51da35c7cab… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/wato/pages/user_profile/__init__.py A cmk/gui/wato/pages/user_profile/abstract_page.py A cmk/gui/wato/pages/user_profile/change_password.py A cmk/gui/wato/pages/user_profile/edit_profile.py A cmk/gui/wato/pages/user_profile/mega_menu.py A cmk/gui/wato/pages/user_profile/replicate.py Log Message: ----------- Split remaining user_profile __init__ into modules Change-Id: Ie222fe4585ac852c90d660eb5a6c58cdc4578829 Commit: 0026541db9f4e9923a7aa0f8ce9da592396acae3 https://github.com/tribe29/checkmk/commit/0026541db9f4e9923a7aa0f8ce9da5923… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/wato/pages/user_profile/page_menu.py Log Message: ----------- User profile: Make all profile sub-pages shortcuts Change-Id: I326f0383ba1e64d94ebad992afb97fe13b275921 Commit: 341d01c6fc5af9955763b91e073c474373984230 https://github.com/tribe29/checkmk/commit/341d01c6fc5af9955763b91e073c47437… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/default_permissions.py M cmk/gui/userdb.py M cmk/gui/wato/pages/user_profile/__init__.py M cmk/gui/wato/pages/user_profile/abstract_page.py M cmk/gui/wato/pages/user_profile/mega_menu.py M cmk/gui/wato/pages/user_profile/page_menu.py A cmk/gui/wato/pages/user_profile/two_factor.py M tests/unit/cmk/gui/test_gui_config.py M tests/unit/cmk/gui/test_pages.py M tests/unit/cmk/gui/test_userdb.py M tests/unit/test_pipfile.py M web/htdocs/js/index.js A web/htdocs/js/modules/cbor_ext.js A web/htdocs/js/modules/webauthn.js A web/htdocs/themes/facelift/images/icon_2fa.svg A web/htdocs/themes/facelift/images/icon_topic_two_factor.png Log Message: ----------- Users can now register webauthn credentials This is the first step of our 2FA WebAuthn GUI integration. It adds a new user profile page which can be used to register and remove authentication devices for the current user. Next steps: * Integrate 2FA with login procedure * Add backup codes Change-Id: Id9cb681a797baa6ac26256a641d515d601f020de Commit: 15b9e402acf9d6c4ab9c022f5228212e16fe80a5 https://github.com/tribe29/checkmk/commit/15b9e402acf9d6c4ab9c022f5228212e1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/login.py M cmk/gui/userdb.py M cmk/gui/wato/pages/user_profile/two_factor.py M tests/unit/cmk/gui/test_pages.py M web/htdocs/js/modules/webauthn.js M web/htdocs/themes/facelift/scss/_login.scss Log Message: ----------- Users can now login with webauthn credentials Next: Add backup codes Change-Id: Iee35f51d07a0cf8f7f08f8729b69507124f8601b Commit: 4a7d217fe25bbcd10eabac2846be79f89d055d9b https://github.com/tribe29/checkmk/commit/4a7d217fe25bbcd10eabac2846be79f89… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/plugins/userdb/htpasswd.py M cmk/gui/userdb.py M cmk/gui/wato/pages/user_profile/two_factor.py M tests/unit/cmk/gui/test_userdb.py A web/htdocs/themes/facelift/images/icon_2fa_backup_codes.svg M web/htdocs/themes/facelift/scss/_login.scss Log Message: ----------- Add backup codes for two-factor authentication In case a user does not have the authentication device at hand, the backup codes can be used as an alternative. The codes can be generated on the user profile page and are only shown once to the user. During generation they are stored in the user profile in the same form as regular passwords. In the moment a backup code is used, it is automatically invalidated. Change-Id: Ib20e87f7ab2b74d9b58888818af786ca399979ff Commit: 17d72bae7aeb6ebda993016290e79faec5700558 https://github.com/tribe29/checkmk/commit/17d72bae7aeb6ebda993016290e79faec… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/userdb.py M cmk/gui/wato/pages/users.py M tests/unit/cmk/gui/test_userdb.py Log Message: ----------- Integrate two-factor with user management * Display enable two-factor authentication in user list * Admins can disable two-factor authentication for users to help them in case they don't have access to their 2nd factor. This can be done via "Setup > Users > Edit user > Disable two-factor authentication". Change-Id: Ib66950c183873e7f015eff76a5ecb2cff6c5853b Commit: 7fcde450d5632d676defb781ffc80468eb27af91 https://github.com/tribe29/checkmk/commit/7fcde450d5632d676defb781ffc80468e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: A .werks/13325 Log Message: ----------- 13325 Two-factor authentication via FIDO2/WebAuthn With this change users of the Checkmk user interface can now configure Checkmk to ask for a second factor during user authentication. The new two-factor authentication is based on FIDO2/WebAuthn. You can use authenticators such as the YubiKey, a USB token, a smart phone, Apple’s Touch ID, and Windows Hello. To enable the new feature, login to the GUI and open the "User" mega menu on the bottom left of the screen. Then select "Two-factor authentication". On the opened page, you first need to click on "Add credential". Once you click that, your browser will ask you to activate your authenticator. Once done, the registration with your user account should be complete and a new registered credentials is displayed. With this step you have enabled the two-factor authentication for you user account. Future logins will only be possible with the activated authenticator. If you don't have your authenticator at hand, you can use backup codes. It is recommended to generate these backup codes right away by clicking on "Regenerate backup codes". The resulting page will show you a list of 10 backup codes. Store them in a save place. Administrators can see that a user has the two-factor authentication enabled in the users list of the Setup. The Authentication column displays "Password (+2FA)" for these users. Admins can disable two-factor authentication for users to help them in case they don't have access to their second factor. This can be done via "Setup > Users > Edit user > Disable two-factor authentication". Please note that the standard makes this feature only usable in case you access the GUI using HTTPS. The WebAuthn two-factor authentication is also restrictive on the type of host address you use to access the GUI. It will be used as relying party identifier (https://www.w3.org/TR/webauthn-2/#relying-party-identifier) and has to be a valid domain string (https://url.spec.whatwg.org/#valid-domain-string). You will have to either use a simple host name or a full qualified domain name. Please note that you need to be consistent in the domain you use for the two-factor authentication to work. Change-Id: Ica6f7a3c2a33d727f5bc48762f57e8c34486497c Compare: https://github.com/tribe29/checkmk/compare/2dc3db8f6b02...7fcde450d563

2 years, 8 months

[tribe29/checkmk] f75b33: Cleanup global variable

by Kenneth

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f75b33f62941b272aed362a1eac17d1c74f82a8f https://github.com/tribe29/checkmk/commit/f75b33f62941b272aed362a1eac17d1c7… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/modules.py M tests/unit/cmk/gui/test_modules.py Log Message: ----------- Cleanup global variable Change-Id: I10a314a5356f96e648aa86c117f605cd091daee1 Commit: f4d1c5c49dd57cfda693458f238f8d21ed42679f https://github.com/tribe29/checkmk/commit/f4d1c5c49dd57cfda693458f238f8d21e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M cmk/gui/modules.py Log Message: ----------- Cleanup some legacy things Change-Id: I70cdf8d4d6efef096af3d3885dafc1341075667c Commit: f5fa73de15e9750026b6fa90bf6f5ae4762e9318 https://github.com/tribe29/checkmk/commit/f5fa73de15e9750026b6fa90bf6f5ae47… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M bin/init-redis M cmk/gui/cron.py M cmk/gui/dashboard.py M cmk/gui/hooks.py A cmk/gui/main_modules.py M cmk/gui/metrics.py R cmk/gui/modules.py M cmk/gui/notifications.py M cmk/gui/sidebar.py M cmk/gui/userdb.py M cmk/gui/views/__init__.py M cmk/gui/visuals.py M cmk/gui/wato/__init__.py M cmk/gui/webapi.py M cmk/post_rename_site/main.py M cmk/update_config.py M omd/packages/check_mk/post-create/01_create-sample-config.py M tests/integration/cmk/gui/plugins/bi/test_bi_plugin.py M tests/integration/cmk/gui/plugins/config/test_config_plugin.py M tests/integration/cmk/gui/plugins/cron/test_cron_plugin.py M tests/integration/cmk/gui/plugins/dashboard/test_dashboard_plugin.py M tests/integration/cmk/gui/plugins/metrics/test_metrics_plugin.py M tests/integration/cmk/gui/plugins/openapi/test_openapi_plugin.py M tests/integration/cmk/gui/plugins/openapi/test_sidebar_plugin.py M tests/integration/cmk/gui/plugins/userdb/test_userdb_plugin.py M tests/integration/cmk/gui/plugins/visuals/test_visuals_plugin.py M tests/integration/cmk/gui/plugins/wato/test_wato_plugin.py M tests/integration/cmk/gui/plugins/watolib/test_watolib_plugin.py M tests/integration/cmk/gui/plugins/webapi/test_webapi_plugin.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/test_background_job.py A tests/unit/cmk/gui/test_main_modules.py R tests/unit/cmk/gui/test_modules.py M web/app/index.wsgi Log Message: ----------- Rename cmk.gui.modules to cmk.gui.main_modules * This reduces one special case: It is now consistent with the plugin namespace `cmk.gui.plugins.main_modules`. * Consolidating all imports to one mechanism along the way Change-Id: I1590e420dfe0b3cf09149e1b7fe8907c04980429 Commit: 2dc3db8f6b02e3561e61a4e256fb93e8cf23c899 https://github.com/tribe29/checkmk/commit/2dc3db8f6b02e3561e61a4e256fb93e8c… Author: Kenneth Okoh <kenneth.okoh(a)tribe29.com> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M web/htdocs/themes/facelift/scss/_sidebar.scss Log Message: ----------- Add snapin: Improve alignment of header, content and description (CMK-8929) Change-Id: I2e60891f0779d81c89070b0357cdd883663c35a8 Compare: https://github.com/tribe29/checkmk/compare/bd4bd996c035...2dc3db8f6b02

2 years, 8 months

← Newer
1
...
40
41
42
43
44
45
46
...
51
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2022