Checkmk git commits August 2021

checkmk-commits@lists.checkmk.com

1 participants
443 discussions

[tribe29/checkmk] 5f4ae7: 12805 FIX Overlapping label inputs (label conditions)

by Lukas Lengler

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 5f4ae7635496c001c99d7b2c7d6fee057f4c343d https://github.com/tribe29/checkmk/commit/5f4ae7635496c001c99d7b2c7d6fee057… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: A .werks/12805 M web/htdocs/js/modules/forms.js Log Message: ----------- 12805 FIX Overlapping label inputs (label conditions) When entering invalid labels the width of the input field was calculated incorrectly. This caused the following label input field to overlap with the current one. CMK-8414 Change-Id: I20e4bfe9de2b7134d1871312e9fa9eed635ec54c

3 years, 1 month

[tribe29/checkmk] d6ad54: First steps towards a CSS color palette

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d6ad54ad9cd9011a7a01ec46d5b82fa5635a4548 https://github.com/tribe29/checkmk/commit/d6ad54ad9cd9011a7a01ec46d5b82fa56… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M web/htdocs/themes/facelift/scss/_main.scss M web/htdocs/themes/facelift/scss/_pages.scss M web/htdocs/themes/facelift/scss/_snapins.scss M web/htdocs/themes/facelift/scss/_variables.scss M web/htdocs/themes/facelift/scss/_variables_common.scss M web/htdocs/themes/facelift/scss/_wato.scss M web/htdocs/themes/modern-dark/scss/_variables.scss Log Message: ----------- First steps towards a CSS color palette color-nuance-2 is removed, because it was overwritten by more specific styles for reports and never actually used. The same colors are now used for errors in the connection tests and for input validation errors in forms. CMK-8194 Change-Id: I3610f774cd80c758d582e55b62090ec8e409b147

3 years, 1 month

[tribe29/checkmk] 2f4622: Fix CRE unit tests after "post rename" merge

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2f462237f4461fe9f3105205e9317d98b7ae2f13 https://github.com/tribe29/checkmk/commit/2f462237f4461fe9f3105205e9317d98b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M cmk/post_rename_site/main.py M tests/unit/cmk/post_rename_site/test_main.py Log Message: ----------- Fix CRE unit tests after "post rename" merge Change-Id: I696f38415b7c4b92c75fac322e9a23b1caa79bb2

3 years, 1 month

[tribe29/checkmk] 6ff5fb: Introduce management of site renamings

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6ff5fbfe64c42da693bacade88aac7b1339ca999 https://github.com/tribe29/checkmk/commit/6ff5fbfe64c42da693bacade88aac7b13… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M bin/.f12 A bin/post-rename-site M cmk/.f12 A cmk/post_rename_site/__init__.py A cmk/post_rename_site/main.py A cmk/post_rename_site/plugins/__init__.py A cmk/post_rename_site/plugins/actions/__init__.py A cmk/post_rename_site/plugins/actions/sites.py A cmk/post_rename_site/registry.py M cmk/update_config.py M omd/packages/check_mk/check_mk.make A omd/packages/check_mk/scripts/post-cp/01_cmk-post-rename-site A omd/packages/check_mk/scripts/post-mv/01_cmk-post-rename-site A omd/packages/check_mk/scripts/post-rename/01_cmk-post-rename-site A omd/packages/check_mk/scripts/update-pre-hooks/01_mkp-disable-outdated A omd/packages/check_mk/scripts/update-pre-hooks/02_cmk-update-config R omd/packages/check_mk/update-pre-hooks/01_mkp-disable-outdated R omd/packages/check_mk/update-pre-hooks/02_cmk-update-config M omd/packages/omd/omdlib/main.py M tests/testlib/pylint_checker_cmk_module_layers.py A tests/unit/cmk/post_rename_site/plugins/actions/test_sites.py A tests/unit/cmk/post_rename_site/test_main.py Log Message: ----------- Introduce management of site renamings Users which execute `omd mv` or `omd cp` expect Checkmk to not only rename the site, but also migrate the Checkmk configuration in a way that they can continue seamlessly with their existing Checkmk configuration. This feature did not exist before and was a common misunderstanding. OMD itself is only caring about migrating the files and file parts that are initially installed with the skel hierarchy of OMD and under control of it. *Clearer:* If you create a clean site and then execute `grep -r $OMD_SITE etc` in your site, you can see a lot of files which contain the ID of the site. These things are already migrated by OMD. But OMD is not aware of the configuration files of the applications shipped with OMD. For example the Checkmk configuration files are not understood by OMD. And that's totally fine from an architectural point of view, because OMD is an separate component that manages installation of different applications, but must not mess with their individual files. However, from a users perspective it's clear that you also want the application files to be migrated during site renaming. And this is what we'll now start to work on. This change introduces the general mechanism: - OMD detects changes of the site ID (mv, cp or restore) - Then it executes the command `post-rename-site -v -o [OLD_SITE_ID]` - The command `post-rename-site` then takes care of the Checkmk configuration updates - It can also detect some situations it can not solve on it's own and warns the user about potential manual steps to do afterwards. The migration steps are realized in so called rename action plugins. One first example can be found in `cmk/post_rename_site/plugins/actions/sites.py`. More to come... CMK-5346 Change-Id: I67d892fee381eb32bccceb60016efccb8b0bad00 Commit: 63556ed73f54ff3cd8fb9bdb2a5f98e2b3b3a064 https://github.com/tribe29/checkmk/commit/63556ed73f54ff3cd8fb9bdb2a5f98e2b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M cmk/post_rename_site/main.py A cmk/post_rename_site/plugins/actions/hosts_and_folders.py M cmk/post_rename_site/plugins/actions/sites.py A tests/unit/cmk/post_rename_site/plugins/actions/conftest.py A tests/unit/cmk/post_rename_site/plugins/actions/test_hosts_and_folders_action.py M tests/unit/cmk/post_rename_site/plugins/actions/test_sites.py M tests/unit/cmk/post_rename_site/test_main.py Log Message: ----------- Add post rename action for host and folders `site` attribute It updates explicitly set `site` attributes and also rewrites the `site` host_tags entries in hosts.mk files. Change-Id: Ia6379ca877c4f46464a2fb29943bf79e8b1604a7 Commit: 078c154e7eb95f04a1f536bcec3a6e4d040358ee https://github.com/tribe29/checkmk/commit/078c154e7eb95f04a1f536bcec3a6e4d0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M cmk/post_rename_site/main.py M tests/unit/cmk/post_rename_site/test_main.py Log Message: ----------- Add post rename action for dynamic host configuration `site` attribute Change-Id: I1af93f22a1932f42de2910d69327cf0d0d2c37b4 Commit: 42d81ca2cc7b85f6c175b14a07d3556547fabb42 https://github.com/tribe29/checkmk/commit/42d81ca2cc7b85f6c175b14a07d355654… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: A cmk/post_rename_site/plugins/actions/update_core_config.py A cmk/post_rename_site/plugins/actions/warn_about_not_migrated_configs.py A cmk/post_rename_site/plugins/actions/warn_changed_ports.py A cmk/post_rename_site/plugins/actions/warn_remote_site.py M tests/unit/cmk/post_rename_site/test_main.py Log Message: ----------- Post rename: Update core config; Add some warnings * After all the configuration changes the core config needs to be updated to enable the site to be started afterwards. * Add some warnings for things the user needs to know after renaming a site. Change-Id: Id10e9668786b10c02b10142032de94a81d9f875c Commit: de6101091fbefcc4c127e55b009d099915e09768 https://github.com/tribe29/checkmk/commit/de6101091fbefcc4c127e55b009d09991… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: A .werks/12850 Log Message: ----------- 12850 Migrating Checkmk configurations during site renamings Users which execute <tt>omd mv</tt> or <tt>omd cp</tt> expect Checkmk to not only rename the site, but also migrate the Checkmk configuration in a way that they can continue seamlessly with their existing Checkmk configuration. This feature did not exist before and was a common misunderstanding. The commands listed above did not take care of the Checkmk configuration files. In fact the site management, which is realizing the renaming of a site, does not know anything about the Checkmk configuration files. However, with this change we create the integration of both worlds. In the moment a site renaming or copy is performed, the site management informs Checkmk about this action and gives it the chance to update it's configuration files. The most important parts of the Checkmk configuration are now updated: <ul> <li>Distributed monitoring (sites) configuration</li> <li>Host & folder site attributes</li> <li>Dynamic host configuration site attribute</li> </ul> The new logic is also trying to detect specific situations and displays warnings about things that can (currently) not be migrated automatically. For example, if the renaming of a distributed remote site is detected, a warning is now displayed that you also have to update the distributed monitoring configuration in the central site of your setup. <i>Details:</i> OMD, which is responsible for providing the site management of Checkmk, itself is only caring about migrating the files and file parts that are initially installed when creating a new Checkmk site. <b>Clearer:</b> If you create a clean site and then execute <tt>grep -r $OMD_SITE etc</tt> in your site, you can see a lot of files which contain the ID of the site. These things are already migrated by OMD. But OMD is not aware of the configuration files of the applications shipped with OMD. For example the Checkmk configuration files are not understood by OMD. And that's totally fine from an architectural point of view, because OMD is an separate component that manages installation of different applications, but must not mess with their individual files. However, from a users perspective it's clear that you also want the application files to be migrated during site renaming. This change introduces the general mechanism: <ul> <li>OMD detects changes of the site ID (mv, cp or restore)</li> <li>Then it executes the command <tt>post-rename-site -v -o [OLD_SITE_ID]</tt></li> <li>The command <tt>post-rename-site</tt> then takes care of the Checkmk configuration updates</li> <li>It can also detect some situations it can not solve on it's own and warns the user about potential manual steps to do afterwards.</li> </ul> The migration steps are realized in so called rename action plugins which can easily be extended. In the git you can find them at <tt>cmk/post_rename_site/plugins/actions</tt>. Change-Id: I2d63fad256e2fa1fad8285e38de97a95cd8270f2 Compare: https://github.com/tribe29/checkmk/compare/19f1899a09c1...de6101091fbe

3 years, 1 month

[tribe29/checkmk] 19f189: check_mk_configuration.py: isort

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 19f1899a09c16790205261d807bff64dcbc23030 https://github.com/tribe29/checkmk/commit/19f1899a09c16790205261d807bff64dc… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M cmk/gui/plugins/wato/check_mk_configuration.py Log Message: ----------- check_mk_configuration.py: isort Change-Id: I88c8cc0c31eb012f6b9f9bd0a578edcb39e1b181

3 years, 1 month

[tribe29/checkmk] 2e28a7: Revert "Nuked our local copy of iwyu_tool."

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2e28a734444e4a9b373530b45dd45230e88aca29 https://github.com/tribe29/checkmk/commit/2e28a734444e4a9b373530b45dd45230e… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M Makefile M livestatus/src/Makefile.am M scripts/find-python-files A scripts/iwyu_tool Log Message: ----------- Revert "Nuked our local copy of iwyu_tool." This reverts commit 3953b66ad29cb8cd2162409987c6923c1f60c371. Not all our local changes have been upstreamed. :-/

3 years, 1 month

[tribe29/checkmk] 3953b6: Nuked our local copy of iwyu_tool.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 3953b66ad29cb8cd2162409987c6923c1f60c371 https://github.com/tribe29/checkmk/commit/3953b66ad29cb8cd2162409987c6923c1… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M Makefile M livestatus/src/Makefile.am M scripts/find-python-files R scripts/iwyu_tool Log Message: ----------- Nuked our local copy of iwyu_tool. The system versions should contain all needed changes nowadays. Change-Id: I9191f3708d585d4da4c48c5b8e12a79f68a4674a

3 years, 1 month

[tribe29/checkmk] 76a24d: Prepare unit tests for namespace support

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 76a24d9966a46f582a8394f8bfd755c0d3f92025 https://github.com/tribe29/checkmk/commit/76a24d9966a46f582a8394f8bfd755c0d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: A tests/unit/cmk/special_agents/__init__.py A tests/unit/cmk/special_agents/agent_aws/__init__.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_cloudwatch.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_costs_and_usage.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_dynamodb.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_ebs.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_ec2.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_elb.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_elbv2.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_glacier.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_lambda.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_rds.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_s3.py M tests/unit/cmk/special_agents/agent_aws/test_agent_aws_wafv2.py A tests/unit/cmk/utils/__init__.py A tests/unit/cmk/utils/bi/__init__.py M tests/unit/cmk/utils/bi/conftest.py M tests/unit/cmk/utils/bi/test_bi_aggregation.py M tests/unit/cmk/utils/bi/test_bi_legacy_config_converter.py M tests/unit/cmk/utils/bi/test_bi_rule.py Log Message: ----------- Prepare unit tests for namespace support When enabling mypy namespace support the module detection slightly changes. To make checking the code possible with and without namespace support, we need to make the directory a package and switch to relative imports. Change-Id: I0245b3bde94011ffe7921a5770fc4624051ef9f3 Commit: 23496fbfbd71d40144ae9b1fc0f0f8eb666112ef https://github.com/tribe29/checkmk/commit/23496fbfbd71d40144ae9b1fc0f0f8eb6… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M scripts/find-python-files Log Message: ----------- Prepare cmk-update-agent unit tests for namespace support With namespaces now "sees" the cmk_update_agent.py and now understand it's types. We now need some more help to understand the mocks in the tests. Change-Id: Ie13d264428385a470a2493d5f09089c99c4559a3 Compare: https://github.com/tribe29/checkmk/compare/e48b21f2b691...23496fbfbd71

3 years, 1 month

[tribe29/checkmk] e48b21: Improve typing in cmk/gui/prediction.py

by Maximilian

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e48b21f2b691b6e2fee378e3c216a1f34649f767 https://github.com/tribe29/checkmk/commit/e48b21f2b691b6e2fee378e3c216a1f34… Author: Maximilian Wirtz <maximilian.wirtz(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: M cmk/gui/prediction.py Log Message: ----------- Improve typing in cmk/gui/prediction.py Change-Id: I3320d7de3044093ec973fc0c60bb18cc043fb5da

3 years, 1 month

[tribe29/checkmk] 3ebcd3: Revert "fileinfo migration to new api"

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 3ebcd3c931aa3aca98d6e04b477999b179afbc2b https://github.com/tribe29/checkmk/commit/3ebcd3c931aa3aca98d6e04b477999b17… Author: Sofia Colakovic <sofia.colakovic(a)tribe29.com> Date: 2021-08-05 (Thu, 05 Aug 2021) Changed paths: R .werks/12928 A checks/fileinfo A checks/sap_hana_fileinfo A cmk/base/check_legacy_includes/fileinfo.py R cmk/base/plugins/agent_based/fileinfo.py R cmk/base/plugins/agent_based/sap_hana_fileinfo.py R cmk/base/plugins/agent_based/utils/fileinfo.py M cmk/gui/plugins/wato/check_parameters/fileinfo-groups.py A tests/unit/checks/generictests/datasets/fileinfo_1.py A tests/unit/checks/generictests/datasets/fileinfo_mixed_sections_regression.py A tests/unit/checks/generictests/datasets/fileinfo_new_empty.py A tests/unit/checks/generictests/datasets/fileinfo_new_output.py A tests/unit/checks/generictests/datasets/fileinfo_old_empty_regression.py A tests/unit/checks/generictests/datasets/fileinfo_old_output_regression.py A tests/unit/checks/test_fileinfo_check.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/checks/test_sap_hana_fileinfo.py A tests/unit/cmk/base/check_legacy_includes/test_fileinfo_utils.py R tests/unit/cmk/base/plugins/agent_based/test_fileinfo_check.py R tests/unit/cmk/base/plugins/agent_based/test_sap_hana_fileinfo.py R tests/unit/cmk/base/plugins/agent_based/utils/test_fileinfo_utils.py M tests/unit/test_plugin_vs_wato.py Log Message: ----------- Revert "fileinfo migration to new api" This reverts commit 493debfdd3694d86c661e467f9df42f6264fe07f. Reason for revert: Broke integration tests Change-Id: If79df352226ee38d21359094def49952e99e2bea

3 years, 1 month

← Newer
1
...
36
37
38
39
40
41
42
...
45
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2021