Checkmk git commits July 2021

checkmk-commits@lists.checkmk.com

1 participants
465 discussions

[tribe29/checkmk] e7aafd: 12846 FIX Fix inheritance of folder contact groups...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e7aafdc4bad85041b34fed2ae651cdafa636f059 https://github.com/tribe29/checkmk/commit/e7aafdc4bad85041b34fed2ae651cdafa… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: A .werks/12846 M cmk/base/config.py M cmk/gui/watolib/hosts_and_folders.py M tests/unit/cmk/base/test_config.py Log Message: ----------- 12846 FIX Fix inheritance of folder contact groups to services of hosts The assignment of contact groups to hosts and services can be controlled using the folder hierarchy of WATO as described in the user manual (https://docs.checkmk.com/latest/en/wato_user.html#_allocation_via_folders). You are only affected by this change in case you use a) the WATO folder hierarchy for assigning contact groups to services. When using the assigning contact groups to services with the following settings, this could result in too many groups being assigned to a service: <ul> <li>Add these groups as contacts to all hosts in this folder: Enabled</li> <li>Add these groups as contacts to all hosts in all subfolders of this folder: Not enabled</li> <li>Always add these groups as contacts to all services in all subfolders of this folder: Enabled</li> </ul> In this situation only the groups from the nearest parent folder should be assigned to the services, just like it is done for the hosts. Instead the services got the groups assigned from all parent folders which have the service assignement enabled. We now have changed the contact groups of the services to be handled exactly like the hosts. Only the contact groups defined in the nearest parent folder with the service assignment enabled will be added to the services. Example: <code> Folder_A (Permission: group1, settings as listed above) |_Folder_B (Permission: group2, settings as listed above) </code> In this scenario, a host in the Folder_B gets the contact group "group2" assigned. Services got the "group1" and "group2" assingned in previous versions. Now the services get the "group2" assigned, just like the host. Change-Id: Ic10b038ca7555441cecebf83b9e7c7ba1a730ee8

2 years, 11 months

[tribe29/checkmk] 92af90: 12846 FIX Fix inheritance of folder contact groups...

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 92af9017add552c4aa9785a817145a024691168f https://github.com/tribe29/checkmk/commit/92af9017add552c4aa9785a817145a024… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: A .werks/12846 M cmk/base/config.py M cmk/gui/watolib/hosts_and_folders.py M tests/unit/cmk/base/test_config.py Log Message: ----------- 12846 FIX Fix inheritance of folder contact groups to services of hosts The assignment of contact groups to hosts and services can be controlled using the folder hierarchy of WATO as described in the user manual (https://docs.checkmk.com/latest/en/wato_user.html#_allocation_via_folders). You are only affected by this change in case you use a) the WATO folder hierarchy for assigning contact groups to services. When using the assigning contact groups to services with the following settings, this could result in too many groups being assigned to a service: <ul> <li>Add these groups as contacts to all hosts in this folder: Enabled</li> <li>Add these groups as contacts to all hosts in all subfolders of this folder: Not enabled</li> <li>Always add these groups as contacts to all services in all subfolders of this folder: Enabled</li> </ul> In this situation only the groups from the nearest parent folder should be assigned to the services, just like it is done for the hosts. Instead the services got the groups assigned from all parent folders which have the service assignement enabled. We now have changed the contact groups of the services to be handled exactly like the hosts. Only the contact groups defined in the nearest parent folder with the service assignment enabled will be added to the services. Example: <code> Folder_A (Permission: group1, settings as listed above) |_Folder_B (Permission: group2, settings as listed above) </code> In this scenario, a host in the Folder_B gets the contact group "group2" assigned. Services got the "group1" and "group2" assingned in previous versions. Now the services get the "group2" assigned, just like the host. Change-Id: Ic10b038ca7555441cecebf83b9e7c7ba1a730ee8

2 years, 11 months

[tribe29/checkmk] 5ac71e: Bumped asio 1.18.0 => 1.18.2.

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5ac71ec9033db7b68d454335076ea4f51709aaad https://github.com/tribe29/checkmk/commit/5ac71ec9033db7b68d454335076ea4f51… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M agents/wnx/scripts/unpack_all.cmd M livestatus/src/.gitignore M livestatus/src/Makefile.am M omd/Licenses.csv R omd/packages/asio/asio-asio-1-18-0.tar.gz A omd/packages/asio/asio-asio-1-18-2.tar.gz M omd/packages/asio/asio.diff Log Message: ----------- Bumped asio 1.18.0 => 1.18.2. Change-Id: I101524f0c0e8ed7098e378d874261c4c4621ce95 Commit: 82f513ac88a1b3b10ef376ad9b19574e0984f569 https://github.com/tribe29/checkmk/commit/82f513ac88a1b3b10ef376ad9b19574e0… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M .werks/first_free Log Message: ----------- Reserved 10 Werk IDS Change-Id: I45e4c85956fbc7c7085f57f3baf91b4d13372ac0 Compare: https://github.com/tribe29/checkmk/compare/532ca711a6f2...82f513ac88a1

2 years, 11 months

[tribe29/checkmk] 532ca7: 13030 FIX check_mk_agent terminates ntpd via timed...

by Benedikt Seidl

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 532ca711a6f218b488d18999b2e9ac9e64337af1 https://github.com/tribe29/checkmk/commit/532ca711a6f218b488d18999b2e9ac9e6… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: A .werks/13030 M agents/check_mk_agent.linux Log Message: ----------- 13030 FIX check_mk_agent terminates ntpd via timedatectl Executing `timedatectl timesync-status` terminates the ntp daemon on certain debian versions. This werk adds two more safeguards to make sure `timedatectl timesync-status` is only executed on systems running systemd-timesyncd. SUP-7059 Change-Id: Id84dd3ffacec1e1cd62486e4f01daae7936b6245

2 years, 11 months

[tribe29/checkmk] 812625: Refactor failed notification to base on Page class

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8126256fec2366b05f815ade82d1617088f37630 https://github.com/tribe29/checkmk/commit/8126256fec2366b05f815ade82d161708… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/notifications.py Log Message: ----------- Refactor failed notification to base on Page class Also make some module local helpers private. Change-Id: I6435f6daa9e1ed34ceb6e9e68b901dc5b9e08e96 Commit: bc32469c357d87373688f56b2d72548717acc678 https://github.com/tribe29/checkmk/commit/bc32469c357d87373688f56b2d7254871… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/notifications.py M cmk/gui/plugins/dashboard/failed_notifications.py M cmk/gui/plugins/sidebar/tactical_overview.py Log Message: ----------- Add type hints And also separate number of failed notification computation from gathering the list of failed notifications to be able to get better return types. Change-Id: Icff306b1156f644b011b3fef0e8903587faba91d Commit: fb88a3a86d1f341fb23dc41c4f994e409811af6b https://github.com/tribe29/checkmk/commit/fb88a3a86d1f341fb23dc41c4f994e409… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/notifications.py Log Message: ----------- Failed notifications: Cleanup module global state * Move the cached states to request globals * Storing the failed notification times per user is not necessary anymore, since we don't have a state that is kept for multiple users anymore. * The acknowledgement timestamp of the user and it's modification time belong together. Grouping them together in a single data structure. Change-Id: I9fb94e93c1700c95100e86d0de0a7f70c8e454bb Compare: https://github.com/tribe29/checkmk/compare/3f2a1ba5f6a4...fb88a3a86d1f

2 years, 11 months

[tribe29/checkmk] 3f2a1b: Push agent: introduce host configuration option

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 3f2a1ba5f6a4c76c2cdc2a7fac5724ce6e312954 https://github.com/tribe29/checkmk/commit/3f2a1ba5f6a4c76c2cdc2a7fac5724ce6… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/base/config.py M cmk/base/default_config/base.py M cmk/base/sources/_checkers.py M cmk/gui/plugins/wato/builtin_attributes.py M cmk/gui/watolib/hosts_and_folders.py M cmk/utils/tags.py M tests/integration/cmk/gui/test_webapi.py M tests/integration/livestatus/test_livestatus.py M tests/unit/cmk/base/test_config.py M tests/unit/cmk/base/test_core_nagios.py M tests/unit/cmk/gui/test_gui_config.py M tests/unit/cmk/gui/watolib/test_host_attributes.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Push agent: introduce host configuration option In order to be able to configure the upcoming 'push agent' configuration on a host, we need a corresponding host configuration option. CMK-8252 Change-Id: If7d00d03a8771621f8424076b12f72f5d93dc3b3

2 years, 11 months

[tribe29/checkmk] d59c49: Rebuild of frozen binaries

by Timotheus Bachinger

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: d59c49b88d5e8653f401e3995aca4040b9f134fe https://github.com/tribe29/checkmk/commit/d59c49b88d5e8653f401e3995aca4040b… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M agents/windows/plugins/mk_jolokia.exe M agents/windows/plugins/mk_logwatch.exe Log Message: ----------- Rebuild of frozen binaries ... after update of used python modules in commits: 4853d07047fb5820ab291b492cbe8f747b1e54b0 3de026dd5eb13935f1cbc9ac5eb0470cedd0abe8 CMK-7800 Change-Id: Ic74e656fdba7f0bbde2c456375b41b3657b3f816

2 years, 11 months

[tribe29/checkmk] 682411: 12817 FIX mk_postgres: improved error message "Ins...

by Uli

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6824118db9f91241b48912223350093db6ca50f9 https://github.com/tribe29/checkmk/commit/6824118db9f91241b48912223350093db… Author: Ulrich Bschorer <ulrich.bschorer(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: A .werks/12817 M checks/postgres_instances M tests/unit/checks/generictests/datasets/postgres_no_instances_regression.py Log Message: ----------- 12817 FIX mk_postgres: improved error message "Instance DATA not running" A postgres instance will be detected as running if a process is found that contains a postgress commandline which contains the name of the env-file. Otherwise the check "SQL Instance" will show the following error message "Instance <INSTANCE_NAME> not running or postgres DATADIR name is not identical with instance name.". Change-Id: Ia2ee0481798dba3c480cd5383f1d3cdadad0942d

2 years, 11 months

[tribe29/checkmk] edfb32: Correctly calculate missing context filters

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: edfb32d3777b6a389ce270697bde9c7b45e4444b https://github.com/tribe29/checkmk/commit/edfb32d3777b6a389ce270697bde9c7b4… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/dashboard.py M cmk/gui/visuals.py Log Message: ----------- Correctly calculate missing context filters Because all needed filters are preloaded on pagemenu, when they are not set, they still give empty values, check has to be more strict Change-Id: Ia5497b5f838576c27f25c0a0697fccbb0be86c58 Commit: 5c3157ad50eac8ff04bcf75cf4bc3523e9d17dbf https://github.com/tribe29/checkmk/commit/5c3157ad50eac8ff04bcf75cf4bc3523e… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/views.py M cmk/gui/visuals.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- Single_info context transform The context spec for single infos now includes a transform for in disk to match the VisualContext type, which implies filters are separate. It also needs a transform to extract from filter into single_spec dictionary. (It works correctly but is so ugly that it can't be a good option) An extra transformation is provided when importing views previous to this change(<2.1.0) to make sure context from disk is loaded correctly. The transform_old_visuals acts on views, and recursively on dashboard->daslet. Reports need an narrower step only for the context in element. Change-Id: Ib696f35601302d64f7550973ee89ca931dc7dc0d Commit: 2d0a5c50c7bef4ca70530b50501a489e187fc4c0 https://github.com/tribe29/checkmk/commit/2d0a5c50c7bef4ca70530b50501a489e1… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/views.py Log Message: ----------- On views users can change saved filters Currently all the saved context filters are loaded on the view filter menu. Because there is no merging, instead is a direct selection between on disk or active filters. User can lively change the active filters of a view. Thus, don't filter them out. Filters become now users choice. Less surprises for the user. If he now deletes a set filter, it get deleted. Change-Id: I32c2834b1401fe28dd713862d26798ac6771ff16 Commit: 3fdd55e1a4e02b3b6e90da7a21e409675dd0448a https://github.com/tribe29/checkmk/commit/3fdd55e1a4e02b3b6e90da7a21e409675… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/plugins/webapi/grafana.py Log Message: ----------- Some cleanup in combined graphs Remove duplicated function that has no special functionality. This creates a cleanup in grafana webapi too, which now uses a raw edition function. I don't think we were explicitly making this feature CEE, it was only a bad import limitation. Usage is for availability dashboard annotations, an obscure and undocumented feature. Still tested that it now works. Rendering of combined graphs in Grafana remains CEE feature. Change-Id: I074d0b85a0c840c87758f9cc33f77363dd31a118 Commit: 3e7ee0edddace32fe26fef200d8ef2934eb62027 https://github.com/tribe29/checkmk/commit/3e7ee0edddace32fe26fef200d8ef2934… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/visuals.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- Remove add_context_to_uri_vars We shall never be using the request vars as a communication bus! Change-Id: Ib811aef359417e055fa20478ed199549cc1fa9ec Compare: https://github.com/tribe29/checkmk/compare/91ac71277108...3e7ee0edddac

2 years, 11 months

[tribe29/checkmk] afbd26: 13030 FIX check_mk_agent terminates ntpd via timed...

by Benedikt Seidl

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: afbd26d8193a6ed99b1b33f44de8371c7090e6fc https://github.com/tribe29/checkmk/commit/afbd26d8193a6ed99b1b33f44de8371c7… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: A .werks/13030 M agents/check_mk_agent.linux Log Message: ----------- 13030 FIX check_mk_agent terminates ntpd via timedatectl Executing `timedatectl timesync-status` terminates the ntp daemon on certain debian versions. This werk adds two more safeguards to make sure `timedatectl timesync-status` is only executed on systems running systemd-timesyncd. SUP-7059 Change-Id: Id84dd3ffacec1e1cd62486e4f01daae7936b6245

2 years, 11 months

← Newer
1
...
6
7
8
9
10
11
12
...
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2021