Checkmk git commits July 2021

checkmk-commits@lists.checkmk.com

1 participants
465 discussions

[tribe29/checkmk] ee685c: Fixed wrong pointer type.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ee685cac0eac9c65ac4a6e331a8bd4f7c73e73cd https://github.com/tribe29/checkmk/commit/ee685cac0eac9c65ac4a6e331a8bd4f7c… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M livestatus/src/ServiceGroupMembersColumn.cc Log Message: ----------- Fixed wrong pointer type. There was a confusion between a std::unique_ptr<Foo> and a Foo*. This worked just by accident: In libstdc++, a std::unique_ptr is implemented as a tuple of the raw pointer and the deleter. Furthermore, the std::tuple implementation effectively removes empty elements where possible. The net effect for all of this is: A std::unique_ptr<Foo> and a Foo* have an identical representation in memory for libstdc++, but this is just an implementation detail not guaranteed by the standard. Change-Id: I667289df2dde5d469cee8342bb7fda3491cb1d46

3 years, 2 months

[tribe29/checkmk] 2ce3df: 12950 FIX missing default tag groups in the REST API

by Christoph Rauch

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 2ce3df20b9717fd305da1ce280d15beb913592d5 https://github.com/tribe29/checkmk/commit/2ce3df20b9717fd305da1ce280d15beb9… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: A .werks/12950 M cmk/gui/openapi.py Log Message: ----------- 12950 FIX missing default tag groups in the REST API Starting from 2.0.0p5, some default tag groups like "tag_criticality", did not appear in the REST API unless one logged in first and after- wards restarted the Apache process. This is now fixed: the default tag groups will appear in the REST specification by default. No further action by the user is neccessary. Change-Id: Ib2ce769c059c64368619c8fc52be51bf8e63ee56 Commit: d293a8d7e3197e7b0e9769ca053c0f2b23e7cf8c https://github.com/tribe29/checkmk/commit/d293a8d7e3197e7b0e9769ca053c0f2b2… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M cmk/gui/wsgi/applications/rest_api.py Log Message: ----------- REST API: dont check twice on authentication Change-Id: I097e6464e7b511cd3a09b787fdd334d9d9d1f08b Commit: 81efdcc4fe727f67d4c4b53bc19b40ebda062c56 https://github.com/tribe29/checkmk/commit/81efdcc4fe727f67d4c4b53bc19b40ebd… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M cmk/gui/plugins/openapi/endpoints/activate_changes.py M cmk/gui/plugins/openapi/endpoints/utils.py M cmk/gui/plugins/openapi/restful_objects/decorators.py M cmk/gui/plugins/openapi/restful_objects/type_defs.py M cmk/gui/plugins/openapi/utils.py M cmk/gui/watolib/activate_changes.py Log Message: ----------- REST API: more detailed errors on activate changes Change-Id: I8bf86056f252cdfa8d00252743e5399a667a9720 Commit: bae2804feb80d795b8b2f74a3878ebda04859cc6 https://github.com/tribe29/checkmk/commit/bae2804feb80d795b8b2f74a3878ebda0… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M cmk/gui/plugins/openapi/restful_objects/request_schemas.py Log Message: ----------- REST API: fix example value Change-Id: I7acfc9f607754489aa7c21163b5fa9c0b8a20e2e Compare: https://github.com/tribe29/checkmk/compare/eaffbb2502a7...bae2804feb80

3 years, 2 months

[tribe29/checkmk] 201df8: Fix filtering permitted paths

by Simon

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 201df8bb3463493383690972dab0e58d9eea3c0e https://github.com/tribe29/checkmk/commit/201df8bb3463493383690972dab0e58d9… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M cmk/gui/inventory.py M cmk/utils/structured_data.py A tests/unit/cmk/gui/test_gui_inventory.py R tests/unit/cmk/gui/test_inventory.py M tests/unit/cmk/utils/structured_data/test_structured_data.py Log Message: ----------- Fix filtering permitted paths Change-Id: Ib4cd619ad2ed48d8bdfe3d23b603534713dddf2d

3 years, 2 months

[tribe29/checkmk] 85b68f: IWYU: Fix 1 include in DowntimeColumn.h

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 85b68f3c464236f002d25f51ce43f0afddfc534c https://github.com/tribe29/checkmk/commit/85b68f3c464236f002d25f51ce43f0afd… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M livestatus/src/DowntimeColumn.h Log Message: ----------- IWYU: Fix 1 include in DowntimeColumn.h Change-Id: Ia4346d24e94f023c20d5d1c3d89bf4344eafd8cc

3 years, 2 months

[tribe29/checkmk] 97977f: Lambdaify DowntimeColumn

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 97977f2ffbdc3cd3aa918b63a8f2389b94b4e4e7 https://github.com/tribe29/checkmk/commit/97977f2ffbdc3cd3aa918b63a8f2389b9… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M livestatus/src/CommentColumn.h M livestatus/src/DowntimeColumn.cc M livestatus/src/DowntimeColumn.h M livestatus/src/ListLambdaColumn.h M livestatus/src/TableHosts.cc M livestatus/src/TableServices.cc Log Message: ----------- Lambdaify DowntimeColumn This transforms the DowntimeColumn in the very same manner as the CommentColumn. We also make a couple of minor adjustments to the CommentColumn to help with the definition and clarify the similarities. CMK-7076 Change-Id: I7814805d3c00f699060ab15d7d6f1c79f7d55075 Commit: 429945217aacba9b210f9604be002d6d3fcc8f67 https://github.com/tribe29/checkmk/commit/429945217aacba9b210f9604be002d6d3… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M livestatus/src/CommentColumn.cc M livestatus/src/CommentColumn.h M livestatus/src/DowntimeColumn.cc M livestatus/src/DowntimeColumn.h M livestatus/src/ServiceGroupMembersColumn.cc M livestatus/src/ServiceGroupMembersColumn.h M livestatus/src/ServiceListColumn.cc M livestatus/src/ServiceListColumn.h M livestatus/src/TableHosts.cc M livestatus/src/TableServiceGroups.cc M livestatus/src/TableServices.cc Log Message: ----------- Do not alias `verbosity` in the column The `verbosity` enums are not exactly identical. Therefore, they cannot be moved to a base class for the columns. Let us simplify this by leaving them in the renderers. CMK-7076 Change-Id: I9a9ecf89fcd9d4a09affad159a0af1209f2fa2e3 Commit: 879b4375fbda0a7e69bff20e87dc15226dc144d3 https://github.com/tribe29/checkmk/commit/879b4375fbda0a7e69bff20e87dc15226… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M livestatus/src/ListLambdaColumn.h M livestatus/src/test/test_ListColumn.cc Log Message: ----------- Add 2nd template arg to base ListColumn::Callback Now, we can use this as the base class to columns such as `comment` and `downtime`. CMK-7076 Change-Id: Ic3e1b9ce28e40c96c1469ed4e370b80f7174ee4b Commit: 7c66679c84066f9ab55614b704c4934a24be77ae https://github.com/tribe29/checkmk/commit/7c66679c84066f9ab55614b704c4934a2… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M livestatus/src/CommentColumn.h M livestatus/src/DowntimeColumn.h M livestatus/src/ListLambdaColumn.h M livestatus/src/TableHosts.cc M livestatus/src/TableServices.cc Log Message: ----------- Let {Comment,Downtime}Column inherit ListColumn::Callback This greatly reduces duplicated boiler plate! CMK-7076 Change-Id: I704960ec6d759b74ab0750b0be2d5673954dfcbf Compare: https://github.com/tribe29/checkmk/compare/27d73d5aad37...7c66679c8406

3 years, 2 months

[tribe29/checkmk] 27d73d: Fix int tests & mkbackup

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 27d73d5aad377835bc68605096b5301beab22181 https://github.com/tribe29/checkmk/commit/27d73d5aad377835bc68605096b5301be… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- Fix int tests & mkbackup * Due to the sticky bit of /run/lock, we need to chmod the rights on the directory, in case root was executing "omd start" etc. Change-Id: I8546038ad5847059bc16d2b9378855aafdfaf8c5

3 years, 2 months

[tribe29/checkmk] eaffbb: 12388 FIX check_mk_agent.aix: Fix execution of cac...

by Simon

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: eaffbb2502a720ae55709f6d689e4ea338de5391 https://github.com/tribe29/checkmk/commit/eaffbb2502a720ae55709f6d689e4ea33… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: A .werks/12388 M agents/check_mk_agent.aix Log Message: ----------- 12388 FIX check_mk_agent.aix: Fix execution of cached plugins Plugins in the folder {{/usr/check_mk/lib/plugins/NUMBER}} are executed asynchronously. Since Checkmk version 2.0.0b4 it was broken because in ksh, dash or similar the following command in the run_cached function C:+ sh -c "COMMAND-STRING" C:- expects executable commands/files but not inline functions. Change-Id: Ic82b511803b5ee01d5285ae579812c4b121641b0

3 years, 2 months

[tribe29/checkmk] fca28d: Fix reportlab: PIL usage

by Timotheus Bachinger

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: fca28d96e8313ee990fa20b08dee727d66b1261b https://github.com/tribe29/checkmk/commit/fca28d96e8313ee990fa20b08dee727d6… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M Pipfile M Pipfile.lock M omd/packages/python-modules/python-modules.make A omd/packages/python-modules/src/reportlab-3.5.18.tar.gz R omd/packages/python-modules/src/reportlab-3.5.9.tar.gz Log Message: ----------- Fix reportlab: PIL usage * we need to bump reportlab to 3.5.18 which includes: https://hg.reportlab.com/hg-public/reportlab/rev/37fce4b8f084 * otherwise reportlab will not work with Pillow in version 6.2.2 and crash with: AttributeError ('module' object has no attribute 'VERSION' Change-Id: I83a93a6d29e57b61b14c37276293f0e82e936d6f

3 years, 2 months

[tribe29/checkmk] 8e2b28: 12948 FIX REST API ETag handling

by Christoph Rauch

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 8e2b28e3c14fa06d70ed330d8c41ec70fa45d439 https://github.com/tribe29/checkmk/commit/8e2b28e3c14fa06d70ed330d8c41ec70f… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: A .werks/12948 M cmk/gui/plugins/openapi/endpoints/folder_config.py M cmk/gui/plugins/openapi/endpoints/host_config.py M cmk/gui/plugins/openapi/restful_objects/constructors.py Log Message: ----------- 12948 FIX REST API ETag handling In 2.0.0p6, the viewing of a host through the REST API might fail due to missing "modification time" information on the host. This led to a HTTP 500 error. Also, the calculation of the ETag was sometimes based on stale cached values, resulting in subsequent HTTP 412 "precondition failed" errors. This werk fixes both of these bug. Change-Id: I10e2926dc2721af198a31fbef5d65ca2d56971fb Commit: f40b0e7104e1fdc972e866d1611de838abe04c4c https://github.com/tribe29/checkmk/commit/f40b0e7104e1fdc972e866d1611de838a… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: A tests/integration/cmk/gui/plugins/openapi/test_openapi_tags.py Log Message: ----------- REST API: integration test for tag_config default config Change-Id: I1f44e61fa4a7f47767afc3aee961ccca9ccd6039 Commit: 022aaf49eaef3e4b6b1e4cbe74d00a3693bcee2e https://github.com/tribe29/checkmk/commit/022aaf49eaef3e4b6b1e4cbe74d00a369… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M tests/testlib/utils.py Log Message: ----------- Integration tests: better detect branch name Change-Id: Ib3e5ba3ba57768e5a55196081cbbe3b20281f55c Compare: https://github.com/tribe29/checkmk/compare/df8e211d6d1b...022aaf49eaef

3 years, 2 months

[tribe29/checkmk] e73859: simplify named tuple syntax

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e73859e6d0d9e223961145b49ee38157fd0ae01e https://github.com/tribe29/checkmk/commit/e73859e6d0d9e223961145b49ee38157f… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M cmk/utils/piggyback.py Log Message: ----------- simplify named tuple syntax Change-Id: I59877b4c72ec13a102264b34dfab099c1a985ea2 Commit: 79ecfd5546aef900869f3e496ef3d67fb98189ff https://github.com/tribe29/checkmk/commit/79ecfd5546aef900869f3e496ef3d67fb… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M cmk/utils/piggyback.py Log Message: ----------- formating: add trailing commas Change-Id: Ie811712ddb836ecc1dcb9d64f2a1fb1846e727f5 Commit: e3406c522b17c50280b93c48b18d82d9a1b960e6 https://github.com/tribe29/checkmk/commit/e3406c522b17c50280b93c48b18d82d9a… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M cmk/utils/piggyback.py Log Message: ----------- str -> HostName Change-Id: I1073c252e149bad759762340f467766c6f6579d7 Commit: 58b77175c82ec9581835e2ebcc629213666b4f60 https://github.com/tribe29/checkmk/commit/58b77175c82ec9581835e2ebcc6292136… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-07-06 (Tue, 06 Jul 2021) Changed paths: M cmk/core_helpers/piggyback.py M cmk/utils/piggyback.py Log Message: ----------- further type improvements Change-Id: I5c8e90b3dfbf6131e9100b1b0fb335c8a1bbc764 Compare: https://github.com/tribe29/checkmk/compare/658db1416d22...58b77175c82e

3 years, 2 months

← Newer
1
...
36
37
38
39
40
41
42
...
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits July 2021