Branch: refs/heads/2.0.0
Home: https://github.com/tribe29/checkmk
Commit: f3c411b08594b968c38f2119943b79d54ca3aa04
https://github.com/tribe29/checkmk/commit/f3c411b08594b968c38f2119943b79d54…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/plugins/visuals/infos.py
Log Message:
-----------
Apply typing for all VisualInfo.single_spec subclasses
Change-Id: I63294863ddbc7a8ee3391ed5b02d09b4566308cd
Commit: 7085bb45783a3e44a74ba0a83f5ab3eab77bf867
https://github.com/tribe29/checkmk/commit/7085bb45783a3e44a74ba0a83f5ab3eab…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/dashboard.py
M cmk/gui/node_visualization.py
M cmk/gui/views.py
M cmk/gui/visuals.py
Log Message:
-----------
Drop the mandatory filter separation
This reduces complexity. The warning comes on each dashlet. There is no
ignore process on the filter list, which all other pages don't use.
The filter lists gets autocompleted because the context is forced to
include at least information of mandatory filters.
The VisualFilterList does not have the ignore feature anymore. That is
not only relevant for the FilterMenu but for all forms. The second use
was on filter forms separating single and multi context, yet in those
case the info_list did the job of separating repetition and forms still
look good. (Unless I'm missing something) I assume it works because in
those cases the filter name matches the single_info key, and if they are
already separated for the form, then there is no need for the ignore.
CMK-8232
Change-Id: I75cbea16520194e874ce1b5c83819910db52dae9
Commit: 3045ae410a2006cd5e6fad66539c31cd740e57c2
https://github.com/tribe29/checkmk/commit/3045ae410a2006cd5e6fad66539c31cd7…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
A .werks/12993
M cmk/gui/plugins/visuals/wato.py
Log Message:
-----------
12993 FIX Filter Multiple WATO folder can now be saved
The Multiple WATO folder filter could be used from the Dashboards and Views
filter menu, yet it could not be saved correspondinly as a context filter, when
editing the view or dashboard. This is now fixed.
Use dual list choice because is a manageable valuespec. The problem with
ListOf is that when the valuespec is to complicated to keep track of it
without the valuespec and it can not be simply recovered the indexing
gets lost among other issues.
SUP-5806
SUP-6263
Change-Id: I40315510bc7755c947945e5ce08317ee3330df15
Compare: https://github.com/tribe29/checkmk/compare/9087a2e77f43...3045ae410a20
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: edea460ed07503fd35a1d9c2755ff075890b1ec2
https://github.com/tribe29/checkmk/commit/edea460ed07503fd35a1d9c2755ff0758…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/availability.py
M cmk/gui/bi.py
M cmk/gui/mobile.py
M cmk/gui/node_visualization.py
M cmk/gui/plugins/views/availability.py
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/plugins/visuals/inventory.py
M cmk/gui/plugins/visuals/utils.py
M cmk/gui/plugins/visuals/wato.py
M cmk/gui/type_defs.py
M cmk/gui/valuespec.py
M cmk/gui/views.py
M cmk/gui/visuals.py
M tests/unit/cmk/gui/plugins/visuals/test_filters.py
Log Message:
-----------
New filter scheme: Use an input value instead
Filters will now require their pertinent configuration giving by the
FilterHTTPVariables, which are exhaustively constructed by the Filter
class using the htmlvars.
For the moment update the form and make sure that pylint, mypy, &
pytests are happy with the change.
Use FilterHeader type, only singular as is alias of string
FilterGroupCombo has inactive filters since 2014, never discarded,
daring now
Extra typing limitations on inventory.get_inventory_attribute output @si
Change-Id: Iba01d573827369a289206167b003f641cc04d653
Commit: f98b23d42cbd23ec8016c4bfffdcf594540fc10b
https://github.com/tribe29/checkmk/commit/f98b23d42cbd23ec8016c4bfffdcf5945…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/plugins/visuals/inventory.py
M cmk/gui/plugins/visuals/utils.py
M cmk/gui/visuals.py
M tests/unit/cmk/gui/plugins/visuals/test_filters.py
Log Message:
-----------
New scheme display fixes where they break
Sometimes out of valuespec the input is a None on empty fields and not a filterHTTPVariables
display checkboxes and radio buttons are left for next commits
Change-Id: I42f17b67ea49100303ee02ea2e1abfcd83d6f5ba
Commit: 42e967a5ad48585be0544698a9b8f44d68e397c6
https://github.com/tribe29/checkmk/commit/42e967a5ad48585be0544698a9b8f44d6…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/plugins/visuals/inventory.py
Log Message:
-----------
New scheme display inventory
Change-Id: Ic219031b9a33a57e0198707900508a8d1a213411
Commit: 900dadd6c797290a0ce3a41a5c48600e48a953ea
https://github.com/tribe29/checkmk/commit/900dadd6c797290a0ce3a41a5c48600e4…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/plugins/visuals/inventory.py
M cmk/gui/plugins/visuals/utils.py
Log Message:
-----------
Cleanup Filters that display radio buttons
The horizontal option in radio group seems to
only influence the mobile GUI. Is it still relevant?
It is also not used on all filters although they would profit.
Change-Id: I2d04a2614c37d510fcfcbfe4504824093dce52da
Commit: 4384ac512910b4d9643901d740b70e04905b01ff
https://github.com/tribe29/checkmk/commit/4384ac512910b4d9643901d740b70e049…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/plugins/visuals/inventory.py
Log Message:
-----------
Cleanup checkboxes
Change-Id: Iaf79ca41e0e2859d519e85d59e3d74d24cc6c420
Commit: 5a29094745ce3164fe0d783f119ab2003ec0568d
https://github.com/tribe29/checkmk/commit/5a29094745ce3164fe0d783f119ab2003…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/views.py
Log Message:
-----------
Remove _get_view_filters which mutates request
The change to request is then pushed later down the data processing
for a view.
Change-Id: Ibec0c2aba0c4a61dc66a815ef43dcbbb5811f2e2
Commit: 5ceceab210acc36a354b27c73e6b419b0bfa66ed
https://github.com/tribe29/checkmk/commit/5ceceab210acc36a354b27c73e6b419b0…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/views.py
M cmk/gui/visuals.py
Log Message:
-----------
Filters use the FilterHTTPVariables as input
Filterheaders generated from input not html request
Keep a backwards compatibility for single_info contexts
Change-Id: I34bc767546d94aac0bfd158c8457ce3cbd6bba6f
Commit: 805796017a4cb4714af2fb8f4a97f5d85c162618
https://github.com/tribe29/checkmk/commit/805796017a4cb4714af2fb8f4a97f5d85…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/valuespec.py
M cmk/gui/views.py
M cmk/gui/visuals.py
M tests/unit/cmk/gui/test_visuals.py
M web/htdocs/js/modules/utils.js
Log Message:
-----------
Working filter creation from the side filter menu
Discard on page_views the concept of single infos. Filters take the dict
of html vars an should thus just use that construct. No need for the
single string option.
The refresh is not working, no persistence yet. Taking the filter as
overwrite, yet when not active return to context merge.
Refresh view including _active urlvar is needed because now the context
is not "merged" upon spec & vars but taken directly out of the filter
menu, which starts from the spec and is changed by user. This makes it
completely user controlled.
Bug of werk 11759 does not come up because filter value is str_mandatory
and now work is directly on the context dict.
Change-Id: I44d0c19e4f917d225f1013601c58bb51ef52f941
Commit: 923b680a1a938f5b2e75a190a59fa23b5b13d6df
https://github.com/tribe29/checkmk/commit/923b680a1a938f5b2e75a190a59fa23b5…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/bi.py
M cmk/gui/node_visualization.py
M cmk/gui/plugins/views/inventory.py
M cmk/gui/plugins/visuals/utils.py
M cmk/gui/views.py
M cmk/gui/visuals.py
Log Message:
-----------
Refactor: get_livestatus_filter_headers
Move this function to utils and utilize it more often
Could not find the reference to the reports
graphs filter_table use context not request
BI singlehost table use context not the old infoname filter with html.request
Change-Id: Ib2c4f60b9db67a9e4b822695d8f7c4645b313dbe
Commit: c8db9824ec2725349a2723b4543441f3bb732ecb
https://github.com/tribe29/checkmk/commit/c8db9824ec2725349a2723b4543441f3b…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/plugins/visuals/wato.py
M tests/unit/cmk/gui/test_views.py
Log Message:
-----------
Multiple WATO folder save and recover
Use dual list choice because is a manageable valuespec. The problem with
ListOf is that when the page menu filters use "reset" the indexing gets
lost. (A bug for another war)
Change-Id: Iffb608417b2a8fad4d0c946515754f9d86756fb8
Commit: d5d7ab50d0f443f47f2a20b8679f1eaf564f2542
https://github.com/tribe29/checkmk/commit/d5d7ab50d0f443f47f2a20b8679f1eaf5…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/plugins/visuals/utils.py
M cmk/gui/plugins/visuals/wato.py
M cmk/gui/visuals.py
Log Message:
-----------
Filter heading info to use value instead
SUP-6284
Change-Id: Ia59aa81477e43dc65bc6ebf1157e41702f41b008
Commit: f79a0250ddcaeb395d3ab87ae422e23cf2a0bfe3
https://github.com/tribe29/checkmk/commit/f79a0250ddcaeb395d3ab87ae422e23cf…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/dashboard.py
M cmk/gui/plugins/dashboard/utils.py
M cmk/gui/plugins/dashboard/view.py
M tests/unit/cmk/gui/test_dashboard.py
Log Message:
-----------
Dashboards use context dict instead of request
on cmk.gui.dashboard._render_dashlet_content there was an additional
loading of context var, which I could not longer find a use for. View
Dashlet that seems to use those variable still works correctly in my
opinion.
Linked views dashlet take the linked view filter configuration at the
highest priority of context when merged.
Fix bug, problem dashboard is a graph and has infos=host&service like
all graphs. It is a very fixed combined graph dashboard, should it merge
filter from the page menu? Currently it doesn't.
Change-Id: I49717bfd365abde74138ee582b8598f89b78bad7
Commit: 12efe354ec41e327f8d26d8256019ab75aca89c6
https://github.com/tribe29/checkmk/commit/12efe354ec41e327f8d26d8256019ab75…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/dashboard.py
M cmk/gui/mobile.py
M cmk/gui/plugins/dashboard/graph.py
M cmk/gui/plugins/dashboard/utils.py
M cmk/gui/plugins/visuals/utils.py
M cmk/gui/type_defs.py
M cmk/gui/views.py
M cmk/gui/visuals.py
M tests/unit/cmk/gui/plugins/views/test_row_table.py
M tests/unit/cmk/gui/plugins/visuals/test_visuals_utils.py
M tests/unit/cmk/gui/test_visuals.py
Log Message:
-----------
Simplify VisualContext type, remove single_info
The new design for filters uses only the full filter variables, which is
the multi_info dict.
Dashboard: performance graphs correctly get context info
Errors on missing info must be handled by the same _render_dashlet
function, which raises the warning on missing context instead of
_render_dashlet_content which raises the error after livestatus failure.
Custom graphs don't rely on the standard graph infos: host & service,
because they don't filter on context. The dashlet crashed because
VisualFilters queries all filters on the infos, thus it still needs to
match the default host & service infos.
Reports: Still use get_context_from_uri_var
Unlike views, reports can have a larger context than a view matching
several datasources. In this case when importing from a view it makes
little sense to use the filter menu valuespec, because datasource info
gets lost. Just assume that the url filters are the direct recent
filters. They still hold the least priority, as report context wins in
precedence. Finally, default view filters don't get transferred to
report, that was always the case with "Export: this view as pdf".
Change-Id: I27b7b9788838abd4ef5147736974982defcbccaa
Commit: 198e071ad850770ac6af00a76f6dc0bf3c2798c4
https://github.com/tribe29/checkmk/commit/198e071ad850770ac6af00a76f6dc0bf3…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/bi.py
M cmk/gui/plugins/views/bi.py
M cmk/gui/plugins/visuals/filters.py
Log Message:
-----------
Update BI filters to new filter scheme
Methods from BI filters like selected_group & service_spec where moved
out to their relevant use place in compute_bi_aggregation_filter,
because then the conform to the basic methods of Filter, that are
required on the function signature by mypy.
Change-Id: I4c4a43b787d85b372de4ae5439ad93ecd8b64bfc
Commit: 24770402e374536415aa31ccce8a2a7f08bf5df8
https://github.com/tribe29/checkmk/commit/24770402e374536415aa31ccce8a2a7f0…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M cmk/gui/plugins/views/utils.py
M cmk/gui/views.py
Log Message:
-----------
FIX linked_views_url_to have active filters
fixed linked urls and multi context report export
This is a bad solution, too much code repetition to pass active filters.
It should maybe be part of the makeuri.
The translation of filters also shows how weak the single_info is on the
url_vars. There is a difference on the filter ident and the
filter_html_var. Both need to be translated. There is also a KeyError
exception, which I believe under the correct translations should not be
required. It should not be possible from out side to create linked views
that would still be missing some context.
Change-Id: I1d475b87cdcbd4aae33a4a43e65d6b2bdfa9fb18
Commit: 4616c643bfd0b16dfbe3c7732943f82aea7c762a
https://github.com/tribe29/checkmk/commit/4616c643bfd0b16dfbe3c7732943f82ae…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M agents/check_mk_agent.aix
M agents/check_mk_agent.freebsd
M agents/check_mk_agent.linux
M agents/check_mk_agent.openwrt
M agents/check_mk_agent.solaris
Log Message:
-----------
check_mk_agents: bundle sections
Change-Id: I6c17b9abe96c75040858419b74769df0f9eb61f3
Compare: https://github.com/tribe29/checkmk/compare/450099989f99...4616c643bfd0
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 5bffda7893c5496ed003b6fcfdcec9ce32ad6770
https://github.com/tribe29/checkmk/commit/5bffda7893c5496ed003b6fcfdcec9ce3…
Author: Ulrich Bschorer <ulrich.bschorer(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
A .werks/12820
M agents/plugins/mk_postgres.py
Log Message:
-----------
12820 FIX mk_postgres: fixed user detection: use default user "postgres" in case of error
This werk fixes the user detection for postgresql docker images.
If the user could no be determined the fallback user "postgres" is used.
Change-Id: Ie55e97914c3ccca5b17ea9f248d2e48db7db6a12
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: aac8db26376fea30594d1ab850dd05e5e0dffc86
https://github.com/tribe29/checkmk/commit/aac8db26376fea30594d1ab850dd05e5e…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M agents/plugins/smart
Log Message:
-----------
smart: revert shebang to bash
Unfortunately, the plugin is still full of bashisms.
Change-Id: I07c5ca10f7be40994d036ccc3be16da56d24d67f
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: cc3f8c6d3c2cb71e54908f1e39e5aa9e0f7c6601
https://github.com/tribe29/checkmk/commit/cc3f8c6d3c2cb71e54908f1e39e5aa9e0…
Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
M agents/wnx/watest/test-log.cpp
Log Message:
-----------
Fix test of logging message
Change-Id: I990f56e9e7609f98f40932564f6a9d83219fa0c6
Commit: 040ba92e6710a2ad2724331f97f5d62832b1563b
https://github.com/tribe29/checkmk/commit/040ba92e6710a2ad2724331f97f5d6283…
Author: Andreas Boesl <andreas.boesl(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
A .werks/12662
M cmk/gui/bi.py
Log Message:
-----------
WK12662: Fixed BI tree layouts
Change-Id: I6131a65adb0572cad5117fd32187d5738434ba40
Commit: b7f94b84f316e0124309e775c02409ff36790967
https://github.com/tribe29/checkmk/commit/b7f94b84f316e0124309e775c02409ff3…
Author: Andreas Boesl <andreas.boesl(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
A .werks/12661
M checks/agent_bi
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/plugins/wato/datasource_programs.py
M tests/unit/cmk/gui/plugins/wato/test_datasource_programs.py
Log Message:
-----------
12661 FIX BI aggregation datasource program: Fixed "By aggregation name" filter
This filter did not work at all. Also updated the documentation that this filter only supports exact aggregation name matches
Change-Id: I774a5d86e0a85c737bf3c19f5ea06db56bedc962
Compare: https://github.com/tribe29/checkmk/compare/c824fa9719ba...b7f94b84f316
Branch: refs/heads/2.0.0
Home: https://github.com/tribe29/checkmk
Commit: 9087a2e77f4303acf8851978abe6701165568c34
https://github.com/tribe29/checkmk/commit/9087a2e77f4303acf8851978abe670116…
Author: Andreas Boesl <andreas.boesl(a)tribe29.com>
Date: 2021-07-22 (Thu, 22 Jul 2021)
Changed paths:
A .werks/12661
M checks/agent_bi
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/plugins/wato/datasource_programs.py
M tests/unit/cmk/gui/plugins/wato/test_datasource_programs.py
Log Message:
-----------
12661 FIX BI aggregation datasource program: Fixed "By aggregation name" filter
This filter did not work at all. Also updated the documentation that this filter only supports exact aggregation name matches
Change-Id: I774a5d86e0a85c737bf3c19f5ea06db56bedc962