Checkmk git commits May 2021

checkmk-commits@lists.checkmk.com

1 participants
482 discussions

[tribe29/checkmk] fefe95: Fix agent plugin unit tests for python 3.4

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: fefe9508bf41ba6afa958a450efed2cade2f57f6 https://github.com/tribe29/checkmk/commit/fefe9508bf41ba6afa958a450efed2cad… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M tests/agent-plugin-unit/Dockerfile Log Message: ----------- Fix agent plugin unit tests for python 3.4 Change-Id: Ib22aeb9a69991a53bdf6cf074e95fa10686e8a79

3 years, 2 months

[tribe29/checkmk] 035a77: [Draft] Bring back agent backery colored update bu...

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 035a77b9a8a4ee902ddba84426261b557cec668a https://github.com/tribe29/checkmk/commit/035a77b9a8a4ee902ddba84426261b557… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M web/htdocs/themes/facelift/scss/_main.scss Log Message: ----------- [Draft] Bring back agent backery colored update button Page menus do support css styling on the div tag. Yet the link inside has strict CSS and overrides. The important flag is placed to win again. That is a bad practice, yet is the same strategy used on: td.count.state a for the view tables. We need a better strategy on styling. Change-Id: I0fc27d1ab968b2de30d15f047bdbf1a15d4451e9 Commit: 52f01f5c8b38a77d1e715d8dd7b0a569597f4339 https://github.com/tribe29/checkmk/commit/52f01f5c8b38a77d1e715d8dd7b0a5695… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M checks/cmciii M tests/unit/checks/test_cmciii_helper.py Log Message: ----------- cmciii: fix wrong keys for phase sensors introduced in dee8f8c43bc2 Change-Id: Ife7f776741debdb02eea80d2e213ad32e4345ce3 Commit: 372f4d810ba7f9046019e0477b3384c5f7edfdba https://github.com/tribe29/checkmk/commit/372f4d810ba7f9046019e0477b3384c5f… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: A .werks/12760 M checks/cmciii M tests/unit/cmk/base/plugins/agent_based/test_cmciii.py Log Message: ----------- 12760 FIX cmciii_temp_in_out: fix crash of plugin Change-Id: Ia767adf7ebdad0b5a42798a805467be7b67bb52a Commit: b23698b07c6541cf4dff4dbee97db2db9052ec99 https://github.com/tribe29/checkmk/commit/b23698b07c6541cf4dff4dbee97db2db9… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M checks/cmciii Log Message: ----------- cmciii: introduce a separate function to split temp_in_out sensors Furthermore, additional keys are not discarded anymore. This will make it possible to make the item configurable later on. Change-Id: I4c4b2907483b7dca5de61a0317db5b64de53b58a Commit: b0df8b1d54c3c881978780d7caffa9ab4e97c0b4 https://github.com/tribe29/checkmk/commit/b0df8b1d54c3c881978780d7caffa9ab4… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M checks/cmciii Log Message: ----------- cmciii: remove last occurences of the word "table" Change-Id: I0dde0fcf9c15051fca861382c30b8510295e34c1 Commit: 5111ba0a72eb7302c4d655057d2f519be03e9243 https://github.com/tribe29/checkmk/commit/5111ba0a72eb7302c4d655057d2f519be… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M tests/unit/checks/test_cmciii_helper.py M tests/unit/cmk/base/plugins/agent_based/test_cmciii.py Log Message: ----------- cmciii: add tests for sensor_item and phase sensors Rename two test functions on the way. Change-Id: Iefd4d41bc1a2d78e4ef60cf9b04afaf07bd9e554 Commit: 19eedfc208c8e6318637e1573bfefabdba5ce87f https://github.com/tribe29/checkmk/commit/19eedfc208c8e6318637e1573bfefabdb… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M checks/cmciii M tests/unit/checks/test_cmciii_helper.py Log Message: ----------- cmciii: Remove special variable treatment for phase sensors Change-Id: I2b37de10fb537dabca6808c50d660560aad603a6 Commit: c6a2474937f7e0ae0091a7928d9b9242b9717034 https://github.com/tribe29/checkmk/commit/c6a2474937f7e0ae0091a7928d9b9242b… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M checks/cmciii M tests/unit/checks/test_generic_legacy_conversion.py Log Message: ----------- cmciii_sensor: remove subcheck that was deprecated in 2017 Change-Id: Iec2b64f8b84f2856bf57e0fed973453672ab70dc Commit: ecc801850f0cd353b4996c6562e6ce7fa05cd48a https://github.com/tribe29/checkmk/commit/ecc801850f0cd353b4996c6562e6ce7fa… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M checks/cmciii Log Message: ----------- cmciii: unify retrieval of data Change-Id: I9656c1a3b74e0a9d63ceba8c7e3a9c1622686631 Compare: https://github.com/tribe29/checkmk/compare/151313c6c3ae...ecc801850f0c

3 years, 2 months

[tribe29/checkmk] 151313: renaming all refrences to the user guide

by Marcel Arentz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 151313c6c3aecf6adab6b4aca89c4eec391df10d https://github.com/tribe29/checkmk/commit/151313c6c3aecf6adab6b4aca89c4eec3… Author: Marcel Arentz <marcel.arentz(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M CONTRIBUTING.md M README.md M agents/plugins/mk_oracle M cmk/gui/htmllib.py M cmk/gui/main_menu.py M cmk/gui/page_menu.py M cmk/gui/plugins/openapi/livestatus_helpers/commands/__init__.py M cmk/gui/plugins/openapi/livestatus_helpers/commands/lowlevel.py M cmk/gui/plugins/openapi/livestatus_helpers/testing.py M cmk/gui/plugins/openapi/restful_objects/request_schemas.py M cmk/gui/plugins/openapi/restful_objects/specification.py M cmk/gui/plugins/sidebar/about.py M cmk/gui/plugins/wato/active_checks.py M cmk/gui/plugins/wato/builtin_modules.py M cmk/gui/valuespec.py M cmk/gui/watolib/rulespecs.py M doc/plugin-api/source/index.rst M doc/treasures/kubernetes/readme.md M notifications/README M tests/unit/cmk/gui/test_htmllib_html_cls.py Log Message: ----------- renaming all refrences to the user guide renamed the links to the current domain. Also worked on the references. All external refs to the docs will be marked as 'docs'. All references to itself on docs.checkmk.com will be marked as 'user guide'. Change-Id: I54666c9f0b90c0b4fc649d3f26de027f5ef0d854

3 years, 2 months

[tribe29/checkmk] 5fedb5: Fix type because html.get_request is Dict[str, Any]

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5fedb5cc7ecc0f634d0fb75e6dcdfdd563833c88 https://github.com/tribe29/checkmk/commit/5fedb5cc7ecc0f634d0fb75e6dcdfdd56… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M cmk/gui/pages.py Log Message: ----------- Fix type because html.get_request is Dict[str, Any] Change-Id: I5917925c535661fe5053f6e4552debdbf031b9a4 Commit: d472f829d13af366c063c2e20660a3a9bfb0bd97 https://github.com/tribe29/checkmk/commit/d472f829d13af366c063c2e20660a3a9b… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M web/htdocs/js/modules/valuespecs.js M web/htdocs/themes/facelift/scss/_main.scss Log Message: ----------- Remove text autocomplete CMK-6935 Change-Id: Iac56dc31d39e17c934c625bbd4adaca59180b94d Commit: 2f28b824a7f2b7adda2abe3b9ea200ee5b3c3d4f https://github.com/tribe29/checkmk/commit/2f28b824a7f2b7adda2abe3b9ea200ee5… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M cmk/gui/htmllib.py M cmk/gui/plugins/dashboard/graph.py M cmk/gui/plugins/metrics/utils.py M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/valuespec.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/sites.py M cmk/gui/watolib/__init__.py M web/htdocs/js/modules/forms.js M web/htdocs/js/modules/valuespecs.js Log Message: ----------- Change text autocompletions by select2dropdowns Text autocompletion was originally designed only for monitored hostnames and configured hostnames. The text field allowed users to enter any value and also to edit configured values. Additionally pasting a string with particular characters(independent of autocomplete), would split it in the case of listofstring valuespec and create new fields. The text autocomplete suffered from some bugs and limitations: - Options availability bug. Sometimes the request would block and no new options would be fetched. Sometimes the workaround of clearing the field, changing focus and returning would restart the query. Sometimes worse in the case of configured hostnames, it was necessary to exit the page. - When request were not blocked, a request fired every onkeyup and when request came back it overwrote the user input. This commit exchanges the adhoc select2 dialog that floats on top of the html.input with a clean drop-down, managed entirely by select2 which directly ajax calls to request data. This allows for separated concerns, the python valuespec does not need to inject JS to place hooks to query the webapi. This fixes the following - The data availability bug, changing input starts a new query. Thus results are always found - Requests are triggered 250ms after User stops typing. This saves on requests. - Select2 cancels previous request as soon as the user changes input and only updates contents from the response of last request. This solves the bug of previous request updating results and confusing user. Old autocomplete valuespecs now inherit thus from dropdownchoice rather than text ascii. - Monitored Hostname. Now has regex input validation. User custom input is permitted - Configured Hostname. Now has regex input validation. User custom input is permitted - Monitored Service. Now has regex input validation. User custom input is permitted - Metric name. Now has input validation, metric name is strictly bound to known metrics - Hostname and service filters. Render directly the dropdowns as filters don't yet use the valuespecs. - Configured Hostname, can be embedded in listofstrings. List of strings is extended to expand on text input and text paste when the underlying datatype is a dropdown. It works as before. CMK-6935 Change-Id: I7c0dac8f4ee6deeaba7d614804500b7e98c1b95d Commit: 8c3efe7991a4dcaaac1a44f8269c5f55ff3cff18 https://github.com/tribe29/checkmk/commit/8c3efe7991a4dcaaac1a44f8269c5f55f… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/infos.py M cmk/gui/valuespec.py M tests/unit/cmk/gui/test_pages.py M web/htdocs/js/modules/valuespecs.js M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Customgraphs editor use only select2 In order to use the modern autocomplete dropdowns for input in host, service, and metric the old valuespec is completely removed. Functionality is good enough - There is no automatic refresh on any form action. This is even a feature request: SUP-2485, SUP-5399, SUP-5949 - Added an apply button to save changes - No need for metric & scalar selector ajax pages. The autocompleter covers all - Because no form & page refresh, can drop the JS part that did that, and caused some bugfixing headaches when styles were changes. All dropdowns use id instead of name like text_input In the single info cases and custom graphs editor, where only a specific hostname, service, and metric make sense enforce that constrain instead of allowing user to write anything. Filters have direct html render, enforce the exact match op=="=" for only what is autocompleted. Change-Id: I685fc48418ae3f743068cbdbd27f2ea3839f5c5c Commit: edf6e50e7a1d28cb11ea374bdd78a9bd54b971c9 https://github.com/tribe29/checkmk/commit/edf6e50e7a1d28cb11ea374bdd78a9bd5… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M cmk/gui/valuespec.py M web/htdocs/js/modules/valuespecs.js Log Message: ----------- Autocompleter options mention incomplete results first This announces user that the list could be incomplete. User can't select as option, it is a warning only not an option Change-Id: If87bc39c91fbbcdf03b428cb023fa051193cbb7d Compare: https://github.com/tribe29/checkmk/compare/fe19ad472c18...edf6e50e7a1d

3 years, 2 months

[tribe29/checkmk] fe19ad: 12322 FIX Standalone Windows exe files are no more...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: fe19ad472c1895378b2ad67761c142b5b345cb6a https://github.com/tribe29/checkmk/commit/fe19ad472c1895378b2ad67761c142b5b… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: A .werks/12322 Log Message: ----------- 12322 FIX Standalone Windows exe files are no more included in distro to avoid false positives from antiviruses In the past we delivered in the shipped package few Windows exe files, which were either intended to be installed on their own or should serve as an example. However some antivirus programs produced false positives for these files. Because in this version the agent installation can only be carried out using the MSI and the example is no more relevant, all exe files have been removed from the shipped package thus fixing the problem with antivirus software. Change-Id: Iec95a54451c2b7b8a065b269360c77570a01f332

3 years, 2 months

[tribe29/checkmk] 9c9202: prediction: move saving code

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9c92024b88bc71c0a5e71028a5127065da487727 https://github.com/tribe29/checkmk/commit/9c92024b88bc71c0a5e71028a5127065d… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M cmk/base/prediction.py M cmk/utils/prediction.py Log Message: ----------- prediction: move saving code As long as we don't read/write in the same module, we'll never fix the typing. Change-Id: I078008f5eae3ff7ab264e51de6e4dc9614c751e9 Commit: 43377427f9195f259b75b59be4541a2f90c17491 https://github.com/tribe29/checkmk/commit/43377427f9195f259b75b59be4541a2f9… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M cmk/base/prediction.py M cmk/gui/prediction.py M cmk/utils/prediction.py Log Message: ----------- prediction: make the loading madness explicit Change-Id: Ia6c79f932f3a20d34b0c7255b1dd79e1aba2d60a Commit: a6d1b665617e118fddbca80bbec37e57fa2929e5 https://github.com/tribe29/checkmk/commit/a6d1b665617e118fddbca80bbec37e57f… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M cmk/base/prediction.py M cmk/gui/prediction.py M cmk/utils/prediction.py M tests/integration/cmk/base/test_services_prediction.py Log Message: ----------- prediction: improve some types Change-Id: I5f4b02572c00bc648ca2b9be17768c4aa68791ac Compare: https://github.com/tribe29/checkmk/compare/10d35fff8e46...a6d1b665617e

3 years, 2 months

[tribe29/checkmk] 934a59: agent_activemq: factor out parse function from main

by Lorenz König

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 934a599243c25f5d7ec904e130f594dc6d03e6c1 https://github.com/tribe29/checkmk/commit/934a599243c25f5d7ec904e130f594dc6… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M agents/special/agent_activemq M cmk/special_agents/agent_activemq.py A tests/unit/cmk/special_agents/test_agent_activemq_.py Log Message: ----------- agent_activemq: factor out parse function from main Change-Id: Ibf63abc6f31f14003536eb638a42b9a8e67c6032 Commit: 10d35fff8e469a54f1c6aacfb694baf7214bf91d https://github.com/tribe29/checkmk/commit/10d35fff8e469a54f1c6aacfb694baf72… Author: Lorenz Koenig <lorenz(a)koenigs-net.de> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: A .werks/12734 M cmk/special_agents/agent_activemq.py M tests/unit/cmk/special_agents/test_agent_activemq_.py Log Message: ----------- 12734 FIX Apache ActiveMQ queues special agent: Parse protocol argument When configuring the special agent for monitoring Apache ActiveMQ queues, users select the protocol to be used (HTTP/HTTPS). However, the special agent did not parse this argument correctly, leading to a crash. This has been fixed. Closes #368 Change-Id: Id6c20bd1be8e094b0f000746564ce0698ce8f729 Compare: https://github.com/tribe29/checkmk/compare/12dd7867dfed...10d35fff8e46

3 years, 2 months

[tribe29/checkmk] aa764d: agent_activemq: factor out parse function from main

by Lorenz König

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: aa764d6763318020caa5a93847701b936aa547ee https://github.com/tribe29/checkmk/commit/aa764d6763318020caa5a93847701b936… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M agents/special/agent_activemq M cmk/special_agents/agent_activemq.py A tests/unit/cmk/special_agents/test_agent_activemq_.py Log Message: ----------- agent_activemq: factor out parse function from main Change-Id: Ibf63abc6f31f14003536eb638a42b9a8e67c6032 Commit: 7999345710adaf8f96c07e381a6fcf46373f8c93 https://github.com/tribe29/checkmk/commit/7999345710adaf8f96c07e381a6fcf463… Author: Lorenz Koenig <lorenz(a)koenigs-net.de> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: A .werks/12734 M cmk/special_agents/agent_activemq.py M tests/unit/cmk/special_agents/test_agent_activemq_.py Log Message: ----------- 12734 FIX Apache ActiveMQ queues special agent: Parse protocol argument When configuring the special agent for monitoring Apache ActiveMQ queues, users select the protocol to be used (HTTP/HTTPS). However, the special agent did not parse this argument correctly, leading to a crash. This has been fixed. Closes #368 Change-Id: Id6c20bd1be8e094b0f000746564ce0698ce8f729 Compare: https://github.com/tribe29/checkmk/compare/f7ca5d6d23aa...7999345710ad

3 years, 2 months

[tribe29/checkmk] 12dd78: `set_cache_opts` -> classmethod

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 12dd7867dfededa60f1b9a98bbe476ce4c47600c https://github.com/tribe29/checkmk/commit/12dd7867dfededa60f1b9a98bbe476ce4… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: M cmk/base/modes/check_mk.py M cmk/core_helpers/cache.py Log Message: ----------- `set_cache_opts` -> classmethod * Remove the argument: only `True` would have an effect. Passing `False` is noop. Therefore, the argument is unnecessary and, actually, but a confusing lie, * Move the function to the class: The function would set two attributes of the class. Scoping it reduces feature envy and could, in the end, make it easier to remove the globals. Change-Id: I215b57a3949d59cb50f9cfca1b3433a1dd36e703

3 years, 2 months

[tribe29/checkmk] 88500f: CMK-7859: remove old windows agent files

by Sergey Kipnis

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 88500f1b599b9183ec2e1209b6ca7133b9b05e44 https://github.com/tribe29/checkmk/commit/88500f1b599b9183ec2e1209b6ca7133b… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-05-06 (Thu, 06 May 2021) Changed paths: R doc/treasures/windows_msi/README R doc/treasures/windows_msi/build_msi.bat R doc/treasures/windows_msi/check_mk_agent.wixobj R doc/treasures/windows_msi/check_mk_agent.wixpdb R doc/treasures/windows_msi/check_mk_agent_baked.wxs R doc/treasures/windows_msi/check_mk_agent_vanilla.wxs R doc/treasures/windows_msi/cmk_InstallDirDlg.wixobj R doc/treasures/windows_msi/cmk_InstallDirDlg.wxs R doc/treasures/windows_msi/cmk_WixUI_InstallDir.wixobj R doc/treasures/windows_msi/cmk_WixUI_InstallDir.wxs R doc/treasures/windows_msi/sources/GPL-V2.rtf R doc/treasures/windows_msi/sources/check_mk.example.ini R doc/treasures/windows_msi/sources/check_mk.ini R doc/treasures/windows_msi/sources/check_mk_agent-64.exe R doc/treasures/windows_msi/sources/check_mk_agent.exe R doc/treasures/windows_msi/sources/gpl_v2.rtf R doc/treasures/windows_msi/sources/plugins.cmkp Log Message: ----------- CMK-7859: remove old windows agent files Change-Id: I47b7688d6bf3df53007e66418c4efaeb669cfb23

3 years, 2 months

← Newer
1
...
36
37
38
39
40
41
42
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits May 2021