Checkmk git commits April 2021

checkmk-commits@lists.checkmk.com

1 participants
553 discussions

[tribe29/checkmk] 926c50: 11800 FIX Avoid escaping in custom host attributes

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 926c5032e15fe7c6bdb517b15080841ca49db3a6 https://github.com/tribe29/checkmk/commit/926c5032e15fe7c6bdb517b15080841ca… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: A .werks/11800 M cmk/gui/watolib/host_attributes.py Log Message: ----------- 11800 FIX Avoid escaping in custom host attributes In case custom host attributes where containing special characters (e.g. "&"), they where stored escaped on disk and therfore also displayed escaped in the GUI. This fix is applied during <tt>omd update</tt>, so no manual interaction is needed when updating to this patchlevel. Change-Id: If46896a8a2b1972e9e8f2bd85230eb34249729e6

3 years, 5 months

[tribe29/checkmk] a5bbf1: 11800 FIX Avoid escaping in custom host attributes

by Timotheus Bachinger

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: a5bbf14391560ffd72c592de0a3191684446fc85 https://github.com/tribe29/checkmk/commit/a5bbf14391560ffd72c592de0a3191684… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: A .werks/11800 M cmk/gui/watolib/host_attributes.py Log Message: ----------- 11800 FIX Avoid escaping in custom host attributes In case custom host attributes where containing special characters (e.g. "&"), they where stored escaped on disk and therfore also displayed escaped in the GUI. This fix is applied during <tt>omd update</tt>, so no manual interaction is needed when updating to this patchlevel. Change-Id: If46896a8a2b1972e9e8f2bd85230eb34249729e6

3 years, 5 months

[tribe29/checkmk] 8fd7ec: Add test to verify registered painters in differen...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8fd7ec4595c409237a8240a22f98379707515a5b https://github.com/tribe29/checkmk/commit/8fd7ec4595c409237a8240a22f9837970… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: A tests/unit/cmk/gui/plugins/views/test_painters.py Log Message: ----------- Add test to verify registered painters in different editions Change-Id: I66ac00bd5114b4e2bb1d224b76318e35d19f41dc Commit: e97e8493595fc5ec41886cc128fb8dec659ca6a6 https://github.com/tribe29/checkmk/commit/e97e8493595fc5ec41886cc128fb8dec6… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M tests/unit/cmk/gui/test_views.py Log Message: ----------- Remove long disabled development test that tested painter properties Change-Id: I8c58a3d507cbf91e33c04b86eea301f4ec8a5f9b Commit: 7201b295224db5cfece491403084b6f55e245188 https://github.com/tribe29/checkmk/commit/7201b295224db5cfece491403084b6f55… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M tests/unit/cmk/gui/plugins/views/test_painters.py Log Message: ----------- Service painters: Add test to verify content The tests don't verify the actual painter content but only whether or not they produce a valid content and don't raise exceptions. After changing the painter escaping mechanic we can use these tests to verify that no painter returns HTML code that will be escaped later. Change-Id: Icac3fccbc5b11bf243e9493371bfb0b657eee58f Commit: f93d836ffb0fe6e6817f5c58d29223ffe9f927ba https://github.com/tribe29/checkmk/commit/f93d836ffb0fe6e6817f5c58d29223ffe… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M cmk/gui/plugins/views/mobile.py M cmk/gui/plugins/views/utils.py Log Message: ----------- Tighten painter content escaping In previous Checkmk versions the content returned by a painters render method was always processed as HTML code, even when only a str object was returned. This unclean handling of the returned data resulted in possible injection or XSS attacks. This change requires multiple painters to be changed in the next steps. Since the str objects are now escaped, the painter render() methods that want to render HTML code need to return HTML() objects instead of str objects. Change-Id: I767c643501165dbe38a04cf28f677f92ec30736c Commit: 1d272f9fcfd960d541cf66f7c5852d5b2a4f50e3 https://github.com/tribe29/checkmk/commit/1d272f9fcfd960d541cf66f7c5852d5b2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M cmk/gui/metrics.py M cmk/gui/plugins/views/painters.py Log Message: ----------- Move dedicated helper function to painter Change-Id: Iff3899342ac61a60482f50369095a653cde82474 Commit: 19c9a24bd1595211fed350f71b94c3110cacddcb https://github.com/tribe29/checkmk/commit/19c9a24bd1595211fed350f71b94c3110… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/views/painters.py M cmk/gui/plugins/views/utils.py M cmk/gui/view_utils.py Log Message: ----------- Fix content escaping of some painters Change-Id: I24aa8431970a9093ec52b18207175845c1e9ac97 Commit: c10fff1d959fae85d7804d4cb6b9b184f59cfbbf https://github.com/tribe29/checkmk/commit/c10fff1d959fae85d7804d4cb6b9b184f… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M tests/unit/cmk/gui/plugins/views/test_painters.py Log Message: ----------- Painters: Verify HTML escaping Change-Id: I3805ef16b4e8954e535808db13a9ffbb7b683dea Commit: 953a3804376b1f8c16539f65699424ceef011588 https://github.com/tribe29/checkmk/commit/953a3804376b1f8c16539f65699424cee… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M cmk/gui/plugins/views/inventory.py Log Message: ----------- Add some type hints to inventory painters Change-Id: I612c0f8dbaa4015dbf404e46594748a256709909 Commit: 68e71df884776bb0f237c311f7955fd2df63ebc4 https://github.com/tribe29/checkmk/commit/68e71df884776bb0f237c311f7955fd2d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M cmk/gui/bi.py M cmk/gui/plugins/views/__init__.py M cmk/gui/plugins/views/bi.py Log Message: ----------- BI painters: Fix content escaping; spread some type hints Change-Id: Idfb40ba89ec94b136b6892224a600bae674bf621 Commit: 18e4cd1400d36721941b298b033f5e352e48d795 https://github.com/tribe29/checkmk/commit/18e4cd1400d36721941b298b033f5e352… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M cmk/gui/plugins/views/crash_reporting.py M cmk/gui/plugins/views/mkeventd.py M cmk/gui/plugins/views/painters.py Log Message: ----------- Remove now redundant escaping Since the generic view painter rendering is now performing escaping on non HTML content, the explicit escaping in the painters is not needed anymore. Change-Id: Ifa2777a389817187b832354ddd91cc194b0a83f0 Compare: https://github.com/tribe29/checkmk/compare/ce24c8308169...18e4cd1400d3

3 years, 5 months

[tribe29/checkmk] dff0a7: 12314 FIX checks: Fix "MS Exchange Information Sto...

by rb

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: dff0a764b1e9e2541bd66ec222cb66ffeb210859 https://github.com/tribe29/checkmk/commit/dff0a764b1e9e2541bd66ec222cb66ffe… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: A .werks/12314 M checks/msexch_isclienttype M checks/msexch_isstore M cmk/base/check_legacy_includes/wmi.py M tests/unit/checks/test_wmi_check.py Log Message: ----------- 12314 FIX checks: Fix "MS Exchange Information Store" rule crash The checks msexch_isclienttype and msexch_isstore crashed with "AttributeError: 'tuple' object has no attribute 'get'" if the rule "MS Exchange Information Store" existed. This should now be fixed. Change-Id: I1cef7e5d6d2c63df173217d7c85e67924caa78f4 Commit: e52069e85d669c4bf0f434e0de85eb3552cdd4a0 https://github.com/tribe29/checkmk/commit/e52069e85d669c4bf0f434e0de85eb355… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: A .werks/12625 M cmk/gui/userdb.py Log Message: ----------- 12625 FIX Fix invalidation of session on logout CMK-7639 Change-Id: I0c3d7a37621636224e75c6e388940200b37ad961 Compare: https://github.com/tribe29/checkmk/compare/a6e7df0abd41...e52069e85d66

3 years, 5 months

[tribe29/checkmk] 71e34b: Fix werk text

by Timotheus Bachinger

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 71e34b337fffd636348f73ef97caa38f1a22c8a4 https://github.com/tribe29/checkmk/commit/71e34b337fffd636348f73ef97caa38f1… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M .werks/11800 Log Message: ----------- Fix werk text Change-Id: Id3ec4688f12f76e412de4e276260a2632a9da200

3 years, 5 months

[tribe29/checkmk] a6e7df: Enable exception logging in bin/fetcher

by Sergey Kipnis

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: a6e7df0abd4107b60f968c8e49ca2e8bcf1a2314 https://github.com/tribe29/checkmk/commit/a6e7df0abd4107b60f968c8e49ca2e8bc… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M cmk/fetchers/controller.py M cmk/utils/observer.py M tests/scripts/misc/fetcher_ram_usage_test Log Message: ----------- Enable exception logging in bin/fetcher - redesign architecture moving the exception management into the controller.process_command - relocate most logic from bin/fetcher to controller and change corresponding API - rework some tests to accept new API - add unit testing - add logging for the FetcherMemoryObserver as an proofing feature - fix testing script CL was validated manually too. Change-Id: I78777d583743d18a8d8afaa1fa9e5ecc157cbb23

3 years, 5 months

[tribe29/checkmk] ce24c8: make get/set item state key prefix symmetric

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ce24c8308169ec43d122a018eaf839af780295d9 https://github.com/tribe29/checkmk/commit/ce24c8308169ec43d122a018eaf839af7… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M cmk/base/agent_based/checking/_legacy_mode.py M cmk/base/api/agent_based/value_store.py M cmk/base/item_state.py Log Message: ----------- make get/set item state key prefix symmetric Change-Id: I21ffedc4c8b2536826e8cac882698275466a7e5c

3 years, 5 months

[tribe29/checkmk] 7fc50e: 11800 FIX Avoid escaping in custom host attributes

by Timotheus Bachinger

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 7fc50e104375202c7ffd6f6645eeba721c2e604f https://github.com/tribe29/checkmk/commit/7fc50e104375202c7ffd6f6645eeba721… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: A .werks/11800 M cmk/gui/watolib/host_attributes.py Log Message: ----------- 11800 FIX Avoid escaping in custom host attributes In case custom host attributes where containing special characters (e.g. "&" or "<" etc.), they where stored escaped on disk and therfore also displayed escaped in the GUI. This fix is applied during <tt>omd update</tt>, so no manual interaction is needed when updating to this patchlevel. Change-Id: If46896a8a2b1972e9e8f2bd85230eb34249729e6

3 years, 5 months

[tribe29/checkmk] e99521: Refactoring: Improve internal logging API for obse...

by Sergey Kipnis

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: e99521fa99c0e521ac091c2e7137a2152f82ac55 https://github.com/tribe29/checkmk/commit/e99521fa99c0e521ac091c2e7137a2152… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: M cmk/utils/observer.py M tests/unit/cmk/utils/test_observer.py Log Message: ----------- Refactoring: Improve internal logging API for observers According to comment in previous review the fixed hostname had been replaced with more flexible hint, which may be interpreted in different way by corresponding objects when logging. Change-Id: Iebcbb940db1aef90a368085d9be589fd8a7522cb

3 years, 5 months

[tribe29/checkmk] 60f4de: 12625 FIX Fix invalidation of session on logout

by rb

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 60f4de8d695fd5e63a91dcbf20e8da29f9d51397 https://github.com/tribe29/checkmk/commit/60f4de8d695fd5e63a91dcbf20e8da29f… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2021-04-12 (Mon, 12 Apr 2021) Changed paths: A .werks/12625 M cmk/gui/userdb.py Log Message: ----------- 12625 FIX Fix invalidation of session on logout CMK-7639 Change-Id: I0c3d7a37621636224e75c6e388940200b37ad961

3 years, 5 months

← Newer
1
...
40
41
42
43
44
45
46
...
56
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits April 2021