Checkmk git commits April 2021

checkmk-commits@lists.checkmk.com

1 participants
553 discussions

[tribe29/checkmk] e66849: 12094 FIX 'local' check: raised ValueError (No esc...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e6684991a3f88862d722c19aa3191bfae3dbff07 https://github.com/tribe29/checkmk/commit/e6684991a3f88862d722c19aa3191bfae… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12094 M cmk/base/plugins/agent_based/local.py M tests/unit/cmk/base/plugins/agent_based/test_local.py Log Message: ----------- 12094 FIX 'local' check: raised ValueError (No escaped character) or (No closing quotation) Change-Id: I438738cb1b6acd40de318482ec92673c73d05c4d Commit: 3fa48940c783aeb55b1cc86b63df039e38a1c3f6 https://github.com/tribe29/checkmk/commit/3fa48940c783aeb55b1cc86b63df039e3… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M cmk/special_agents/agent_proxmox_ve.py A tests/unit/cmk/special_agents/proxmox_ve-files/proxmox_ve-backup-2020-12-30.log A tests/unit/cmk/special_agents/proxmox_ve-files/proxmox_ve-backup-2021-01-17.log A tests/unit/cmk/special_agents/proxmox_ve-files/proxmox_ve-backup-2021-02-11.log A tests/unit/cmk/special_agents/proxmox_ve-files/proxmox_ve-backup-2021-04-11.log A tests/unit/cmk/special_agents/proxmox_ve-files/proxmox_ve-backup-2021-04-15.log A tests/unit/cmk/special_agents/test_agent_proxmox_ve.py Log Message: ----------- agent_proxmox_ve: improve testability, add typing, add tests Change-Id: I2973d3de61c1d222a5a68fa04868980e428eb7fe Commit: bf530f55a71752967e22f1d77e1983f914050cd0 https://github.com/tribe29/checkmk/commit/bf530f55a71752967e22f1d77e1983f91… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A tests/unit/cmk/special_agents/proxmox_ve-files/proxmox_ve-backup-2021-04-10.log M tests/unit/cmk/special_agents/test_agent_proxmox_ve.py Log Message: ----------- agent_proxmox_ve: add test with log of erroneous backup Change-Id: Ib6a4dfdefcbd1a9210ef61e2bc25477261f524a0 Commit: 1fee25646d59a975159e68f0012dc4a783337519 https://github.com/tribe29/checkmk/commit/1fee25646d59a975159e68f0012dc4a78… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12709 M cmk/special_agents/agent_proxmox_ve.py M tests/unit/cmk/special_agents/test_agent_proxmox_ve.py Log Message: ----------- 12709 FIX agent_proxmox_ve: Crash with KeyError('started_time') when corresponding backup job failed In case a backup job failed, unfinished VM backup logs do not contain `started_time`, which would result in unhandled KeyError('started_time') when sorting backup entries. This change will make `agent_proxmox_ve` use the time the job failed at as `started_time` for each VM in order to be able to assign a failed backup to a certain point in time. Change-Id: Ia2486f074ddde49cf62f346d5d09ddcb3d579699 Commit: b7157235d285bb7b143ee37836e9f3df6fcb0ffe https://github.com/tribe29/checkmk/commit/b7157235d285bb7b143ee37836e9f3df6… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12087 M cmk/base/plugins/agent_based/hr_mem.py M tests/unit/cmk/base/plugins/agent_based/test_hr_mem.py Log Message: ----------- revert²: 12087 FIX hr_mem: raises KeyError() on invalid SNMP data Change-Id: I30527224982afd9430eae83e1c0e22c62e6eb57a Commit: f78643dfabf1f14e3a9ad72cbde4d02713bf3140 https://github.com/tribe29/checkmk/commit/f78643dfabf1f14e3a9ad72cbde4d0271… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12088 M cmk/base/plugins/agent_based/mssql_counters_section.py Log Message: ----------- revert²: 12088 FIX mssql_counters: ValueError() raised on unknown timestamp format Change-Id: I9553802caf34e3e74ed351604fce60953777c9cb Commit: a769769418ff55a9beb87d2c68e09488ccccd2b5 https://github.com/tribe29/checkmk/commit/a769769418ff55a9beb87d2c68e09488c… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12089 M checks/cisco_ucs_hdd M checks/cisco_ucs_lun Log Message: ----------- revert²: 12089 FIX cisco_ucs_\*: ValueError (invalid literal for int() with base 10: '') raised Change-Id: I143c7a79b2c82f9accceaee6b7e987479ed4f3a4 Commit: 06581080046e36bf60af6eb210704903fb6ee3b1 https://github.com/tribe29/checkmk/commit/06581080046e36bf60af6eb210704903f… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12090 M cmk/base/plugins/agent_based/zypper.py Log Message: ----------- revert²: 12090 FIX zypper crash with "IndexError(list index out of range)" Change-Id: I5b1e18d693d56a9f1f71b937a7b5c7fa6a6410f2 Commit: 3ec79af195b89889751b0ec1ce232515a865a2de https://github.com/tribe29/checkmk/commit/3ec79af195b89889751b0ec1ce232515a… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12091 M checks/mysql_capacity Log Message: ----------- revert²: 12091 FIX mysql_capacity: ValueError() raised if ':' in error message Change-Id: If0fae705565ad3a527cf4543495253a923f39798 Commit: ff31d7a1e6b06b9ef60233bc5e8a7aca0ca3b28a https://github.com/tribe29/checkmk/commit/ff31d7a1e6b06b9ef60233bc5e8a7aca0… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12092 M cmk/base/plugins/agent_based/cisco_mem_asa.py M tests/unit/cmk/base/plugins/agent_based/test_cisco_mem_asa.py Log Message: ----------- revert²: 12092 FIX cisco_mem_asa: raises IndexError() on bad SNMP data Change-Id: Id27713b8750d578e317cc7c4bd134d8c331a234a Commit: ac34d9da04895f37844a2323e86cf70f850815eb https://github.com/tribe29/checkmk/commit/ac34d9da04895f37844a2323e86cf70f8… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12093 M cmk/base/plugins/agent_based/proxmox_ve_backup_status.py M tests/unit/cmk/base/plugins/agent_based/test_proxmox_ve_backup_status.py Log Message: ----------- 12093 FIX proxmox_ve_backup_status: ZeroDivisionError() raised on some agent input Zero-values for transfer_time, upload_amount or upload_time could result in ZeroDivisionError being raised. This change omits specific results in those cases. Change-Id: I2120c2ed3a624fe830d1a6e6934557c24e068008 Commit: 1470c486fe7cc740ea36aa41c696b6ce93a10709 https://github.com/tribe29/checkmk/commit/1470c486fe7cc740ea36aa41c696b6ce9… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12095 M checks/storcli_pdisks Log Message: ----------- 12095 FIX storcli_pdisks: KeyError(<ITEM>) raised in check-function if item vanished storcli_pdisks check function did not check for the existence of an item in the preprocessed data and raised KeyError() in case it didn't exists. This change aborts the check resulting in UNKN state in that case. Change-Id: I089af507d10aa33e4dd23148791b1bff8a29213b Commit: c77b19c679962877b0310d89f596a90b05fd9300 https://github.com/tribe29/checkmk/commit/c77b19c679962877b0310d89f596a90b0… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12707 M checks/md Log Message: ----------- 12707 FIX `md` check: crashes with IndexError (list index out of range) on invalid input Fed with input different from what the `df` check is made for it tries to access non-existent input elements and crashes with unhandled IndexError exception. This change makes `md` check for the minimum number of expected elements before accessing them. Change-Id: I4edb9e6b8e3e6774e94af22bf92793bde124d585 Commit: 1500b7a66e94c15ffd70e77ba625675710295785 https://github.com/tribe29/checkmk/commit/1500b7a66e94c15ffd70e77ba62567571… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M cmk/gui/wato/pages/activate_changes.py Log Message: ----------- Fix site change HTML escaping (after tightening table.cell escaping) Change-Id: Id296271f806a263a311ceafaa40d0a8df166672c Compare: https://github.com/tribe29/checkmk/compare/17836e29fc16...1500b7a66e94

3 years, 4 months

[tribe29/checkmk] 17836e: 12562 FIX Fix RuntimeError when opening a folder c...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 17836e29fc16c12b3899968d50015901ae6f80ea https://github.com/tribe29/checkmk/commit/17836e29fc16c12b3899968d50015901a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12562 M cmk/gui/watolib/sites.py Log Message: ----------- 12562 FIX Fix RuntimeError when opening a folder configuration (2.0.0p3 regression) When opening a folder in setup parts of the Checkmk configuration is loaded in background. While loading this configuration also old configuration formats are transformed for a seamless migration of old configuration settings. One of these transformations of old livestatus proxy configuration could fail with an error showing the message: "RuntimeError (dictionary changed size during iteration)". This issue was present in previous versions but was not triggered on folder configuration pages, but only on global settings or site management pages. This fix solves the issues for all of those places. Change-Id: Ia41cfbf31d3ae265e3aadb8e3c5526d41538c3ef

3 years, 4 months

[tribe29/checkmk] b77d7b: 12673 FIX cisco_nexus_cpu: Remove duplicated service

by Andreas Umbreit

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b77d7bf0d65ebab9f34f9ba9b045330552b4ed11 https://github.com/tribe29/checkmk/commit/b77d7bf0d65ebab9f34f9ba9b04533055… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12673 M cmk/base/check_legacy_includes/cisco_cpu_scan_functions.py Log Message: ----------- 12673 FIX cisco_nexus_cpu: Remove duplicated service When discovering services on a Cisco Nexus device, a duplicated "CPU utilization" service may be discovered, with check commands check_mk-cisco_cpu and check_mk-cisco_nexus_cpu. This is fixed now by only discovering the check_mk-cisco_nexus_cpu based service. SUP-6134 Change-Id: I02081e6bec7ae743cc07405de8fb296884eafcc2

3 years, 4 months

[tribe29/checkmk] 015cec: 12561 FIX Fix KeyError (site_id) crash on host pro...

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 015cec176df92233bf1563ce152ee04acd57fcba https://github.com/tribe29/checkmk/commit/015cec176df92233bf1563ce152ee04ac… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12561 M cmk/gui/watolib/sites.py Log Message: ----------- 12561 FIX Fix KeyError (site_id) crash on host properties page (2.0.0p2 regression) When opening the host properties page in the setup an exception KeyError ("site_id") could appear in distributed setups. This issue was triggered when a folder has a site attribute configured which does not have a site specific global setting defined. This situation is now cleanly handled to prevent this exception. Change-Id: I0bf2a842a1ae67cade02694897dd197df0cd919f Commit: 93fb73dd4e6f894817f2e753e5761f54abd27da1 https://github.com/tribe29/checkmk/commit/93fb73dd4e6f894817f2e753e5761f54a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12562 M cmk/gui/watolib/sites.py Log Message: ----------- 12562 FIX Fix RuntimeError when opening a folder configuration (2.0.0p3 regression) When opening a folder in setup parts of the Checkmk configuration is loaded in background. While loading this configuration also old configuration formats are transformed for a seamless migration of old configuration settings. One of these transformations of old livestatus proxy configuration could fail with an error showing the message: "RuntimeError (dictionary changed size during iteration)". This issue was present in previous versions but was not triggered on folder configuration pages, but only on global settings or site management pages. This fix solves the issues for all of those places. Change-Id: Ia41cfbf31d3ae265e3aadb8e3c5526d41538c3ef Compare: https://github.com/tribe29/checkmk/compare/2d8106eea8ab...93fb73dd4e6f

3 years, 4 months

[tribe29/checkmk] 719ad1: 12560 FIX Cascading livestatus proxy can now open ...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 719ad1f2e4255ff3b7ef22459594ea4fde7156ca https://github.com/tribe29/checkmk/commit/719ad1f2e4255ff3b7ef22459594ea4fd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12560 Log Message: ----------- 12560 FIX Cascading livestatus proxy can now open encrypted sockets The livestatus proxy can be configured to cascade livestatus connections. The feature was introduced with 1.5.0 by werk #5970 which describes how this can be used. In previous versions the livestatus proxy was always offering a plain text livestatus connection. Even if the site configuration offered the option "Encrypt communication". Changing the option simply did not have any effect. Trying to connect to this socket using a livestatus client with encryption enabled simply failed all the time. With this change the livestatus proxy is now respecting the "Encrypt communication" and offering a TLS encrypted server socket using the certificate of the site where the livestatus proxy is running on. Change-Id: I957d5785b993c403568ceb258ba595311ebbe49b Commit: e94f71ccfd17a145dd17e33d32372ece54a63559 https://github.com/tribe29/checkmk/commit/e94f71ccfd17a145dd17e33d32372ece5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12561 M cmk/gui/watolib/sites.py Log Message: ----------- 12561 FIX Fix KeyError (site_id) crash on host properties page (2.0.0p2 regression) When opening the host properties page in the setup an exception KeyError ("site_id") could appear in distributed setups. This issue was triggered when a folder has a site attribute configured which does not have a site specific global setting defined. This situation is now cleanly handled to prevent this exception. Change-Id: I0bf2a842a1ae67cade02694897dd197df0cd919f Compare: https://github.com/tribe29/checkmk/compare/4efc5ddf3fa5...e94f71ccfd17

3 years, 4 months

[tribe29/checkmk] 2d8106: 12730 FIX <tt>mk_zypper</tt>: Increase timeout fro...

by Robert Sander

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 2d8106eea8ab625799b673ca25afcf569c0b1d09 https://github.com/tribe29/checkmk/commit/2d8106eea8ab625799b673ca25afcf569… Author: Robert Sander <r.sander(a)heinlein-support.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12730 M agents/plugins/mk_zypper Log Message: ----------- 12730 FIX <tt>mk_zypper</tt>: Increase timeout from 10 to 50 s The agent plugin <tt>mk_zypper</tt>, which collects data about updates on SUSE Linux hosts, had an built-in timeout of 10 s. This was too short, since <tt>zypper refresh</tt> can run for 20 s or more. This werk increases the timeout to 50 s. Note that this plugin is normally executed asynchronously and in large time intervals, so increasing this timeout is not problematic. For this werk to come into effect, you need to update the agent on affected hosts. Closes #364 Change-Id: I8a36b45e26c2333482b2908711f1af211e55de7e

3 years, 4 months

[tribe29/checkmk] 4efc5d: 12730 FIX <tt>mk_zypper</tt>: Increase timeout fro...

by Robert Sander

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4efc5ddf3fa54d088580d5092868706062a8fcb9 https://github.com/tribe29/checkmk/commit/4efc5ddf3fa54d088580d509286870606… Author: Robert Sander <r.sander(a)heinlein-support.de> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12730 M agents/plugins/mk_zypper Log Message: ----------- 12730 FIX <tt>mk_zypper</tt>: Increase timeout from 10 to 50 s The agent plugin <tt>mk_zypper</tt>, which collects data about updates on SUSE Linux hosts, had an built-in timeout of 10 s. This was too short, since <tt>zypper refresh</tt> can run for 20 s or more. This werk increases the timeout to 50 s. Note that this plugin is normally executed asynchronously and in large time intervals, so increasing this timeout is not problematic. For this werk to come into effect, you need to update the agent on affected hosts. Closes #364 Change-Id: I8a36b45e26c2333482b2908711f1af211e55de7e

3 years, 4 months

[tribe29/checkmk] efe7d1: 12673 FIX cisco_nexus_cpu: Remove duplicated service

by Andreas Umbreit

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: efe7d153303cb7d70d03c9c66cbe92f88218e40a https://github.com/tribe29/checkmk/commit/efe7d153303cb7d70d03c9c66cbe92f88… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: A .werks/12673 M cmk/base/check_legacy_includes/cisco_cpu_scan_functions.py Log Message: ----------- 12673 FIX cisco_nexus_cpu: Remove duplicated service When discovering services on a Cisco Nexus device, a duplicated "CPU utilization" service may be discovered, with check commands check_mk-cisco_cpu and check_mk-cisco_nexus_cpu. This is fixed now by only discovering the check_mk-cisco_nexus_cpu based service. SUP-6134 Change-Id: I02081e6bec7ae743cc07405de8fb296884eafcc2

3 years, 4 months

[tribe29/checkmk] 0d5858: Execute docker build job on correct node

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 0d5858511e75cc5f4ab0e60a13e610ccc77d6717 https://github.com/tribe29/checkmk/commit/0d5858511e75cc5f4ab0e60a13e610ccc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-04-26 (Mon, 26 Apr 2021) Changed paths: M buildscripts/scripts/build-cmk-container.jenkins Log Message: ----------- Execute docker build job on correct node Change-Id: I659c37ad3756fad8dcb80e5d6a8e7bdfcc60caf2

3 years, 4 months

[tribe29/checkmk]

by Lars

Branch: refs/tags/v1.6.0p23 Home: https://github.com/tribe29/checkmk

3 years, 4 months

← Newer
1
...
13
14
15
16
17
18
19
...
56
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits April 2021