Checkmk git commits March 2021

checkmk-commits@lists.checkmk.com

1 participants
838 discussions

[tribe29/checkmk] 06a2a6: 12553 FIX Agent bakery: Fix host label conditions ...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 06a2a6a8b8463eae15e32cc6598878bfd80170c0 https://github.com/tribe29/checkmk/commit/06a2a6a8b8463eae15e32cc6598878bfd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12553 A cmk/gui/watolib/host_label_sync.py M cmk/utils/labels.py M tests/unit/cmk/gui/test_background_job.py M tests/unit/cmk/gui/test_cron.py M tests/unit/cmk/gui/watolib/test_watolib.py M tests/unit/cmk/utils/test_labels.py Log Message: ----------- 12553 FIX Agent bakery: Fix host label conditions in distributed setups In previous Checkmk versions agent bakery rules that were using host label conditions could not be used correctly in distributed setups. The background is that in distributed setups the discovered(!) host labels are stored on remote sites for hosts that are assigned with a remote site. But the processing of agent bakery rules is done one the central site during agent baking. Without the discovered host labels of remote site hosts, the bakery could not compute the correct agent configuration for these hosts. The hosts were not matched based on their discovered host labels. This change now sets up a synchronization of discovered host labels from remote sites to the central site for the bakery rules to be able to match the correct hosts. The synchronization is being executed on a regular base (every 10 minutes for now) as background job. You can have a look at the state of this synchronization at "Setup > Background jobs > Discovered host label synchronization". Change-Id: Id7112edf0f91a5d2c46d5bfd566defea0ec6b645 Commit: d2d946479b80497dcb720fc3c2f4bdf669d103c1 https://github.com/tribe29/checkmk/commit/d2d946479b80497dcb720fc3c2f4bdf66… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: M cmk/gui/background_job.py M cmk/gui/watolib/host_label_sync.py M cmk/utils/labels.py M tests/unit/cmk/utils/test_labels.py Log Message: ----------- Label synchronization can now gather discovered labels of a single host The rule match analyzer of the ruleset editor needs have the discovered host labels available locally. In this mode we know the site and host we want to have the labels for and we want to enforce fetching the labels of that host. This is the base for that operation mode. Change-Id: I5d4c1066ef6c7189f3ef9651d2371b77847d6d55 Commit: c0778b0333fa06f937e323b7f4e794dcf429aeec https://github.com/tribe29/checkmk/commit/c0778b0333fa06f937e323b7f4e794dcf… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12554 M cmk/gui/wato/pages/rulesets.py Log Message: ----------- 12554 FIX Ruleset editor: Fix analyzing host label matching in distributed setups The ruleset editor provides a mode that allows a user to analyze the matching of rules on specific hosts services. This mode analyzes the conditions configured for a rule and reports whether or not these conditions match on the given host. One of these conditions can be host labels. In distributed setups the host labels are stored on the site the host is monitored from, while the analyzation of the condition matching is being done on the central site. If you have rules that have host labels configured as conditions, analyzing the rule matching did not work because of the missing discovered host labels in the central site. This is now solved by synchronizing the host labels from the remote site to the central site in the moment they are needed. This mechanism is based on the synchronization mechanism that was introduced with werk #12553. Change-Id: Icc7323c159bbec948c24c8d3672922723d1617d2 Commit: d16821abff731c193d6443d07eddc5a040763df5 https://github.com/tribe29/checkmk/commit/d16821abff731c193d6443d07eddc5a04… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12555 M cmk/gui/plugins/views/sorters.py Log Message: ----------- 12555 FIX Views: Fix crash when sorting hosts by IPv4 addresses When trying to sort a host view by the IPv4 address column, an exception like "TypeError ('>' not supported between instances of 'str' and 'tuple')" occurred when the hosts to be sorted had mixed addreses (IPv4 addresses and host or DNS names) configured. Change-Id: If94a77f3d85519f7383896d2a08c1a9b4b7f12ee Compare: https://github.com/tribe29/checkmk/compare/7ae5c009bf7b...d16821abff73

3 years, 3 months

[tribe29/checkmk] 7ae5c0: improve readablility/maintainability of doc test

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7ae5c009bf7baf2586124f1590ddb4cc99927664 https://github.com/tribe29/checkmk/commit/7ae5c009bf7baf2586124f1590ddb4cc9… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: M cmk/base/api/agent_based/render.py Log Message: ----------- improve readablility/maintainability of doc test Change-Id: I61b899dbbdebf480997bd1405628e42ef402ca3d

3 years, 3 months

[tribe29/checkmk] 15a2a0: 12646 FIX agent_azure: correct piggyback-section h...

by Uli

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 15a2a04879919345ab7c77b35db5f8ea73f024ec https://github.com/tribe29/checkmk/commit/15a2a04879919345ab7c77b35db5f8ea7… Author: Ulrich Bschorer <ulrich.bschorer(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12646 M cmk/special_agents/agent_azure.py M tests/unit/cmk/special_agents/agent_azure/test_agent_azure_sections.py Log Message: ----------- 12646 FIX agent_azure: correct piggyback-section headers Since version 2.0.0i2 the piggyback section header names have been post-processed (dash was replaced with an underscore). This could lead to the piggyback data no longer matching the configured CMK hosts. This fix removes the postprocessing for piggyback section headers. Change-Id: I2a7d6cdf4efc3830a2b5208b840ed506db9c1496

3 years, 3 months

[tribe29/checkmk] 346064: 12457 FIX Cleanup routine for hosts no longer need...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 346064f0b18620c35d73f4636264eff0918f30d9 https://github.com/tribe29/checkmk/commit/346064f0b18620c35d73f4636264eff09… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12457 M cmk_base/automations/check_mk.py Log Message: ----------- 12457 FIX Cleanup routine for hosts no longer needlessly loads the complete config The internally used clean-up command <tt>cmk --automation delete-hosts {hostname}</tt> always loaded the complete host configuration and all checks. This information was never actually needed. Change-Id: I6a407f6a9ff8c1ad41d432f0bbb270b2f5f89e25

3 years, 3 months

[tribe29/checkmk] d9c324: WK12457: Cleanup routine for hosts no longer needl...

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: d9c324026c71e5c82024de789036adbb74d3baea https://github.com/tribe29/checkmk/commit/d9c324026c71e5c82024de789036adbb7… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12457 M cmk/base/automations/check_mk.py Log Message: ----------- WK12457: Cleanup routine for hosts no longer needlessly loads the complete config Change-Id: Ia7790d618ada768088fd8059ce47ae8da5707e3e Commit: 4241699a5545afb417843061e8b3420f1285f5dd https://github.com/tribe29/checkmk/commit/4241699a5545afb417843061e8b3420f1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12553 A cmk/gui/watolib/host_label_sync.py M cmk/utils/labels.py M tests/unit/cmk/gui/test_background_job.py M tests/unit/cmk/gui/test_cron.py M tests/unit/cmk/gui/watolib/test_watolib.py M tests/unit/cmk/utils/test_labels.py Log Message: ----------- 12553 FIX Agent bakery: Fix host label conditions in distributed setups In previous Checkmk versions agent bakery rules that were using host label conditions could not be used correctly in distributed setups. The background is that in distributed setups the discovered(!) host labels are stored on remote sites for hosts that are assigned with a remote site. But the processing of agent bakery rules is done one the central site during agent baking. Without the discovered host labels of remote site hosts, the bakery could not compute the correct agent configuration for these hosts. The hosts were not matched based on their discovered host labels. This change now sets up a synchronization of discovered host labels from remote sites to the central site for the bakery rules to be able to match the correct hosts. The synchronization is being executed on a regular base (every 10 minutes for now) as background job. You can have a look at the state of this synchronization at "Setup > Background jobs > Discovered host label synchronization". Change-Id: Id7112edf0f91a5d2c46d5bfd566defea0ec6b645 Commit: 68e29b8103128e99020b18df45f2390a47e79831 https://github.com/tribe29/checkmk/commit/68e29b8103128e99020b18df45f2390a4… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: M cmk/gui/background_job.py M cmk/gui/watolib/host_label_sync.py M cmk/utils/labels.py M tests/unit/cmk/utils/test_labels.py Log Message: ----------- Label synchronization can now gather discovered labels of a single host The rule match analyzer of the ruleset editor needs have the discovered host labels available locally. In this mode we know the site and host we want to have the labels for and we want to enforce fetching the labels of that host. This is the base for that operation mode. Change-Id: I5d4c1066ef6c7189f3ef9651d2371b77847d6d55 Commit: 793a23c0d353052126352561eac1a25cab7ba119 https://github.com/tribe29/checkmk/commit/793a23c0d353052126352561eac1a25ca… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12554 M cmk/gui/wato/pages/rulesets.py Log Message: ----------- 12554 FIX Ruleset editor: Fix analyzing host label matching in distributed setups The ruleset editor provides a mode that allows a user to analyze the matching of rules on specific hosts services. This mode analyzes the conditions configured for a rule and reports whether or not these conditions match on the given host. One of these conditions can be host labels. In distributed setups the host labels are stored on the site the host is monitored from, while the analyzation of the condition matching is being done on the central site. If you have rules that have host labels configured as conditions, analyzing the rule matching did not work because of the missing discovered host labels in the central site. This is now solved by synchronizing the host labels from the remote site to the central site in the moment they are needed. This mechanism is based on the synchronization mechanism that was introduced with werk #12553. Change-Id: Icc7323c159bbec948c24c8d3672922723d1617d2 Commit: 5d4e0315920730340050be05570604bf047692ef https://github.com/tribe29/checkmk/commit/5d4e0315920730340050be05570604bf0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12555 M cmk/gui/plugins/views/sorters.py Log Message: ----------- 12555 FIX Views: Fix crash when sorting hosts by IPv4 addresses When trying to sort a host view by the IPv4 address column, an exception like "TypeError ('>' not supported between instances of 'str' and 'tuple')" occurred when the hosts to be sorted had mixed addreses (IPv4 addresses and host or DNS names) configured. Change-Id: If94a77f3d85519f7383896d2a08c1a9b4b7f12ee Compare: https://github.com/tribe29/checkmk/compare/fc92c39e1675...5d4e03159207

3 years, 3 months

[tribe29/checkmk] 5fc569: Small improvement in contributing guidelines regar...

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5fc569c72c90c1c3ec195a527a3bad60cad489fd https://github.com/tribe29/checkmk/commit/5fc569c72c90c1c3ec195a527a3bad60c… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: M CONTRIBUTING.md Log Message: ----------- Small improvement in contributing guidelines regarding licensing Change-Id: I4efed3b484903431bef382c3e453d4a5b347baa0

3 years, 3 months

[tribe29/checkmk] fc92c3: Small improvement in contributing guidelines regar...

by Jörg Herbel

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: fc92c39e16755b0f9ead70692ac4175e6db5c261 https://github.com/tribe29/checkmk/commit/fc92c39e16755b0f9ead70692ac4175e6… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: M CONTRIBUTING.md Log Message: ----------- Small improvement in contributing guidelines regarding licensing Change-Id: I4efed3b484903431bef382c3e453d4a5b347baa0

3 years, 3 months

[tribe29/checkmk] b435a1: Revert "NOCHECK: add test to reproduce FEED-5871"

by Frans Fürst

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: b435a1e5285c67408be3155d994df8cc2619183a https://github.com/tribe29/checkmk/commit/b435a1e5285c67408be3155d994df8cc2… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: M cmk/base/plugins/agent_based/hr_mem.py M tests/unit/cmk/base/plugins/agent_based/test_hr_mem.py Log Message: ----------- Revert "NOCHECK: add test to reproduce FEED-5871" This reverts commit 0035ea0e52118f6fd03a9c115028b70ce22a78e9.

3 years, 3 months

[tribe29/checkmk] 8163f6: Reserved 10 Werk IDS

by Andreas Umbreit

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8163f635355243e8f9c4e2f2c89c8df821472643 https://github.com/tribe29/checkmk/commit/8163f635355243e8f9c4e2f2c89c8df82… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: M .werks/first_free Log Message: ----------- Reserved 10 Werk IDS Change-Id: Iadaa9a4fac8654dd0b4605f2f813988f9d7b7338

3 years, 3 months

[tribe29/checkmk] 0035ea: NOCHECK: add test to reproduce FEED-5871

by Frans Fürst

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 0035ea0e52118f6fd03a9c115028b70ce22a78e9 https://github.com/tribe29/checkmk/commit/0035ea0e52118f6fd03a9c115028b70ce… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: M cmk/base/plugins/agent_based/hr_mem.py M tests/unit/cmk/base/plugins/agent_based/test_hr_mem.py Log Message: ----------- NOCHECK: add test to reproduce FEED-5871 Change-Id: I38ad484df1cb4d546e64d66c602ef4e7c4f235ff Commit: ca7adaa0d6fdcc7f8f2ae661afe107e7798dd73a https://github.com/tribe29/checkmk/commit/ca7adaa0d6fdcc7f8f2ae661afe107e77… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12087 M cmk/base/plugins/agent_based/hr_mem.py Log Message: ----------- 12087 FIX hr_mem: raises KeyError() on invalid SNMP data An empty value for hrStorageType cannot be mapped to a known type and currently crashes with a KeyError(). This change will just ignore hr_mem-entries without given hrStorageType. Change-Id: I66927b4b76dc78c7d0c51f6de8c32f7bc2f75af7 Commit: 4cce1845b082f72dd87425c38d8793f7fe0583cc https://github.com/tribe29/checkmk/commit/4cce1845b082f72dd87425c38d8793f7f… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12088 M cmk/base/plugins/agent_based/mssql_counters_section.py Log Message: ----------- 12088 FIX mssql_counters: ValueError() raised on unknown timestamp format 'YYYY/mm/dd HH:MM:SS [AM|PM]' could not yet be recognized by the timestamp parser. This change just adds this format. Change-Id: Icda08e23e329940c12d8a047f1c820ae06a0ddfd Commit: b152c240555e39d2349a98d639aa42e5220fc7c9 https://github.com/tribe29/checkmk/commit/b152c240555e39d2349a98d639aa42e52… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12089 M checks/cisco_ucs_hdd M checks/cisco_ucs_lun Log Message: ----------- 12089 FIX cisco_ucs_*: ValueError (invalid literal for int() with base 10: '') raised An empty value for @cucsStorageLocalLunSize raised an exception when tried to be parsed as int. This change will assume '0' if no value is given. Change-Id: Icc8d5eab1448d77277a0029b33b0fec39ef9124f Commit: 8c6a8703726fad22e99f8f687969935a8b8f83a5 https://github.com/tribe29/checkmk/commit/8c6a8703726fad22e99f8f687969935a8… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12090 M checks/zypper Log Message: ----------- 12090 FIX zypper - IndexError (list index out of range) In case the zypper section is empty the check would crash due to an dedicated access to line 1. This change makes the check not access line 1 if not present. Change-Id: I9a38b9f0997beb440623da11a0692917dfbc135c Commit: 6d1285ef01f478416421a54db6b8fc1a801f1a9c https://github.com/tribe29/checkmk/commit/6d1285ef01f478416421a54db6b8fc1a8… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12091 M checks/mysql_capacity Log Message: ----------- 12091 FIX mysql_capacity: ValueError() raised if ':' in error message Splitting a message string containing instance and message results in an error if the message itself contains the delimiter (':'). This change will make sure the input string will be splitted into 2 parts max. Change-Id: I70049ca2fafae232ee842d6bd01b300db2d69f35 Commit: 289cecb39ef846eda34ee7ad9c96f1b8697b6f7f https://github.com/tribe29/checkmk/commit/289cecb39ef846eda34ee7ad9c96f1b86… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: A .werks/12092 M cmk/base/plugins/agent_based/cisco_mem_asa.py M tests/unit/cmk/base/plugins/agent_based/test_cisco_mem_asa.py Log Message: ----------- 12092 FIX cisco_mem_asa: raises IndexError() on bad SNMP data cisco_mem_asa disvovery and check functions would crash when parsing empty SNMP lines. Additionally the plugin uses two distinct functions for parsing different versions of input data. This change brings both parsing functions together and makes the new one check for empty input and thus fix the described bug. Change-Id: Iec429a611e47691825ae0f05e6707da427d65a2b Commit: d5bd968faa3e1ad0b7e20cb17d26e63881500a92 https://github.com/tribe29/checkmk/commit/d5bd968faa3e1ad0b7e20cb17d26e6388… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-03-30 (Tue, 30 Mar 2021) Changed paths: R .werks/12087 R .werks/12088 R .werks/12089 R .werks/12090 R .werks/12091 R .werks/12092 M checks/cisco_ucs_hdd M checks/cisco_ucs_lun M checks/mysql_capacity M checks/zypper M cmk/base/plugins/agent_based/cisco_mem_asa.py M cmk/base/plugins/agent_based/hr_mem.py M cmk/base/plugins/agent_based/mssql_counters_section.py M tests/unit/cmk/base/plugins/agent_based/test_cisco_mem_asa.py Log Message: ----------- revert accidentally commited changes Change-Id: I0cd64dbbdc1aaa4ada8c890b481878d61605ed92 Compare: https://github.com/tribe29/checkmk/compare/19be8e0f3886...d5bd968faa3e

3 years, 3 months

← Newer
1
2
3
4
5
6
7
8
...
84
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits March 2021