Checkmk git commits November 2021

checkmk-commits@lists.checkmk.com

1 participants
424 discussions

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 66fe8eeda72b72e73fdab9af1a806cd47ca310c8 https://github.com/tribe29/checkmk/commit/66fe8eeda72b72e73fdab9af1a806cd47… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M tests/unit/cmk/utils/test_agent_registration.py Log Message: ----------- Adapt test Change-Id: I0acf094b1c7c0cffd1a3518381f3f00f36dde27e Commit: 559e7b3a7a4a19803c924bb15f0f6ffcd6d520fb https://github.com/tribe29/checkmk/commit/559e7b3a7a4a19803c924bb15f0f6ffcd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M tests/unit/test_pipfile.py Log Message: ----------- Improve pipfile test * Ignore build artifact files in omd/build * Suppress warnings raised by scanned files * Add logging for skipped incompatible files Change-Id: I1b78fe173ea6883a5fcb34e5848925297acb5067 Compare: https://github.com/tribe29/checkmk/compare/9f0c6e10e6d1...559e7b3a7a4a

2 years, 10 months

[tribe29/checkmk] ed2dfa: config: make Service.id() call explicit

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ed2dfacde0b73d372555115290edfff0ba2ceb16 https://github.com/tribe29/checkmk/commit/ed2dfacde0b73d372555115290edfff0b… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M cmk/base/config.py Log Message: ----------- config: make Service.id() call explicit Service.__eq__ actually compares the value of '.id()'. That is weird, because other attributes may differ. Change-Id: I92c44f16b5176c7fc9b933fe06b143edb9e7560e Commit: 42b357b0d88de2200e8117d6fd322422d14713cb https://github.com/tribe29/checkmk/commit/42b357b0d88de2200e8117d6fd322422d… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M cmk/base/autochecks/__init__.py Log Message: ----------- remove redundant sorting (AutochecksStore.write sorts as well) Change-Id: I0937cf7886fee892f9644ff351ca154615b1e567 Commit: 2bfa181676661a833f62f73f601f209cdd183f9f https://github.com/tribe29/checkmk/commit/2bfa181676661a833f62f73f601f209cd… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M cmk/base/agent_based/discovery/__init__.py M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/autochecks/__init__.py M tests/unit/cmk/base/agent_based/discovery/test_discovered_services.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py Log Message: ----------- Delay creation of AutocheckService instances The only difference between AucheckEntry and AutocheckService is the presence of the service description. We should only compute it if and when we actually need it. Change-Id: I56dc864378fbba10e91dce8239890d2d898f3ac2 Commit: af7cc1746609137201e110261b27d3ce8e12421f https://github.com/tribe29/checkmk/commit/af7cc1746609137201e110261b27d3ce8… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M cmk/base/export.py M cmk/gui/plugins/views/utils.py M cmk/gui/utils/labels.py M cmk/gui/view_utils.py M cmk/utils/labels.py M cmk/utils/rulesets/ruleset_matcher.py M cmk/utils/type_defs/_misc.py M tests/unit/cmk/base/test_discovered_labels.py Log Message: ----------- test: improve type hints Change-Id: Ie8840c31eadb544d12f28bbc5650cda3a6a035a3 Commit: 60a0db2f6a042636938bcc74839f87b19b7b78fa https://github.com/tribe29/checkmk/commit/60a0db2f6a042636938bcc74839f87b19… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: R tests/unit/checks/generictests/datasets/mem_win_regression.py A tests/unit/checks/test_mem_win.py Log Message: ----------- mem_win: add some unit tests Change-Id: I505f43363fe33b6e57d8fdc8e3a7cd114b151fc4 Commit: 350afa16975f306f3950d70065b6cf9ca43a31bd https://github.com/tribe29/checkmk/commit/350afa16975f306f3950d70065b6cf9ca… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M checks/mem Log Message: ----------- check_mem_windows: split into several sub-functions Change-Id: If23ef7d1ef26fba81196673830a289832dcedace Commit: 59de89fbe3c0f226ffee37815c4a52850d403824 https://github.com/tribe29/checkmk/commit/59de89fbe3c0f226ffee37815c4a52850… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: A .werks/13489 M checks/mem M tests/unit/checks/test_mem_win.py Log Message: ----------- 13489 FIX <tt>mem_win</tt>: Fix missing levels in service graphs The metrics produced by the Windows memory check, <tt>mem_win</tt>, were missing levels and boundaries. They have beend added, s.t. the levels are now drawn into the graphs shown in the service output. SUP-8336 Change-Id: Ie7b8a05d6f6e494861eba9f30bee0a64d5e78a67 Commit: 33ebacf91404822b6b833ead31a4c9696a1bea78 https://github.com/tribe29/checkmk/commit/33ebacf91404822b6b833ead31a4c9696… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M checks/mem M tests/unit/checks/test_mem_win.py Log Message: ----------- mem_win: remove duplicate metric in case of avg. + pred. levels Change-Id: Iaad7f4ba328cd2d5debf47715cae9fb755c8411a Commit: 9f0c6e10e6d1af8bdff0198ab91d09a7ada45348 https://github.com/tribe29/checkmk/commit/9f0c6e10e6d1af8bdff0198ab91d09a7a… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M checks/mem Log Message: ----------- mem_win: reduce unit chaos at least a bit. It's still horrible: * Absolute levels on free space come in MB (hard to change). * Non-averaged metrics are expected in Bytes. * Total and averaged metrics are expected in MB. * Averaging is done in KB. * Predictive levels come in GB. Change-Id: Ia17fdec2b1af50b98ee0c3911fcfc247360e62e0 Compare: https://github.com/tribe29/checkmk/compare/9c2b8f0f616b...9f0c6e10e6d1

2 years, 10 months

[tribe29/checkmk] 89694d: 12240 <tt>mk_cups_queues</tt>: Accept printer name...

by Frans Fürst

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 89694db7a5cbae7b3867eb24f09e55b0578be4fb https://github.com/tribe29/checkmk/commit/89694db7a5cbae7b3867eb24f09e55b05… Author: stefani <stefani(a)bibliothek.uni-kassel.de> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: A .werks/12240 M agents/plugins/mk_cups_queues Log Message: ----------- 12240 <tt>mk_cups_queues</tt>: Accept printer names with hyphens ("-") The agent plugin <tt>mk_cups_queues</tt>, which delivers data about printers in queues within the CUPS printing system, now accepts printer names which contain hyphens ("-"). As a result, the corresponding check plugin <tt>cups_queues</tt> will now receive data about such printers and discover them. Note that you have to update the Checkmk agent on the corresponding hosts for this werk to become effective. Closes #336 Change-Id: Id87a713d7b6206950a6319e40b42a7de2a071e3a Commit: 383a9e2db14437d941737c81f3debc58b1621ee0 https://github.com/tribe29/checkmk/commit/383a9e2db14437d941737c81f3debc58b… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M .werks/12240 Log Message: ----------- change werk version Compare: https://github.com/tribe29/checkmk/compare/ec44f8f069ca...383a9e2db144

2 years, 10 months

[tribe29/checkmk] 9c2b8f: Correct strings "rule package" to "rule pack" (CMK...

by Kenneth

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9c2b8f0f616b11fe050d1d5933b6c2890aa2143e https://github.com/tribe29/checkmk/commit/9c2b8f0f616b11fe050d1d5933b6c2890… Author: Kenneth Okoh <kenneth.okoh(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M cmk/ec/defaults.py M cmk/ec/main.py M cmk/gui/wato/mkeventd.py M cmk/gui/watolib/search.py M tests/unit/cmk/gui/wato/test_mkeventd.py Log Message: ----------- Correct strings "rule package" to "rule pack" (CMK-8783) Change-Id: I26791fecc43d49d86e49842d59f59f2db4137d56

2 years, 10 months

[tribe29/checkmk] cdd1ea: simplify fetch_all

by Kenneth

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: cdd1eada8a458478df191a4261b668920e12ddcd https://github.com/tribe29/checkmk/commit/cdd1eada8a458478df191a4261b668920… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M cmk/base/agent_based/data_provider.py M cmk/base/sources/_checkers.py Log Message: ----------- simplify fetch_all ... and move the comment where it now belongs. Change-Id: If4c20da6d34cbb6b8011865d69c77147421f4651 Commit: d3193de86a9dc8efd376e5e343140789c3be30ea https://github.com/tribe29/checkmk/commit/d3193de86a9dc8efd376e5e343140789c… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M cmk/base/agent_based/data_provider.py M cmk/base/sources/_checkers.py M tests/unit/cmk/base/agent_based/test_data_provider_collect_host_sections.py Log Message: ----------- cleanup `nodes`-tuple We have no reason to believe the sources "hostname" and "ipaddress" attributes would not agree with the corresponding variables. But even if it they did differ, it is probably more honest to use the sources' hostname and ipaddress to construct the host key. Change-Id: I969f741bb369ffa9882767fd51392107d0386fa1 Commit: ef97912d329e0858f1e600db84c4654949a71828 https://github.com/tribe29/checkmk/commit/ef97912d329e0858f1e600db84c465494… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M cmk/utils/check_utils.py Log Message: ----------- prepare for hybrid parameters Enabling the unwrapper to deal with hybrid parameters will allow us to simplify the parameter merging logic. Change-Id: I62a40896498f78bf4645254f3e57ddbb97ad8515 Commit: 020d1fc66b8dac4bf57eb6afed0e7700b4ae1a54 https://github.com/tribe29/checkmk/commit/020d1fc66b8dac4bf57eb6afed0e7700b… Author: Kenneth Okoh <kenneth.okoh(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: A .werks/13387 M cmk/gui/wato/pages/rulesets.py M web/htdocs/themes/facelift/scss/_wato.scss Log Message: ----------- 13387 Improve usability of "Create rule" buttons So far the "Create rule" buttons were positioned at the bottom of a ruleset page and did not fit in with the standard Checkmk buttons. These buttons are now located at the top of the page as page menu suggestions and yield several more intuitive options for preselecting folder, host and service/device before entering the rule properties dialog. Also, "Create rule" is reworded to "Add rule". (CMK-8518) Change-Id: I995dc03362f4d392b063db755999c3edcc940ee4 Compare: https://github.com/tribe29/checkmk/compare/6cff695eaf60...020d1fc66b8d

2 years, 10 months

[tribe29/checkmk] 6cff69: Bypass creation of AutocheckService instances

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6cff695eaf604417246d644a3b23eb4de1253e70 https://github.com/tribe29/checkmk/commit/6cff695eaf604417246d644a3b23eb4de… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-11-08 (Mon, 08 Nov 2021) Changed paths: M cmk/update_rrd_fs_names.py Log Message: ----------- Bypass creation of AutocheckService instances The service classes currently are a mess, because they sometimes contain the fully computed parameters, and sometimes only the discovered parameters. Since in this case we don't need either of them, it's best to just load the autocheck entries, and compute the description separately. Note that we now assume that we can in fact compute the service description of all affected autochecks, and do not silently skip them upon an exception raised by 'config.service_description'. Change-Id: I225d06de163c366a339ca85edd3d121ad6ab9350

2 years, 10 months

[tribe29/checkmk] f756ce: Refactor Windows agent: comments, namepsaces, name...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f756ce74343b620f4347ae7db5e839e8fd1f64c1 https://github.com/tribe29/checkmk/commit/f756ce74343b620f4347ae7db5e839e8f… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-11-07 (Sun, 07 Nov 2021) Changed paths: M agents/wnx/src/common/cfg_info.h M agents/wnx/src/engine/providers/plugins.cpp M agents/wnx/src/engine/providers/plugins.h M agents/wnx/watest/test-section_providers.cpp Log Message: ----------- Refactor Windows agent: comments, namepsaces, names of tests Change-Id: I2bd44bdf788ccafce43d5c9145ae24a861851370

2 years, 10 months

[tribe29/checkmk] 8e2346: Make new unit test resilience test compatible

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8e234673aefc7362076d5fdbad5f14039940e93d https://github.com/tribe29/checkmk/commit/8e234673aefc7362076d5fdbad5f14039… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M tests/unit/cmk/gui/test_modules.py Log Message: ----------- Make new unit test resilience test compatible Change-Id: Ia533bbc4325e6c5e13f68e742c48faf562030111

2 years, 10 months

[tribe29/checkmk] f21e9d: Fix gh-actions test

by Christoph Rauch

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f21e9dde1d31cde76bf73571c6ee8c23da1a3f3c https://github.com/tribe29/checkmk/commit/f21e9dde1d31cde76bf73571c6ee8c23d… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M tests/unit/cmk/gui/watolib/test_watolib.py Log Message: ----------- Fix gh-actions test * the config variable was wrongly classified as a CEE part, but is part of CRE Change-Id: I174956856e2c7cd605d1c1fb2a7d69533b9c0cce

2 years, 10 months

[tribe29/checkmk] 1ae88e: Use a (single!) correct external command to remove...

by Christoph Rauch

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 1ae88ebcb3a2b70da3cf9683b40d532758818513 https://github.com/tribe29/checkmk/commit/1ae88ebcb3a2b70da3cf9683b40d53275… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M cmk/gui/plugins/views/commands.py Log Message: ----------- Use a (single!) correct external command to remove a comment. Removing an acknowledgement via DEL_FOO_COMMENT is not correct, it just removes the comment in question, but not the acknowledged state. Doing a REMOVE_FOO_ACKNOWLEDGEMENT afterwards doesn't help either, there is nothing to be removed anymore... Change-Id: Iffddbb948ae23c5e939dd1340edd54ee0f88cf68 Commit: 5f3ad50ae85652920cc5d20614e30e2d47c9049f https://github.com/tribe29/checkmk/commit/5f3ad50ae85652920cc5d20614e30e2d4… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: A .werks/13076 M cmk/gui/plugins/openapi/restful_objects/decorators.py Log Message: ----------- 13076 FIX REST API, extend lock to encompass validation logic This Werk fixes a very severe data inconsistency problem in the REST API. Previously, only the actual working code of the individual endpoints were locked, but the validation logic which gets executed before the endpoints didn't fall into that locking scope. This logic could then trigger a cache load which could lead to data inconsistency and even data loss when using the REST API highly concurrently. The observed effects were: * when moving hosts concurrently, some hosts may disappear * when moving hosts concurrently, some hosts may end up in multiple folders * when editing hosts, spurious 421 or 401 responses could appear The locks have now been modified to encompass also the validation logic. This Werk fixes the afore mentioned problems. There are no further actions to be taken. Change-Id: I4323df250c4202ebb88c1d0a87694741e9eccb6e Commit: d8669b41fbef8f43fbf7e0ad18e9f61a9a5531fb https://github.com/tribe29/checkmk/commit/d8669b41fbef8f43fbf7e0ad18e9f61a9… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: A .werks/13079 M cmk/gui/fields/attributes.py Log Message: ----------- 13079 FIX REST API crash when setting SNMP credential In previous versions the REST API crashed with a HTTP 500 error when a SNMP credential of type "no_auth_no_cred" was being accessed or set. This Werk fixes this. There are no further actions necessary. Change-Id: I93699948505c446bae54a12a0fd2b1c9b9798505 Commit: 6e67f49ffe791ed7b47b73ced66e337334814f83 https://github.com/tribe29/checkmk/commit/6e67f49ffe791ed7b47b73ced66e33733… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M cmk/gui/fields/attributes.py Log Message: ----------- host/folder attributes: remove OrderedDict instances Change-Id: I5855cb07c2a9b45fe6f70cfe4b3c668f200f9729 Compare: https://github.com/tribe29/checkmk/compare/a4f116fe1dba...6e67f49ffe79

2 years, 10 months

← Newer
1
...
33
34
35
36
37
38
39
...
43
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits November 2021