Checkmk git commits January 2021

checkmk-commits@lists.checkmk.com

1 participants
657 discussions

[tribe29/checkmk] e503cd: PRO TIP: parse data into a dictionary

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e503cd5af23507e25b19628310c853bed385b53d https://github.com/tribe29/checkmk/commit/e503cd5af23507e25b19628310c853bed… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M checks/printer_supply Log Message: ----------- PRO TIP: parse data into a dictionary If you make the key the item, you can simply discover one service per key, and look up the appropriate data in the check function. Change-Id: Iea575c0ca2c2425c999d7d7f002242b3a5b65ca7 Commit: d56fb76d772e8fa29e77fcbc6eefc32068267612 https://github.com/tribe29/checkmk/commit/d56fb76d772e8fa29e77fcbc6eefc3206… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M checks/emcvnx_disks Log Message: ----------- PRO TIP: simple return if no data is found If the items dataset is not found in the parsed sections, we can just return without creating any result. The checking engine will create a generic and consistent message in those cases. This works both for the old and new check API. Change-Id: Ia6e6b4532b9efc438142fd57c97948c0c2926b30 Commit: 49c58eef81efc254115fbba967c49c69b462e300 https://github.com/tribe29/checkmk/commit/49c58eef81efc254115fbba967c49c69b… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M checks/mcafee_av_client Log Message: ----------- PRO TIP: make magic imports explicit When migrating the check plugin to the new check API, it is often a good idea to make all 'magic' imports explicit. This reduces the noise in IDEs with linters and helps identifying the areas of the plugin that need special attention during migration. Change-Id: I9db25d001334abb283da52c942d1dcc0b1ad3f16 Compare: https://github.com/tribe29/checkmk/compare/ca1d4c585a93...49c58eef81ef

3 years, 8 months

[tribe29/checkmk] 52be3f: Fix werk version

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 52be3f82df7dee2689da51b1d6ed466478d288ce https://github.com/tribe29/checkmk/commit/52be3f82df7dee2689da51b1d6ed46647… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M .werks/11397 Log Message: ----------- Fix werk version Change-Id: I88ca9b55e39c75ceddb8e503727ec1bd00699fef Commit: 793d7e471b0802323561188eb99b89813c478713 https://github.com/tribe29/checkmk/commit/793d7e471b0802323561188eb99b89813… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: A .werks/11839 Log Message: ----------- 11839 FIX Windows agent allows only one windows agent updater process to run In some rare cases, Windows agent updater process may hang. Previously, Windows agent has ignored this situation - OS might be overloaded with many running cmk-agent-updater processess. With this release, Windows agent terminates (on timeout) previousy started updater process and thus fixes the problem. Change-Id: I7b461cd1f75a578f89a1af1b465627717d447c39 Commit: 33ac1747157ba4d7521d2ca051837bb97c5c9741 https://github.com/tribe29/checkmk/commit/33ac1747157ba4d7521d2ca051837bb97… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M .werks/11839 M tests/unit/cmk/utils/test_werks.py Log Message: ----------- Fix werk version Change-Id: Icde2139513d4a83b14ce73d709ab2404907edfe0 Compare: https://github.com/tribe29/checkmk/compare/c424918b875f...33ac1747157b

3 years, 8 months

[tribe29/checkmk] a2851e: 11927 FIX Pattern Editor: Unable to analyze matchi...

by Lukas Lengler

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: a2851e1010c284ac6adfb426065e4b42e96dd28a https://github.com/tribe29/checkmk/commit/a2851e1010c284ac6adfb426065e4b42e… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: A .werks/11927 M cmk/gui/wato/pages/pattern_editor.py Log Message: ----------- 11927 FIX Pattern Editor: Unable to analyze matching, because "service" parameter is missing The "service" parameter was not needed for the Pattern Editor. Now it is removed completely. Change-Id: I2952fab9247b36cf64e509c9224e24665290a007

3 years, 8 months

[tribe29/checkmk] ca1d4c: 11927 FIX Pattern Editor: Unable to analyze matchi...

by Lukas Lengler

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ca1d4c585a932e3e04a4a18952f44feb674e01ec https://github.com/tribe29/checkmk/commit/ca1d4c585a932e3e04a4a18952f44feb6… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: A .werks/11927 M cmk/gui/wato/pages/pattern_editor.py Log Message: ----------- 11927 FIX Pattern Editor: Unable to analyze matching, because "service" parameter is missing The "service" parameter was not needed for the Pattern Editor. Now it is removed completely. Change-Id: I2952fab9247b36cf64e509c9224e24665290a007

3 years, 8 months

[tribe29/checkmk] c42491: Pin importlib_resources an importlib_metadata for ...

by AZurhake

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: c424918b875f0b8d488fcc55ef8c1c102cd1e318 https://github.com/tribe29/checkmk/commit/c424918b875f0b8d488fcc55ef8c1c102… Author: Alex Zurhake <alex.zurhake(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M buildscripts/infrastructure/os-nodes/debian-8/Dockerfile M buildscripts/infrastructure/os-nodes/ubuntu-14.04/Dockerfile M buildscripts/infrastructure/os-nodes/ubuntu-16.04/Dockerfile Log Message: ----------- Pin importlib_resources an importlib_metadata for old debian and ubuntu versions Change-Id: I26366510dfb3e63c71d97e6e8e8552f24f145966

3 years, 8 months

[tribe29/checkmk] 3ad65e: 11397 FIX Fix Service discovery when service check...

by Óscar Nájera

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 3ad65e69ddb2a82a03fc78ad281c1f46f74ccb0b https://github.com/tribe29/checkmk/commit/3ad65e69ddb2a82a03fc78ad281c1f46f… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: A .werks/11397 M cmk_base/discovery.py Log Message: ----------- 11397 FIX Fix Service discovery when service checkoutput has values of -inf This extends werk 7469, by making sure checkoutputs with values of -inf don't crash the service discovery page. Perfdata is unnecessary and can contain unparsable values, like "inf". If it is passed back and forth and unparsable values appear it lead to value errors. Simply discard perfdata when it will be used in the service discovery page. Extend fix of CMK-2147 and werk 7469 SUP-5026 Change-Id: Ib7d64a0b801056f1c1fb91b18a9d15e6dbba45da

3 years, 8 months

[tribe29/checkmk] 2a9eed: [CMK-6907] - fix plugins.cpp

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2a9eed459ede277157bb1a51381f30396be73a9f https://github.com/tribe29/checkmk/commit/2a9eed459ede277157bb1a51381f30396… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M agents/wnx/src/engine/providers/internal.h M agents/wnx/src/engine/providers/plugins.cpp M agents/wnx/src/engine/providers/plugins.h M agents/wnx/watest/test-plugin.cpp M agents/wnx/watest/test-section_fileinfo.cpp M agents/wnx/watest/test_tools.cpp Log Message: ----------- [CMK-6907] - fix plugins.cpp - remove partly whitebox tests - rework fileinfo tests(as affected by fix above) according to corporate guideline: simple, short, one test per call, user story - improve again testing tools Change-Id: I0db370019fddc8539dca0ce7488499f4000a7262

3 years, 8 months

[tribe29/checkmk] 6e7092: Execution of Agent Plugins (Solaris and AIX agent)

by Lukas Lengler

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 6e7092d91ef838190e92f2c501be421ec0b6b0b2 https://github.com/tribe29/checkmk/commit/6e7092d91ef838190e92f2c501be421ec… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M agents/check_mk_agent.aix M agents/check_mk_agent.solaris Log Message: ----------- Execution of Agent Plugins (Solaris and AIX agent) This should allow consistent execution of agent plugins. foo.py agent plugins are executed with Python 3 if Python 3 is installed. bar_2.py agent plugins are executed if Python 2 is installed and the respective Python 3 agent plugin (bar.py) does not exist. If no correct Python version is found the plugin will not be executed. All other agent plugins are still executed the default way. Change-Id: I2c63ff8524f2360c292c5ae8dff6531353dea028

3 years, 8 months

[tribe29/checkmk] e72a33: Execution of Agent Plugins (Solaris and AIX agent)

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e72a33f3275d29318e4d5215352a5a8f67e6554a https://github.com/tribe29/checkmk/commit/e72a33f3275d29318e4d5215352a5a8f6… Author: Lukas Lengler <lukas.lengler(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M agents/check_mk_agent.aix M agents/check_mk_agent.solaris Log Message: ----------- Execution of Agent Plugins (Solaris and AIX agent) This should allow consistent execution of agent plugins. foo.py agent plugins are executed with Python 3 if Python 3 is installed. bar_2.py agent plugins are executed if Python 2 is installed and the respective Python 3 agent plugin (bar.py) does not exist. If no correct Python version is found the plugin will not be executed. All other agent plugins are still executed the default way. Change-Id: I2c63ff8524f2360c292c5ae8dff6531353dea028 Commit: fde715025913798bbe126c1c32675c56d2f78688 https://github.com/tribe29/checkmk/commit/fde715025913798bbe126c1c32675c56d… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: A .werks/11884 M checks/printer_supply M tests/unit/checks/test_generic_legacy_conversion.py Log Message: ----------- 11884 FIX printer_supply: Drop support for configuration via *.mk file The pluigin printer_supply can no longer be configured using the config variable `printer_supply_some_remaining_status` in an .mk file. Users that still used such an old style configuration must remove the variable, andf set up a rule "Printer cartridge levels" instead. Change-Id: Id80889097bbc1d9d9f360f90e479f671d8565733 Commit: 328b8043a17ee79e52d1ffa481de7fd021162106 https://github.com/tribe29/checkmk/commit/328b8043a17ee79e52d1ffa481de7fd02… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M checks/printer_supply Log Message: ----------- PRO TIP: consolidate parse_function We move all code that convertes or dismisses data into the parse function. In this case in particular: * skip 'useless' devices immediately, not only during discovery * strip description * convert numerical values Further cleanung up of the parse function is required! Change-Id: I96547e004f4d20a85ac9b097166bab0f6eca217f Commit: 3366046c364f7a6e6014830c49075307fbb5c022 https://github.com/tribe29/checkmk/commit/3366046c364f7a6e6014830c49075307f… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: M checks/printer_supply Log Message: ----------- PRO TIP: drop saveint The saveint function has the undesired property of returning 0 if *any exception at all* occurs. This may obfuscate unexpected errors, and is rarely what we need. There is no coresponding function exposed by the new check API. In this case, lines with `level` being zero have been ignored anyway. Change-Id: Id30a4d47722de7da1fb3b89b79e20adf3dfe6b14 Compare: https://github.com/tribe29/checkmk/compare/b428616c0e04...3366046c364f

3 years, 8 months

[tribe29/checkmk] 86077e: 11910 FIX Add warn/crit metrics for percentage usa...

by rb

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 86077ede85fcb100b4da443d40d4486412d51663 https://github.com/tribe29/checkmk/commit/86077ede85fcb100b4da443d40d448641… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2021-01-13 (Wed, 13 Jan 2021) Changed paths: A .werks/11910 M cmk/base/plugins/agent_based/k8s_stats_fs.py M cmk/base/plugins/agent_based/utils/df.py M tests/unit/cmk/base/plugins/agent_based/test_k8s_stats.py M tests/unit/cmk/base/plugins/agent_based/test_oracle_asm_diskgroup.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_data_volume.py Log Message: ----------- 11910 FIX Add warn/crit metrics for percentage usage of filesystems CMK-6521 Change-Id: I787fed6a1dcb2f0a2eafc96f8dbc6f7dab4b3eed

3 years, 8 months

← Newer
1
...
50
51
52
53
54
55
56
...
66
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2021