Checkmk git commits August 2020

checkmk-commits@lists.checkmk.com

1 participants
411 discussions

[tribe29/checkmk] 94ab21: Improved checkman lnx_if

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 94ab2102f29f0361f336f6a373af328199506a0c https://github.com/tribe29/checkmk/commit/94ab2102f29f0361f336f6a373af32819… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M checkman/lnx_if Log Message: ----------- Improved checkman lnx_if Change-Id: Idc76c3f264968cc2e69327ff5c26052ae6feb822

3 years, 9 months

[tribe29/checkmk] f62b59: The fetcher processes are a pure CEE/CME feature

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f62b59f8e6b9336fd43124ef715b0312de9043cd https://github.com/tribe29/checkmk/commit/f62b59f8e6b9336fd43124ef715b0312d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: R bin/fetcher Log Message: ----------- The fetcher processes are a pure CEE/CME feature Move the entry point "fetcher" command to the enterprise hierarchy. Change-Id: I42f83c69efa9c5177236f8115ccb058c42ca158b Commit: bad77ebe4f188da72aa0b69716c1e404933df4d1 https://github.com/tribe29/checkmk/commit/bad77ebe4f188da72aa0b69716c1e4049… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M tests/testlib/pylint_checker_cmk_module_layers.py Log Message: ----------- Cleanup some layer violation suppression bin/fetcher clearly belongs to cmk.fetchers. Add the required declaration to be able to drop the suppression. Change-Id: I7c7757b0a453da380d2c8bee5d855e7b8c83574b Compare: https://github.com/tribe29/checkmk/compare/06e9b1371b27...bad77ebe4f18

3 years, 9 months

[tribe29/checkmk] 06e9b1: agent_bi: Improve error handling when no BI aggreg...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 06e9b1371b276091c828dc87f75fc83c890fc00e https://github.com/tribe29/checkmk/commit/06e9b1371b276091c828dc87f75fc83c8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M cmk/special_agents/agent_bi.py Log Message: ----------- agent_bi: Improve error handling when no BI aggregation is configured Change-Id: If48421c51c91c1bf2018ea4a61bc997a454568fd

3 years, 9 months

[tribe29/checkmk] e15359: Fix pseudo integration tests after API change

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e15359b8b5cd2a6e6a02d73e6c9112b3e875a4d2 https://github.com/tribe29/checkmk/commit/e15359b8b5cd2a6e6a02d73e6c9112b3e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M tests/integration/cmk/lib/snmplib/conftest.py Log Message: ----------- Fix pseudo integration tests after API change Change-Id: Ie2a3bbb642180310651460cc376018fd94aaaad2

3 years, 9 months

[tribe29/checkmk] 7a2321: Fixed "Boolean Blindness" anti-pattern.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7a23213014b2a87b812f5bd57dded210bc5ff8aa https://github.com/tribe29/checkmk/commit/7a23213014b2a87b812f5bd57dded210b… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M livestatus/src/Queue.h M livestatus/src/module.cc M livestatus/src/test/test_Queue.cc Log Message: ----------- Fixed "Boolean Blindness" anti-pattern. CMK-5250 Change-Id: Ia86e5e9afd6b477f0b98155391f19367db182b41

3 years, 9 months

[tribe29/checkmk] b6a9bf: Checker: Use operation mode definition instead of ...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b6a9bff96e32ad8aff687b08b690111e11e7ffb8 https://github.com/tribe29/checkmk/commit/b6a9bff96e32ad8aff687b08b690111e1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M cmk/base/data_sources/_abstract.py M cmk/fetchers/type_defs.py Log Message: ----------- Checker: Use operation mode definition instead of flag Change-Id: Ic5552a09006d4a1cbff041349f156627f5a92d9b Commit: 74b5f728283c0cb97e393373e5e0f2ec36acfa3c https://github.com/tribe29/checkmk/commit/74b5f728283c0cb97e393373e5e0f2ec3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M cmk/fetchers/_base.py M cmk/fetchers/program.py Log Message: ----------- Some fetcher / checker logging improvements It is important to have helpful debug logging in this new area to be able to track down issues in test or customer environments without having to dig into the code. Change-Id: I20c836d22397319a11a47984c46550b3603d21d6 Compare: https://github.com/tribe29/checkmk/compare/c2bae1a1b945...74b5f728283c

3 years, 9 months

[tribe29/checkmk] c2bae1: Use logger in SNMP backends

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c2bae1a1b94535ad8db2bfadfdb44c996831bdbf https://github.com/tribe29/checkmk/commit/c2bae1a1b94535ad8db2bfadfdb44c996… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/data_sources/snmp.py M cmk/base/modes/check_mk.py M cmk/fetchers/factory.py M cmk/fetchers/snmp.py M cmk/snmplib/type_defs.py M tests/unit/cmk/fetchers/test_classic_snmp.py M tests/unit/cmk/lib/test_snmplib_snmp_scan.py M tests/unit/cmk/lib/test_snmplib_snmp_table.py Log Message: ----------- Use logger in SNMP backends Executing the SNMP fetcher with increased log level resulted in a terminated fetcher because it produced some output using console.verbose and console.vverbose which broke the core / fetcher protocol. This resulted in the following errors in the cmc.log: === 2020-08-31 10:36:28 [7] [fetcher pool scheduler] unscheduling service "snmp;Check_MK" at 2020-08-31 10:36:28 2020-08-31 10:36:28 [6] [fetcher pool] [fetcher pool 128944] Execute data source 2020-08-31 10:36:28 [7] [fetcher pool] [fetcher pool 128944] hr_cpu: Fetching data 2020-08-31 10:36:28 [2] [fetcher pool] [fetcher pool 128944] Unsupported protocol in fetcher header: 'Executing BULKWALK of ".1.3.6.1.' 2020-08-31 10:36:28 [2] [fetcher pool] [fetcher pool 128944] cannot read fetcher header: Bad message 2020-08-31 10:36:28 [7] [fetcher pool scheduler] scheduling service "snmp;Check_MK" at 2020-08-31 10:37:28 2020-08-31 10:36:29 [5] [fetcher pool] [fetcher pool 128944] aborting running fetcher: 2020-08-31 10:36:29 [7] [fetcher pool] [fetcher pool 128944] waiting for termination 2020-08-31 10:36:29 [5] [fetcher pool] [fetcher pool 128944] terminated 2020-08-31 10:36:29 [5] [fetcher pool] [fetcher pool 130049] started, commandline: /omd/sites/heute/bin/fetcher === This commit adds loggers to the SNMP backends and changes all output to use the logger. This makes the fetchers automatically handle the output correctly. Change-Id: I86d014e2ca30686bf5f87f98c46ac350f071cfe6

3 years, 9 months

[tribe29/checkmk] a0c4df: Consistently use mutex, no need for atomic.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a0c4dfaca0ff63d42ee1081356db6d8d8bb66929 https://github.com/tribe29/checkmk/commit/a0c4dfaca0ff63d42ee1081356db6d8d8… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M livestatus/src/Queue.h Log Message: ----------- Consistently use mutex, no need for atomic. Change-Id: I22185bfd510030058ae5ba2db04a8510771ebbf6 Commit: 7de7eda02f6ec8f543ec5bbd61c1e1886fcdf00a https://github.com/tribe29/checkmk/commit/7de7eda02f6ec8f543ec5bbd61c1e1886… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M livestatus/src/Queue.h Log Message: ----------- Avoid "hurry up and wait" scenarios. See e.g. https://en.cppreference.com/w/cpp/thread/condition_variable/notify_one CMK-5250 Change-Id: I85871606920fc32f951f6d94fb9588ec807d989d Commit: 6aa422fbfa240eb13f2cbebee012a2cb94bb8c57 https://github.com/tribe29/checkmk/commit/6aa422fbfa240eb13f2cbebee012a2cb9… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M livestatus/src/Queue.h Log Message: ----------- A fully synchronized bounded queue needs 2 condition variables. Because we have 2 potentially blocking operations (push and pop), we need 2 condition variables, too. CMK-5250 Change-Id: I7f9b267fe43398f7d2d021e8423e9c87922d017b Compare: https://github.com/tribe29/checkmk/compare/ae8929b39afa...6aa422fbfa24

3 years, 9 months

[tribe29/checkmk] 72c8c4: Race condition free file removal

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 72c8c4c9dc2f633ec3fb5789abe69fb50eafcd8c https://github.com/tribe29/checkmk/commit/72c8c4c9dc2f633ec3fb5789abe69fb50… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M cmk/base/inventory.py Log Message: ----------- Race condition free file removal Change-Id: I16333f5ce9c7ffe542761133c95493b6f401bfde Commit: b73c3b19e8505fbbb22a1f77747e4cabcf78b5da https://github.com/tribe29/checkmk/commit/b73c3b19e8505fbbb22a1f77747e4cabc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M cmk/base/plugins/agent_based/livestatus_status.py M tests/unit/cmk/base/plugins/agent_based/test_livestatus_status.py Log Message: ----------- livestatus_status: Make compatible with checker/fetcher mode * Skip Checkmk helper testing when checker/fetcher mode is enabled. There is no Checkmk helper running in this mode. * Naming Check_MK -> Checkmk along the way Change-Id: I965ee4e89bbcb377f27c20beb19bf3579fdf4f1f Commit: 49ef069d4ce66f9d724f00939a6070dab193d45c https://github.com/tribe29/checkmk/commit/49ef069d4ce66f9d724f00939a6070dab… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M cmk/base/checking.py M cmk/base/data_sources/_data_sources.py M cmk/base/discovery.py M cmk/fetchers/controller.py M cmk/fetchers/type_defs.py Log Message: ----------- Minimal approach to make checker work This change uses the exact same logic as the Check helpers. Except that it uses the raw data from the fetcher instead of fetching new information on it's own. In one of the next steps we should refactor the functions changed here (meaning check_inventory and do_check including the decorator and update_host_sections). It is probably a good way to split them up into separate steps to make them reusable in a cleaner way. With enabled checkers / fetchers the Check_MK service now produces a crash as result. This happens in some parse function because the data transported from fetcher to checker breaks the encoding. This will be fixed in one of the next commits. Add some useful debug logging along the way. Change-Id: Ic65daa545be40f00afb9e60c273f0d6b20deb3ba Commit: ae8929b39afae407b490544bc5843eb015b2c0d6 https://github.com/tribe29/checkmk/commit/ae8929b39afae407b490544bc5843eb01… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M cmk/fetchers/controller.py Log Message: ----------- Fix transport of raw agent data from fetcher Previously the bytes were decoded in a wrong way. We don't have the most efficient transport yet, but it's working now :). Change-Id: I2fe5f0582ac975003089dc87dd900f6c962fb789 Compare: https://github.com/tribe29/checkmk/compare/e5e9fca3bc08...ae8929b39afa

3 years, 9 months

[tribe29/checkmk] e5e9fc: [CMK-5316] - introduce simple protocol to keep fet...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e5e9fca3bc0865ab182774a93211839418ffb06d https://github.com/tribe29/checkmk/commit/e5e9fca3bc0865ab182774a9321183941… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2020-08-31 (Mon, 31 Aug 2020) Changed paths: M cmk/fetchers/controller.py M tests/unit/cmk/fetchers/test_controller.py Log Message: ----------- [CMK-5316] - introduce simple protocol to keep fetcher payloads Based on controller.Header First commit from. In next commit this protocol will replace json protocol Change-Id: I7c5596b0ad82896ef6ad6f8ebbad44156d42e8d5

3 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2020