Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 450e170e918cf2d9a541ed86ee5798acb0b9721f
https://github.com/tribe29/checkmk/commit/450e170e918cf2d9a541ed86ee5798acb…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-07-02 (Thu, 02 Jul 2020)
Changed paths:
M tests-py3/pylint/test_pylint.py
Log Message:
-----------
Fix formatting
Change-Id: I338e24080a9ce56ef42830e90380b8bbee6a606e
Commit: 1b1ff44a67f59f4d83e55e9219bb1170710d361a
https://github.com/tribe29/checkmk/commit/1b1ff44a67f59f4d83e55e9219bb11707…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-07-02 (Thu, 02 Jul 2020)
Changed paths:
A tests-py3/unit/cmk/base/data_sources/conftest.py
A tests-py3/unit/cmk/base/data_sources/test_cmd_caching.py
M tests-py3/unit/cmk/base/data_sources/test_snmp_data_source.py
R tests-py3/unit/cmk/base/test_data_sources_cmd_caching.py
Log Message:
-----------
Refactor some data sources tests
Global variables:
- Reset the mutable state from the data sources *after* the
test. Resetting before the tests is a bad idea as the last
test pollutes the state.
- Reset global mutable state by default in every data source
test by moving the fixture in the package scope.
- Replace a global variable used *in the tests* with
library features.
Readability:
- Shorten names by skipping namespace, the scope of the tests
is short enough that there is no ambiguity.
- Reformat to better highlight the structure.
- Do not pass fixtures as argument when they are not used in
the body. Seamingly unused arguments are noisy.
- Do not put teardown code in `try/finally:`. Teardown code in
the test body is but distracting noise. After all, the
teardown section of the test framework fullfills this role.
- Fixturize patch when possible. The patch still does two
things: actually patching and some sanity checks. It is not
clear whether the sanity checks (of global variables!) really
needs to be performed each time `DataSource._run` is called or
whether it could not be in the test body.
Change-Id: If7b57ecffe96f4afe2094ae3444804d37f4e1d79
Commit: 11b6ee3293dcca4f2dcc984f9cb2b660c8cb0253
https://github.com/tribe29/checkmk/commit/11b6ee3293dcca4f2dcc984f9cb2b660c…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-07-02 (Thu, 02 Jul 2020)
Changed paths:
M cmk/base/data_sources/_data_sources.py
M cmk/base/data_sources/host_sections.py
M cmk/base/inventory.py
M tests-py3/unit/cmk/base/data_sources/test_host_sections.py
Log Message:
-----------
Consistently instantiate MHS
This also does not leak the MHS store from the MultiHostSections class.
CMK-4726
Change-Id: Ia54edca842994c736c4bb2f887aae1c32fb3bda3
Commit: fb94a5b8a1e29a8d9fcb5c4d1f1a608f21f18f9f
https://github.com/tribe29/checkmk/commit/fb94a5b8a1e29a8d9fcb5c4d1f1a608f2…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-07-02 (Thu, 02 Jul 2020)
Changed paths:
M cmk/base/data_sources/_data_sources.py
Log Message:
-----------
Simpler max_cachefile_age handling in DS
`max_cachefile_age` was actually one of three constants:
- the value given to the function if there is one
- config.cluster_max_cachefile_age for clusters
- config.check_max_cachefile_age otherwise
However, the code was treating it as if it were a function of the host.
We gain some clarity by setting its value once at the start of the
method.
CMK-4838
Change-Id: I32647af7442754e8f96fdcf4ab0ef04d51746921
Commit: bcec284d56ddd3189add2e44ae00699230c9ddda
https://github.com/tribe29/checkmk/commit/bcec284d56ddd3189add2e44ae0069923…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-07-02 (Thu, 02 Jul 2020)
Changed paths:
M cmk/base/checking.py
M cmk/base/data_sources/host_sections.py
M cmk/base/discovery.py
M tests-py3/unit/cmk/base/data_sources/test_data_sources.py
M tests-py3/unit/cmk/base/data_sources/test_host_sections.py
Log Message:
-----------
Mapping API for MultiHostSections
MultiHostSections is an AbstractHostSections container.
We make this fact clear by providing the Mapping API to the
class. We further avoid leaking the `Dict[HostKey,
AbstractHostSections]` store.
We remove the `MultiHostSectionsData` type. `MultiHostSections`
also *is* a `Mapping[HostKey, AbstractHostSections]` and should
be used instead.
CMK-4838
Change-Id: I5fb845c42b0ea030a9249b293d6c1db399592eb3
Commit: 3dc8a786225398e16bac47cf3f2f50388ab45ae4
https://github.com/tribe29/checkmk/commit/3dc8a786225398e16bac47cf3f2f50388…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-07-02 (Thu, 02 Jul 2020)
Changed paths:
M cmk/base/data_sources/_data_sources.py
M cmk/base/dump_host.py
Log Message:
-----------
Readability: DataSources.get_host_sections()
- Use short and consistent names for the variables
- Shorten long lines
DataSources: Remove one more method
CMK-4838
Change-Id: I6a98c0110b661ab4bbacd5527294cc8d266464bd
Compare: https://github.com/tribe29/checkmk/compare/2d26eabbff8e...3dc8a7862253
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 468ea8e7e4fbe4c97a9c38ae81ada7159a54c358
https://github.com/tribe29/checkmk/commit/468ea8e7e4fbe4c97a9c38ae81ada7159…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-07-01 (Wed, 01 Jul 2020)
Changed paths:
M tests-py3/pylint/test_pylint.py
Log Message:
-----------
List the long-running modules first on the pylint commandline.
The normal modules taking the longest time take max. 10sec, while the epic
all-checks-in-one-module thingy takes 250sec alone (the combined bakery
plugins don't matter here).
Pylint seems to process the files in commandline order, so listing this
monster first will reduce the overall time when pylint runs parallel jobs.
Concrete numbers on a Mac Book: 7min3sec => 5min14sec. Not bad for moving a
few lines around...
Change-Id: I1a8914988398bad1b342ed82756990f70262ef6a
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 62441635c2c462dc236321bdf021ce4b1711b803
https://github.com/tribe29/checkmk/commit/62441635c2c462dc236321bdf021ce4b1…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-07-01 (Wed, 01 Jul 2020)
Changed paths:
M active_checks/check_cpu_peaks
M active_checks/check_mail
M active_checks/check_mail_loop
M active_checks/check_sql
M agents/plugins/mk_postgres.py
M agents/wnx/plugins/prototype/db2/mk_db2.checkmk.py
M bin/fetcher
M bin/livedump
M bin/mkbackup
M bin/mkbench
M checks/arista_bgp
M checks/aws.include
M checks/aws_dynamodb_summary
M checks/aws_ebs_limits
M checks/aws_rds_limits
M checks/aws_wafv2_summary
M checks/df.include
M checks/docker_container_diskstat
M checks/k8s_pods_cm
M checks/temperature.include
M cmk/base/check_table.py
M cmk/base/plugins/agent_based/utils/checkpoint.py
M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py
M doc/helpers/import-memory
M inventory/oracle_systemparameter
M livestatus/api/python/livestatus.py
M omd/packages/maintenance/diskspace
M omd/packages/maintenance/merge-crontabs
M omd/packages/omd/omdlib/backup.py
M omd/packages/omd/omdlib/certs.py
M omd/packages/omd/omdlib/config_hooks.py
M omd/packages/omd/omdlib/contexts.py
M omd/packages/omd/omdlib/dialog.py
M omd/packages/omd/omdlib/init_scripts.py
M omd/packages/omd/omdlib/main.py
M omd/packages/omd/omdlib/skel_permissions.py
M omd/packages/omd/omdlib/users_and_groups.py
M omd/packages/omd/omdlib/utils.py
M omd/packages/omd/omdlib/version_info.py
M tests-py3/gui_crawl/test_gui_crawl.py
M tests-py3/integration/cmk/base/test_modes.py
M tests-py3/integration/cmk/gui/test_webapi.py
M tests-py3/integration/cmk/lib/snmplib/test_snmp_table.py
M tests-py3/integration/cmk/utils/test_msi_engine_it.py
M tests-py3/integration/livestatus/test_livestatus.py
M tests-py3/integration/notifications/test_unreachable_notifications.py
M tests-py3/scripts/install-cmk.py
M tests-py3/scripts/run-dockerized.py
M tests-py3/testlib/containers.py
M tests-py3/testlib/event_console.py
M tests-py3/testlib/site.py
M tests-py3/testlib/utils.py
M tests-py3/unit/agents/special/test_special_agent_args.py
M tests-py3/unit/checks/checktestlib.py
M tests-py3/unit/checks/generictests/crashtest.py
M tests-py3/unit/checks/generictests/regression.py
M tests-py3/unit/checks/test_hp_msa_volume.py
M tests-py3/unit/checks/test_ibm_mq_channels.py
M tests-py3/unit/checks/test_ibm_mq_include.py
M tests-py3/unit/checks/test_ibm_mq_managers.py
M tests-py3/unit/checks/test_ibm_mq_queues.py
M tests-py3/unit/checks/test_ps.py
M tests-py3/unit/cmk/base/api/agent_based/register/test_check_plugins.py
M tests-py3/unit/cmk/base/api/agent_based/register/test_section_plugins.py
M tests-py3/unit/cmk/base/api/agent_based/test_utils_value_store.py
M tests-py3/unit/cmk/base/data_sources/test_program_data_source.py
M tests-py3/unit/cmk/base/data_sources/test_snmp_data_source.py
M tests-py3/unit/cmk/base/data_sources/test_tcp_data_source.py
M tests-py3/unit/cmk/base/test_check_api.py
M tests-py3/unit/cmk/base/test_discovered_labels.py
M tests-py3/unit/cmk/ec/test_ec_status.py
M tests-py3/unit/cmk/ec/test_rule_matching.py
M tests-py3/unit/cmk/gui/plugins/test_metrics_utils.py
M tests-py3/unit/cmk/gui/plugins/views/test_icons.py
M tests-py3/unit/cmk/gui/test_sidebar.py
M tests-py3/unit/cmk/gui/test_userdb_ldap_connector.py
M tests-py3/unit/cmk/gui/test_views.py
M tests-py3/unit/cmk/gui/test_visuals.py
M tests-py3/unit/cmk/gui/utils/test_html.py
M tests-py3/unit/cmk/gui/watolib/test_config_sync.py
M tests-py3/unit/cmk/gui/wsgi/test_wsgi_router.py
M tests-py3/unit/cmk/lib/test_snmplib_utils.py
M tests-py3/unit/cmk/special_agents/test_utils_datacache.py
M tests-py3/unit/cmk/utils/rulesets/test_ruleset_transformer.py
M tests-py3/unit/cmk/utils/rulesets/test_tuple_rulesets.py
M tests-py3/unit/cmk/utils/structured_data/test_structured_data.py
M tests-py3/unit/cmk/utils/test_crash_reporting.py
M tests-py3/unit/cmk/utils/test_man_pages.py
M tests-py3/unit/cmk/utils/test_msi_patch.py
M tests-py3/unit/cmk/utils/test_notify_utils.py
M tests-py3/unit/cmk/utils/test_packaging.py
M tests-py3/unit/cmk/utils/test_piggyback.py
M tests-py3/unit/cmk/utils/test_python_printer.py
M tests-py3/unit/omdlib/test_omdlib_main.py
M tests-py3/unit/test_permissions.py
M werk
Log Message:
-----------
com2ann the remaining misc. modules.
Change-Id: I89a70d53ac6a4ac6607884dcce138dfc8c25911e
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 572b3b54b7ed12dd954db4bd392c3aef3383f048
https://github.com/tribe29/checkmk/commit/572b3b54b7ed12dd954db4bd392c3aef3…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-07-01 (Wed, 01 Jul 2020)
Changed paths:
M cmk/base/api/agent_based/checking_types.py
M cmk/base/api/agent_based/register/check_plugins.py
M cmk/base/api/agent_based/register/check_plugins_legacy.py
M cmk/base/api/agent_based/register/section_plugins.py
M cmk/base/api/agent_based/register/section_plugins_legacy.py
M cmk/base/api/agent_based/register/section_plugins_legacy_scan_function.py
M cmk/base/api/agent_based/render.py
M cmk/base/api/agent_based/utils.py
M cmk/base/api/agent_based/value_store.py
M cmk/base/autochecks.py
M cmk/base/automations/__init__.py
M cmk/base/automations/check_mk.py
M cmk/base/backup.py
M cmk/base/caching.py
M cmk/base/check_api.py
M cmk/base/check_api_utils.py
M cmk/base/check_table.py
M cmk/base/check_utils.py
M cmk/base/checking.py
M cmk/base/compress_history.py
M cmk/base/config.py
M cmk/base/core.py
M cmk/base/core_config.py
M cmk/base/core_factory.py
M cmk/base/core_nagios.py
M cmk/base/cpu_tracking.py
M cmk/base/crash_reporting.py
M cmk/base/decorator.py
M cmk/base/default_config/base.py
M cmk/base/default_config/notify.py
M cmk/base/diagnostics.py
M cmk/base/discovered_labels.py
M cmk/base/discovery.py
M cmk/base/dump_host.py
M cmk/base/events.py
M cmk/base/exceptions.py
M cmk/base/export.py
M cmk/base/inventory.py
M cmk/base/inventory_plugins.py
M cmk/base/ip_lookup.py
M cmk/base/item_state.py
M cmk/base/localize.py
M cmk/base/modes/__init__.py
M cmk/base/modes/check_mk.py
M cmk/base/nagios_utils.py
M cmk/base/notify.py
M cmk/base/obsolete_output.py
M cmk/base/packaging.py
M cmk/base/parent_scan.py
M cmk/base/plugins/agent_based/hr_mem.py
M cmk/base/plugins/agent_based/local.py
M cmk/base/plugins/agent_based/omd_apache.py
M cmk/base/plugins/agent_based/utils/ucd_hr_detection.py
M cmk/base/prediction.py
M cmk/base/profiling.py
M cmk/base/rrd.py
M cmk/base/section.py
M cmk/base/utils.py
M cmk/fetchers/controller.py
M cmk/gui/plugins/views/icons/utils.py
M cmk/special_agents/agent_jolokia.py
M cmk/utils/check_utils.py
Log Message:
-----------
com2ann the rest of cmk/.
Change-Id: I106854bc150ff1e9eb51f215e8439676cd90b29a
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 028f4a3def290fb88e55457e9fea9a8d809dba1c
https://github.com/tribe29/checkmk/commit/028f4a3def290fb88e55457e9fea9a8d8…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-07-01 (Wed, 01 Jul 2020)
Changed paths:
M cmk/gui/mobile.py
M cmk/gui/views.py
M cmk/gui/visuals.py
M tests-py3/unit/cmk/gui/test_visuals.py
Log Message:
-----------
Fix wrong context computation from URL
* The views (regular + mobile GUI) did not correctly hand over their
single infos to visuals.get_context_from_uri_vars which then was
unable to handle the single info variables correctly.
* visuals.get_context_from_uri_vars itself did handle all filter
variables that are related to the given infos as single info variables.
This bug had no impact before, because of the issue above.
Change-Id: Iff64af30943e02ebe256609975553349b642c7f5
Commit: 5e95d971d6def685810b54d60c4fd4dab9d410db
https://github.com/tribe29/checkmk/commit/5e95d971d6def685810b54d60c4fd4dab…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-07-01 (Wed, 01 Jul 2020)
Changed paths:
M cmk/gui/visuals.py
Log Message:
-----------
Reduce some nesting levels
Change-Id: Ied47e2b73dd813a09b7f7f8d3c963e2194bc41ed
Commit: 8aca401adc8197bf8673410ea7a84c33171bf526
https://github.com/tribe29/checkmk/commit/8aca401adc8197bf8673410ea7a84c331…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-07-01 (Wed, 01 Jul 2020)
Changed paths:
M agents/plugins/Makefile
Log Message:
-----------
py2 files: Add executable flag to prevent issues with the permission test
Change-Id: Icdd5896a9a9ef58b3e80ff8dee21754d17b16dca
Compare: https://github.com/tribe29/checkmk/compare/c90c5badc4b4...8aca401adc81
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: c90c5badc4b4794bbb3e0f780da52061b794db0d
https://github.com/tribe29/checkmk/commit/c90c5badc4b4794bbb3e0f780da52061b…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-07-01 (Wed, 01 Jul 2020)
Changed paths:
M cmk/base/data_sources/_cache.py
M cmk/base/data_sources/_data_sources.py
M cmk/base/data_sources/_utils.py
M cmk/base/data_sources/abstract.py
M cmk/base/data_sources/agent.py
M cmk/base/data_sources/host_sections.py
M cmk/base/data_sources/ipmi.py
M cmk/base/data_sources/piggyback.py
M cmk/base/data_sources/programs.py
M cmk/base/data_sources/snmp.py
M cmk/base/data_sources/tcp.py
Log Message:
-----------
com2ann cmk/base/data_sources/*
* `com2ann` on the directory
* `yapf` the files
* fix the recursive types by hand
Change-Id: I129471a1e86da9cb747bb0a4012a42109ef91dbb
