Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 239308ec827863b22715a33cd40a7909ce06d5f6
https://github.com/tribe29/checkmk/commit/239308ec827863b22715a33cd40a7909c…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
A .werks/11217
M agents/windows/plugins/mssql.vbs
M checks/mssql_tablespaces
M tests/unit/checks/generictests/datasets/mssql_tablespaces_regression.py
Log Message:
-----------
11217 Configurable timeouts for MSSQL agent plugin
This werk adds the option to configure timeouts for the MSSQL agent
plugin (rule "Microsoft SQL Server (Windows)"). There are two types of
timeouts. The connection timeout is triggered when the agent plugin takes
too long to connect to an instance. The command timeout controls the
time available for executing commands such as SQL queries on the instances.
If a connection timeout is triggered, the plugin skips the entire instance
and continues with the next one. Note that this werk also changes the default
connection timeout from 2 seconds to the default value used by ADO (15 s).
In case of a command timeout, only the current command is skipped and the
plugin continues with the next command on the same instance.
Finally, this werk also fixes a bug in the handling of errors for the check
<tt>mssql_tablespaces<\tt>. Errors such as timeouts reported by the agent
plugin are now displayed in the GUI and the check goes to CRITICAL instead of
UNKNOWN.
Change-Id: I93b8b8182a2c4738dede656362ab6d29389fffab
Commit: 3b78609ac51192faf3cb34902afbfeb49bca447e
https://github.com/tribe29/checkmk/commit/3b78609ac51192faf3cb34902afbfeb49…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
A .werks/11218
M agents/windows/plugins/mssql.vbs
Log Message:
-----------
11218 MSSQL Agent Plugin: Use MSOLEDBSQL if available
The MSSQL agent plugin now tries to connect to the instances using the
OLE DB provider <tt>MSOLEDBSQL<\tt>. If this fails, the plugin falls back
to <tt>SQLOLEDB<\tt>, which is the provider that was used up to now.
Change-Id: Ic1ea79c281923729ec143d1eda7a17149207eb8e
Compare: https://github.com/tribe29/checkmk/compare/063c7a4d2585...3b78609ac511
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 02d3c32da12c6fa2792132526872f5b902064d06
https://github.com/tribe29/checkmk/commit/02d3c32da12c6fa2792132526872f5b90…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
M livestatus/src/DynamicHostFileColumn-impl.cc
M livestatus/src/HostFileColumn-impl.cc
Log Message:
-----------
Some IWYU fixes.
Making the compiler, the linker, *and* IWYU happy at the same time is a kind
of black art. :-/
Change-Id: Ibd7ec59125c7137c05ac24ae8f6601b0e1975d49
Commit: 2549e623379305e50d37e2f36dacda9ff8679775
https://github.com/tribe29/checkmk/commit/2549e623379305e50d37e2f36dacda9ff…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
R checks/chrony
A cmk/base/plugins/agent_based/chrony.py
M cmk/utils/migrated_check_variables.py
M tests/testlib/base.py
R tests/unit/checks/generictests/datasets/chrony_1_regression.py
R tests/unit/checks/generictests/datasets/chrony_2_regression.py
R tests/unit/checks/generictests/datasets/chrony_3_regression.py
R tests/unit/checks/generictests/datasets/chrony_4_regression.py
R tests/unit/checks/generictests/datasets/chrony_5_regression.py
R tests/unit/checks/generictests/datasets/chrony_6_regression.py
A tests/unit/cmk/base/plugins/agent_based/test_chrony.py
Log Message:
-----------
chrony: migrate to new API
Change-Id: I6bb78a67174374f595bcfd44e1ae10c5b59bcd0d
Compare: https://github.com/tribe29/checkmk/compare/cb42bfd02338...2549e6233793
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 30e50503db206fbfacfaad953e73c7a2d2b23617
https://github.com/tribe29/checkmk/commit/30e50503db206fbfacfaad953e73c7a2d…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
M cmk/base/plugins/agent_based/utils/diskstat.py
M tests/unit/cmk/base/plugins/agent_based/test_aix_diskiod.py
M tests/unit/cmk/base/plugins/agent_based/utils/test_diskstat_utils.py
Log Message:
-----------
Refactored cmk/base/plugins/agent_based/utils/diskstat.py and adjusted
unit test
Change-Id: I720101383dc951ac5355b8c33cad559974e291d0
Commit: f36c3d352f1cb2ee4494ec26ea85e75e8434e711
https://github.com/tribe29/checkmk/commit/f36c3d352f1cb2ee4494ec26ea85e75e8…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
A .werks/11224
R checks/winperf_phydisk
A cmk/base/plugins/agent_based/winperf_phydisk.py
M tests/testlib/base.py
R tests/unit/checks/generictests/datasets/winperf_phydisk_regression.py
A tests/unit/cmk/base/plugins/agent_based/test_winperf_phydisk.py
Log Message:
-----------
11224 FIX winperf_phydisk: Interpret averaging parameter correctly
The check <tt>winperf_phydisk<\tt> now interprets the timespan parameter for
computing averaged values correctly (ruleset "Levels on disk IO (old style
checks)"). Previously, the user was supposed to specify a value in minutes,
however, the check plugin actually expected a value in seconds. This has been
corrected.
This change is incompatible, since the check plugin now behaves differently
for a given averaging timespan. User-defined rules might have to be adjusted
to account for this.
This change also migrates the section and the check plugin winperf_phydisk
to the new API.
Change-Id: I6d74b71352fd516a62eefcb748f9b291d445708b
Commit: 3096a4d177adbe8ee02178ab754132509384033e
https://github.com/tribe29/checkmk/commit/3096a4d177adbe8ee02178ab754132509…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
A livestatus/src/DynamicHostFileColumn-impl.cc
M livestatus/src/DynamicHostFileColumn.cc
M livestatus/src/DynamicHostFileColumn.h
A livestatus/src/HostFileColumn-impl.cc
M livestatus/src/HostFileColumn.cc
M livestatus/src/HostFileColumn.h
M livestatus/src/Makefile.am
M livestatus/src/TableCrashReports.cc
M livestatus/src/TableHosts.cc
Log Message:
-----------
Preparatory step: Templatize HostFileColumn and DynamicHostFileColumn.
Explicit template instatiation to satisfy the linker is horrible...
Change-Id: I87613ed902832347cb068648ac2a3bd03d5dad9b
Commit: 127f5baf6576d68eb83ec9a71368a28f522a914a
https://github.com/tribe29/checkmk/commit/127f5baf6576d68eb83ec9a71368a28f5…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
M livestatus/src/DynamicHostFileColumn.cc
M livestatus/src/DynamicHostFileColumn.h
M livestatus/src/HostFileColumn.cc
M livestatus/src/HostFileColumn.h
M livestatus/src/TableCrashReports.cc
M livestatus/src/TableHosts.cc
Log Message:
-----------
Move columnData calls into HostFileColumn, no Table should ever call this.
Change-Id: I429306c7c0b066a3b0864bcb22ae2fe9da1ce277
Commit: cb42bfd023381c79ebb4104ca73d935b58cd0980
https://github.com/tribe29/checkmk/commit/cb42bfd023381c79ebb4104ca73d935b5…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
M livestatus/src/DynamicHostFileColumn.cc
M livestatus/src/DynamicHostFileColumn.h
M livestatus/src/HostFileColumn.cc
M livestatus/src/HostFileColumn.h
M livestatus/src/TableCrashReports.cc
Log Message:
-----------
Simplify type signature a bit.
Change-Id: Ida848e3f97200ff5569bd966920499be35018b1d
Compare: https://github.com/tribe29/checkmk/compare/78c4bc4da667...cb42bfd02338
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: dc8e478cd21283dce88efc9d404defdd574814dd
https://github.com/tribe29/checkmk/commit/dc8e478cd21283dce88efc9d404defdd5…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
M cmk/gui/backup.py
M cmk/gui/bi.py
M cmk/gui/breadcrumb.py
M cmk/gui/crash_reporting.py
M cmk/gui/dashboard.py
M cmk/gui/logwatch.py
M cmk/gui/main_menu.py
M cmk/gui/node_visualization.py
M cmk/gui/notifications.py
M cmk/gui/notify.py
M cmk/gui/pagetypes.py
M cmk/gui/plugins/main_menu/__init__.py
M cmk/gui/plugins/main_menu/mega_menus.py
M cmk/gui/plugins/main_menu/utils.py
M cmk/gui/plugins/sidebar/utils.py
M cmk/gui/plugins/views/utils.py
M cmk/gui/plugins/wato/utils/base_modes.py
M cmk/gui/sidebar.py
M cmk/gui/type_defs.py
M cmk/gui/views.py
M cmk/gui/visuals.py
M cmk/gui/wato/page_handler.py
M cmk/gui/wato/user_profile.py
M cmk/gui/werks.py
Log Message:
-----------
Resolve two import cycles
* move make_*_breadcrumb functions to cmk.gui.breadcrumb
* move MegaMenu, TopicMenuTopic, TopicMenuItem to cmk.gui.type_defs
An import cycles between cmk.gui.pagetypes und
cmk.gui.plugins.main_menu.mega_menus remains.
Change-Id: I4345f5c0327b598d6e3e949a5f08c52abdc48873
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 6891107001c566f580c800118795a47a210463bd
https://github.com/tribe29/checkmk/commit/6891107001c566f580c800118795a47a2…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
M cmk/base/api/agent_based/checking_classes.py
M cmk/base/api/agent_based/register/check_plugins_legacy.py
M cmk/base/api/agent_based/type_defs.py
M cmk/base/checking.py
M cmk/base/config.py
M cmk/base/discovery.py
M cmk/base/plugins/agent_based/agent_based_api/v0/type_defs.py
M tests/unit/cmk/base/api/agent_based/test_checking_classes.py
Log Message:
-----------
Check API: move Parameters to type_defs
Change-Id: I4cad6360244043126a61de20282ee42f1466710d
Commit: ccd5d9149fee7a0877ad07f4ef2c6fe1a09c41c0
https://github.com/tribe29/checkmk/commit/ccd5d9149fee7a0877ad07f4ef2c6fe1a…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
M cmk/base/api/agent_based/register/check_plugins.py
M cmk/base/api/agent_based/register/utils.py
M tests/unit/cmk/base/api/agent_based/register/test_check_plugins.py
Log Message:
-----------
Check API: move three functions in prep for inventory
Change-Id: Iaa340107035904a2c3264d51a9fb00775601337e
Commit: 82079c48324342932afe970bf28c76cca77b5f01
https://github.com/tribe29/checkmk/commit/82079c48324342932afe970bf28c76cca…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
M cmk/base/automations/check_mk.py
M cmk/base/data_sources/_abstract.py
M cmk/base/data_sources/_data_sources.py
M cmk/base/data_sources/ipmi.py
M cmk/base/data_sources/piggyback.py
M cmk/base/data_sources/programs.py
M cmk/base/data_sources/snmp.py
M cmk/base/data_sources/tcp.py
M cmk/base/inventory.py
M cmk/base/modes/check_mk.py
M tests/unit/cmk/base/data_sources/test_cmd_caching.py
M tests/unit/cmk/base/data_sources/test_data_sources.py
M tests/unit/cmk/base/data_sources/test_host_sections.py
Log Message:
-----------
Turn one more class attr into meth arg
CMK-5044
Change-Id: Ifb042e28c97f3d8e5df16dd59d155ee86dd5eac0
Compare: https://github.com/tribe29/checkmk/compare/a83dc84a7d99...82079c483243
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 7723091884cbf9dd4dc4145e07d8d8397d6282dc
https://github.com/tribe29/checkmk/commit/7723091884cbf9dd4dc4145e07d8d8397…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
R livestatus/src/DoublePointerColumn.h
M livestatus/src/TableStatus.cc
M livestatus/src/global_counters.cc
M livestatus/src/global_counters.h
Log Message:
-----------
Replaced DoublePointerColumn with DoubleLambdaColumn.
Change-Id: I20ab2c87125d5afb31dbda113783e473b565bda7
Commit: 96bd6a4ea7dd4f68e99eb355bbd098573217602d
https://github.com/tribe29/checkmk/commit/96bd6a4ea7dd4f68e99eb355bbd098573…
Author: Frans Fürst <frans.fuerst(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
R checks/f5_bigip_cluster
R checks/f5_bigip_cluster_v11
A cmk/base/plugins/agent_based/f5_bigip_cluster.py
M cmk/base/plugins/agent_based/utils/f5_bigip.py
M tests/testlib/base.py
M tests/unit/checks/test_generic_legacy_conversion.py
A tests/unit/cmk/base/plugins/agent_based/test_f5_bigip_cluster.py
M tests/unit/cmk/gui/watolib/test_rulespecs.py
Log Message:
-----------
f5_bigip_cluster: migrate check to new API
Change-Id: Ie8732043bac02abd95003b533a53d120b07072e2
Commit: 2d98e3489bde8fef5c916b73e18cd1cb5e5721d4
https://github.com/tribe29/checkmk/commit/2d98e3489bde8fef5c916b73e18cd1cb5…
Author: Frans Fürst <frans.fuerst(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
R checks/f5_bigip_vcmpfailover
M cmk/base/plugins/agent_based/f5_bigip_cluster_status.py
A cmk/base/plugins/agent_based/f5_bigip_vcmpfailover.py
M cmk/base/plugins/agent_based/utils/f5_bigip.py
M tests/testlib/base.py
M tests/unit/checks/test_generic_legacy_conversion.py
A tests/unit/cmk/base/plugins/agent_based/test_f5_bigip_vcmpfailover.py
Log Message:
-----------
f5_bigip_vcmpfailover: migrate check to new API
Change-Id: I652207306eaeab4433844ca46ee2dd8f5746089b
Commit: 69c156c095d13fdfac0de796ac0367119ccb35fc
https://github.com/tribe29/checkmk/commit/69c156c095d13fdfac0de796ac0367119…
Author: Frans Fürst <frans.fuerst(a)tribe29.com>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
R checks/f5_bigip_vcmpguests
A cmk/base/plugins/agent_based/f5_bigip_vcmpguests.py
M tests/testlib/base.py
A tests/unit/cmk/base/plugins/agent_based/test_f5_bigip_vcmpguests.py
Log Message:
-----------
f5_bigip_vcmpguests: migrate check to new API
Change-Id: I6b3bb8b42fccfe4df220607a7d5e9b34eadab194
Compare: https://github.com/tribe29/checkmk/compare/11f460de7f69...69c156c095d1