Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 44b0d32b7ae916015a309d9faa68abb3ced031da
https://github.com/tribe29/checkmk/commit/44b0d32b7ae916015a309d9faa68abb3c…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M Makefile
M livestatus/src/Makefile.am
Log Message:
-----------
Use Clang 10 per default.
Change-Id: Iafad5e7550e916bec8c16eef76ae266dff2cda75
Commit: c51b735d7bd2e737fdf211a27949e63ec6591b5e
https://github.com/tribe29/checkmk/commit/c51b735d7bd2e737fdf211a27949e63ec…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M bin/mkeventd_open514.cc
M livestatus/api/c++/Livestatus.cc
M livestatus/api/c++/Livestatus.h
M livestatus/api/c++/demo.cc
M livestatus/src/Aggregator.h
M livestatus/src/AndingFilter.cc
M livestatus/src/AndingFilter.h
M livestatus/src/AttributeListAsIntColumn.cc
M livestatus/src/AttributeListAsIntColumn.h
M livestatus/src/AttributeListColumn.cc
M livestatus/src/AttributeListColumn.h
M livestatus/src/AttributeListLambdaColumn.h
M livestatus/src/AttributesLambdaColumn.cc
M livestatus/src/AttributesLambdaColumn.h
M livestatus/src/Average.cc
M livestatus/src/Average.h
M livestatus/src/BitMask.h
M livestatus/src/BlobColumn.cc
M livestatus/src/BlobColumn.h
M livestatus/src/BoolLambdaColumn.h
M livestatus/src/BoolPointerColumn.h
M livestatus/src/ChronoUtils.h
M livestatus/src/Column.cc
M livestatus/src/Column.h
M livestatus/src/ColumnFilter.cc
M livestatus/src/ColumnFilter.h
M livestatus/src/ColumnsColumn.cc
M livestatus/src/ColumnsColumn.h
M livestatus/src/CommentColumn.cc
M livestatus/src/CommentColumn.h
M livestatus/src/ContactGroupsColumn.cc
M livestatus/src/ContactGroupsColumn.h
M livestatus/src/ContactGroupsMemberColumn.cc
M livestatus/src/ContactGroupsMemberColumn.h
M livestatus/src/CountAggregator.cc
M livestatus/src/CountAggregator.h
M livestatus/src/CrashReport.cc
M livestatus/src/CrashReport.h
M livestatus/src/CustomTimeperiodColumn.cc
M livestatus/src/CustomTimeperiodColumn.h
M livestatus/src/CustomVarsDictColumn.cc
M livestatus/src/CustomVarsDictColumn.h
M livestatus/src/CustomVarsDictFilter.cc
M livestatus/src/CustomVarsDictFilter.h
M livestatus/src/CustomVarsExplicitColumn.cc
M livestatus/src/CustomVarsExplicitColumn.h
M livestatus/src/CustomVarsNamesColumn.cc
M livestatus/src/CustomVarsNamesColumn.h
M livestatus/src/CustomVarsValuesColumn.cc
M livestatus/src/CustomVarsValuesColumn.h
M livestatus/src/DoubleAggregator.h
M livestatus/src/DoubleColumn.cc
M livestatus/src/DoubleColumn.h
M livestatus/src/DoubleFilter.cc
M livestatus/src/DoubleFilter.h
M livestatus/src/DoublePointerColumn.h
M livestatus/src/DowntimeColumn.cc
M livestatus/src/DowntimeColumn.h
M livestatus/src/DowntimeOrComment.cc
M livestatus/src/DowntimeOrComment.h
M livestatus/src/DowntimesOrComments.cc
M livestatus/src/DowntimesOrComments.h
M livestatus/src/DynamicColumn.cc
M livestatus/src/DynamicColumn.h
M livestatus/src/DynamicEventConsoleReplicationColumn.cc
M livestatus/src/DynamicEventConsoleReplicationColumn.h
M livestatus/src/DynamicHostFileColumn.cc
M livestatus/src/DynamicHostFileColumn.h
M livestatus/src/DynamicHostRRDColumn.cc
M livestatus/src/DynamicHostRRDColumn.h
M livestatus/src/DynamicRRDColumn.cc
M livestatus/src/DynamicRRDColumn.h
M livestatus/src/DynamicServiceRRDColumn.cc
M livestatus/src/DynamicServiceRRDColumn.h
M livestatus/src/EventConsoleConnection.cc
M livestatus/src/EventConsoleConnection.h
M livestatus/src/FileSystemHelper.cc
M livestatus/src/Filter.h
M livestatus/src/HostContactsColumn.cc
M livestatus/src/HostContactsColumn.h
M livestatus/src/HostFileColumn.cc
M livestatus/src/HostFileColumn.h
M livestatus/src/HostGroupsColumn.cc
M livestatus/src/HostGroupsColumn.h
M livestatus/src/HostListColumn.cc
M livestatus/src/HostListColumn.h
M livestatus/src/HostListStateColumn.cc
M livestatus/src/HostListStateColumn.h
M livestatus/src/HostMetricsColumn.cc
M livestatus/src/HostMetricsColumn.h
M livestatus/src/HostRRDColumn.cc
M livestatus/src/HostRRDColumn.h
M livestatus/src/HostServiceState.h
M livestatus/src/HostSpecialDoubleColumn.cc
M livestatus/src/HostSpecialDoubleColumn.h
M livestatus/src/HostSpecialIntColumn.cc
M livestatus/src/HostSpecialIntColumn.h
M livestatus/src/InputBuffer.cc
M livestatus/src/InputBuffer.h
M livestatus/src/IntAggregator.h
M livestatus/src/IntColumn.cc
M livestatus/src/IntColumn.h
M livestatus/src/IntFilter.cc
M livestatus/src/IntFilter.h
M livestatus/src/IntLambdaColumn.h
M livestatus/src/ListColumn.cc
M livestatus/src/ListColumn.h
M livestatus/src/ListFilter.cc
M livestatus/src/ListFilter.h
M livestatus/src/ListLambdaColumn.h
M livestatus/src/LogCache.cc
M livestatus/src/LogCache.h
M livestatus/src/LogEntry.cc
M livestatus/src/LogEntry.h
M livestatus/src/LogEntryStringColumn.cc
M livestatus/src/LogEntryStringColumn.h
M livestatus/src/Logfile.cc
M livestatus/src/Logfile.h
M livestatus/src/Logger.cc
M livestatus/src/Logger.h
M livestatus/src/LogwatchListColumn.cc
M livestatus/src/LogwatchListColumn.h
M livestatus/src/Metric.cc
M livestatus/src/Metric.h
M livestatus/src/MetricsColumn.h
M livestatus/src/NullColumn.cc
M livestatus/src/NullColumn.h
M livestatus/src/OStreamStateSaver.h
M livestatus/src/OffsetBoolColumn.cc
M livestatus/src/OffsetBoolColumn.h
M livestatus/src/OffsetDoubleColumn.cc
M livestatus/src/OffsetDoubleColumn.h
M livestatus/src/OffsetIntColumn.cc
M livestatus/src/OffsetIntColumn.h
M livestatus/src/OffsetPerfdataColumn.cc
M livestatus/src/OffsetPerfdataColumn.h
M livestatus/src/OffsetSStringColumn.cc
M livestatus/src/OffsetSStringColumn.h
M livestatus/src/OffsetStringColumn.cc
M livestatus/src/OffsetStringColumn.h
M livestatus/src/OffsetStringHostMacroColumn.cc
M livestatus/src/OffsetStringHostMacroColumn.h
M livestatus/src/OffsetStringMacroColumn.cc
M livestatus/src/OffsetStringMacroColumn.h
M livestatus/src/OffsetStringServiceMacroColumn.cc
M livestatus/src/OffsetStringServiceMacroColumn.h
M livestatus/src/OffsetTimeColumn.cc
M livestatus/src/OffsetTimeColumn.h
M livestatus/src/OringFilter.cc
M livestatus/src/OringFilter.h
M livestatus/src/OutputBuffer.cc
M livestatus/src/OutputBuffer.h
M livestatus/src/PerfdataAggregator.cc
M livestatus/src/PerfdataAggregator.h
M livestatus/src/Poller.h
M livestatus/src/Query.cc
M livestatus/src/Query.h
M livestatus/src/Queue.h
M livestatus/src/RRDColumn.cc
M livestatus/src/RRDColumn.h
M livestatus/src/RegExp.cc
M livestatus/src/RegExp.h
M livestatus/src/Renderer.cc
M livestatus/src/Renderer.h
M livestatus/src/RendererBrokenCSV.cc
M livestatus/src/RendererBrokenCSV.h
M livestatus/src/RendererCSV.cc
M livestatus/src/RendererCSV.h
M livestatus/src/RendererJSON.cc
M livestatus/src/RendererJSON.h
M livestatus/src/RendererPython.cc
M livestatus/src/RendererPython.h
M livestatus/src/RendererPython3.cc
M livestatus/src/RendererPython3.h
M livestatus/src/ServiceContactsColumn.cc
M livestatus/src/ServiceContactsColumn.h
M livestatus/src/ServiceGroupMembersColumn.cc
M livestatus/src/ServiceGroupMembersColumn.h
M livestatus/src/ServiceGroupsColumn.cc
M livestatus/src/ServiceGroupsColumn.h
M livestatus/src/ServiceListColumn.cc
M livestatus/src/ServiceListColumn.h
M livestatus/src/ServiceListStateColumn.cc
M livestatus/src/ServiceListStateColumn.h
M livestatus/src/ServiceMetricsColumn.cc
M livestatus/src/ServiceMetricsColumn.h
M livestatus/src/ServiceRRDColumn.cc
M livestatus/src/ServiceRRDColumn.h
M livestatus/src/ServiceSpecialDoubleColumn.cc
M livestatus/src/ServiceSpecialDoubleColumn.h
M livestatus/src/ServiceSpecialIntColumn.cc
M livestatus/src/ServiceSpecialIntColumn.h
M livestatus/src/StatsColumn.cc
M livestatus/src/StatsColumn.h
M livestatus/src/Store.cc
M livestatus/src/Store.h
M livestatus/src/StringColumn.cc
M livestatus/src/StringColumn.h
M livestatus/src/StringFilter.cc
M livestatus/src/StringFilter.h
M livestatus/src/StringLambdaColumn.h
M livestatus/src/StringPointerColumn.h
M livestatus/src/StringUtils.cc
M livestatus/src/StringUtils.h
M livestatus/src/Table.cc
M livestatus/src/TableColumns.cc
M livestatus/src/TableColumns.h
M livestatus/src/TableCommands.cc
M livestatus/src/TableCommands.h
M livestatus/src/TableComments.cc
M livestatus/src/TableComments.h
M livestatus/src/TableContactGroups.cc
M livestatus/src/TableContactGroups.h
M livestatus/src/TableContacts.cc
M livestatus/src/TableContacts.h
M livestatus/src/TableCrashReports.cc
M livestatus/src/TableCrashReports.h
M livestatus/src/TableDowntimes.cc
M livestatus/src/TableDowntimes.h
M livestatus/src/TableEventConsole.h
M livestatus/src/TableEventConsoleEvents.cc
M livestatus/src/TableEventConsoleEvents.h
M livestatus/src/TableEventConsoleHistory.cc
M livestatus/src/TableEventConsoleHistory.h
M livestatus/src/TableEventConsoleReplication.cc
M livestatus/src/TableEventConsoleReplication.h
M livestatus/src/TableEventConsoleRules.cc
M livestatus/src/TableEventConsoleRules.h
M livestatus/src/TableEventConsoleStatus.cc
M livestatus/src/TableEventConsoleStatus.h
M livestatus/src/TableHostGroups.cc
M livestatus/src/TableHostGroups.h
M livestatus/src/TableHosts.cc
M livestatus/src/TableHosts.h
M livestatus/src/TableHostsByGroup.cc
M livestatus/src/TableHostsByGroup.h
M livestatus/src/TableLog.cc
M livestatus/src/TableLog.h
M livestatus/src/TableServiceGroups.cc
M livestatus/src/TableServiceGroups.h
M livestatus/src/TableServices.cc
M livestatus/src/TableServices.h
M livestatus/src/TableServicesByGroup.cc
M livestatus/src/TableServicesByGroup.h
M livestatus/src/TableServicesByHostGroup.cc
M livestatus/src/TableServicesByHostGroup.h
M livestatus/src/TableStateHistory.cc
M livestatus/src/TableStateHistory.h
M livestatus/src/TableStatus.cc
M livestatus/src/TableStatus.h
M livestatus/src/TableTimeperiods.cc
M livestatus/src/TableTimeperiods.h
M livestatus/src/TimeAggregator.h
M livestatus/src/TimeColumn.cc
M livestatus/src/TimeColumn.h
M livestatus/src/TimeFilter.cc
M livestatus/src/TimeFilter.h
M livestatus/src/TimePointerColumn.h
M livestatus/src/TimeperiodColumn.cc
M livestatus/src/TimeperiodColumn.h
M livestatus/src/TimeperiodsCache.cc
M livestatus/src/TimeperiodsCache.h
M livestatus/src/Triggers.cc
M livestatus/src/auth.cc
M livestatus/src/global_counters.cc
M livestatus/src/mk_inventory.cc
M livestatus/src/mk_inventory.h
M livestatus/src/mk_logwatch.cc
M livestatus/src/mk_logwatch.h
M livestatus/src/module.cc
M livestatus/src/opids.cc
M livestatus/src/opids.h
M livestatus/src/pnp4nagios.cc
M livestatus/src/pnp4nagios.h
M livestatus/src/strutil.cc
M livestatus/src/test/TableQueryHelper.cc
M livestatus/src/test/test_CrashReport.cc
M livestatus/src/test/test_CustomVarsDictFilter.cc
M livestatus/src/test/test_FileSystemHelper.cc
M livestatus/src/test/test_LogEntry.cc
M livestatus/src/test/test_Metric.cc
M livestatus/src/test/test_OffsetStringMacroColumn.cc
M livestatus/src/test/test_Queue.cc
M livestatus/src/test/test_RegExp.cc
M livestatus/src/test/test_StringUtil.cc
M livestatus/src/test/test_utilities.cc
M livestatus/src/test/test_utilities.h
M livestatus/src/unixcat.cc
Log Message:
-----------
Reformatted C/C++ code with clang-format-10.
Change-Id: I3bdc9f87039bfbd9dea643be04842fcd695f5a58
Commit: c8d1e30dad3d172d81a37bf0c28cac3e503a1d31
https://github.com/tribe29/checkmk/commit/c8d1e30dad3d172d81a37bf0c28cac3e5…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
A .werks/11153
M checkman/kernel.util
M checks/cpu_util.include
M cmk/gui/plugins/metrics/cpu.py
M cmk/gui/plugins/wato/check_parameters/cpu_utilization.py
M tests-py3/unit/checks/generictests/datasets/kernel.py
M tests-py3/unit/checks/test_kernel_check.py
Log Message:
-----------
11153 Averaging of single-core CPU utilization
This werk extends the following checks by an option to compute averaged
single-core CPU utilizations (previously, this was only possible for the total
CPU utilization): hr_cpu, huawei_switch_cpu, kernel.util, tplink_cpu,
winperf_processor.util. In particular, this option is now available for Linux/UNIX
(kernel.util) and Windows systems (winperf_processor.util).
To activate the averaging, use the option "Averaging for single cores" of the rules
"CPU utilization on Linux/UNIX" or "CPU utilization for simple devices" (depending on
the check). Note that, as described in the documentations of these rules, this option
only has an effect when used together with the sub-options "Apply single-core levels"
or "Graphs for averaged single-core utilizations".
Change-Id: I974a427d650c16bd014282dab073376a19b6d384
Commit: 5a66155fefa3e1d0869509a22f2b5f0a9423eac7
https://github.com/tribe29/checkmk/commit/5a66155fefa3e1d0869509a22f2b5f0a9…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M buildscripts/infrastructure/build-nodes/scripts/install-gnu-toolchain.sh
Log Message:
-----------
Downgrade GDB even further, 9.1 => 9.0.
9.1 doesn't like make 3.81, just like 9.2. Let's see if 9.0 works...
Change-Id: I77e1e980626e8b6fab34972d9d5c9c814fa8180d
Compare: https://github.com/tribe29/checkmk/compare/ab83fc4cd613...5a66155fefa3
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: bcab60bc0fac0d6889dbef329c850465edd90e94
https://github.com/tribe29/checkmk/commit/bcab60bc0fac0d6889dbef329c850465e…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M checks/cpu_util.include
M tests-py3/unit/checks/generictests/datasets/kernel.py
Log Message:
-----------
Refactored _util_perfdata in checks/cpu_util.include to prepare for
adding option to average single-core CPU utilizations
Change-Id: Ifd493fc50f614f4357e9c577aca28012912e2faf
Commit: 5e6463b7d1e4ba43b184ea6fa81a082beca06df8
https://github.com/tribe29/checkmk/commit/5e6463b7d1e4ba43b184ea6fa81a082be…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M checks/if.include
Log Message:
-----------
Slight refactoring of checks/if.include to allow for input values to
already be rates instead of data volumes
Change-Id: Ib8bd2337ea21c2eb8447b77c23342635e38b294c
Commit: 15ba6f89721151d5ac60a46b513b9c1e79764082
https://github.com/tribe29/checkmk/commit/15ba6f89721151d5ac60a46b513b9c1e7…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
A .werks/11155
M checkman/aws_ec2.cpu_credits
M checks/aws_ec2
M tests-py3/unit/checks/generictests/datasets/aws_ec2_2019-03-08_08-52-25_5c821f39c09ef_regression.py
Log Message:
-----------
11155 FIX Monitoring of AWS EC2 instances
The checks aws_ec2, aws_ec2.cpu_credits, aws_ec2.cpu_util, aws_ec2.disk_io and
aws_ec2.network_io now go stale instead of to UNKN if the corresponding EC2 instance
is turned off.
Change-Id: I8691df55f6940e05cfaa2c05355a1e6df6c777e8
Commit: ab83fc4cd6137fc50b11a97229e1b2f9e2a31d6a
https://github.com/tribe29/checkmk/commit/ab83fc4cd6137fc50b11a97229e1b2f9e…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
A .werks/11156
M checkman/aws_rds.agent_jobs
M checkman/aws_rds.cpu_credits
M checkman/aws_rds.replica_lag
M checkman/aws_rds.replication_slot_usage
M checkman/aws_rds.transaction_logs_usage
M checks/aws_rds
M cmk/gui/plugins/metrics/aws.py
M cmk/gui/plugins/wato/check_parameters/aws.py
M cmk/special_agents/agent_aws.py
Log Message:
-----------
11156 FIX Monitoring of AWS RDS DBs
This werk fixes some issues with the monitoring of AWS RDS DBs:
<ul>
<li>The checks aws_rds.network_io and aws_rds.disk_io now yield correct rates.</li>
<li>The services produced by the checks aws_rds.transaction_logs_usage,
aws_rds.replication_slot_usage and aws_rds.agent_jobs are now discoverable, which wasn't
the case before due to a bug in the AWS special agent.</li>
<li>For PostgreSQL databases, the check aws_rds.replica_lag now additionally reports the
Cloudwatch metric OldestReplicationSlotLag, which wasn't the case before due to a bug in
the AWS special agent.</li>
<li>The rule "AWS/RDS Replica lag" for the check aws_rds.replica_lag has been adjusted to
allow for setting levels smaller than one second on the replication lag.</li>
This werk is incompatible. Depending on the used configuration, users should delete and
re-create the rules "AWS/RDS Replica lag".
Change-Id: Ib6f3236f42f3b99f845d071a324b7d07464c62d7
Compare: https://github.com/tribe29/checkmk/compare/585598385b82...ab83fc4cd613
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 96fa21744d2c90837963d4d01b22ff3d6e1646d7
https://github.com/tribe29/checkmk/commit/96fa21744d2c90837963d4d01b22ff3d6…
Author: Ronny Bruska <ronny.bruska(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
A .werks/11186
M cmk/gui/plugins/wato/check_mk_configuration.py
Log Message:
-----------
11186 FIX Fixed some wrong displayed parameters for hosts if cmc is used
CMK-4366
Change-Id: I5353d1e9fdac71235db8e570b7d69b155b077496
Commit: 5d6746b49763ee96b027aa9e42a647a2c6da4aa8
https://github.com/tribe29/checkmk/commit/5d6746b49763ee96b027aa9e42a647a2c…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M web/htdocs/js/modules/popup_menu.js
M web/htdocs/js/modules/utils.js
Log Message:
-----------
Refactoring of popup_menu.js #1
popup_id is replaced by the object active_popup.
It has register and close methods to register a
new popup and to close an existing popup. This
brings popup related functions and attributes
closer together. Its methods popup and container
return the HTML elements of the popup and the
container that contains the popup which makes
element access easier.
Furthermore del_event_handler is moved to utils.js
where its counterpart add_event_handler lives.
Change-Id: Iadc00acd66aafa115ff058bba5951619eda5ad65
Commit: 646f60f7c82f41beda5b5273f4657b05bfd2881a
https://github.com/tribe29/checkmk/commit/646f60f7c82f41beda5b5273f4657b05b…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M cmk/gui/htmllib.py
M cmk/gui/valuespec.py
M web/htdocs/js/modules/popup_menu.js
Log Message:
-----------
Refactoring of popup_menu.js #2
This commit reduces the amount of arguments that
are passed to the function toggle_popup. Since
many of the arguments are mutual exclusive they
are now bundled together in render_popup_trigger
and submitted together as one object to
toggle_popup. The type property is added to the
object to make the code in toggle_popup more
readable.
The type "colorpicker" needed a little more care
since it included a "hidden" function call in
valuespec.py. This call is now moved to directly
to toggle_popup. This made it possible to reduce
the arguments of generate_colorpicker_body.
Change-Id: I28a3e48d5c2720205c6cce7ca1e1baef08be560f
Commit: a1c3267bc623180d37fb3716eafe8e740d5c5180
https://github.com/tribe29/checkmk/commit/a1c3267bc623180d37fb3716eafe8e740…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M web/htdocs/js/modules/popup_menu.js
Log Message:
-----------
Fix for werk 10653
Change-Id: Ic8ee481d99391ad7bb85220a914ae8f35f3e8234
Compare: https://github.com/tribe29/checkmk/compare/420c9803836c...a1c3267bc623
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 8966bd7ad46495154d87360a05a38f5c1f8611b0
https://github.com/tribe29/checkmk/commit/8966bd7ad46495154d87360a05a38f5c1…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M cmk/base/automations/check_mk.py
M cmk/base/config.py
M cmk/base/modes/check_mk.py
M cmk/base/snmp.py
M cmk/base/snmp_utils.py
M cmk/utils/type_defs.py
Log Message:
-----------
Remove dependencies on config from cmk.base.snmp
The `create_snmp_host_config` instantiates a HostConfig, performs
some sanitization on its arguments, and returns the result of a
method from HostConfig.
The code should therefore be consolidated by moving it to
`cmk.base.config.HostConfig`. However, the argument sanitization
calls `ip_lookup`, which imports `config`: circular imports. For,
now, we therefore move the function somewhere else.
`ScanFunction` also goes to `cmk.utils.type_defs` to avoid more
circular imports.
Magically importing the config *in* a function never makes sense.
If anything, configuration must be passed to functions.
CMK-4610
Change-Id: Iba3493711b4ac3ce6c4236da240a64a3039c42a7
Commit: 1db868ddeb4cd79d49c49afa1a60eb783fefaf97
https://github.com/tribe29/checkmk/commit/1db868ddeb4cd79d49c49afa1a60eb783…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M cmk/base/snmp.py
M cmk/fetchers/factory.py
M cmk/fetchers/snmp_backend/classic.py
M cmk/fetchers/snmp_backend/stored_walk.py
M cmk/utils/snmp_table.py
M cmk/utils/type_defs.py
M tests-py3/integration/cmk/base/snmp/test_snmp.py
M tests-py3/integration/cmk/utils/test_snmp_table.py
M tests-py3/unit/cmk/base/test_snmp_utils.py
M tests-py3/unit/cmk/fetchers/test_classic_snmp.py
M tests-py3/unit/cmk/utils/test_snmp_table_unit.py
Log Message:
-----------
Simplify code by passing snmp_config to backends
CMK-4610
Change-Id: I883221a9c25541b06ac663e7f80a2f3e24c8ee90
Commit: b39b3f39a708d4fa1576f1f673ad471cdff8dc32
https://github.com/tribe29/checkmk/commit/b39b3f39a708d4fa1576f1f673ad471cd…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
R cmk/base/cleanup.py
M cmk/base/config.py
M cmk/base/core.py
M cmk/base/discovery.py
M cmk/base/inventory.py
M cmk/base/item_state.py
M cmk/base/snmp.py
A cmk/utils/cleanup.py
Log Message:
-----------
Move `cleanup` from base to utils
The module itself has no deps on base.
With this change, we get rid of all the dependencies of `cmk.base.snmp`
on `base`. Now, we are able to increase the cohesion of our SNMP code by
moving `cmk.utils.snmp_table` and `cmk.base.snmp` back to a common
package, possibly outside of `cmk.utils`.
CMK-4610
Change-Id: I18654d4883c9c4e19671dec7e4fe4aacad795876
Compare: https://github.com/tribe29/checkmk/compare/171f9e04bd48...b39b3f39a708