Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 724feabbc08b52826673225b73303c3bc2dd3afa
https://github.com/tribe29/checkmk/commit/724feabbc08b52826673225b73303c3bc…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-06-19 (Fri, 19 Jun 2020)
Changed paths:
M cmk/base/check_api_utils.py
Log Message:
-----------
check_api_utils: minor cleanups
Change-Id: I547d16e90469f8a5042197a6bd3d26a4cadf0c96
Commit: d941ea8c1e83de1cc44fdfb63af771da1624f830
https://github.com/tribe29/checkmk/commit/d941ea8c1e83de1cc44fdfb63af771da1…
Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com>
Date: 2020-06-19 (Fri, 19 Jun 2020)
Changed paths:
M cmk/special_agents/agent_storeonce4x.py
M tests-py3/unit/agents/special/test_special_agent_args.py
A tests-py3/unit/cmk/special_agents/test_agent_storeonce4x.py
Log Message:
-----------
FIX: Unique token file per StoreOnce instance
* In case multiple HP StoreOnce instances should be queried, a
dedicated token file is created.
* The token file name will have the instance's hostname preceded.
* Unit tests for special agent
CMK-4732
Change-Id: I14a3febf4aaaa3310d64297a717f2b0bea5ad32b
Commit: ef79c71405f01825c9316957d81c365bb0700a39
https://github.com/tribe29/checkmk/commit/ef79c71405f01825c9316957d81c365bb…
Author: Christoph Rauch <christoph.rauch(a)tribe29.com>
Date: 2020-06-19 (Fri, 19 Jun 2020)
Changed paths:
A buildscripts/infrastructure/build-nodes/ubuntu-19.04/Dockerfile
M buildscripts/scripts/build-cmk-container.jenkins
M buildscripts/scripts/build-cmk-version.jenkins
M buildscripts/scripts/lib/integration.groovy
M buildscripts/scripts/test-agent-plugin-unit.jenkins
M buildscripts/scripts/test-gui-crawl.jenkins
M buildscripts/scripts/test-integration-single.jenkins
M buildscripts/scripts/test-pylint-3.jenkins
M buildscripts/scripts/test-python3-bandit.jenkins
M buildscripts/scripts/test-python3-pipenv-deps.jenkins
M buildscripts/scripts/test-python3-unit.jenkins
Log Message:
-----------
Revert "builds: drop support for ubuntu 19.04, use 20.04 to build"
This reverts commit 82f0b7d0cd442deac25047254268230e345e5289.
Compare: https://github.com/tribe29/checkmk/compare/839a737f4de9...ef79c71405f0
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: d3e410ddd30624f2357dfaf6395350aa9bcd30d2
https://github.com/tribe29/checkmk/commit/d3e410ddd30624f2357dfaf6395350aa9…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-06-19 (Fri, 19 Jun 2020)
Changed paths:
M cmk/base/data_sources/abstract.py
M tests-py3/unit/cmk/base/data_sources/test_abstract_data_source.py
Log Message:
-----------
data_sources: Log invalid section name
Instead of parsing it, and then later silently not using/finding it, log a warning
when an invalid section name is encountered, and dissmiss all its lines.
Change-Id: I66da839b3de070c6991ece5decb1749b6edc175e
Commit: 839a737f4de945796fb0207ccc27cbeec3090e49
https://github.com/tribe29/checkmk/commit/839a737f4de945796fb0207ccc27cbeec…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-06-19 (Fri, 19 Jun 2020)
Changed paths:
M cmk/base/autochecks.py
M cmk/base/config.py
Log Message:
-----------
config: rename an argument for 'clarity'
Change-Id: I0c09ad4c906d51407e4a05b65ec8e53717117965
Compare: https://github.com/tribe29/checkmk/compare/82f0b7d0cd44...839a737f4de9
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 4ba177982fe3637012329c95461a15187ca3ec47
https://github.com/tribe29/checkmk/commit/4ba177982fe3637012329c95461a15187…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-19 (Fri, 19 Jun 2020)
Changed paths:
M tests-py3/pylint/test_pylint.py
Log Message:
-----------
Display pylint version in the pylint test
It is not uncommon that new versions of pylint discover new linting
errors. However, this may come a little unpleasant when the new errors
cannot be related to their cause: the new pylint version.
This patch makes sure that the version of pylint used in the tests is
shown in the tests.
Change-Id: I75425b507619623e9ac4ade42acd5e6c1d42d8f6
Commit: 82f0b7d0cd442deac25047254268230e345e5289
https://github.com/tribe29/checkmk/commit/82f0b7d0cd442deac25047254268230e3…
Author: Christoph Rauch <christoph.rauch(a)tribe29.com>
Date: 2020-06-19 (Fri, 19 Jun 2020)
Changed paths:
R buildscripts/infrastructure/build-nodes/ubuntu-19.04/Dockerfile
M buildscripts/scripts/build-cmk-container.jenkins
M buildscripts/scripts/build-cmk-version.jenkins
M buildscripts/scripts/lib/integration.groovy
M buildscripts/scripts/test-agent-plugin-unit.jenkins
M buildscripts/scripts/test-gui-crawl.jenkins
M buildscripts/scripts/test-integration-single.jenkins
M buildscripts/scripts/test-pylint-3.jenkins
M buildscripts/scripts/test-python3-bandit.jenkins
M buildscripts/scripts/test-python3-pipenv-deps.jenkins
M buildscripts/scripts/test-python3-unit.jenkins
Log Message:
-----------
builds: drop support for ubuntu 19.04, use 20.04 to build
Change-Id: Iceb0af19341dac837cd1c0172d64cc8cad55bf51
Compare: https://github.com/tribe29/checkmk/compare/7c7b24bcbeb0...82f0b7d0cd44
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 85ec7051d0b9d9d00e2d3f5ef343cc9ee5729e2d
https://github.com/tribe29/checkmk/commit/85ec7051d0b9d9d00e2d3f5ef343cc9ee…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-19 (Fri, 19 Jun 2020)
Changed paths:
M cmk/fetchers/controller.py
M tests-py3/unit/cmk/fetchers/test_controller.py
Log Message:
-----------
Handle protocol header with a class
This offers several advantages:
- it is self-contained
- it is easier to test
- the fields have names
- parsing and serialization are in the same place
CMK-4707
Change-Id: I4ced63af02eb9fef28ccfc848294d261e60911eb
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 7fc98fe753a0a704addd96be1a7549f51f783396
https://github.com/tribe29/checkmk/commit/7fc98fe753a0a704addd96be1a7549f51…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-06-19 (Fri, 19 Jun 2020)
Changed paths:
M cmk/base/check_utils.py
M cmk/base/config.py
M tests-py3/unit/cmk/base/test_checks.py
Log Message:
-----------
CheckAPI: remove dead code III
Change-Id: I1d8090b23c77bd231fceca16fb7b91044a0dfa0b
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: e7378c3b7d95c7ecb2ac3183602e3cb8221a461f
https://github.com/tribe29/checkmk/commit/e7378c3b7d95c7ecb2ac3183602e3cb82…
Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com>
Date: 2020-06-18 (Thu, 18 Jun 2020)
Changed paths:
A bin/fetcher
M cmk/base/data_sources/programs.py
A cmk/fetchers/controller.py
M cmk/utils/paths.py
A tests-py3/unit/cmk/fetchers/test_controller.py
Log Message:
-----------
[CMK-4707] - fetcher skeleton
- 'main' fetcher in bin
- simple protocol description and partial implementation
- base logic related to the fetchers, json, transferring data, argument processing and exception management
- make crazy pylinter happy(programs.py)
- path for fetcher-config in cmk.util.paths
- make crazy pylinter happy(managed.py)
Change-Id: I007f1d2f4ade40ef491541d37fbbfc075ad2c135
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: a03b12c2278ce82df06e77b2dcb07420c26e7e80
https://github.com/tribe29/checkmk/commit/a03b12c2278ce82df06e77b2dcb07420c…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-18 (Thu, 18 Jun 2020)
Changed paths:
M cmk/base/snmp_scan.py
M tests-py3/unit/cmk/base/test_snmp_scan.py
Log Message:
-----------
snmp_scan: Add whitebox testing
We cannot split huge functions without tests and we cannot properly test
huge functions. We are lucky enough that whitebox testing is at all
possible. This is not meant to stay this way.
CMK-4766
Change-Id: I5c3e94ea504fa718c0350dda7bbfd6481c5f7aed
Commit: bfb67bf4cd76f347ae4fc8dffbd2553cb328c300
https://github.com/tribe29/checkmk/commit/bfb67bf4cd76f347ae4fc8dffbd2553cb…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-18 (Thu, 18 Jun 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
M cmk/base/snmp_scan.py
M tests-py3/unit/cmk/base/test_snmp_scan.py
Log Message:
-----------
snmp_scan: Refactoring #1 split function
CMK-4766
Change-Id: Ib945a8963d1f9983b79d6c2fc87ff1fdd1ce81cf
Commit: f748bd2f61e083a3e1e1f9f6e3e04a9342c75916
https://github.com/tribe29/checkmk/commit/f748bd2f61e083a3e1e1f9f6e3e04a934…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-18 (Thu, 18 Jun 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
M cmk/base/discovery.py
M cmk/base/inventory.py
M cmk/base/snmp_scan.py
M tests-py3/unit/cmk/base/data_sources/test_snmp_data_source.py
M tests-py3/unit/cmk/base/test_snmp_scan.py
Log Message:
-----------
snmp_scan: Refactoring #2 - pass sections later
The list of sections is computed as late as possible, that is, in the
CachedSNMPDetector. The scan function does not need to know whether the
caller is discovery or inventory. It only needs the corresponding
SNMPSectionPlugin iterable.
This removes more deps of snmp_scan on base.
We can now unit test the module.
CMK-4766
Change-Id: I0df39233aae36a1944b831abddd421e358929832
Commit: 7b94f97e7052fa8f110de9e5648f79426e7c8c94
https://github.com/tribe29/checkmk/commit/7b94f97e7052fa8f110de9e5648f79426…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-18 (Thu, 18 Jun 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
M cmk/base/snmp_scan.py
M tests-py3/unit/cmk/base/data_sources/test_snmp_data_source.py
M tests-py3/unit/cmk/base/test_snmp_scan.py
Log Message:
-----------
snmp_scan: Remove deps on `cmk.base.config`
- The caller now takes care of flagging for inventory/discovery.
- Perform the filtering using the management board separately after the
call to `gather_...`.
CMK-4766
Change-Id: I257d71c7572a8b8150e281b379e47e63f7cb9a9e
Commit: 1816b787c3329614bea0e3d4d76f5a6273b8ae11
https://github.com/tribe29/checkmk/commit/1816b787c3329614bea0e3d4d76f5a627…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-18 (Thu, 18 Jun 2020)
Changed paths:
M cmk/base/api/__init__.py
M cmk/base/api/agent_based/checking_types.py
M cmk/base/api/agent_based/register/check_plugins.py
M cmk/base/api/agent_based/register/check_plugins_legacy.py
M cmk/base/api/agent_based/register/section_plugins.py
M cmk/base/api/agent_based/section_types.py
M cmk/base/api/agent_based/value_store.py
M cmk/base/check_api.py
M cmk/base/check_table.py
M cmk/base/checking.py
M cmk/base/config.py
M cmk/base/data_sources/__init__.py
M cmk/base/data_sources/abstract.py
M cmk/base/data_sources/host_sections.py
M cmk/base/data_sources/ipmi.py
M cmk/base/data_sources/piggyback.py
M cmk/base/data_sources/programs.py
M cmk/base/data_sources/snmp.py
M cmk/base/data_sources/tcp.py
M cmk/base/discovery.py
M cmk/base/inventory.py
M cmk/base/inventory_plugins.py
M cmk/utils/type_defs.py
M tests-py3/unit/checks/test_generic_legacy_conversion.py
M tests-py3/unit/cmk/base/api/agent_based/register/test_check_plugins.py
M tests-py3/unit/cmk/base/api/agent_based/register/test_check_plugins_legacy.py
M tests-py3/unit/cmk/base/api/agent_based/register/test_section_plugins.py
M tests-py3/unit/cmk/base/api/agent_based/register/test_section_plugins_legacy.py
M tests-py3/unit/cmk/base/api/agent_based/test_utils_value_store.py
R tests-py3/unit/cmk/base/api/test_plugin_name.py
M tests-py3/unit/cmk/base/data_sources/test_host_sections.py
M tests-py3/unit/cmk/base/test_config.py
A tests-py3/unit/cmk/utils/test_type_defs_plugin_name.py
Log Message:
-----------
Define PluginName in `cmk.utils.type_defs`
We need `PluginName` in `snmp_scan`, which is on a lower abstraction
level than the API.
CMK-4766
Change-Id: I5144def9e669b19021b8574696c6de37aab5320a
Commit: d6affa568c609730d4a98f46e9a2dd2f0af762a8
https://github.com/tribe29/checkmk/commit/d6affa568c609730d4a98f46e9a2dd2f0…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-18 (Thu, 18 Jun 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
M cmk/base/snmp_scan.py
M tests-py3/unit/cmk/base/test_snmp_scan.py
Log Message:
-----------
Remove last dep of `snmp_scan` on higher layers
CMK-4766
Change-Id: I03299c1ef8121406d1e9d9a942440ab9cf06c1c2
Commit: 686c636b0a8c31fffcc32732d7b54a8fe078deab
https://github.com/tribe29/checkmk/commit/686c636b0a8c31fffcc32732d7b54a8fe…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-06-18 (Thu, 18 Jun 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
M cmk/base/discovery.py
M cmk/base/inventory.py
R cmk/base/snmp_scan.py
A cmk/snmplib/snmp_scan.py
R tests-py3/unit/cmk/base/test_snmp_scan.py
A tests-py3/unit/cmk/lib/test_snmplib_snmp_scan.py
Log Message:
-----------
Move snmp_table to snmplib
It is another SNMP module used as a library in base. So it makes sense
to move it to a lower abstraction layer than base.
CMK-4766
Change-Id: Id38ee1a1c2891ebe44faca5fc92ff6f659f58d20
Compare: https://github.com/tribe29/checkmk/compare/f334759561b8...686c636b0a8c