Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: cbefedfbd76f4e7f0a9111921339ffc8f4c13b46
https://github.com/tribe29/checkmk/commit/cbefedfbd76f4e7f0a9111921339ffc8f…
Author: Christoph Rauch <christoph.rauch(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M Makefile
A cmk/gui/openapi.py
M cmk/gui/plugins/openapi/__init__.py
M cmk/gui/plugins/openapi/endpoints/__init__.py
M cmk/gui/plugins/openapi/restful_objects/constructors.py
M cmk/gui/plugins/openapi/restful_objects/decorators.py
R cmk/gui/plugins/openapi/specgen.py
M tests/unit/cmk/gui/conftest.py
M web/htdocs/openapi/checkmk.yaml
Log Message:
-----------
REST API: agent bakery endpoints
Change-Id: I13abebd6ed449782fad756d5f94d0476989e18ac
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: c7a025c7d430a0a57bcd569fd7ad6c13e719858b
https://github.com/tribe29/checkmk/commit/c7a025c7d430a0a57bcd569fd7ad6c13e…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/discovery.py
Log Message:
-----------
Fix typo
Change-Id: I56e7d11c0bc2fa866f38b7dd977965d016482c83
Commit: 92d6e4cbbd84c604722dbaff310db1488cacc9d4
https://github.com/tribe29/checkmk/commit/92d6e4cbbd84c604722dbaff310db1488…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/abstract.py
Log Message:
-----------
Make "may_use_cache_file" handling static
Inspection of the call sites shows that the setter is always
called on the `abstract.DataSource` class and never on an
instance or a derived class. We make this fact explicit in the
class itself with static accessors.
List of call sites (obtained from ack-grep):
cmk/base/modes/check_mk.py:94: data_sources.abstract.DataSource.set_may_use_cache_file()
cmk/base/modes/check_mk.py:1279: data_sources.abstract.DataSource.set_may_use_cache_file(
cmk/base/modes/check_mk.py:1518: data_sources.abstract.DataSource.set_may_use_cache_file(
cmk/base/automations/check_mk.py:216: data_sources.abstract.DataSource.set_may_use_cache_file(use_caches)
cmk/base/automations/check_mk.py:1543: data_sources.abstract.DataSource.set_may_use_cache_file(
cmk/base/data_sources/__init__.py:247: abstract.DataSource.set_may_use_cache_file()
enterprise/cmk/base/cee/keepalive.py:382: data_sources.abstract.DataSource.set_may_use_cache_file(False)
enterprise/cmk/base/cee/keepalive.py:596: data_sources.abstract.DataSource.set_may_use_cache_file()
CMK-4244
Change-Id: Iaa34e2f4662b9866cc07db431b1e55a995a2ee51
Commit: 8b7180d21ea0cecd0bdbcddf769e9278881dfd81
https://github.com/tribe29/checkmk/commit/8b7180d21ea0cecd0bdbcddf769e92788…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/discovery.py
M cmk/base/inventory.py
Log Message:
-----------
Call classmethod on class where possible
This helps clarify the usage of the `_no_cache` flag, apparently, the
cache may be disabled globally (on DataSource) or for SNMP only.
CMK-4244
Change-Id: I85843605a80f24924753ab865360970255937e50
Compare: https://github.com/tribe29/checkmk/compare/7fb06fc7f918...8b7180d21ea0
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 54ed879c142c2857307e0b9b8968ea7d85f7a70e
https://github.com/tribe29/checkmk/commit/54ed879c142c2857307e0b9b8968ea7d8…
Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
A .werks/10934
M checks/sap_hana_status
A tests-py3/unit/checks/generictests/datasets/sap_hana_status.py
Log Message:
-----------
10934 Make sap_hana_status multi-SID compatible
The agent plugin mk_sap_hana already delivers data per SID.
Now also the check sap_hana_status will generate a service for the status and version per SID.
If you already discovered such services, rediscovery is needed.
Change-Id: Ic0a92af665237407dfc7a26b47528d34d9dbb1c4
Commit: d5ce8b5027596e68488a5f1c243a2748dd6eb806
https://github.com/tribe29/checkmk/commit/d5ce8b5027596e68488a5f1c243a2748d…
Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
A .werks/10933
A checkman/hwg_ste2
A checkman/hwg_ste2.humidity
A checks/hwg.include
M checks/hwg_humidity
A checks/hwg_ste2
M checks/hwg_temp
A tests-py3/unit/checks/generictests/datasets/hwg_humid.py
A tests-py3/unit/checks/generictests/datasets/hwg_ste2.py
A tests-py3/unit/checks/generictests/datasets/hwg_temp.py
M tests-py3/unit/cmk/base/test_snmp_scan.py
Log Message:
-----------
10933 Support STE2 for HWG Humdity and Temperature
STE *and* STE2 for HWG devices is now supported.
Change-Id: Ic235504295e16d78cdb75ae20a35a103d02507a6
Commit: 7fb06fc7f91876a12dc37d8acc7767cc3c9bebe9
https://github.com/tribe29/checkmk/commit/7fb06fc7f91876a12dc37d8acc7767cc3…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M bin/mkbackup
Log Message:
-----------
Python 2/3 compatibility fixes, part 7.
Change-Id: I17c57ab4e72f6f0ecfd96d30731e49b9e8996d66
Compare: https://github.com/tribe29/checkmk/compare/d62f3d99c93f...7fb06fc7f918
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: d351ef2402ca57e499128565c66eab2b09a86a10
https://github.com/tribe29/checkmk/commit/d351ef2402ca57e499128565c66eab2b0…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
A tests-py3/unit/cmk/base/data_sources/test_host_sections.py
R tests-py3/unit/cmk/base/test_host_sections.py
Log Message:
-----------
move test_host_sections.py
Change-Id: I3640bd199772b61b0517e827f79abd8bbc4fe662
Commit: dbb23899c2daafdfb6b394dfd031026400864bbd
https://github.com/tribe29/checkmk/commit/dbb23899c2daafdfb6b394dfd03102640…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M tests-py3/unit/cmk/base/data_sources/test_host_sections.py
Log Message:
-----------
host section tests: factor out set up & make pylint happy
Change-Id: I7f077f5104fe7ceabc4a2b0f90e079f136d0e896
Commit: b216947dba6fbe6202f21ff7fdc949149dd96091
https://github.com/tribe29/checkmk/commit/b216947dba6fbe6202f21ff7fdc949149…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M tests-py3/unit/cmk/base/data_sources/test_host_sections.py
Log Message:
-----------
add test for mutli_host_sections
Change-Id: I7f5b78bf38e981d678e2e38e0eaa554d8a393c48
Commit: f8944a8b6d05bc67d54bff2609e769289267bca7
https://github.com/tribe29/checkmk/commit/f8944a8b6d05bc67d54bff2609e769289…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/host_sections.py
M cmk/base/discovery.py
M tests-py3/unit/cmk/base/data_sources/test_host_sections.py
Log Message:
-----------
CheckAPI: add two methods to get parsed section kwargs
The new check- and discovery functions get their arguments
in an new way:
*Every* section gets parsed, and then passed to the function
by a separate named argument.
In case of a cluster check function a dict-layer introduced,
such that every section contains its data by node name.
Change-Id: I15425f26091307e7c1277b39bec6ee4d06fe6fb7
Compare: https://github.com/tribe29/checkmk/compare/974c35048eca...f8944a8b6d05
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: d7784cd1de58b6d0656273eeaf59a96329faa95c
https://github.com/tribe29/checkmk/commit/d7784cd1de58b6d0656273eeaf59a9632…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/snmp.py
Log Message:
-----------
Reduce cyclomatic complexity
Now, we clearly see that there are three cache modes: no cache, write
cache, and read/write cache.
CMK-4244
Change-Id: I2417ce252f227bf8a4c3cbd978b20e24cfa66f7b
Commit: 412de1e32db3b9d2aac899ce0cc9a5febd20dcba
https://github.com/tribe29/checkmk/commit/412de1e32db3b9d2aac899ce0cc9a5feb…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/snmp.py
M tests-py3/unit/cmk/base/test_snmp_unit.py
Log Message:
-----------
snmp: Name special columns
This eases testing.
Change-Id: Iba05822f385598097fa4bbd57179543e7e60e3d4
Commit: 7437037841728ca8715de91ef4ce39bd50d46fa5
https://github.com/tribe29/checkmk/commit/7437037841728ca8715de91ef4ce39bd5…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/snmp.py
Log Message:
-----------
Remove temporaries and more explicit logic
- remove two unnecessary temporaries
- separate intendence from the business logic
Decrease the size of `get_snmp_table()` #4
CMK-4244
Change-Id: I2d7649a90e56bd771e3972126b6270701258d8d6
Commit: b92e0d4ed4c921e554e1ac7eecb455b16d3bc44a
https://github.com/tribe29/checkmk/commit/b92e0d4ed4c921e554e1ac7eecb455b16…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/snmp.py
Log Message:
-----------
Let `_get_snmpwalk` return rowinfo in any case
Before, some columns were special-cased before the call and once more in
the function. The function now handles every column types.
CMK-4244
Change-Id: I43ae9ee80f79f35a615060f5e57df4df6933604d
Commit: 56e70db92c4646c2b356bafa8af84f4dd3748675
https://github.com/tribe29/checkmk/commit/56e70db92c4646c2b356bafa8af84f4dd…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M tests-py3/unit/cmk/base/data_sources/test_snmp_data_source.py
Log Message:
-----------
Test SNMP DS execute method
CMK-4244
Change-Id: Ie4648eb82996ea958b679769595f93ef8fbeff75
Commit: 5fbc5a7ccfcaa07a8c373c8bbf63a545a4007dad
https://github.com/tribe29/checkmk/commit/5fbc5a7ccfcaa07a8c373c8bbf63a545a…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
Log Message:
-----------
SNMP DS: Sort names first
The fetcher should take the sorted list.
CMK-4244
Change-Id: I50c04ff55c8c7cd50606e77b9286452ed42dd0d7
Commit: 9837c9ed9dafbe03adece5fcc3a6eb7af4d61db4
https://github.com/tribe29/checkmk/commit/9837c9ed9dafbe03adece5fcc3a6eb7af…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
Log Message:
-----------
SNMP: Make static raw data fetcher
CMK-4244
Change-Id: I326c9d59faee9abd92ad1395bb9026fb6f463382
Commit: 682c5e28534abe8b03c78886f88910709ffa7e31
https://github.com/tribe29/checkmk/commit/682c5e28534abe8b03c78886f88910709…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
Log Message:
-----------
Extract SNMPDataFetcher
To do: There is no need to instantiate if the data is readily available
from the cache.
CMK-4244
Change-Id: I7e4011d3a04632e02f4b31779e86c7f310331a38
Commit: 974c35048eca9aaefa75e2b72962241452594415
https://github.com/tribe29/checkmk/commit/974c35048eca9aaefa75e2b7296224145…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
M cmk/base/data_sources/snmp.py
Log Message:
-----------
Simplify SNMP data fetcher
This patch simplifies the SNMP data fetcher by precomputing the elements
[name : str, oid_info : OIDInfo] of the loop.
- The fetcher needs less attributes.
- The fetcher does not need to load the inventory plugins anymore.
CMK-4218
Change-Id: Ieb1097720bc7c07f90549b1d018fc2c30a0e3695
Compare: https://github.com/tribe29/checkmk/compare/0a06ab083d77...974c35048eca
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 0a06ab083d77133895d341368001066028980d77
https://github.com/tribe29/checkmk/commit/0a06ab083d77133895d34136800106602…
Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com>
Date: 2020-04-23 (Thu, 23 Apr 2020)
Changed paths:
A tests-py3/unit/test_sanity_checks.py
M tests/testlib/utils.py
Log Message:
-----------
Sanity test for check development
Already existing checks can be part of a site configuration and are
therefore not allowed to be deleted or renamed. This test should give
developers in the future an automatic feedback if there about to do so.
Change-Id: I167c75cddc46d13b1c30c455a3b1f2496ca39613